C / C++ / MFC

printf("%s",result[i])

printf("Decimal %d in binary = %c ",someNumber);

#include <stdlib.h>
#include <string.h>
#include <stdio.h>

#define SIZE 10

void findbinary(int number, char result[], int index);

int main (void)
{
    int someNumber = 233;
    char result[SIZE];
    findbinary(someNumber, result,0);
    printf("Decimal %d in reversed binary %s\n", someNumber, result);
    return 0;
}

void findbinary(int number, char result[], int index)
{

    if ( index == SIZE)
      exit(-1); //TODO: notify the error

    if(number == 0){
        result[index] = '\0'; // append theterminator
        return;
    }
    result[index] = (number % 2) + '0'; // obtain either the CHARACTER '0' or '1'
    findbinary(number / 2, result, index + 1);
}

C:\Users\rjmac\source\repos>wmic bootconfig get description
Description
\Device\Harddisk0\Partition1  


C:\Users\rjmac\source\repos>wmic diskdrive where DeviceID=\\.\PHYSICALDRIVE0
Node - RJM-INSPIRON15
ERROR:
Description = Invalid query

C:\Users\rjmac\source\repos>wmic diskdrive -?      

DISKDRIVE - Physical disk drive management. 

HINT: BNF for Alias usage.
(<alias> [WMIObject] | <alias> [<path where>] | [<alias>] <path where>) [<verb clause>].

USAGE:

DISKDRIVE ASSOC [<format specifier>]
DISKDRIVE CREATE <assign list>
DISKDRIVE DELETE
DISKDRIVE GET [<property list>] [<get switches>]
DISKDRIVE LIST [<list format>] [<list switches>]

Richard MacCutchan wrote:

So the error message "Description = Invalid query" is telling you that the command is in error, and you need to find out what the correct format is.

std::cout << exec("wmic diskdrive where DeviceID='\\\\\\\\.\\\\PHYSICALDRIVE3' get model,serialnumber");

#include <iostream>
#include <string>
#include <array>

std::string exec(const char* cmd) {
    std::array<char, 128> buffer;
    std::string result;
    std::unique_ptr<FILE, decltype(&_pclose)> pipe(_popen(cmd, "r"), _pclose);
    if (!pipe) {
        throw std::runtime_error("popen() failed!");
    }
    while (fgets(buffer.data(), buffer.size(), pipe.get()) != nullptr) {
        result += buffer.data();
    }
    return result;
}

void replaceString(std::string& subject, const std::string& search,
    const std::string& replace) {
    size_t pos = 0;
    while ((pos = subject.find(search, pos)) != std::string::npos) {
        subject.replace(pos, search.length(), replace);
        pos += replace.length();
    }
}

void main() {
    std::string index = exec("wmic bootconfig get description");
    index = index.at(index.find_last_of("\\") - 1);
    std::string modelSerialNumber = "wmic diskdrive where DeviceID='\\\\\\\\.\\\\PHYSICALDRIVE" + index + "' get model,serialnumber";
    modelSerialNumber = exec(modelSerialNumber.c_str());
    replaceString(modelSerialNumber, "Model", "");
    replaceString(modelSerialNumber, "SerialNumber", "");
    replaceString(modelSerialNumber, " ", "");
    std::cout << modelSerialNumber;
}

diskdrive where DeviceID='\\\\.\\PHYSICALDRIVE0'

David Crow wrote:

diskdrive where DeviceID='\\\\.\\PHYSICALDRIVE0'produces a result that can be parsed.
In C/C++, each of those backslashes needs to be escaped (with a backslash).

Richard MacCutchan wrote:

The problem goes back to the first days of MS-DOS, when they chose the backslash for the path separator,

Richard MacCutchan wrote:

Microsoft could have addressed this when they created the first version of Windows, but obviously no one thought it important.

JohnCodding wrote:

Any help is appreciated!