Re: How would I implement this? - C# Discussion Boards

Nick Parker19-Aug-03 18:49

19-Aug-03 18:49

Nishant S wrote:
This won't work when there is no tcode attribute at all.

Ah, gotcha, I'm a little Sleepy | :zzz:

Glad you have it working. Smile | :)

-Nick Parker

Nish Nishant19-Aug-03 19:06

Nish Nishant

19-Aug-03 19:06

Heheh,

ZZZ and RegExps dont go together.

Nish

p.s. Good night Nick and thanks too Smile | :)

Extending MFC Applications with the .NET Framework [NW] (My book with Tom)
Summer Love and Some more Cricket [NW] (My first novel)
Shog's review of SLASMC [NW]
Come with me if you want to live

Nish Nishant19-Aug-03 18:41

Nish Nishant

19-Aug-03 18:41

Okay. It needed a space.

The correct pattern to use is :-

string pattern = "type[^>]+ (tcode='(?<code>[\\S]+)')?[^>]*>";

I am still a little scared though as to whether even this might have some hidden issues.

Nish

Philip Fitzsimons20-Aug-03 2:51

How would I implement this?

20-Aug-03 2:51

thats correct - looks like you need a space when tcode is there, I would suggest you make the space part of the optional tcode bit...

string pattern = "type[^>]+( tcode='(?[\\S]+)')?[^>]*>";

"When the only tool you have is a hammer, a sore thumb you will have."

deanoA19-Aug-03 17:07

deanoA

19-Aug-03 17:07

I have 20 textboxes. Lets say, they are txtbox1 to txtbox20
Now, I would like to check them one by one if their text is null.
If txtbox1.Text is null, i would stop checking the other textboxes right away. I can easily perform this using an if-else but, its not gonna be that readable. So I want to use a switch statement. The problem is, how?

Please help. Frown | :(

"To teach is to learn twice"

Nick Parker19-Aug-03 17:37

19-Aug-03 17:37

daljv wrote:
So I want to use a switch statement. The problem is, how?

Why not just do soomething like this:

ControlCollection col = (ControlCollection)this.Controls;
foreach(Control t in col)
{
	if(t is TextBox)
	{
	       if(t.Text != String.Empty)
                {
                        // Do something here.
		      break;
                 }
	}
}

-Nick Parker

Frank Olorin Rizzi20-Aug-03 1:54

Frank Olorin Rizzi

20-Aug-03 1:54

Nick Parker wrote:
ControlCollection col = (ControlCollection)this.Controls;foreach(Control t in col){ if(t is TextBox) { if(t.Text != String.Empty) { // Do something here. break; } }}

Hmmm...
I can't help myself....

1~ he wanted to stop as soon as one text box had no text (actually he mentioned only the first text box, but I'll assume it was an example).
Thus

<br />
//...<br />
    if(t.Text == String.Empty)  break;<br />
//...<br />

Also, why not keep your own collection of controls containing only the text boxes so that you would not have to parse through all of the controls in the form?

Actually, since they are all text boxes, make it a collection of text boxes...

So, when you add them to the form's Controls in your initializer, also add them to myBoxes;
then:

<br />
foreach(TextBox t in myBoxes)<br />
{<br />
  if(t.Text == String.Empty)  break;<br />
  //Do whatever you need here...<br />
}<br />

HTH,
F.O.R.

Nick Parker20-Aug-03 2:16

20-Aug-03 2:16

Frank Olorin Rizzi wrote:
if(t.Text == String.Empty) break;

Woops, I guess I flip-flopped that. Blush | :O

Ah well, I think he got the main idea which was important.

Frank Olorin Rizzi wrote:
Also, why not keep your own collection of controls containing only the text boxes so that you would not have to parse through all of the controls in the form?

Because then he would have to maintain that collection where as the Form already maintains a collection of all controls applied to it. This is more extensible and easier to maintain. Granted there are other ways to do this, they simple require more work and don't provide much more in the efficiency department. Smile | :)

-Nick Parker

Roland Bär20-Aug-03 2:25

Roland Bär

20-Aug-03 2:25

Nick Parker wrote:
Because then he would have to maintain that collection where as the Form already maintains a collection of all controls applied to it. This is more extensible and easier to maintain. Granted there are other ways to do this, they simple require more work and don't provide much more in the efficiency department.

This argument lacks, if there are more text boxes in th esame form...

Roland Bär

Nick Parker20-Aug-03 2:58

20-Aug-03 2:58

Roland Bär wrote:
This argument lacks, if there are more text boxes in th esame form...

Show me an example please.

-Nick Parker

Roland Bär20-Aug-03 3:05

Roland Bär

20-Aug-03 3:05

Sorry, not precice enough ... Blush | :O

if you have the 20 textboxes, that should be tested, and then also other textboxes in the same form, that should not be checked, it is better to have the 20 textboxes in an own collection. Like this you can iterate over your collection without checking if it is a textbox to be checked or not.

Hope it is clear what I mean. Unsure | :~

greets

Roland

Nick Parker20-Aug-03 3:23

20-Aug-03 3:23

Roland Bär wrote:
if you have the 20 textboxes, that should be tested, and then also other textboxes in the same form, that should not be checked, it is better to have the 20 textboxes in an own collection. Like this you can iterate over your collection without checking if it is a textbox to be checked or not.

There are other ways around your problem, however my answer still identifies how to accomplish what he was asking for.

-Nick Parker

Frank Olorin Rizzi20-Aug-03 2:41

Frank Olorin Rizzi

20-Aug-03 2:41

Nick Parker wrote:
Because then he would have to maintain that collection where as the Form already maintains a collection of all controls applied to it

hmm.. yes, I see what you mean.
...speaking of which, let me ask this:

If I picked the TextBox object that gets added to the Form's Controls collection (say it is named tBox1), and simply add it to my own collection (say an Hashtable) like so:
myTable.Add(myTable.Count, tBox1);

Wouldn't I be adding just a reference?
Thus the impact on the memory would be relatively small?

Or am I missing something here?

Nick Parker20-Aug-03 3:28

20-Aug-03 3:28

There are many ways in which you can tackle this, depending on the exact circumstances you should consider using a specific method. My method is rather abstract. Smile | :)

-Nick Parker

Philip Fitzsimons20-Aug-03 3:00

20-Aug-03 3:00

this won't work - t is TextBox, t would still be a Control which does not have a .Text field so use "as".
also why are you casting this.Controls? its a ControlCollection already...

foreach(Control t in this.Controls)<br />
{<br />
 TextBox tb = t as TextBox;<br />
<br />
 if(tb != null && tb.Text == String.Empty)<br />
 {<br />
  // Do something here<br />
  break;<br />
 }<br />
}

"When the only tool you have is a hammer, a sore thumb you will have."

Nick Parker20-Aug-03 3:02

20-Aug-03 3:02

Philip Fitzsimons wrote:
this won't work

Yes, it will, try it.

Philip Fitzsimons wrote:
also why are you casting this.Controls? its a ControlCollection already...

Test your code, it will fail if you don't cast it, mine did, I previously wasn't casting it. Smile | :)

-Nick Parker

Philip Fitzsimons20-Aug-03 3:08

20-Aug-03 3:08

I can't see who it would work - it won't work on my computer...

"t" is a Control.
"t.Text" is not valid on a Control.

how does it compile?

"When the only tool you have is a hammer, a sore thumb you will have."

Nick Parker20-Aug-03 3:25

20-Aug-03 3:25

Philip Fitzsimons wrote:
how does it compile?

Drop my code onto a form, it works. Big Grin | :-D

-Nick Parker

Philip Fitzsimons20-Aug-03 4:42

20-Aug-03 4:42

no it does not:

error CS0117: 'System.Web.UI.Control' does not contain a definition for 'Text'

"When the only tool you have is a hammer, a sore thumb you will have."

Nick Parker20-Aug-03 4:53

20-Aug-03 4:53

Philip Fitzsimons wrote:
no it does not:

Ah, I see you are doing this on an ASP.NET webform. This works on a Windows Form. Wink | ;)

-Nick Parker

Philip Fitzsimons20-Aug-03 5:07