|
As a general practice I use block markers. However this also depends on established coding standards as well, as some companies require them while others don't.
"Computer games don't affect kids; I mean if Pac-Man affected us as kids, we'd all be running around in darkened rooms, munching magic pills and listening to repetitive electronic music."
-- Marcus Brigstocke, British Comedian
|
|
|
|
|
IMHO, I prefer:
if (!whatever) return 'Something';
But if i need to put more code in a single line:
if (!whatever) {
return auxObj.toResult( data => {
} );
}
|
|
|
|
|
...nearly always.
If it's
if (!validity check) return errorcode;
Or
if (!validity check) throw somekindoferror;
then I don't.
And I don't care that you think there should be only one exit from a function: I do validity checking at the top of the function, report errors where I can, and exit immediately. That way the rest of the function is clean and using clean data.
Just makes things more obvious IMO.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
+1
I like validity checks at the beginning too.
But... if the validation is somewhere in the middle, then I set an "not OK" and only return at the end.
M.D.V. 
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
There should be a single exit from an algorithm. Functions are not algorithms, they are implementations of them, consisting of many different algorithms, such as input / error validation.
GCS d--(d-) s-/++ a C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- r+++ y+++* Weapons extension: ma- k++ F+2 X
|
|
|
|
|
But doing that, you miss out on 843 levels of indentation!
veni bibi saltavi
|
|
|
|
|
And that is what widescreen monitors were invented for! 
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
In my student days, one of the ACM periodicals (it might have been one of the SIG newsletters; I don't remember) had an article with the title 'The rightward migration of source code'. The problem became very apparent very soon after the introduction of 'structured programming', until programmers learned to distinguish between 'use' and 'overuse' of the concept.
|
|
|
|
|
OriginalGriff wrote: If it's
if (!validity check) return errorcode;</blockquote> Sure, but I burned my fingers on that one: It took me a day of debugging to realize the return was not effectuated until after the execution of the 'finally' clause in the enclosing exception block.
(The effect of the 'finally' clause taking for granted that all structures had been successfully updated, didn't manifest until far later in the execution order; that's why the problem took so long to find.)
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
