|
Hi,
I took a brief look at your project. Looks like you had a lot of fun working on it. I can see that you are using a compiler that supports at least C++14 just by looking at some of the features you are using. But it seems you are mostly writing in just C.
I suspect that you could make your library much simpler by using some C++17 features. You should be able to attach a std::basic_streambuf directly to your allocator buffer. You could then parse it with the C++17 std::basic_string_view.
Try playing around with this:
template <typename T>
class make_stream_buffer_no_copy : public std::basic_streambuf<T, std::char_traits<T> >
{
public:
make_stream_buffer_no_copy(T* p, std::streamsize n)
{
basic_streambuf<T>::setg(p, p, p + n);
basic_streambuf<T>::setp(p, p + n);
}
std::basic_string_view<T> get_string_view()
{
return std::basic_string_view<T>(basic_streambuf<T>::pbase(), basic_streambuf<T>::_Gcount);
}
}
You should be able to attach this directly to your MemoryPool base address.
If you decide to go ALL into C++17 then you could also rewrite MemoryPool with memory_resource[^] 
Best Wishes,
-David Delaune
|
|
|
|
|
You're looking at my old, messy codebase. My new one is cleaner and more efficient. At any rate I'm actually targeting C++11 (maybe 14?) i'm pretty sure (whatever the Arduino IDE uses) and I don't have access to a lot of the C++ standard stuff like the STL.
That's why it looks Cish. Arduino code is C++ but tends to be Cish due to lack of program space for all the extra code that templates tend to introduce.
Edit: adding, the difficulty isn't in managing pointers and data structures for me. That's second nature. That's where a lot of the full C++ features can help, but frankly, I can do without when necessary. I use them when I have them though for the most part. That said, the difficulty in this project was reducing RAM use by streaming everything and doing things like inline string compares right off the "filestream"
Real programmers use butterflies
|
|
|
|
|
honey the codewitch wrote: I don't have access to a lot of the C++ standard stuff
Yeah, the Arduino probably has std::basic_streambuf but it might not have std::basic_string_view.
|
|
|
|
|
yeah, I'm just sort of avoiding the STL altogether (except for some standard type definitions which arduino has as well) rather than both introducing confusion over what's there and what's not, and potentially introducing code bloat via templates. On these little machines every byte of program space counts.
Real programmers use butterflies
|
|
|
|
|
honey the codewitch wrote: hese little machines every byte of program space counts
Yeah, some years ago I had to write my own tcp/ip stack for a Rabbit semiconductor board. I remember having to support IEEE 802.1Q so I ended up with a single char[1522] which was enough room for parsing 1 packet at a time.
Fun times.
|
|
|
|
|
Nice. Right now I'm thrilled with myself, because after several innovations I was able to cram query results into dozens of bytes per row (and I only needed one row at a time) - basically the JSON reader *only* needs space enough in the capture for the largest string you're actually going to examine - you skip everything else and scan denormalized through the document until you find what you want, then you "extract" it - extractions are extremely efficient nested structures that allow you to direct the pull parser to retrieve certain elements. That way you can for example, retrieve say, 3 relevant fields off of an object regardless of field order, and one of those fields could have subobjects or arrays that get values extracted from them.
It does this all in one pass, and then returns the reader to a known good position after it has read over the necessary bit of the document. It returns tight structures representing all the data it captured in highly efficient recyclable memory pools which you can free any time you don't need anymore at almost no cost.
...(clipped)
S07E09 Bitter Pill
S07E10 Things Unseen
S07E11 Tipping Point
S07E12 Sea Change
S07E13 Reckoning
Scanned 112 episodes and -5320 characters in 9425 milliseconds using 23 bytes of LexContext and 50 bytes of the pool
Forgive the negative value - the little 8 bit proc can't handle a number in the 190k range being dumped to the serial port. it overflows and goes negative is all. otherwise everything on there is accurate. It took a total (not counting incidental locals on the stack) 73 bytes to extract an episode_number, season_number and name from each of the 112 episodes in the 200k burn notice series JSON document.
The reason it matters is this source JSON document I'm using is actually composed of several very "chunky" online dumps of the sort you tend to get from mongoDB repositories. I got the dumps from tmdb.com. Each http request generates lots of data, and you have to pick through it, which is what this is ultimately for - but it works on files too.
Real programmers use butterflies
|
|
|
|
|
Well,
I have not looked in depth at your JSON parser. But I imagine that it's probably a sliding window state machine because that's how I would do it. But that means your lib has some limitations that you're not telling us... such as the window size. Does it continue parsing on window overflow or bail out?
I'm too lazy to create a solution/project for your code. If you update your article and add that I'll take a closer look.
When I was looking yesterday... it appeared to be completely cross-platform...
|
|
|
|
|
1. You define the window size
2. It's quite miserly about how it uses it. Like in my last example, it only used 23 bytes of that window. That's because 90% of the data it only examines one character at a time. The remainder is the stuff you actually request.
3. On an out of memory error it halts the parse and (hopefully*) tries to recover to a known good position, like advancing past the remainder of a string value it got stuck in the middle of. Calling one of the navigation methods again should resume it. Eventually I may make a way to read values in chunks but for now I'm not worried about it. Mostly it would be to process things like base64 blobs
* this is a source of bugs, I'm sure. There's simply so many corner cases there's no way I'll catch them all without the library getting mature. If you've written parsers, you know how easy it is (sometimes) to do naive "panic mode" recovery where you just throw away symbols until a known good state, and how hard it is to actually do good error recovery. In this case, since it's a pull parser, "panic mode" isn't an option since I don't keep a stack.
Real programmers use butterflies
|
|
|
|
|
honey the codewitch wrote: Eventually I may make a way to read values in chunks
I guess if it's a garage hobby project it doesn't really matter but your lib would need to handle chunked 206 in the real world. There are many HTTP/S servers that completely ignore client headers such as Accept-Encoding and send a gzip stream anyway. Some will send a 206 and give you half the data you requested out of the blue.
For example Varnish Cache[^] always sends a 206 even when it sends you the whole file! Laymen believe that internet software is orderly and structured but it's really complete anarchy out there in the real world.
|
|
|
|
|
That's transport layer stuff my lib doesn't deal with. It knows nothing of files, HTTP, or sockets. I have a class I derive and implement a read() method to make it work for various input sources. You'd want that that supported HTTP properly.
Real programmers use butterflies
|
|
|
|
|
|
Not Santana ? And they go along with his philosophy that "you've got to Change Your Evil Ways".
| Ravings en masse^ |
|---|
| "The difference between genius and stupidity is that genius has its limits." - Albert Einstein | | "If you are searching for perfection in others, then you seek disappointment. If you seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010 |
|
|
|
|
|
I think it's a wreath of Franklin ...
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
|
They're doing it just to prove me wrong.
I keep posting, as appropriate, that "There's no cure for stupid".
Well, there is, actually, one cure - and dying (of COVID) doesn't where off.*
* unfortunately, the sharing will also hurt those who did know better.
| Ravings en masse^ |
|---|
| "The difference between genius and stupidity is that genius has its limits." - Albert Einstein | | "If you are searching for perfection in others, then you seek disappointment. If you seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010 |
|
|
|
|
|
Well, over here we had some 'pots & pans music' during prime minister Rutte's speech about the lockdown measures from his tower office in the Binnenhof, he did not let that disturb him though 
|
|
|
|
|
"Medley: I'll be Home for Christmas / Katie, Bar The Door"
|
|
|
|
|
Just Discovered: Reactions.
Countered the thumbs down with a thumbs up. And then some.
The only thing I can think of as non-positive is that isn't this behavior by UK'ers (and Parisians, at one point, too) a Leslie of sorts?
| Ravings en masse^ |
|---|
| "The difference between genius and stupidity is that genius has its limits." - Albert Einstein | | "If you are searching for perfection in others, then you seek disappointment. If you seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010 |
|
|
|
|
|
As I said to my son earlier today, these are the same idiots who behave idiotically in normal times. I had hoped that Covid would maybe act as a cull of this species, but the governments does not seem to want to let it.
|
|
|
|
|
Richard MacCutchan wrote: I had hoped that Covid would maybe act as a cull of this species, but the governments does not seem to want to let it.
The reason the government is not letting it happen (at least in some states) is that the cull would not be limited to the participants but will be further distributed into the others.
Your idea would work if we could gather all of them into a single location (like, for example, Alabama) and not let them out to spread it after giving it to one another. However - if we could isolate them in a single location like that the problem wouldn't be a problem and innumerable other problems would dissipate, as well.
| Ravings en masse^ |
|---|
| "The difference between genius and stupidity is that genius has its limits." - Albert Einstein | | "If you are searching for perfection in others, then you seek disappointment. If you seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010 |
|
|
|
|
|
My comment was strictly tongue ibn cheek. But I do recall a science fiction film years ago where aliens gave some people some gizmos which had "the power of life and death". Ultimately some clever scientist discovered that they could selectively destroy all the evil people on earth. Would that it were true.
|
|
|
|
|
W∴ Balboos, GHB wrote: The reason the government is not letting it happen (at least in some states) is that the cull would not be limited to the participants but will be further distributed into the others.
No, the real problem is that, with the exception of parts of the United States, Western governments have disarmed most law-abiding people. In the not-so-distant past, most law-abiding farmers also had shotguns, and you can be sure that they would be warning off any suspected plague-carriers from the cities.
Freedom is the freedom to say that two plus two make four. If that is granted, all else follows.
-- 6079 Smith W.
|
|
|
|
|
W∴ Balboos, GHB wrote: Your idea would work if we could gather all of them into a single location (like, for example, Alabama) and not let them out to spread it after giving it to one another.
Something similar was the master move in a book. If I recall correctly it was (translated back from spanish) "The mercenary" but I can't find it...
first I thought it was Heinlein's, but no...
Then I checked Pohl... no.
Pity... you would like it for sure.
M.D.V. 
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
Heinlein had a somewhat similar idea as "Coventry" in his future history, where people who cold not fit into society and who would not accept mental alteration were sent.
Freedom is the freedom to say that two plus two make four. If that is granted, all else follows.
-- 6079 Smith W.
|
|
|
|
|
I don't think it was it.
In the one I mean, the scene takes place in a football stadium. All those "insurgents" are taken there by the central char (supposedly a rebel too) and, when everybody is inside, the doors get closed and everyone inside gets killed.
The descriptions are pretty graphical and the "speech" of the "betrayor" after that is...  but on the same time it kind of makes sense in a macabre way. Short after the book ends.
Nevermind...
M.D.V. 
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
