Re: Changing the properties of multiple labels in some kind of loop? - C# Discussion Boards

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:17

Hi Pete

Thanks for your input.
That's what i'm trying to do, loop over all the controls but it's making the loop that i'm having difficulty with.

I see someone has just left me some example code so will check that out now, perhaps it's what i need.

Cheers
Ron

OriginalGriff16-Nov-20 5:06

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:06

There are several ways: the messiest is to scan the Forms Controls collection:

foreach (Control c in Controls)
    {
    if (c is Label lab)
        {
        lab.Visible = true;
        }
    }

It's messy for two reasons:
1) If any of the labels are within a container (e.g. a Panel) then you need to recurse through all container Controls collection as well.
2) If there are any labels you didn't want to hide, you have to "tag" them somehow to prevent you affecting them.

A neater solution is to construct an array or List of the labels you want to work with, and use that instead of the Form Controls collection. It's a little work to set up, but it's more specific and easier to code.

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!

Ralf Meier16-Nov-20 5:16

Ralf Meier

16-Nov-20 5:16

but to de-messy it :
he could check the Label-Name if it corresponds to those Labels he wants to work with.

Re: Changing the properties of multiple labels in some kind of loop?

OriginalGriff16-Nov-20 5:27

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:27

That's nasty as well, particularly once he realizes that sticking to VS default names for everything is a really bad idea ... Laugh | :laugh:

Ron_UK16-Nov-20 5:36

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:36

LOL! the default names seem fine to me, no problems yet and been using it for years.

Every so often you need to do something unusual and this is one of those cases.
I'm soon to work on a program with 256 labels to display register values from a chip so need to create another loop program to run through and update all the values in both hex & binary.

If i change the label names to say result1, result2, result3.
Could i use an alternative loop method to select the label name seeing they have digits at the end?

OriginalGriff16-Nov-20 5:48

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:48

Do yourself a favour, and stop using Visual Studio default names for everything - you may remember that "TextBox8" is the mobile number today, but when you have to modify it in three weeks time, will you then? Use descriptive names - "tbMobileNo" for example - and your code becomes easier to read, more self documenting, easier to maintain - and surprisingly quicker to code because Intellisense can get to to "tbMobile" in three keystrokes, where "TextBox8" takes thinking about and 8 keystrokes...

plan for maintenance: it will happen, and your memory of what is what will fade. Using descriptive names means that you can pick it back up faster in a few months time!

And 256 labels? Oh dear.
Use a DataTable instead, and set that as the DataSource for a table-based control (DataGridView) instead. It's a lot tidier, and much, much easier to work with (and layout neatly with scroll bars as required, and so forth)
It's also a lot easier on the user as well - you can provide search facilities very easily so they can find which register they are interested in much more quickly!

Ron_UK16-Nov-20 5:58

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:58

Hi Griff

Sound advice, thank you.

I'm being lazy Griff, I normally program Microcontrolles and always choose descriptive names for registers so i should really be more descriptive with Visual Studio names.

Yer i know, 256 labels, lol, i'm a glutton for punishment that's for sure.
I've only just changed them to text boxes as they look pretty smart all laid out.

I'll check the Data Table you mentioned, never had to use one before so will take a look in a moment.
VS has so many smart tools, i've only every used 25% of them over the years.

Thanks again for your help.
Ron Smile | :)

Ron_UK16-Nov-20 5:19

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:19

Hi Griff

Ahhhhhh, that rings a bell now, thanks for the example.
Brain needed a gentle nudge, been a while since i did it.

Thanks for replying so quickly and for the advice.

Cheers
Ron

OriginalGriff16-Nov-20 5:27

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:27

You're welcome!

Ron_UK16-Nov-20 8:39

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 8:39

Hi Griff

The code worked a treat, thank you.
I just adjusted it to work with my text boxes instead of labels and hey presto.

Hopefully this info will help another poor soul in the future.

Many thanks
Ron

OriginalGriff16-Nov-20 9:29

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 9:29

You're welcome!

Luc Pattyn16-Nov-20 5:30

Luc Pattyn

16-Nov-20 5:30

And if you're really lucky there is an extremely simple approach that takes only a single line of code:
let's assume you have say 9 textboxes and 9 labels telling what the textboxes are for; let's hope they are all organized in two columns, so all neatly atop each other.

Now add a Panel to your Form, covering all the space where you want the labels to go, but not covering anything else (that is where you need to be lucky). Now put the labels on the Panel, not on the Form itself. You can now make all labels (in)visible by changing the visibility of the Panel! And that takes a single line of code...

Smile | :)

Luc Pattyn [My Articles]
If you can't find it on YouTube try TikTok...

Re: Changing the properties of multiple labels in some kind of loop?

Ron_UK16-Nov-20 5:40

Re: Changing the properties of multiple labels in some kind of loop?

16-Nov-20 5:40

Hi Luc

Thanks for the tip, amazing how the simplest of idea's are staring you in the face, lol!

To be honest i need to make other changes too, like updating the text on each with a different value.
I'm working on a big project to display register values of a chip.

What i was hoping to do was use some kind of simple for loop to access the label name seeing that the names have a digit at the end, then update the properties when needed.

Cheers
Ron

Gerry Schmitz16-Nov-20 7:13

Gerry Schmitz

16-Nov-20 7:13

If you subclass the label, or make the equivalent user control, you can add code to the constructor and / or loaded / initialized events to automatically "register" the label in a (static) collection that you can iterate at will at run time.

It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food

How to make a dll library?

Alex Dunlop16-Nov-20 0:22

16-Nov-20 0:22

I have wrote some lines of code for exporting DataGridView contents to Excel file. The code works fine in the main Form. I want to make a class (.dll file) from my code so I could use it as reference in many projects. How is it possible?
My code is:

private void btnExport_Click(object sender, EventArgs e)
       {
           Microsoft.Office.Interop.Excel._Application app = new Microsoft.Office.Interop.Excel.Application();
           Microsoft.Office.Interop.Excel._Workbook workbook = app.Workbooks.Add(Type.Missing);
           Microsoft.Office.Interop.Excel._Worksheet worksheet = null;
           worksheet = workbook.Sheets["Sheet1"];
           worksheet = workbook.ActiveSheet;
           worksheet.Name = "pmInfo";
           for (int i = 1; i < dataGridView1.Columns.Count+1; i++)
           {
               worksheet.Cells[1, i] = dataGridView1.Columns[i - 1].HeaderText;
           }
           for (int i = 0; i < dataGridView1.Rows.Count; i++)
           {
               for (int j = 0; j < dataGridView1.Columns.Count; j++)
               {
                   worksheet.Cells[i + 2, j + 1] = dataGridView1.Rows[i].Cells[j].Value.ToString();
               }
           }
           var saveFileDialoge = new SaveFileDialog();
           saveFileDialoge.FileName = "Output";
           saveFileDialoge.DefaultExt = ".xlsx";
           if (saveFileDialoge.ShowDialog()==DialogResult.OK)
           {
               workbook.SaveAs(saveFileDialoge.FileName, Type.Missing, Type.Missing, Type.Missing, Type.Missing, Type.Missing, Microsoft.Office.Interop.Excel.XlSaveAsAccessMode.xlExclusive, Type.Missing, Type.Missing, Type.Missing, Type.Missing, Type.Missing);

           }
       }

Create a .NET Standard class library using Visual Studio - .NET Core | Microsoft Docs[^]

Richard MacCutchan16-Nov-20 0:44

Richard MacCutchan

16-Nov-20 0:44

Alex Dunlop16-Nov-20 0:47

16-Nov-20 0:47

I pasted this code in the Class, but "Columns" and "Rows" have red underline. I cannot compile the class.

Richard MacCutchan16-Nov-20 0:51

Richard MacCutchan

16-Nov-20 0:51

There is quite a bit missing from that code to make it into a dll. I suggest you follow the link I gave you and read up on how to make a class library.

OriginalGriff16-Nov-20 0:50

16-Nov-20 0:50

First, make it as generic as possible: instead of writing it as an Event handler which works with a specific DataGridView and Sheet make it a generic routine that takes several parameters: The data source, the Sheet name, and the file path to write to. You call that generic method from your handler.
Ideally, you shouldn't pass a control like a DGV, but the underlying datasource it uses instead. You can access the properties from that quite easily - this shows you how: Converting a List to a DataTable[^]

You should not be using a dialog in a dll, as there is no guarantee that the calling application will be running under windows - it potentially could be a web app or on a server, where the user can't see a SaveFileDialog, and shouldn't have access to the file system anyway.

Then create a new Project as a ClassLibrary and move your method into it.
Add a reference (and using statement if necessary) to the library to your original project, and you can call it from there.

Alex Dunlop16-Nov-20 1:51

16-Nov-20 1:51

I tried the following class code. Now, my problem is that "Rows" and "Columns" have red underline. They have not been defined in my class while I have used Microsoft Office Excel 16 object reference.
How can I sole those red underlines?
My updated code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace DataGridView
{
    class ExcelExport
    {

        public void Export(string fileName, string DataSource,string FileName)
        {
            /*fileName is the name of the file will be written.
            DataSource is the DataGridView name used*/
            Microsoft.Office.Interop.Excel._Application app = new Microsoft.Office.Interop.Excel.Application();
            Microsoft.Office.Interop.Excel._Workbook workbook = app.Workbooks.Add(Type.Missing);
            Microsoft.Office.Interop.Excel._Worksheet worksheet = null;
            worksheet = workbook.Sheets["Sheet1"];
            worksheet = workbook.ActiveSheet;
            worksheet.Name = fileName;
            for (int i = 1; i < DataSource.Columns.Count + 1; i++)
            {
                worksheet.Cells[1, i] = DataSource.Columns[i - 1].HeaderText;
            }
            for (int i = 0; i < DataSource.Rows.Count; i++)
            {
                for (int j = 0; j < DataSource.Columns.Count; j++)
                {
                    worksheet.Cells[i + 2, j + 1] = DataSource.Rows[i].Cells[j].Value.ToString();
                }
            }
            var saveFileDialoge = new SaveFileDialog();
            saveFileDialoge.FileName = FileName;
            saveFileDialoge.DefaultExt = ".xlsx";
            if (saveFileDialoge.ShowDialog() == DialogResult.OK)
            {
                workbook.SaveAs(saveFileDialoge.FileName, Type.Missing, Type.Missing, Type.Missing, Type.Missing, Type.Missing, Microsoft.Office.Interop.Excel.XlSaveAsAccessMode.xlExclusive, Type.Missing, Type.Missing, Type.Missing, Type.Missing, Type.Missing);

            }
        }
    }
}

OriginalGriff16-Nov-20 2:17

16-Nov-20 2:17

Look at your code:

public void Export(string fileName, string DataSource,string FileName)
        {
            /*fileName is the name of the file will be written.
            DataSource is the DataGridView name used*/
...
            for (int i = 1; i < DataSource.Columns.Count + 1; i++)

Why do you think that a string would have rows or columns?

Alex Dunlop16-Nov-20 2:25

16-Nov-20 2:25

Yes, I notice my fault later. But I tried to create an DGV object like this:

private DataGridView DataSource = new DataGridView();

But it shows red underline under DataGridView. It says, DataGridView is a namespace.

OriginalGriff16-Nov-20 2:41

16-Nov-20 2:41

Why are you trying to create a DataGridView at all? Do you expect magic to happen and it to be filled with data that exists in a different DataGridView?

Why do I get the feeling that you have no idea what you are doing, and are so far out of your depth that you are just guessing what to try? You didn't write that Excel code at all, did you?

Alex Dunlop16-Nov-20 2:48