Re: WPF: Can't get what I need to do to get things right (responsive controls). - WPF Discussion Boards

Re: WPF: Can't get what I need to do to get things right (responsive controls).

23-Aug-18 0:41

hello Richard,
While playing around "Symbiosis" of ViewBox and Canvas I stumbled across a weird behavior of Canvas.
Eg., both ViewBox and Canvas are (Grid.Row="1"). I've got "Row1" dimensions and made a Canvas (Sketch inside) with exactly same dimensions. Then I put it into a ViewBox. Yes, as I wrote yesterday this "Symbiosis" keeps position and scales controls. That's true.
However, I noticed one weirdness. I colored Canvas and when I maximized window (1920x1080) I had seen that Canvas hadn't overlapped entire width of the window. There were two pretty wide, vertical non-colored "columns", to the left and right of colored Canvas.

P.S. I've tried to play with Canvas' height and width, to no avail. It just disappears, if it has no dimensions.

Code:

<Window x:Class="WpfApplication6.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:local="clr-namespace:WpfApplication6"
        mc:Ignorable="d"
        Title="MainWindow" Height="768" Width="1024" MinHeight="768" MinWidth="1024" MaxHeight="1080" MaxWidth="1920" WindowStartupLocation="CenterScreen" >


    <Grid ShowGridLines="True">
        <Grid.RowDefinitions >

            <RowDefinition Height="80"/>
            <RowDefinition Height="1*"/>
            <RowDefinition Height="160"/>

        </Grid.RowDefinitions>

        <Viewbox  Grid.Row="1" HorizontalAlignment="Center" VerticalAlignment="Center" Stretch="Uniform" StretchDirection="Both">

            <Canvas  Width="1024" Height="500"  Background="Bisque">

                <Path Data="M319.5,255.83333 L511.5,255.47633" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1.357" Margin="255.468,175.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="193"/>
                <Path Data="M511.57098,255.50012 L526.16688,303.50007" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="49" Margin="447.468,175.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="15.596"/>
                <Path Data="M526.62867,303.49938 L526.62867,319.49875" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="17" Margin="462.064,223.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="1"/>
                <Path Data="M319.5,235.34375 L319.5,299" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="64.656" Margin="255.468,175.844,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="1"/>
                <Path Data="M321,320.5 L336,320.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1" Margin="255.468,239.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="16"/>
                <Path Data="M444.85589,319.5 L459.39349,319.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1" Margin="447.468,239.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="15.537"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="28.5" Margin="259.468,179.5,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="31.5"/>
                <Path Data="M446.54684,283.34826 L453.83331,299.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="39" Margin="445.468,181.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="11.266"/>
                <Path Data="M442.48196,282.90707 L442.58496,299.49959" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="39" Margin="439.468,181.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="1.103"/>
                <Path Data="M441.82235,299.49664 L453.8333,299.49666" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1" Margin="439.468,219.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="17.266"/>
                <Ellipse Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="25" Margin="419.365,227.302,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="25"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="28" Margin="531.921,176,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="65"/>
                <TextBlock x:Name="textBlock" HorizontalAlignment="Left" Height="17" Margin="534.924,181,0,0" Grid.Row="1"  Text="Bus station" VerticalAlignment="Top" Width="59" Foreground="#FF4E2323"/>
                <Path Data="M590.09595,283.93897 L590.09595,336.20181" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="52" Margin="561.819,202.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="3" StrokeThickness="3"/>
                <Path Data="M503.5,261.5 L509.5,261.857" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1.357" Margin="439.468,181.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="7"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="32.143" Margin="424.218,181.857,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="14.5"/>
                <Path Data="M511.91667,319.5 L504.91667,305.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="15" Margin="441.468,225.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="7"/>
                <Path Data="M483.95601,305.5 L504.95601,305.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1" Margin="420.468,225.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="22"/>
                <Path Data="M484.5,305.5 L479,319.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="15" Margin="414.968,225.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="6.5"/>
                <Ellipse Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="25" Margin="274.968,227.302,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="25"/>
                <Path Data="M511.91667,319.5 L504.91667,305.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="15" Margin="297.435,225.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="7"/>
                <Path Data="M483.95601,305.5 L504.95601,305.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1" Margin="276.602,225.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="22"/>
                <Path Data="M484.867,305.5 L479,319.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="15" Margin="270.601,225.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="6.867"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="28.5" Margin="295.968,179.5,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="31.5"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="28.5" Margin="332.468,179.5,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="31.5"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="28.5" Margin="366.968,179.5,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="21"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="58.5" Margin="389.968,179.5,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="20"/>
                <Rectangle Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="26.143" Margin="392.968,181.857,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="14"/>
                <Path Data="M367.50001,319.5 L479.08333,319.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="1" Margin="303.468,239.5,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="112.583"/>
                <Ellipse Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="8" Margin="283.593,235.375,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="8"/>
                <Ellipse Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="8" Margin="428.218,235.5,0,0" Grid.Row="1" Stroke="Black" VerticalAlignment="Top" Width="8"/>
                <Path Data="M320.5,332.302 L668.532,333.5" Fill="#FFF4F4F5" HorizontalAlignment="Left" Height="2.198" Margin="256.468,252.302,0,0" Grid.Row="1" Stretch="Fill" Stroke="Black" VerticalAlignment="Top" Width="349.032"/>
                <Path Data="M512.5,119 L512.5,529" Fill="#FFF5F4F4" HorizontalAlignment="Left" Height="411" Margin="495.158,39,0,0" Grid.Row="1" Stretch="Fill" Stroke="#FFF11C3A" VerticalAlignment="Top" Width="1"/>
                <TextBlock x:Name="textBlock1" HorizontalAlignment="Left" Height="39" TextWrapping="Wrap" Text="I need that Row" VerticalAlignment="Top" Width="331" FontSize="24" TextAlignment="Center" Canvas.Left="334" Canvas.Top="-59"/>
                <TextBlock x:Name="textBlock1_Copy" HorizontalAlignment="Left" Height="39" TextWrapping="Wrap" Text="I need that Row" VerticalAlignment="Top" Width="332" FontSize="24" TextAlignment="Center" Grid.Row="2" Canvas.Left="332" Canvas.Top="562"/>
                <TextBlock x:Name="textBlock2" HorizontalAlignment="Left" Height="24" Margin="387.968,10,0,0" Grid.Row="1" TextWrapping="Wrap" Text="Center vert. line of the 1024x768 screen" VerticalAlignment="Top" Width="277.032"/>

            </Canvas>
        </Viewbox>


    </Grid>




</Window>

thanks in advance!

modified 23-Aug-18 7:00am.

Richard Deeming23-Aug-18 8:15

Re: WPF: Can't get what I need to do to get things right (responsive controls).

23-Aug-18 8:15

The Viewbox has Stretch="Uniform". That means it won't change the aspect ratio of the child Canvas.

If you resize the window so that row 1 has an aspect ratio that isn't 256 × 125 (1024 × 500), then you'll end up with spaces around your Viewbox, either on the left and right sides, or on the top and bottom sides.

If you want to fill the entire background of the row, add a Rectangle to the same grid row, outside of the Viewbox, and set your fill there. You'll need to add it to the markup before the Viewbox, so that the rectangle appears behind it.

XML

<Rectangle Grid.Row="1" Fill="Bisque" />

<Viewbox  Grid.Row="1" HorizontalAlignment="Center" VerticalAlignment="Center" Stretch="Uniform" StretchDirection="Both">
    <Canvas Width="1024" Height="500"> <!-- No background colour here -->
        ...
    </Canvas>
</Viewbox>

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Pew_new23-Aug-18 8:34

Re: WPF: Can't get what I need to do to get things right (responsive controls).

23-Aug-18 8:34

I think that the case with rectangle isn't a way.
I need overlapping of entire Row1 by Canvas. Because I'm going to use whole space of Row1, from left to right.
True, I can't figure out what I need to do for that.

modified 23-Aug-18 14:41pm.

Richard Deeming23-Aug-18 8:39

Re: WPF: Can't get what I need to do to get things right (responsive controls).

23-Aug-18 8:39

I can assure you, it is the way. Smile | :)

Try it and see.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Pew_new23-Aug-18 8:52

Re: WPF: Can't get what I need to do to get things right (responsive controls).

23-Aug-18 8:52

Yes, agree. That's fake way.

There's no canvas at fake colored places. Smile | :)

I need overlapping of entire Row1.

Richard Deeming23-Aug-18 9:05

Re: WPF: Can't get what I need to do to get things right (responsive controls).

23-Aug-18 9:05

You can't have the canvas maintain its aspect ratio and cover the entire space at the same time.

Either the canvas will be distorted, or there will be spaces around it.

There's nothing "fake" about using a rectangle to fill the background of the row.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Pew_new24-Aug-18 3:09

Re: WPF: Can't get what I need to do to get things right (responsive controls).

24-Aug-18 3:09

Richard>There's nothing "fake" about using a rectangle to fill the background of the row.

It would be better if that Rectangle would help me to adapt a Canvas properly. Smile | :)

I saw at least a few apps where Canvas was playing, so to speak, one of key roles and excellently adapted to the range of resolutions. From relatively older 1024x768 to modern 1920x1080.
Unfortunately the history has no records by which way it was made. Confused | :confused:

I've tried many variants of ViewBox/Canvas symbiosis and different Canvas aspect ratios, to no avail.
Previously I thought that WPF (in contrast with WinForm) is more advanced stuff, at least in terms of adaptation/responsiveness. Now, I see it's not that. Thumbs Down | :thumbsdown:

I guess there are ways to solve that. But they are not based on pure XAML.

modified 24-Aug-18 9:42am.

Gerry Schmitz24-Aug-18 6:08

Gerry Schmitz

24-Aug-18 6:08

You approached it all wrong.

At a minimum, all your "graphics" should have been a "user control".

You've mixed content for 3 rows.

As mentioned, "margins" are for "touching up"; not "layout".

Why "paths" instead of "images"?

None of it makes any sense.

"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal

Re: WPF: Can't get what I need to do to get things right (responsive controls).

Pew_new25-Aug-18 7:36

Scale items with ViewBox within an ItemsControl

25-Aug-18 7:36

Gerry Schmitz> you approached it all wrong.

OK, these words are just words.
Could you show me correct approaches by means of uploading a working code (as it was done above, in previous posts).
Let's suppose. It'll be "simpliest" task called " how to make Canvas to be fully adaptive/responsive to the range of resolutions e.g. 1024x768 ---> 1920x1080".

Really have no clue how to do that by professional way.
I would be much appreciated.

modified 25-Aug-18 13:58pm.

Kenneth Haugland7-Aug-18 6:07

Kenneth Haugland

7-Aug-18 6:07

So I have some FrameworkElements that I want to scale with a ViewBox. This works fine with normal XAML code:

HTML

<Viewbox Height="100" Width="100">
    <local:InfiniteLoadDiagramBase/>
</Viewbox>

But as soon as I want to join them together and scale them appropriately to the available size I have a problem:

HTML

<ItemsControl x:Name="MyItems">
           <ItemsControl.ItemsPanel>
               <ItemsPanelTemplate>
                   <WrapPanel>
                   </WrapPanel>
               </ItemsPanelTemplate>
           </ItemsControl.ItemsPanel>
           <ItemsControl.ItemTemplate>
               <DataTemplate>
                   <Viewbox Height="100" Width="100" Stretch="UniformToFill">
                       <ContentControl Content="{Binding}"/>
                   </Viewbox>
               </DataTemplate>
           </ItemsControl.ItemTemplate>
       </ItemsControl>

The ViewBox simply refuses to scale them according to the set size of the ViewBox. Any ideas on how to fix this?

Re: Scale items with ViewBox within an ItemsControl

Kenneth Haugland8-Aug-18 3:56

Kenneth Haugland

8-Aug-18 3:56

Still havent found out what was wrong with this, but here is one of the FrameworkElements Im trying to bind the ItemsControl to

public class SourceDiagramBase : FrameworkElement, INotifyPropertyChanged
{
    private VisualCollection _children;

    public SourceDiagramBase()
    {
        _children = new VisualCollection(this);
        _children.Add(CreateDrawingVisual());
    }

    protected override int VisualChildrenCount { get { return _children.Count; } }


    protected override Visual GetVisualChild(int index)
    {
        return _children[index];
    }



    public double Scale
    {
        get { return (double)GetValue(ScaleProperty); }
        set { SetValue(ScaleProperty, value); }
    }

    // Using a DependencyProperty as the backing store for Scale.  This enables animation, styling, binding, etc...
    public static readonly DependencyProperty ScaleProperty =
        DependencyProperty.Register("Scale", typeof(double), typeof(SourceDiagramBase), new PropertyMetadata(20d));

    protected override Size MeasureOverride(Size availableSize)
    {
        return new Size(this.Scale * 12d, this.Scale * 12d);
    }


    private DrawingVisual CreateDrawingVisual()
    {
        DrawingVisual drawingVisual = new DrawingVisual();
        DrawingContext drawingContext = drawingVisual.RenderOpen();

        drawingContext.PushTransform(new ScaleTransform(this.Scale, this.Scale));

        double thick = 0.04;
        drawingContext.DrawEllipse(Brushes.Transparent, new Pen(Brushes.Black, thick), new Point(6, 6), 3,3);

        drawingContext.DrawLine(new Pen(Brushes.Black, thick), new Point(6, 3), new Point(6, 2));
        drawingContext.DrawLine(new Pen(Brushes.Black, thick), new Point(6, 9), new Point(6, 10));

        drawingContext.DrawLine(new Pen(Brushes.Black, thick), new Point(6, 2), new Point(12, 2));
        drawingContext.DrawLine(new Pen(Brushes.Black, thick), new Point(6, 10), new Point(12, 10));

        drawingContext.Close();
        return drawingVisual;
    }

    public event PropertyChangedEventHandler PropertyChanged;

    // This method is called by the Set accessor of each property.
    // The CallerMemberName attribute that is applied to the optional propertyName
    // parameter causes the property name of the caller to be substituted as an argument.
    private void NotifyPropertyChanged([CallerMemberName] String propertyName = "")
    {
        if (PropertyChanged != null)
        {
            PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
        }
    }
}

PredicateBuilder Question

Kevin Marois14-Jul-18 18:21

Re: PredicateBuilder Question

14-Jul-18 18:21

I'm querying 3 tables with Joins:

// List for returning results
List<PurchasingEntity> results = null;

// Query of all joined records 
IQueryable<PurchasingEntity> query = (from c in db.Companies
                                        join p in db.Projects on c.Id equals p.CompanyId
                                        join j in db.Jobs on p.Id equals j.ProjectId
                                        select new PurchasingEntity
                                        {
                                            CompanyId = c.Id,
                                            CompanyName = c.CompanyName,
                                            ProjectId = p.Id,
                                            ProjectName = p.ProjectName,
                                            ProjectStatusId = p.StatusId.HasValue ? p.StatusId : 0,
                                            JobId = j.Id,
                                            JobNumber = j.JobId,
                                            Phase = j.Phase,
                                            Quantity = j.Quantity.HasValue ? j.Quantity.Value : 0,
                                            StartDate = j.StartDate.HasValue ? j.StartDate : null,
                                            LumberVendorId = j.LumberVendorId,
                                            HardwareVendorId = j.HardwareVendorId,
                                            TrussVendorId = j.TrussVendorId
                                        });

// Create the PredicateBuilder
var predicate = PredicateBuilder.True<PurchasingEntity>();

// Add status Awarded filter
predicate = predicate.And(i => i.ProjectStatusId == awardedId);

// Add optional query parameters
if (companyId > 0)
{
    predicate = predicate.And(i => i.CompanyId == companyId);
}

if (projectId > 0)
{
    predicate = predicate.And(i => i.ProjectId == projectId);
}

if (startDate != null)
{
    predicate = predicate.And(i => i.StartDate >= startDate);
}

if (endDate != null)
{
    predicate = predicate.And(i => i.StartDate <= endDate);
}

// Set the query's WHERE clause to the predicate and call ToList
results = query.Where(predicate).ToList();

I doh't want to include an Companies, Projects, or Jobs if they are marked as deleted, which is DeletedDT.HasValue.

The problem is that the PredicateBuilder is working on type PurchasingEntity which is being formed via the join.

How do I filter these out???

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming16-Jul-18 8:19

Re: PredicateBuilder Question

16-Jul-18 8:19

You'll need to add the filters to the base query:

from c in db.Companies
join p in db.Projects on c.Id equals p.CompanyId
join j in db.Jobs on p.Id equals j.ProjectId
where c.DeletedDT == null && p.DeletedDT == null && j.DeletedDT == null
...

Also, since you're combining all of the filters using And, you don't actually need the predicate builder. Calling Where multiple times will have the same effect.

query = query.Where(i => i.ProjectStatusId == awardedId);

// Add optional query parameters
if (companyId > 0)
{
    query = query.Where(i => i.CompanyId == companyId);
}

if (projectId > 0)
{
    query = query.Where(i => i.ProjectId == projectId);
}

if (startDate != null)
{
    query = query.Where(i => i.StartDate >= startDate);
}

if (endDate != null)
{
    query = query.Where(i => i.StartDate <= endDate);
}

results = query.ToList();

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Gerry Schmitz16-Jul-18 10:15

Gerry Schmitz

16-Jul-18 10:15

Seems like a candidate for an "active entity" view:

How to Use SQL Server Views with the Entity Framework

"(I) am amazed to see myself here rather than there ... now rather than then".
― Blaise Pascal

WPF HyperLink Binding To MainWindowViewMOdel Not Working

Kevin Marois9-Jul-18 17:02

Re: WPF HyperLink Binding To MainWindowViewMOdel Not Working

9-Jul-18 17:02

Here's my link:

<TextBlock Grid.Row="0" 
            Margin="5">

    <Hyperlink x:Name="link">
        <TextBlock Text="Purchasing"
                    FontSize="14"/>
        <i:Interaction.Triggers>
            <i:EventTrigger EventName="Click">
                <i:InvokeCommandAction Command="{Binding ActionCommand, RelativeSource={RelativeSource AncestorType=Window}}"
                                        CommandParameter="{Binding ElementName=link}"/>
            </i:EventTrigger>
        </i:Interaction.Triggers>
    </Hyperlink>

</TextBlock>

I get

System.Windows.Data Error: 40 : BindingExpression path error: 'ActionCommand' property not found on 'object' ''MainWindowView' (Name='window')'. BindingExpression:Path=ActionCommand; DataItem='MainWindowView' (Name='window'); target element is 'InvokeCommandAction' (HashCode=36783718); target property is 'Command' (type 'ICommand')

It is trying to bind to the VIEW, not the VIEWMODEL. What's wrong here?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Pete O'Hanlon9-Jul-18 20:07

Pete O'Hanlon

9-Jul-18 20:07

Your RelativeSource is set a Window. As WPF allows you to bind to other controls, as well as ViewModels, it makes no assumptions about what you are trying to do so it doesn't automatically try to pick up the DataContext. Try changing this to {Binding DataContext.ActionCommand, RelativeSource={RelativeSource AncestorType=Window}} instead.

This space for rent

Re: WPF HyperLink Binding To MainWindowViewMOdel Not Working

Kevin Marois10-Jul-18 6:53

Bind TabItem ContexMenu Command To Window VM

10-Jul-18 6:53

That did it. Thank you.

Any thoughts on this? Probably similar but I can't seem to get it right.

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Kevin Marois8-Jul-18 12:03

8-Jul-18 12:03

I'm adding a context menu to my tabs with "Close", "Close All", and "Close All But This". Heres' the XAML:

<Style TargetType="TabItem">

    <Setter Property="ContextMenu">
        <Setter.Value>
            <ContextMenu>

                <MenuItem Header="Close All" 
                        Command="{Binding DataContext.CloseTabCommand, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType={x:Type MenuItem}, AncestorLevel=1}}"
                        CommandParameter="{Binding }"/>

                <MenuItem Header="Close All" 
                        Command="{Binding DataContext.CloseAllTabsCommand, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType={x:Type MenuItem}, AncestorLevel=1}}"
                        CommandParameter="{Binding }"/>

                <MenuItem Header="Close All But This" 
                        Command="{Binding DataContext.CloseAllButThisTabCommand, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType={x:Type MenuItem}, AncestorLevel=1}}"
                        CommandParameter="{Binding }"/>

            </ContextMenu>
        </Setter.Value>
    </Setter>

</Style>

The biding isn't work. The commands aren't called. Here's the output window messages:

System.Windows.Data Error: 4 : Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='System.Windows.Controls.MenuItem', AncestorLevel='1''. BindingExpression:Path=DataContext.CloseTabCommand; DataItem=null; target element is 'MenuItem' (Name=''); target property is 'Command' (type 'ICommand')

System.Windows.Data Error: 4 : Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='System.Windows.Controls.MenuItem', AncestorLevel='1''. BindingExpression:Path=DataContext.CloseAllTabsCommand; DataItem=null; target element is 'MenuItem' (Name=''); target property is 'Command' (type 'ICommand')

System.Windows.Data Error: 4 : Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='System.Windows.Controls.MenuItem', AncestorLevel='1''. BindingExpression:Path=DataContext.CloseAllButThisTabCommand; DataItem=null; target element is 'MenuItem' (Name=''); target property is 'Command' (type 'ICommand')

What's the right way to bind the menu item's command to the main window's VM?

Thanks

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming9-Jul-18 8:35

WPF: ContextMenu Strikes Again. DataContext Not Updated[^]

9-Jul-18 8:35

XML

<ContextMenu DataContext="{Binding PlacementTarget.DataContext, RelativeSource={RelativeSource Self}}">

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois9-Jul-18 16:23

9-Jul-18 16:23

Well that didn't work. I've tried a number of things. This is what I have now.

<Style TargetType="TabItem">

    <Setter Property="ContextMenu">
        <Setter.Value>
            <ContextMenu DataContext="{Binding DataContext, ElementName=Window}">

                <MenuItem Header="Close" 
                            Command="{Binding CloseTabCommand}"
                            CommandParameter="{Binding}"/>

                <MenuItem Header="Close All Tabs" 
                            Command="{Binding CloseAllTabsCommand}"
                            CommandParameter="{Binding}"/>

                <MenuItem Header="Close All But This" 
                            Command="{Binding CloseAllButThisTabCommand}"
                            CommandParameter="{Binding}"/>

            </ContextMenu>
        </Setter.Value>
    </Setter>

    <Setter Property="Template">
        <Setter.Value>
            <ControlTemplate TargetType="TabItem">
                <Grid Name="Panel">
                    <ContentPresenter x:Name="ContentSite"
                                        VerticalAlignment="Center"
                                        HorizontalAlignment="Center"
                                        ContentSource="Header"
                                        Margin="10,2"/>
                </Grid>
                <ControlTemplate.Triggers>
                    <Trigger Property="IsSelected" Value="True">
                        <Setter TargetName="Panel" Property="Background" Value="LightSkyBlue" />
                    </Trigger>
                    <Trigger Property="IsSelected" Value="False">
                        <Setter TargetName="Panel" Property="Background" Value="White" />
                    </Trigger>
                </ControlTemplate.Triggers>
            </ControlTemplate>
        </Setter.Value>
    </Setter>

</Style>

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Pete O'Hanlon10-Jul-18 7:08

Pete O'Hanlon

10-Jul-18 7:08

ElementName is looking for an element named Window. If you haven't named your window "Window", that's not going to work. The RelativeSource you do in your other post should find the owning Window.

This space for rent

Kevin Marois10-Jul-18 7:38

10-Jul-18 7:38

I have the window's name set to 'window'.

This is driving me nuts. I can't seem to get this right. here's what I have now:

<Style TargetType="TabItem">

    <Setter Property="ContextMenu">
        <Setter.Value>
            <ContextMenu DataContext="{Binding DataContext, RelativeSource={RelativeSource AncestorType=Window}}"
                    x:Name="tabMenu">

                <MenuItem Header="Close" 
                    Command="{Binding CloseTabCommand}"
                    CommandParameter="{Binding}"/>

                <MenuItem Header="Close All Tabs" 
                    Command="{Binding CloseAllTabsCommand}"
                    CommandParameter="{Binding}"/>

                <MenuItem Header="Close All But This" 
                    Command="{Binding CloseAllButThisTabCommand}"
                    CommandParameter="{Binding}"/>

            </ContextMenu>
        </Setter.Value>
    </Setter>

    <Setter Property="Template">
        <Setter.Value>
            <ControlTemplate TargetType="TabItem">
                <Grid Name="Panel">
                    <ContentPresenter x:Name="ContentSite"
                                VerticalAlignment="Center"
                                HorizontalAlignment="Center"
                                ContentSource="Header"
                                Margin="10,2"/>
                </Grid>
                <ControlTemplate.Triggers>
                    <Trigger Property="IsSelected" Value="True">
                        <Setter TargetName="Panel" Property="Background" Value="LightSkyBlue" />
                    </Trigger>
                    <Trigger Property="IsSelected" Value="False">
                        <Setter TargetName="Panel" Property="Background" Value="White" />
                    </Trigger>
                </ControlTemplate.Triggers>
            </ControlTemplate>
        </Setter.Value>
    </Setter>

</Style>

The Output Window shows

System.Windows.Data Error: 4 : Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='System.Windows.Window', AncestorLevel='1''. BindingExpression:Path=DataContext; DataItem=null; target element is 'ContextMenu' (Name='tabMenu'); target property is 'DataContext' (type 'Object')

Again, it looks like it can't find the Window.

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Pete O'Hanlon10-Jul-18 10:40

Pete O'Hanlon

10-Jul-18 10:40

Sorry, I misread the part that this was a context menu. A context menu doesn't sit in the visual tree so you can't relative source back to it. What you're looking to do will be some variation of this[^].

This space for rent

Kevin Marois10-Jul-18 11:21