C / C++ / MFC

Anthony Appleyard28-Jul-18 18:35

28-Jul-18 18:35

The affected project ('dragclip_vc') is still doing it this morning (5.37 a.m. by UK time), and wanting this upgrade every time that I open it.

The other mentioned project ('makeobj_vc') opened correctly this morning and did not ask for this upgrade again.

If needed, I have old backup copies of all my Visual C++ projects on an offload-disk.

modified 29-Jul-18 0:47am.

Richard MacCutchan28-Jul-18 22:20

28-Jul-18 22:20

This is not that unusual. The upgrade system in Visual Studio can have problems for a variety of reasons. Your best bet is just to create a new project, and then copy the source files into the new project location and add them manually to the project.

Victor Nijegorodov28-Jul-18 21:22

Victor Nijegorodov

28-Jul-18 21:22

Anthony Appleyard wrote:
But in the last few days, an automatic upgrade came: it shows a MessageBox that says "One-way upgrade. Visual Studio will automatically make functional changes to the following projects in order to open them

What VS version are you using?
In what version is it about to upgrade?

Anthony Appleyard28-Jul-18 23:39

28-Jul-18 23:39

Victor Nijegorodov wrote:
What VS version are you using?
In what version is it about to upgrade?

When I run my project makeobj_vc , the initial black panel shows "Visual Studio / Community 2015".

When I opened its help just now, a top panel said "We recommend using Visual Studio 2017 / Download now"; but will that cause a quick replacement of my VS 2015 by VS 2017, or will there be a long complicated process?

Richard MacCutchan28-Jul-18 23:41

28-Jul-18 23:41

Please be patient when posting messages. New messages often go into the moderation queue and need to be verified by a human. And it is Sunday, so lots of people are taking things easy.

Anthony Appleyard28-Jul-18 23:39

28-Jul-18 23:39

Richard MacCutchan28-Jul-18 23:42

28-Jul-18 23:42

Fix your existing problems first. Once you have all your projects successfully building in VS2015 then you can consider upgrading to 2017.

Anthony Appleyard29-Jul-18 0:39

29-Jul-18 0:39

Thanks for your help. I am sorry if I have caused any problems.

I tried uploading VS 2017; it installed itself alongside my VS 2015 and did not obliterate it.

I used my desktop "Visual C 2015 devenv.exe" icon to access my VS 2015, and I tried to access several of my projects. All but one of them that I tried came up and recompiled successfully, and there was no "One-way upgrade. Visual Studio ..." nuisance.

The only project that caused trouble was dragclip_vc, which kept on showing the "One-way upgrade. Visual Studio will automatically make functional changes to the following projects in order to open them. ...". MessageBox. So I remade this project as a new VS 2015 project dragclip2 using copies of dragclip_vc's source files, and this new project behaves OK. I suspect that the "One-way upgrade. Visual Studio ..." nuisance persisted because dragclip is such a small project that it does not have some feature that "One-way upgrade. Visual Studio ..." looks for to see if it has already been called on that project.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Next step for me, I suppose, is to find how to run VS 2017. It looks very different from VS 2015.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I keep pointers to all my Visual C++ projects in a folder called C:\Visual_C\Visual_C_pointers\

modified 29-Jul-18 12:25pm.

Richard MacCutchan29-Jul-18 0:50

29-Jul-18 0:50

No problem, just pointing out how the system works. And, for some odd reason, most of your messages were going to moderation as potential spam.

Anthony Appleyard29-Jul-18 18:20

29-Jul-18 18:20

Thanks. Do you want me to send to you a copy of the old form of my 'dragclip' program?, so that you can investigate why "One-way upgrade. Visual Studio ..." repeatedly asked to upgrade it?

Richard MacCutchan29-Jul-18 21:13

29-Jul-18 21:13

No thanks. You should report it to Microsoft though.

Anthony Appleyard28-Jul-18 23:39

28-Jul-18 23:39

I am using VS 2015. When I opened its help just now, a top panel recommended using VS 2017; will that cause a quick replacement of my VS 2015 by VS 2017, or will there be a long complicated process?

Anthony Appleyard28-Jul-18 23:39

28-Jul-18 23:39

I have VS 2015. Its help recommends upgrading to VS 2017.

Anthony Appleyard29-Jul-18 0:03

Trouble with the current automatic upgrade

29-Jul-18 0:03

I have now upgraded to VS 2017. I have used it to remake my project 'dragclip_vc'. In it, the top menu has entries for "File, Edit, View, Project, Team, Tools, Windows, Help", but none of then seem to lead to an option letting me compile or run the source file. What should I do?

Anthony Appleyard28-Jul-18 19:50

unique_ptr and make_unique -- [SOLVED]

28-Jul-18 19:50

I have been using Visual C++ for many years to develop programs, without trouble.

Today, a new automatic upgrade system shows up whenever I call one of my Visual C++ projects.

In one of them, the automatic upgrade showed and operated, asking me to click on things, OK, and I had to re-open the component files that it displays, and I saved the run, and exited, and after that, it comes up OK when called.

In another of them, however often I open it and exit from it, every time I open it, the automatic upgrade shows, and I must run it, and it wipes the display of the program's files that I had opened. What causes that?

Richard Andrew x6427-Jul-18 17:58

Richard Andrew x64

27-Jul-18 17:58

[See below the original question for the solution.]

I have been struggling with this for a while now, and I can't seem to figure it out.

Here's my declaration:

C++

std::unique_ptr<BYTE*, std::function<void(BYTE**)>>     _VersionData{};

And here's where I attempt to instantiate it:

C++

_VersionData = std::make_unique<BYTE*>(new BYTE[_VersionDataLength], [](BYTE** ptr) {delete *ptr; }); // Attempting to use a lambda expression as a custom destructor

The errors I receive are:

C++

error C2440: 'initializing': cannot convert from 'initializer list' to 'unsigned char *'
note: The initializer contains too many elements

I'm probably way off in my interpretation of the documentation. Can someone show me how this is supposed to work? Smile | :)

[SOLUTION]

Turns out I was really way off with the attempt shown above.

Here's the working code.

The declaration in the class header file:

C++

std::unique_ptr<BYTE, void(*)(BYTE*)>                 _VersionData;

The instantiation in the source file:

C++

auto CustomDeleter = [](BYTE* ptr) {delete[] ptr; };

_VersionData = std::unique_ptr<BYTE, decltype(CustomDeleter)>(new BYTE[_VersionDataLength], CustomDeleter);

And the most important part, the constructor initializer list:

C++

CFileVersionInfo::CFileVersionInfo()
	: _VersionData(nullptr, [](BYTE* ptr) {delete[] ptr; })
{
   // constructor code here...
}

The difficult we do right away...
...the impossible takes slightly longer.

modified 28-Jul-18 11:42am.

Re: unique_ptr and make_unique -- [SOLVED]

Richard MacCutchan28-Jul-18 6:00

Re: unique_ptr and make_unique -- [SOLVED]

28-Jul-18 6:00

Now that you understand it, how about writing an article for the rest of us?

Richard Andrew x6428-Jul-18 11:06

Richard Andrew x64

28-Jul-18 11:06

Thanks for the vote of confidence, Richard! Big Grin | :-D

I can't say that I completely understand it. Getting it to work was partly just trying different things until I hit upon the magic combination!

I do understand some parts of it better now, but hardly well enough to write an article. Smile | :)

The difficult we do right away...
...the impossible takes slightly longer.

Where I can learn about using wsprintf?

GESY26-Jul-18 8:01

26-Jul-18 8:01

Where I can learn about using wsprintf? I using Visual Studio 12 with plain C Code Lines.

For examples, this lines give me 2 different results depending on the
formatting I believe but I can't find any practical info about it.

For example what the " >>6" or " >>12" do?

Thanks, check the code below and you see what I mean

DWORD DVALE=19542016;

wsprintf(BUFF, "Version is %d \n Good Night",DVALE >>6 & 0xff);
MessageBox(hWndMain,BUFF,"The Value",MB_OK); // Display 192

wsprintf(BUFF, "Version is %d \n Good Night",DVALE >> 12 & 0xff);
MessageBox(hWndMain,BUFF,"The Value",MB_OK); // Display 163

Victor Nijegorodov26-Jul-18 8:25

Victor Nijegorodov

26-Jul-18 8:25

Did you try to pass the L"Version is %d \n Good Night" rather than "Version is %d \n Good Night"?
" >>6" or " >>12" just do what they must do according to the https://msdn.microsoft.com/en-us/library/336xbhcz.aspx?f=255&MSPPError=-2147217396

Joe Woodbury26-Jul-18 8:26

Joe Woodbury

26-Jul-18 8:26

The greater-than signs are shift operators (https://msdn.microsoft.com/en-us/library/336xbhcz.aspx?f=255&MSPPError=-2147217396). The result is then truncated using a bitwise and operator (Bitwise AND Operator: &[^])

GESY26-Jul-18 16:25

26-Jul-18 16:25

Auch, you think I can remember those days?

That's a lot of math, if I start experimenting I may get it back.
But for now, that page got me hungry!!!
But I did catch the idea of shifting, all this because
a code that I posted here, that some one tested and said works correctly
and got the right values, however I don't, I do not see how may code
works correctly on his computer, but on mine I get big numbers, far for what
I am looking for. Go ahead and check it, and tell me what you think if you please....
Thanks

Look for "No-Errors-but-wrong-values-on-return"

Joe Woodbury26-Jul-18 17:45

Joe Woodbury

26-Jul-18 17:45

Sorry, I can't diagnose what happens on your computer.

(And whatever you are doing elsewhere is pointless and bad practice. Errors in your code have been identified. Just check the windows version and end it there.

To clarify: DON'T check the versions of system DLLs. There are multiple versions of many DLLs and you have no idea which DLL is actually being used.)

modified 26-Jul-18 23:55pm.

GESY27-Jul-18 4:05

27-Jul-18 4:05

But you can tell the studio whichone too look for or use, I think.

GESY27-Jul-18 4:07