Re: Error when firing SetTimer in a Modeless Dlg - C / C++ / MFC Discussion Boards

Try
inline void CAdd1Dlg::OnTimer(UINT nIDEvent)

Just tried it and I still get the same error.. Frown | :(

Thanks for the help though, Smile | :)

Rob

Hi Rob,

glad to be of assistance.

What you've posted is the disassembly - 10-15 years ago people would actually program writing this mumbo-jumbo! Wink | ;)

Assuming you're using MS VC++, you can see the call stack _when you're debugging_ by pressing alt+7 (or choosing View->Debug windows->Call Stack. You can also see it in the variables window by expanding the combo box at the top of this window, the one labeled "context".

The call stack is a list of all the calls that led to the point in the program where you are right now. This is how the call stack looked i a test program using OnTimer:

CTest10View::OnTimer(unsigned int 1) line 139
CWnd::OnWndMsg(unsigned int 275, unsigned int 1, long 0, long * 0x0012fd10) line 1829
CWnd::WindowProc(unsigned int 275, unsigned int 1, long 0) line 1585 + 30 bytes
AfxCallWndProc(CWnd * 0x00422cf0 {CTest10View hWnd=0x0006031a}, HWND__ * 0x0006031a, unsigned int 275, unsigned int 1, long 0) line 215 + 26 bytes
AfxWndProc(HWND__ * 0x0006031a, unsigned int 275, unsigned int 1, long 0) line 368
AfxWndProcBase(HWND__ * 0x0006031a, unsigned int 275, unsigned int 1, long 0) line 220 + 21 bytes
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e192da()
CWinThread::Run() line 480 + 11 bytes
CWinApp::Run() line 400
AfxWinMain(HINSTANCE__ * 0x00400000, HINSTANCE__ * 0x00000000, char * 0x001325f8, int 1) line 49 + 11 bytes
WinMain(HINSTANCE__ * 0x00400000, HINSTANCE__ * 0x00000000, char * 0x001325f8, int 1) line 30
WinMainCRTStartup() line 330 + 54 bytes
KERNEL32! 77e87903()

Reading from bottom up you can find the call to WinMain which call AfxWinMain, which called CWinApp::Run() which callled CWinThread::Run() which called GetMessage and DispatchMessage (the USER32! things). Then you can see the trace through the MFC windows procedures (WinProc, AfxCallWndProc, CWnd::WindowProc) and the routing through the message map (CWnd::OnWndMsg and finally CTest10View::OnTimer).

Cheers
Steen.

"To claim that computer games influence children is rediculous. If Pacman had influenced children born in the 80'ies we would see a lot of youngsters running around in dark rooms eating pills while listening to monotonous music"

The Stack Overflow problem usually arises when you are (unaware) calling the same function several times as fast as you can, until the stack gets full Dead | X|

.
So, what are you doing inside of your OnTimer() function? Could it be possible that you are executing this same function (kind of recursive call, but without an exit condition)?
On the other hand, where are you creating the timer? Could you please show us some of your code to handle the IDC_S_TIMER1 timer's id in your OnTimer() function?

Sure...

<br />
void CAdd1Dlg::OnTimer(UINT nIDEvent) <br />
{<br />
	switch (nIDEvent)<br />
	{<br />
	case IDC_S_TIMER1:<br />
		//decrement the count<br />
		iS --;<br />
		//format and display the count<br />
		m_ctlTime1.Display(iS,iM,iH,iD,(CString)m_strTime1="%D:%H:%M:%S");<br />
		break;<br />
	}<br />
	<br />
	UpdateData(FALSE);<br />
	<br />
	CAdd1Dlg::OnTimer(nIDEvent);<br />

<br />
<br />
void OnTimerStart();<br />
if(something.....)<br />
{<br />
}<br />
else<br />
	{<br />
		UpdateData(TRUE);<br />
		<br />
		//Start the timer<br />
		iTa = iDa*24*60*60+iHa*60*60+iMa*60+iSa;<br />
		iTPDT = iPDTD*24*60*60+iPDTH*60*60+iPDTM*60+iPDTS;<br />
		iDiff = iTa-iTPDT;<br />
		iS = iDiff;<br />
<br />
		strTime.Format("%d",iS);<br />
		<br />
		SetTimer(IDC_S_TIMER1,1000,NULL);<br />
		<br />
		//Disable Start Button and enable stop<br />
		m_bStopTime1.EnableWindow(TRUE);<br />
		m_bStartTime1.EnableWindow(FALSE);<br />
		m_bGrab1.EnableWindow(FALSE);<br />
		GetDlgItem(IDC_E_MIN1)->EnableWindow(FALSE);<br />
		GetDlgItem(IDC_E_SEC1)->EnableWindow(FALSE);<br />
		GetDlgItem(IDC_E_QUANTITY)->EnableWindow(FALSE);<br />
		GetDlgItem(IDC_E_MAXBID)->EnableWindow(FALSE);<br />
		GetDlgItem(IDC_E_ITEM)->EnableWindow(FALSE);<br />
		<br />
		fileEditText.Remove(_T("Timestart.txt"));<br />
		fileEditText.Remove(_T("TimeUrlstart.txt"));<br />
		UpdateData(FALSE);<br />
	}	<br />

I can only find one section that I do a SetTimer()... The reason I use switch in nIDEvent is because I use to have 2 timere that i would switch between.. I only have 1 now.. I tried to remove the switch and I still get the same error..

Thanks for the help!!!

Rob

Rob,

It seems that you have some re-entrancy code and a very bad function call. You are calling your function (as I said in my previous message) inside of your function, creating a recursive call with no exit at all. Let me be more specific ...
In your function OnTimer() you have a line at the end that says "CAdd1Dlg::OnTimer(nIDEvent)" and this is the horrible bug. Instead you have to call the base method, i.e. CDialog::OnTimer(nIDEvent).

On the other hand, the timer has been set to signal every one second, and in the code where you are handling this event, there is no way to stop the messaging system sending the signal every one second, and here is where meanwhile you are decrementing your variable and formatting your display, another call has been made and so on.
One good rule is if your timer's handler do a lot of work and the timer's period is short, you have to tell the messaging system "give me a break". So in your code, you can use something like:

void CAdd1Dlg::OnTimer(UINT nIDEvent){
switch (nIDEvent){
case IDC_S_TIMER1:
KillTimer(IDC_S_TIMER1); // Stop the timer
//decrement the count
iS --;
//format and display the count
m_ctlTime1.Display(iS,iM,iH,iD,(CString)m_strTime1="%D:%H:%M:%S");
UpdateData(FALSE);
SetTimer(IDC_S_TIMER1, 1000, NULL); // Restart the timer
break;
}
//UpdateData(FALSE); <=== Make this call before.
//CAdd1Dlg::OnTimer(nIDEvent) <=== Dead | X|

OOPS! This is the bad guy in your code
CDialog::OnTimer(nIDEvent); // Use this instead.
}

I hope this helps

Au revoir.

THANK YOU VERY MUCH!!!

Changing the CAdd1Dlg::OnTimer(nIDEvent) to CDialog::OnTimer(nIDEvent) fixed everything..

Thanks for taking the time to help!
Big Grin | :-D

Rob Jones

Hi A.R.

Your solution to Rob's recursive call problem is of course absolutely correct. However, I don't think Rob's got a re-entrance problem.

>On the other hand, the timer has been set to signal every one second, and in the code where you are handling this event, there is no way to stop the messaging system sending the signal every one second, and here is where meanwhile you are decrementing your variable and formatting your display, another call has been made and so on.

Rob is handling the WM_TIMER message, and while the program is in OnTimer it will not get new messages from the message queue and hence OnTimer will not be called again. Only when Rob returns from OnTimer will a new WM_TIMER message be dispatched. So while a steady stream of WM_TIMER messages will certainly make the application seem unresponsive, it will not lead to any concurrency issues. Furthermore, WM_TIMER messages are handled in a similar manner to WM_PAINT - they are low-priority and will only be handled if the message queue is empty, and multiple WM_TIMER messages in the queue will be merged into one message. And there is no way to find out just how may WM_TIMER messages got zapped. That's why you cannot use timers to make a good clock - you'll have to read the system time inside OnTimer, and cannot rely on exactly 1 second between WM_TIMER messages (not even on average over a period of time). And don't take my word for it - it's all described in Petzold chapter 7.

>One good rule is if your timer's handler do a lot of work and the timer's period is short, you have to tell the messaging system "give me a break".
This is actually very good advice, but only for responsivity-reasons, not for concurrency.

Cheers
Steen.

"To claim that computer games influence children is rediculous. If Pacman had influenced children born in the 80'ies we would see a lot of youngsters running around in dark rooms eating pills while listening to monotonous music"

Whenever I try to call DoModal() for a dialog it gets an access violation in LoadResource(...). I tried rebooting thinking my computer was low on resources. No luck. I tried making a new dialog, with no code and calling DoModal() on that one. Same thing happened. I tried the Resourde ID Organizer utility I got from this site. Still no luck.

This just started happening to my project. Other dialogs that I created before today come up fine.

Pleeeeeaaase hellllp meeeeee!!!!!!!!!!! Dead | X|

It sounds like your resource script has troubles. Have you tried going into the debugger to see what the problem is, and stepping back to see at what stage the function is being called ?

Christian

As I learn the innermost secrets of the around me, they reward me in many ways to keep quiet.

Men with pierced ears are better prepared for marriage. They've experienced pain and bought Jewellery.

Never mind.

I am an idiot. I forgot to do AFX_MANAGE_STATE(AfxGetStaticModuleState());

Sorry for bothering you.

No bother at all. I find often verbalising a problem helps me to find it. FWIW I was not going to suggest that, so I guess I wasn't going to be much help anyhow Wink | ;)

Christian

As I learn the innermost secrets of the around me, they reward me in many ways to keep quiet.

Men with pierced ears are better prepared for marriage. They've experienced pain and bought Jewellery.

My app has a console that redirects stdout and stderr, but
apparently it doesn't capture OutputDebugString() messages
or any internal messages from DX8. Is there a way to do it?

Steve The Plant

To get OutputDebugStrings you'd have to call WaitForDebugEvent. However, this function is apparently designed to be used by debugger running in separate process. I have no idea if this is possible from within the running program itself - this would be a self-debugging configuration Wink | ;)

Tomasz Sowinski -- http://www.shooltz.com

With a help of VxD or Kernel Mode Device Driver, you can monitor any messages for debug output. Grab exellent utility at;

http://www.sysinternals.com/ntw2k/freeware/debugview.shtml

Utility looks like single binary but they embedded device drivers for Win9x and NT/Win2k. (They are kind of an alien, not human.)

reiko

As the other comments stated, you probably want to do it using by debug events.

But since it's in the same app, just blast a new address into the jump table for OutputDebugString (it's in the IMPORT section of your PE (at runtime). If you also wan't to "steal" GetProcAddress() usage you'll have to patch the first few bytes of OutputDebugString() to be a "jmp X", where X is the address of your (stdcall!) replacement function. Either way, you would have to know some IA32 assembly to know what's going on.

Hello, I'm new to dealing with graphical user interfaces and currently I am working on a program that would need to display an acquired image onto the screen. The image is an array of unsigned char buffer containing the RGB values. Would anyone know how I may display it effeciently in my view? Currently, I am doing a nested for loop inside OnDraw() and I don't believe this is the correct way.

Don't laugh Blush | :O

, but here's what I've got--

BYTE R, G, B;

for (unsigned long y=0; y "less than" imageHeight; y++)
{
for (unsigned long x=0; x "less than" imageWidth; x++)
{
R = imageBuffer[(y*imageWidth*3)+(x*3)];
G = imageBuffer[(y*imageWidth*3)+(x*3)+1];
B = imageBuffer[(y*imageWidth*3)+(x*3)+2];

cDC->SetPixel(x, y, RGB(R,G,B));
}
}

Thanks in advance!

Jerry

the quickest way to do this is to create a DIB from your RGB buffer.

a DIB is a rather complex data structure that holds a Device Independent Bitmap.

but, to make a 24-bit DIB out of an RGB buffer you need to do the following:

1. allocate enough memory for the DIB. this is a BITMAPINFOHEADER plus the pixels. pixels in a 24-bit DIB are 3 bytes per pixel with 1-3 bytes at the end of each row so that the number of bytes in a row is multiple of 4.

2. fill in the member of the BITMAPINFOHEADER struct

3. copy the RGB pixels into the DIB so that the DIB is vertically flipped compared to the RGB buffer and R and B are swapped.

4. call StretchDIBits.

if you want a working sample of all this, see JpegFile. this is a JPG read/write class that deals with RGB images (from/to JPG) and DIBs (for display).

-c

------------------------------
Smaller Animals Software, Inc.
http://www.smalleranimals.com

Maybe when the image is first aquired you could create a CBitmap and us the SetBitmapBits method. Then in your OnDraw you could render the bitmap instead of processing the the array each time. Just a possiblity, don't know if it will work for you.

Also, for future you can use the <pre> or <code> tags for any code snippets. Or at least use the HTML encoding < rather than "less than"

Whats the easiest way to pass the Parameter BSTR pkMbtID to the stored procedure "Values(pkMbtID....."
Must i use crateparameter method or what.

STDMETHODIMP CMBT::ADDMBT(BSTR pkMbtID, BSTR MbtType)

_bstr_t ProcMBT (L"Alter proc sp_AdoTest"
L"as "
L"INSERT INTO MBT (pkMbtID, MbtType) Values Values(pkMbtID, MbtType)");
L"return");

/Bigge

Just use it. If your stored proc is expecting a varchar, or the like, a BSTR will work. This is COM after all.

if you are going to use the CreateParameter method via ADO then you will need to supply the value as a varaint. The best way to do this is to use the wrapper classes _variant_t and _bstr_t

e.g.

_variant_t vValue(_bstr_t("Hello"));

Cool | :cool:

What is the easiest way to set tooltips for static-controls (or any other controls such as buttons etc.)?

thanks in advance

You will have to use the CToolTipCtrl class, see msdn for more info

I tried out

It works with buttons, but the tooltips do not seem to work in my static-controls Confused | :confused: