C / C++ / MFC

1-Nov-17 3:03

error :
24 no operator = for thie
104 string to TCHAR warning

i have a 'player.bmp' in the same map

// blua tigro 1 nov 2017
// sprite 1

#if defined(UNICODE) && !defined(_UNICODE)
    #define _UNICODE
#elif defined(_UNICODE) && !defined(UNICODE)
    #define UNICODE
#endif

#include <tchar.h>
#include <windows.h>
bool key[ 256 ] ;
int winx , winy ;
#define FRAME_TIMER 1
class Sprite
{
public :
  int x , y , w , h ;
  bool visable ;
  BITMAP bmp ;
  Sprite(){;}
  void loadbmpfromfile( HINSTANCE hinstance , TCHAR * file )
  {
    bmp = LoadBitmap( hinstance , _T( file ) ) ;
    w = bmp.bmWidth ;
    h = bmp.bmHeight ;
    visable = true ;
  }
  void show( HDC hdc )
  {
    if ( visable )
    {
    //draw mask whit and [ upper half of bmp ]
    BitBlt( hdc , x , y , w , h/2 , hdc , 0 , 0 , MERGECOPY ) ;
    //draw picture whit or [ lower half of bmp ]
    BitBlt( hdc , x , y , w , h/2 , hdc , 0 , h/2 , MERGEPAINT ) ;
    }
  }
  bool hit( Sprite spr )
  {
    if ( x + w < spr.x ) return false ;
    if ( x > spr.x + spr.w ) return false ;
    if ( y + h < spr.y ) return false ;
    if ( y > spr.y + spr.h ) return false ;
    return true ;
  }
} ;
Sprite player ;
/*  Declare Windows procedure  */
LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM);

/*  Make the class name into a global variable  */
TCHAR szClassName[ ] = _T("CodeBlocksWindowsApp");

int WINAPI WinMain (HINSTANCE hThisInstance,
                     HINSTANCE hPrevInstance,
                     LPSTR lpszArgument,
                     int nCmdShow)
{
    HWND hwnd;               /* This is the handle for our window */
    MSG messages;            /* Here messages to the application are saved */
    WNDCLASSEX wincl;        /* Data structure for the windowclass */

    /* The Window structure */
    wincl.hInstance = hThisInstance;
    wincl.lpszClassName = szClassName;
    wincl.lpfnWndProc = WindowProcedure;      /* This function is called by windows */
    wincl.style = CS_DBLCLKS;                 /* Catch double-clicks */
    wincl.cbSize = sizeof (WNDCLASSEX);

    /* Use default icon and mouse-pointer */
    wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hCursor = LoadCursor (NULL, IDC_ARROW);
    wincl.lpszMenuName = NULL;                 /* No menu */
    wincl.cbClsExtra = 0;                      /* No extra bytes after the window class */
    wincl.cbWndExtra = 0;                      /* structure or the window instance */
    /* Use Windows's default colour as the background of the window */
    wincl.hbrBackground = (HBRUSH) COLOR_BACKGROUND;

    /* Register the window class, and if it fails quit the program */
    if (!RegisterClassEx (&wincl))
        return 0;

    /* The class is registered, let's create the program*/
    hwnd = CreateWindowEx (
           0,                   /* Extended possibilites for variation */
           szClassName,         /* Classname */
           _T("sprite 1"),       /* Title Text */
           WS_OVERLAPPEDWINDOW, /* default window */
           CW_USEDEFAULT,       /* Windows decides the position */
           CW_USEDEFAULT,       /* where the window ends up on the screen */
           800,                 /* The programs width */
           600,                 /* and height in pixels */
           HWND_DESKTOP,        /* The window is a child-window to desktop */
           NULL,                /* No menu */
           hThisInstance,       /* Program Instance handler */
           NULL                 /* No Window Creation data */
           ) ;

    /* Make the window visible on the screen */
    ShowWindow (hwnd, nCmdShow);

    player.loadbmpfromfile(hThisInstance,"player.bmp") ;

    /* Run the message loop. It will run until GetMessage() returns 0 */
    while (GetMessage (&messages, NULL, 0, 0))
    {
        /* Translate virtual-key messages into character messages */
        TranslateMessage(&messages);
        /* Send message to WindowProcedure */
        DispatchMessage(&messages);
    }

    /* The program return-value is 0 - The value that PostQuitMessage() gave */
    return messages.wParam;
}


/*  This function is called by the Windows function DispatchMessage()  */

LRESULT CALLBACK WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
  PAINTSTRUCT paint ;
  HDC hdc = BeginPaint( hwnd , &paint ) ;
  RECT rect ;

  switch (message)                  /* handle the messages */
  {
    case WM_CREATE :
      player.x = 0 ;
      player.y = 0 ;
      SetTimer( hwnd , FRAME_TIMER , 40 , NULL ) ;
    case WM_KEYDOWN :
      key[ wParam ] = true ;
      switch( wParam )
      {
        case VK_ESCAPE :
          PostQuitMessage( 0 ) ;
          break ;
        default : ;
      }
      break ;
    case WM_KEYUP :
      key[ wParam ] = false ;
      break ;
    case WM_TIMER :
      switch( wParam )
      {
        case FRAME_TIMER :
          if ( key[ VK_UP ] ) player.y-- ;
          if ( key[ VK_DOWN ] ) player.y++ ;
          if ( key[ VK_LEFT ] ) player.x-- ;
          if ( key[ VK_RIGHT ] ) player.x++ ;

          if ( player.y > winy ) player.y = 0 ;
          if ( player.y < 0 ) player.y = winy ;
          if ( player.x > winx ) player.x = 0 ;
          if ( player.x < 0 ) player.x = winx ;
          InvalidateRect( hwnd , NULL , true ) ;
        break ;
        default : ;
      }
      break ;
    case WM_PAINT :
      GetClientRect( hwnd , &rect ) ;
      winx = rect.right ;
      winy = rect.bottom ;

      player.show( hdc ) ;

      EndPaint( hwnd , &paint ) ;
    case WM_DESTROY :
      PostQuitMessage( 0 ) ;       /* send a WM_QUIT to the message queue */
      break;
    default:                      /* for messages that we don't deal with */
      return DefWindowProc (hwnd, message, wParam, lParam);
  }
  return 0 ;
}

Richard MacCutchan1-Nov-17 3:18

1-Nov-17 3:18

Please stop doing this. Do not just dump a load of code with a vague comment and expect someone to figure out what the problem is and then fix it for you. Edit your question, remove the code not relevant to the problem, and explain clearly what is going wrong, and where it happens.

Jochen Arndt1-Nov-17 3:26

Jochen Arndt

1-Nov-17 3:26

The _T() macro is for constant strings (and characters) only:

// Wrong:
//bmp = LoadBitmap( hinstance , _T( file ) ) ;
// Correct: 
bmp = LoadBitmap(hinstance, file);

When supporting Unicode and non-Unicode builds, all constant strings must be embedded in that macro:

// Wrong:
//player.loadbmpfromfile(hThisInstance,"player.bmp") ;
// Correct:
player.loadbmpfromfile(hThisInstance, _T("player.bmp"));

David Crow1-Nov-17 3:32

1-Nov-17 3:32

Both errors look like they could be coming from the call to LoadBitmap(), but since you failed to include line numbers, it's hard to say for sure. That function returns a BOOL not a BITMAP. Also, the _T() macro is for string literals.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles

bluatigro2-Nov-17 0:13

2-Nov-17 0:13

a error font by the compler
can have a source elsewere so i have to post al the code

i don't know how to include the line numbers

my english in writing is not great
so i have to be short

bluatigro2-Nov-17 1:01

2-Nov-17 1:01

ok i try it

i changed the folowing :
player.loadbmpformfil( ,_T("player.bmp)) ;

my sprite looks like this now :

class Sprite
{
public :
  int x , y , w , h ;
  bool visable ;
  HBITMAP hbmp ;
  HDC bmphdc ;
  Sprite(){;}
  void loadbmpfromfile( HINSTANCE hinstance , TCHAR * file )
  {
    hbmp = LoadBitmap( hinstance , file ) ;
    w = hbmp.i ;
    h = hbmp.i ;
    visable = true ;
  }
  void show( HDC hdc )
  {
    if ( visable )
    {
    //draw mask whit and [ upper half of bmp ]
    BitBlt( hdc , x , y , w , h/2 , bmphdc , 0 , 0 , MERGECOPY ) ;
    //draw picture whit or [ lower half of bmp ]
    BitBlt( hdc , x , y , w , h/2 , bmphdc , 0 , h/2 , MERGEPAINT ) ;
    }
  }
  bool hit( Sprite spr )
  {
    if ( x + w < spr.x ) return false ;
    if ( x > spr.x + spr.w ) return false ;
    if ( y + h < spr.y ) return false ;
    if ( y > spr.y + spr.h ) return false ;
    return true ;
  }
} ;
Sprite player ;

i know this is wrong . how do i do this ?
my wm_paint :

case WM_PAINT :
  GetClientRect( hwnd , &rect ) ;
  winx = rect.right ;
  winy = rect.bottom ;

  player.bmphdc = CreateCompatibleDC(hdc);

  player.show( hdc ) ;

  DeleteDC( player.bmphdc ) ;

  EndPaint( hwnd , &paint ) ;

this can be wrong . how do i do this ?

Richard MacCutchan2-Nov-17 1:46

2-Nov-17 1:46

I told you a week ago, you must call BeginPaint inside your WM_PAINT code. So it needs to be:

C++

    case WM_PAINT :
      hdc = BeginPaint( hwnd , &paint );

// All painting code or calls to functions that paint:
 
      EndPaint( hwnd , &paint ) ;
      break; // make sure you have a break or return after every case block

bluatigro3-Nov-17 0:09

3-Nov-17 0:09

ok done that
how do i proseed next ?

case WM_PAINT :
  hdc = BeginPaint( hwnd , &paint ) ;
  GetClientRect( hwnd , &rect ) ;
  winx = rect.right ;
  winy = rect.bottom ;

  player.bmphdc = CreateCompatibleDC( hdc ) ;

  player.show( hdc ) ;

  DeleteDC( player.bmphdc ) ;

  EndPaint( hwnd , &paint ) ;
  break ;
case WM_DESTROY :

Richard MacCutchan3-Nov-17 0:28

3-Nov-17 0:28

bluatigro wrote:
how do i proseed next ?

What do you mean? As far as I can see the above code does not do anything.

bluatigro7-Nov-17 22:36

7-Nov-17 22:36

by me pc its giving error's

if i knew what to do i won't ask

this is new to me

what do i ad / change so it does work as expected ?

it shoot show a sprite 'player.bmp' whit cursor control

Richard MacCutchan7-Nov-17 22:45

[win32] VR double buffering ?

7-Nov-17 22:45

bluatigro wrote:
by me pc its giving error's

What errors? Where do they occur? What is your code trying to do? Please provide proper information so we can try to help. Also, if this is all new to you then you would do well to study some tutorials on Windows programming. Here are two that are very useful:

EFNet #Winprog[^]
Win32 Programming - FunctionX[^]

bluatigro31-Oct-17 4:24

31-Oct-17 4:24

i m trying as coding exersise
a verry simple VR system

error :
the picture isn't Always right

// bluatigro 31 okt 2017
// win triangle
#if defined(UNICODE) && !defined(_UNICODE)
    #define _UNICODE
#elif defined(_UNICODE) && !defined(UNICODE)
    #define UNICODE
#endif

#include <tchar.h>
#include <windows.h>
#include <vector>
#include <math.h>
int winx , winy ;
class d3d
{
public :
  double x , y , z ;
  d3d()
  {
    x = 0.0 ;
    y = 0.0 ;
    z = 0.0 ;
  }
  d3d( double a , double b , double c )
  {
    x = a ;
    y = b ;
    z = c ;
  }
} ;
d3d operator + ( d3d a , d3d b )
{
  return d3d( a.x+b.x,a.y+b.y,a.z+b.z) ;
}
d3d operator / ( d3d a , double b )
{
  return d3d( a.x/b,a.y/b,a.z/b) ;
}
d3d pnt[256] ;
void setpoint( int no ,
               double a ,
               double b ,
               double c )
{
  pnt[ no ] = d3d(a,b,c) ;
}
class triangle
{
public :
  d3d punt[ 3 ] , mid ;
  COLORREF color ;
  triangle()
  {
    ;
  }
  triangle( d3d p1 , d3d p2 , d3d p3 ,
           COLORREF kl )
  {
    punt[ 0 ] = p1 ;
    punt[ 1 ] = p2 ;
    punt[ 2 ] = p3 ;
    mid = ( p1 + p2 + p3 ) / 3 ;
    color = kl ;
  }
  void show( HDC hdc )
  {
    POINT p[ 3 ] ;
    int i ;
    if ( mid.z > -900)
    {
      for ( i = 0 ; i < 3 ; i++ )
      {

        p[i].x=(LONG)(winx/2+punt[i].x/
                    (punt[i].z+1000.0)*1000) ;
        p[i].y=(LONG)(winy/2-punt[i].y/
                    (punt[i].z+1000.0)*1000) ;
      }
      HBRUSH brush = CreateSolidBrush( color ) ;
      HPEN pen = CreatePen( PS_SOLID , 0 , color ) ;
      SelectObject( hdc , pen ) ;
      SelectObject( hdc , brush ) ;

      Polygon( hdc , p , 3 ) ;

      SelectObject( hdc , pen ) ;
      DeleteObject( pen ) ;
      SelectObject( hdc , brush ) ;
      DeleteObject( brush ) ;
    } // end if mid.z > -900
  }
} ;
const COLORREF red = RGB( 255 , 0 , 0 ) ;
const COLORREF green = RGB( 0 , 255 , 0 ) ;
const COLORREF yellow = RGB( 255 , 255 , 0 ) ;
const COLORREF blue = RGB( 0 , 0 , 255 ) ;
const COLORREF magenta = RGB( 255 , 0 , 255 ) ;
const COLORREF cyan = RGB( 0 , 255 , 255 ) ;

bool key[ 256 ] ;
triangle triangles[100] ;
int tritel ;
#define FRAME_TIMER 1
void show_al( HDC hdc )
{
  int i , j ;
  triangle h ;
  for ( i = 1 ; i < tritel ; i++ )
  {
    for ( j = 0 ; j < i - 1 ; j++ )
    {
      if ( triangles[i].mid.z
         > triangles[j].mid.z )
      {
        h = triangles[i] ;
        triangles[i] = triangles[j] ;
        triangles[j] = h ;
      }
    }
  }
  for ( i = 0 ; i < tritel ; i++ )
    triangles[i].show( hdc ) ;
}
void tri( int p1 , int p2 , int p3 , COLORREF kl )
{
  if ( tritel >= 100 ) return ;
  triangles[ tritel ] = triangle(pnt[p1],
                                 pnt[p2],
                                 pnt[p3],
                                 kl) ;
  tritel++ ;
}
void quad( int p1 , int p2 , int p3 , int p4
          , COLORREF kl )
{
  d3d p = ( pnt[p1]+pnt[p2]+pnt[p3]+pnt[p4])/4;
  setpoint( 255 , p.x,p.y,p.z ) ;
  tri( 255 , p1 , p2 , kl ) ;
  tri( 255 , p2 , p3 , kl ) ;
  tri( 255 , p3 , p4 , kl ) ;
  tri( 255 , p4 , p1 , kl ) ;
}
d3d rotatey( d3d a , double b )
{
  double s = sin( b ) , c = cos( b ) , x , z ;
  x = c * a.x - s * a.z ;
  z = s * a.x + c * a.z ;
  return d3d( x , a.y , z ) ;
}
triangle roty( triangle t , double b )
{
  t.mid = rotatey( t.mid , b ) ;
  t.punt[2] = rotatey( t.punt[2] , b ) ;
  t.punt[1] = rotatey( t.punt[1] , b ) ;
  t.punt[0] = rotatey( t.punt[0] , b ) ;
  return t ;
}
/*  Declare Windows procedure  */
LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM);

/*  Make the class name into a global variable  */
TCHAR szClassName[ ] = _T("CodeBlocksWindowsApp");

int WINAPI WinMain (HINSTANCE hThisInstance,
                     HINSTANCE hPrevInstance,
                     LPSTR lpszArgument,
                     int nCmdShow)
{
    HWND hwnd;               /* This is the handle for our window */
    MSG messages;            /* Here messages to the application are saved */
    WNDCLASSEX wincl;        /* Data structure for the windowclass */

    /* The Window structure */
    wincl.hInstance = hThisInstance;
    wincl.lpszClassName = szClassName;
    wincl.lpfnWndProc = WindowProcedure;      /* This function is called by windows */
    wincl.style = CS_DBLCLKS;                 /* Catch double-clicks */
    wincl.cbSize = sizeof (WNDCLASSEX);

    /* Use default icon and mouse-pointer */
    wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hCursor = LoadCursor (NULL, IDC_ARROW);
    wincl.lpszMenuName = NULL;                 /* No menu */
    wincl.cbClsExtra = 0;                      /* No extra bytes after the window class */
    wincl.cbWndExtra = 0;                      /* structure or the window instance */
    /* Use Windows's default colour as the background of the window */
    wincl.hbrBackground = (HBRUSH) COLOR_BACKGROUND;

    /* Register the window class, and if it fails quit the program */
    if (!RegisterClassEx (&wincl))
        return 0;

    /* The class is registered, let's create the program*/
    hwnd = CreateWindowEx (
           0,                   /* Extended possibilites for variation */
           szClassName,         /* Classname */
           _T("Rotating cube 1.0"),       /* Title Text */
           WS_OVERLAPPEDWINDOW, /* default window */
           CW_USEDEFAULT,       /* Windows decides the position */
           CW_USEDEFAULT,       /* where the window ends up on the screen */
           800,                 /* The programs width */
           600,                 /* and height in pixels */
           HWND_DESKTOP,        /* The window is a child-window to desktop */
           NULL,                /* No menu */
           hThisInstance,       /* Program Instance handler */
           NULL                 /* No Window Creation data */
           );

    /* Make the window visible on the screen */
    ShowWindow (hwnd, nCmdShow);

    /* Run the message loop. It will run until GetMessage() returns 0 */
    while (GetMessage (&messages, NULL, 0, 0))
    {
        /* Translate virtual-key messages into character messages */
        TranslateMessage(&messages);
        /* Send message to WindowProcedure */
        DispatchMessage(&messages);
    }

    /* The program return-value is 0 - The value that PostQuitMessage() gave */
    return messages.wParam;
}


/*  This function is called by the Windows function DispatchMessage()  */

LRESULT CALLBACK WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
  int t ;
  PAINTSTRUCT paint ;
  HDC hdc ;
  RECT rect ;
  GetClientRect( hwnd , &rect ) ;
  switch (message)                  /* handle the messages */
  {
    case WM_CREATE :
      tritel = 0 ;
      setpoint( 0 , 100 , 100 , 100 ) ;
      setpoint( 1 , 100 , 100 , -100 ) ;
      setpoint( 2 , 100 , -100 , 100 ) ;
      setpoint( 3 , 100 , -100 , -100 ) ;
      setpoint( 4 , -100 , 100 , 100 ) ;
      setpoint( 5 , -100 , 100 , -100 ) ;
      setpoint( 6 , -100 , -100 , 100 ) ;
      setpoint( 7 , -100 , -100 , -100 ) ;
      quad( 0 , 1 , 3 , 2 , red ) ;
      quad( 7 , 6 , 4 , 5 , cyan ) ;
      quad( 0 , 1 , 5 , 4 , green ) ;
      quad( 7 , 6 , 2 , 3 , magenta ) ;
      quad( 0 , 2 , 6 , 4 , blue ) ;
      quad( 7 , 5 , 1 , 3 , yellow ) ;
      SetTimer(hwnd,FRAME_TIMER,40,NULL) ;
      break ;
    case WM_TIMER :
      if ( wParam == FRAME_TIMER )
      {
        for ( t = 0 ; t < tritel ; t++ )
        {
          triangles[t] = roty(triangles[t],.1);
        }
        InvalidateRect( hwnd , NULL , true ) ;
      }
      break ;
    case WM_KEYDOWN :
      if ( wParam == VK_ESCAPE )
        PostQuitMessage( 0 ) ;
      break ;
    case WM_PAINT :
      GetClientRect( hwnd , &rect ) ;
      hdc = BeginPaint( hwnd , &paint ) ;
      winx = rect.right ;
      winy = rect.bottom ;

      show_al( hdc ) ;

      EndPaint( hwnd , &paint ) ;
      break ;
    case WM_DESTROY :
      PostQuitMessage( 0 ) ;       /* send a WM_QUIT to the message queue */
      break ;
    default :                      /* for messages that we don't deal with */
      return DefWindowProc (hwnd, message, wParam, lParam);
  }

  return 0 ;
}

David Crow31-Oct-17 8:01

31-Oct-17 8:01

bluatigro wrote:

the picture isn't Always right

And that means what exactly? Confused | :confused:

Richard MacCutchan31-Oct-17 22:40

31-Oct-17 22:40

And you think we can guess what all that code is supposed to do, and what it isn't doing right?

bluatigro1-Nov-17 0:37

1-Nov-17 0:37

the code shoot show a colored rotating cube

i want to get rid of showing drawing
it gives ugly effects

i want double buffering

i have no idea where / what i have to change in the code
to that effect

i got now : WS_POPUP | WS_MAXIMIZE
how do i get fulscreen ?

Richard MacCutchan1-Nov-17 1:03

1-Nov-17 1:03

bluatigro wrote:
i have no idea where / what i have to change

Well you cannot expect anyone here to understand all that code in a few minutes. You need to narrow down where the problem is and gather some more information about what is happening.

Your Window style should be based on WS_OVERLAPPEDWINDOW, not WS_POPUP. Google for "set Window full screen".

David Crow1-Nov-17 3:36

1-Nov-17 3:36

If you wrote the code to display the cube, then surely you can also remove it. If not, can you ask on the site where you procured the code from? Grabbing code from other sites, blindly throwing it into a compiler, and then wondering why it doesn't work hardly defines the software development process.

bluatigro2-Nov-17 0:20

passing parameters to Cdialog

2-Nov-17 0:20

i use the mdsn site + goolge for info
yes its a lot of code i wrote it myself
and i don't expect the error's to be fount fast

the problem whit my code is that you see the drawing of the triangles
over eatch other

i think i have to change somthing in WM_PAINT
but i m not sure

ForNow30-Oct-17 12:11

ForNow

30-Oct-17 12:11

Hi I know the CDialog constructer takes two parameters an id template and Parent Cwnd

if my derived CDialog wanted to pass a parameter woud be the first or last

in my case I passed it as the first and got a warning

C++

RTMDialog::RTMDialog(LPARAM mylparam, CWnd* pParent /*=NULL*/)
    : CDialog(IDD_DIALOG9, pParent)

the extra param is mylparam

Re: passing parameters to Cdialog

Sascha Lefèvre30-Oct-17 12:28

Sascha Lefèvre

30-Oct-17 12:28

What kind of warning?

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Re: passing parameters to Cdialog

ForNow30-Oct-17 13:13

ForNow

30-Oct-17 13:13

C++

progDebug.cpp(356): warning C4930: 'RTMDialog Abenddialog(LPARAM,CWnd *)': prototyped function not called (was a variable definition intended?)

Here is the source

C++

RTMDialog Abenddialog(LPARAM mylparam, CWnd* pParent /*=NULL*/);

Re: passing parameters to Cdialog Constructer defination

ForNow30-Oct-17 13:19

ForNow

30-Oct-17 13:19

C++

class RTMDialog : public CDialog
{
	DECLARE_DYNAMIC(RTMDialog)

public:
	RTMDialog(LPARAM mylparam,CWnd* pParent = NULL);   // standard constructor

Re: passing parameters to Cdialog Constructer defination

David Crow31-Oct-17 2:48