C / C++ / MFC

Re: Save the content from List Control in text file vc++

22-Mar-17 4:16

Hello everyone,
I have created an editable list control (report style) with numbers. How could I save all content of list in a text file, each edited "number" below the other. I tried something like this:

void CDataDialog::OnOK()
{
	CWnd* pwndCtrl = GetFocus();
	// get the control ID which is 
	// presently having the focus
	int ctrl_ID = pwndCtrl->GetDlgCtrlID();
	CString str;
	ofstream outFile;
	outFile.open("sample.txt");
	switch (ctrl_ID)
	{   //if the control is the EditBox 
	case IDC_EDIT1:
		//get the text from the EditBox
		GetDlgItemText(IDC_EDIT1, str);
		for (int i = 1; i <= m_nCon; i++)
		{
			outFile << str <<endl;
			outFile << m_nCon << endl;
		}
		outFile.close();
			//set the value in the listContorl with the
		//specified Item & SubItem values

		
		SetCell(::GetDlgItem(m_hWnd, IDC_LIST1),
			str, nItem, nSubItem);

		::SendDlgItemMessage(m_hWnd, IDC_EDIT1,
			WM_KILLFOCUS, 0, 0);
		::ShowWindow(::GetDlgItem(m_hWnd, IDC_EDIT1),
			SW_HIDE);
		break;
		
	default:
		break;
	}
}

but by this way I can save only the last edited item in text file. Thank you in advance!!

David Crow22-Mar-17 4:48

David Crow

22-Mar-17 4:48

Something like:

CStdioFile file("sample.txt", CFile::modeCreate);

int nCount = listControl.GetItemCount();
for (int x = 0; x < nCount; x++)
{
    CString strText = listControl.GetItemText(x, 0); // first column
    file.WriteString(strText);
}

file.Close();

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles

Re: Save the content from List Control in text file vc++

lolici22-Mar-17 5:23

Re: Save the content from List Control in text file vc++

22-Mar-17 5:23

I wrote this:

void CDataDialog::OnBnClickedOk()
{
	// TODO: Add your control notification handler code here
	//CDialog::EndDialog(0);
	CStdioFile file("over1.txt", CFile::modeCreate);

	int nCount = m_List.GetItemCount();
	for (int x = 0; x < nCount; x++)
	{
		CString strText = m_List.GetItemText(x, 0); // first column
		
		file.WriteString(strText);
	}

	file.Close();
	
}

and when execute it I get this statement: "Debug assertion failed". Is this because I already use CString CDataDialog::GetItemText(HWND hWnd, int nItem, int nSubItem) const??? Sorry I didn't mention it in the first post.

CString CDataDialog::GetItemText(
	HWND hWnd, int nItem, int nSubItem) const
{
	LVITEM lvi;
	memset(&lvi, 0, sizeof(LVITEM));
	lvi.iSubItem = nSubItem;
	CString str;
	int nLen = 128;
	int nRes;
	do
	{
		nLen *= 2;
		lvi.cchTextMax = nLen;
		lvi.pszText = str.GetBufferSetLength(nLen);
		nRes = (int)::SendMessage(hWnd,
			LVM_GETITEMTEXT, (WPARAM)nItem,
			(LPARAM)&lvi);
	} while (nRes == nLen - 1);
	str.ReleaseBuffer();
	return str;
}

David Crow22-Mar-17 5:26

David Crow

22-Mar-17 5:26

lolici wrote:
...and when execute it I get this statement: "Debug assertion failed".

You'll need to step through the code using the debugger to find the line that is asserting.

Re: Save the content from List Control in text file vc++

lolici22-Mar-17 5:35

Re: Save the content from List Control in text file vc++

22-Mar-17 5:35

The problem is here:

int nCount = m_List.GetItemCount();

I need another function than GetItemCount? Smile | :)

David Crow22-Mar-17 5:37

David Crow

22-Mar-17 5:37

That line is NOT asserting. You need to step into the GetItemCount() method (until you find an ASSERT() macro).

Re: Save the content from List Control in text file vc++

Victor Nijegorodov22-Mar-17 9:58

Re: Save the content from List Control in text file vc++

22-Mar-17 9:58

lolici wrote:
I wrote this:
void CDataDialog::OnBnClickedOk()
{
    // TODO: Add your control notification handler code here
    //CDialog::EndDialog(0);
    CStdioFile file("over1.txt", CFile::modeCreate);

<pre>
<span class="code-keyword">int</span> nCount = m_List.GetItemCount();</pre></blockquote>
What is m_List? Where and how is it defiled/initialized?

lolici wrote:
CString CDataDialog::GetItemText(
HWND hWnd, int nItem, int nSubItem) const
{
LVITEM lvi;
memset(&lvi, 0, sizeof(LVITEM));
lvi.iSubItem = nSubItem;
CString str;
int nLen = 128;
int nRes;
do
{
nLen *= 2;
lvi.cchTextMax = nLen;
lvi.pszText = str.GetBufferSetLength(nLen);
nRes = (int)::SendMessage(hWnd,
LVM_GETITEMTEXT, (WPARAM)nItem,
(LPARAM)&lvi);
} while (nRes == nLen - 1);
str.ReleaseBuffer();
return str;
}

Why do you iplement your own function rather than use CListCtrl::GetItemText (MFC) method?

lolici23-Mar-17 2:36

Re: Save the content from List Control in text file vc++

23-Mar-17 2:36

m_list is the control variable I declared about list control. Smile | :)

I used CListCtrl::GetItemText (MFC)
but didn't work either :/

Victor Nijegorodov23-Mar-17 7:20

Re: Save the content from List Control in text file vc++

23-Mar-17 7:20

Then please show your code how this variable was attached to the list control: did you use MFC DDX_... mechanism or something else?

lolici23-Mar-17 8:14

Re: Save the content from List Control in text file vc++

23-Mar-17 8:14

Here it is Smile | :)

public: CListCtrl m_List;

void CDataDialog::DoDataExchange(CDataExchange* pDX)
{
	CDialog::DoDataExchange(pDX);

	DDX_Control(pDX, IDC_LIST1, m_List);
}

I could also upload the project or the executable if it is possible.

Victor Nijegorodov23-Mar-17 12:29

A complex macro definition

23-Mar-17 12:29

lolici wrote:
I could also upload the project or the executable if it is possible.

Please, read the rules about asking the question here to know whether it is possible.

samzcs20-Mar-17 10:01

samzcs

20-Mar-17 10:01

C++

# define blHeadTable ((V_ROM1_FAR tblHead V_ROM2_FAR V_ROM3 *)(BL_HEAD_ADDRESS))

# define  GetblDID1()           (blHeadTable->DID[1])

I am a little confused in the first macro declaration.

Appreciate any explanation.

Jochen Arndt20-Mar-17 22:37

20-Mar-17 22:37

Basically it casts the fixed address BL_HEAD_ADDRESS as a pointer to some type:

# define someTypeAddr ((someType *)(BL_HEAD_ADDRESS))

In your case the type is V_ROM1_FAR tblHead V_ROM2_FAR V_ROM3.
Assuming that V_ROM1_FAR and V_ROM2_FAR are something like far *, the type is a pointer in V_ROM3 that points to a tblHead pointer.

Effectively it will assign a pointer to a tblHead structure at a fixed address.

samzcs21-Mar-17 2:22

samzcs

21-Mar-17 2:22

I understand it's like:

C++

# define someTypeAddr ((someType *)(BL_HEAD_ADDRESS))

But the type:

C++

V_ROM1_FAR tblHead V_ROM2_FAR V_ROM3

I am still a little confused with it.

C++

int a Char short, is that similar?

Thanks

Jochen Arndt21-Mar-17 2:32

21-Mar-17 2:32

You have to lookup first how V_ROM1_FAR and V_ROM2_FAR are defined.
Then it will be something like

far * tblHead far * V_ROM3

far is a compiler and platform specific keyword. See Far pointer - Wikipedia[^].

See also Cx51 User's Guide: Abstract Pointers[^] (I did not found a better link that explains such castings).

samzcs21-Mar-17 2:36

samzcs

21-Mar-17 2:36

Thanks, I understand it.

Looked into V_ROM2_FAR V_ROM3, V_ROM2_FAR be defined as const, V_ROM3 blank

dev c

Alvi ZaDa20-Mar-17 7:18

Alvi ZaDa

20-Mar-17 7:18

i hv problem in using basic rules of dev c Frown | :(

Re: dev c

Richard Deeming20-Mar-17 8:47

Richard Deeming

20-Mar-17 8:47

You also seem to have a problem in using the basic rules of asking a question! D'Oh! | :doh:

HOW TO ASK A QUESTION - C / C++ / MFC Discussion Boards[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: dev c

Victor Nijegorodov20-Mar-17 9:58

Change from Cstring to double in listview vc++

20-Mar-17 9:58

Alvi ZaDa wrote:
i hv problem in using basic rules of dev c

1. What is "hv"?
2. What is "dev c"?
What exactly is the "problem in using basic rules" you have?

Re: dev c

Patrice T20-Mar-17 11:45

Patrice T

20-Mar-17 11:45

Alvi ZaDa wrote:
i hv problem in using basic rules of dev c

Asking questions is a skill[^]
Some guidelines for posting questions in the forums[^]

Patrice

“Everything should be made as simple as possible, but no simpler.” Albert Einstein

lolici20-Mar-17 1:31

Re: Change from Cstring to double in listview vc++

20-Mar-17 1:31

Hello everyone!
I've used a list control to display data and an edit box to edit them. So I used this function:

void CDataDialog::SetCell(HWND hWnd1,
CString value, int nRow, int nCol)

I want to make this change:

void CDataDialog::SetCell(HWND hWnd1,
double value, int nRow, int nCol)

but I have problem with other functions such as GetDlgItemText which I don't know how to change. Here is the code:

void CDataDialog::SetCell(HWND hWnd1,
	double value, int nRow, int nCol)
{
	TCHAR     szString[256];
	swprintf(szString, value, 0);

	//Fill the LVITEM structure with the 
	//values given as parameters.
	LVITEM lvItem;
	lvItem.mask = LVIF_TEXT;
	lvItem.iItem = nRow;
	lvItem.pszText = szString;
	lvItem.iSubItem = nCol;
	if (nCol >0)
		//set the value of listItem
		::SendMessage(hWnd1, LVM_SETITEM,
		(WPARAM)0, (WPARAM)&lvItem);
	else
		//Insert the value into List
		ListView_InsertItem(hWnd1, &lvItem);

}

CString CDataDialog::GetItemText(
	HWND hWnd, int nItem, int nSubItem) const
{
	LVITEM lvi;
	memset(&lvi, 0, sizeof(LVITEM));
	lvi.iSubItem = nSubItem;
	CString str;
	int nLen = 128;
	int nRes;
	do
	{
		nLen *= 2;
		lvi.cchTextMax = nLen;
		lvi.pszText = str.GetBufferSetLength(nLen);
		nRes = (int)::SendMessage(hWnd,
			LVM_GETITEMTEXT, (WPARAM)nItem,
			(LPARAM)&lvi);
	} while (nRes == nLen - 1);
	str.ReleaseBuffer();
	return str;
}

void CDataDialog::OnClickList1(NMHDR *pNMHDR, LRESULT *pResult)
{
	//LPNMITEMACTIVATE pNMItemActivate = reinterpret_cast<LPNMITEMACTIVATE>(pNMHDR);
	// TODO: Add your control notification handler code here
	//*pResult = 0;
	Invalidate();
	HWND hWnd1 = ::GetDlgItem(m_hWnd, IDC_LIST1);
	LPNMITEMACTIVATE temp = (LPNMITEMACTIVATE)pNMHDR;
	RECT rect;
	//get the row number
	nItem = temp->iItem;
	//get the column number
	nSubItem = temp->iSubItem;
	if (nSubItem == 0 || nSubItem == -1 || nItem == -1)
		return;
	//Retrieve the text of the selected subItem 
	//from the list
	CString str = GetItemText(hWnd1, nItem,
		nSubItem);

	RECT rect1, rect2;
	// this macro is used to retrieve the Rectanle 
	// of the selected SubItem
	ListView_GetSubItemRect(hWnd1, temp->iItem,
		temp->iSubItem, LVIR_BOUNDS, &rect);
	//Get the Rectange of the listControl
	::GetWindowRect(temp->hdr.hwndFrom, &rect1);
	//Get the Rectange of the Dialog
	::GetWindowRect(m_hWnd, &rect2);

	int x = rect1.left - rect2.left;
	int y = rect1.top - rect2.top;

	if (nItem != -1)
		::SetWindowPos(::GetDlgItem(m_hWnd, IDC_EDIT1),
			HWND_TOP, rect.left + x, rect.top + 4,
			rect.right - rect.left - 3,
			rect.bottom - rect.top - 1, NULL);
	::ShowWindow(::GetDlgItem(m_hWnd, IDC_EDIT1), SW_SHOW);
	::SetFocus(::GetDlgItem(m_hWnd, IDC_EDIT1));
	//Draw a Rectangle around the SubItem
	::Rectangle(::GetDC(temp->hdr.hwndFrom),
		rect.left, rect.top - 1, rect.right, rect.bottom);
	//Set the listItem text in the EditBox
	::SetWindowText(::GetDlgItem(m_hWnd, IDC_EDIT1), str);
	*pResult = 0;
}

void CDataDialog::OnOK()
{
	CWnd* pwndCtrl = GetFocus();
	// get the control ID which is 
	// presently having the focus
	int ctrl_ID = pwndCtrl->GetDlgCtrlID();
	double str;
	switch (ctrl_ID)
	{   //if the control is the EditBox 
	case IDC_EDIT1:
		//get the text from the EditBox
		GetDlgItemText(IDC_EDIT1, str);

		//set the value in the listContorl with the
		//specified Item & SubItem values
		SetCell(::GetDlgItem(m_hWnd, IDC_LIST1),
			str, nItem, nSubItem);

		::SendDlgItemMessage(m_hWnd, IDC_EDIT1,
			WM_KILLFOCUS, 0, 0);
		::ShowWindow(::GetDlgItem(m_hWnd, IDC_EDIT1),
			SW_HIDE);
		break;
	default:
		break;
	}
}

Thank you in advance! Smile | :)

Jochen Arndt20-Mar-17 2:02

Re: Change from Cstring to double in listview vc++

20-Mar-17 2:02

A list control can not store double values without additional handling. To set the text of an item to a floating point value it must be converted. Read the documentation of the used sprintf, _sprintf_l, swprintf, _swprintf_l, __swprintf_l[^] function.
So you have to use something like

WCHAR szString[256];
swprintf(szString, sizeof(szString) / sizeof(WCHAR), L"%G", value);

But it would be better to use _snprintf_s, _snprintf_s_l, _snwprintf_s, _snwprintf_s_l[^] here:

TCHAR szString[256];
_sntprintf_t(szString, sizeof(szString) / sizeof(TCHAR), _T("%G"), value);

To get a double value back when reading the cell text use _tstof (atof, _atof_l, _wtof, _wtof_l[^]):

// double CDataDialog::GetItemText(HWND hWnd, int nItem, int nSubItem) const
double CDataDialog::GetItemDouble(HWND hWnd, int nItem, int nSubItem) const
{
    CString str = GetItemText(hWnd, nItem, nSubItem);
    return _tstof(str);
}

modified 20-Mar-17 9:01am.

lolici20-Mar-17 2:56

Re: Change from Cstring to double in listview vc++

20-Mar-17 2:56

I did it but I got this: "no suitable constructor exists from double to ATL::CStringT wchar_t StrTraitMFC__DLL<wchar_t,atl chtraitsctr<wchar_t="">>>" on

CString str = GetItemText(hWnd, nItem, nSubItem);

If I don't turn data from string to double could I "pass" them in a text file after edit them on the list view? Smile | :)

Jochen Arndt20-Mar-17 3:00