C#

maarten_oosterhoff wrote:

not how it affects reviewers. But fair enough I guess.

maarten_oosterhoff wrote:

If you know what GetDescendant() does, then you'll know the return type (assuming here).

maarten_oosterhoff wrote:

What is more important, the method and what it does, or the specific technical return type?

F-ES Sitecore wrote:

you can't discern the types simply by looking at them

var frob = DoSomething();

var myFoos = new Dictionary<string, Foo>();

// Vs:
// Dictionary<string, Foo> myFoos = new Dictionary<string, Foo>();

IDictionary<string, Foo> myFoos = new Dictionary<string, Foo>();

// Vs:
// var myFoos = (IDictionary<string, Foo>)new Dictionary<string, Foo>();

// Where followed by FirstOrDefault or SingleOrDefault can be replaced with an overload of the second function:
var customer = ctx.Customers.FirstOrDefault(c => c.HasOrders);
...
// This is an IQueryable<T> - you can't add it to a number in the line below:
var postage = ctx.Postage.Where(p => P.Country == customer.Country);
...
// Did you really mean to modify the value variable as well as the valuePlusPostage here?
var valuePlusPostage = value += postage;