Re: Checking for range of numbers - C# Discussion Boards

OriginalGriff12-Dec-15 4:47

OriginalGriff

12-Dec-15 4:47

Vunic wrote:
I just want to filter out the set that goes like 0-10,20-29,40-49

Are you sure?
Don't you want

0-9,20-29,40-49

To be consistent?
If you do, then it's relatively trivial: a divide by 10, and a check if the result is even via the lowest remaining bit will do it, won't it?

Or am I missing something?

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Eytukan12-Dec-15 5:02

12-Dec-15 5:02

Yes it's consistent.

I had made a typo, glad you picked it up. it was 0-9, not 0-10, to start with.
Better put this way :

Series A : 0-9, 20-29 40-49 .....
Series B : 10-19 30-39 50-59 ......

I just need to check for either A series or B series. Then its a matter of switching the IF and ELSE blocks.

As you see divide by 10 will not help. Take this case : 23 , this comes from A series. 33, comes from B series. How would you differentiate ?

Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.

Eytukan12-Dec-15 5:07

12-Dec-15 5:07

Damn. You are right. the brain just kicked back to life. I was just focusing on the reminder part D'Oh! | :doh:

Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.

OriginalGriff12-Dec-15 5:14

OriginalGriff

12-Dec-15 5:14

I have whole weeks like that! Laugh | :laugh:

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Eytukan12-Dec-15 19:10

12-Dec-15 19:10

It happens. Actually this module what I'm doing is fairly complex, if the folks around me come to know I had stuck over this trivia, for sure they'd be puzzled, how I'm going to do the rest of the stuff. They wouldn't understand this phenomena! Smile | :)

Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.

OriginalGriff12-Dec-15 23:53

OriginalGriff

12-Dec-15 23:53

I can keep a secret if you can! Wink | ;)

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

harold aptroot12-Dec-15 23:41

harold aptroot

12-Dec-15 23:41

If you divide these by 10, you map the range 0-9 to 0, 10-19 to 1, etc.

Then just check if that's even.

if ((x / 10 & 1) == 0)
    // filtered out
else
    // ignored

Eytukan16-Dec-15 5:00

16-Dec-15 5:00

Yup I've done the same way Thumbs Up | :thumbsup:

thanks

Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.

Luc Pattyn14-Dec-15 12:07

Luc Pattyn

14-Dec-15 12:07

for natural numbers just use: bool OK=number%20<10;

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Eytukan16-Dec-15 4:59

Current datagrid row not being selected

16-Dec-15 4:59

Wow another good thought! Thumbs Up | :thumbsup:

Feels great I wasn't a fool to think about a way through mod fn. $Shucks | :-\$

Starting to think people post kid pics in their profiles because that was the last time they were cute - Jeremy.

Member 1144944710-Dec-15 1:46

10-Dec-15 1:46

Why is it that in this code which is in a button, when I click in the button to fill a row that is empty, instead of sending the message "Fill the empty cells", it selects the previous row and add it as a new line (it copies the row with the previous Id)? Thank you.

if (grid_lic.CurrentRow.Cells[1].Value.ToString() == "" || grid_lic.CurrentRow.Cells[2].Value.ToString() == "" || grid_lic.CurrentRow.Cells[6].Value.ToString() == "")
MessageBox.Show("Fill the empty cells");
else                                   
   {

dbcCommand Command = new OdbcCommand("insert into lojas (NIF, Loja, bloqueado, DataFim, lastupdate, Nome) values (?, ?, ?, ?, ?, ?)", connection);
                        Command.CommandType = CommandType.Text;
                        Command.Parameters.AddWithValue("@NIF", grid_lic.CurrentRow.Cells[1].Value);
                        Command.Parameters.AddWithValue("@Loja", grid_lic.CurrentRow.Cells[2].Value);
                        Command.Parameters.AddWithValue("@Bloqueado", checkBox_bloq.Checked);
                        Command.Parameters.AddWithValue("@DataFim", grid_lic.CurrentRow.Cells[4].Value);
                        Command.Parameters.AddWithValue("@lastupdate", grid_lic.CurrentRow.Cells[5].Value);
                        Command.Parameters.AddWithValue("@Nome", grid_lic.CurrentRow.Cells[6].Value);
connection.Open();
Command.ExecuteNonQuery();

modified 10-Dec-15 7:47am.

Richard Deeming10-Dec-15 3:36

Richard Deeming

10-Dec-15 3:36

That would suggest that the empty row is not the current row.

Debug your code and check the CurrentRow property. Then work out why it's not pointing to the empty row.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Member 1144944710-Dec-15 4:49

10-Dec-15 4:49

That´s exactly the problem I described with other words. It is selecting the previous row, not the one where the mouse is clicked. But this only happens if the cell selected is empty, because if I write in the cell and click the button, that same row is the current row, not the previous one. That´s what the following code is telling:

MessageBox.Show(grid_lic.CurrentCell.ColumnIndex.ToString()); MessageBox.Show(grid_lic.CurrentCell.RowIndex.ToString());

I don't know where is the source of the problem. Any clue?

Richard Deeming10-Dec-15 5:18

Richard Deeming

10-Dec-15 5:18

Sounds like the empty row doesn't become "current" until you start editing it.

Try checking the Selected property of the CurrentRow, which will probably be false. Also, check the SelectedRows collection to see if it contains the empty row.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Member 1144944710-Dec-15 6:34

10-Dec-15 6:34

The empty row belongs to the collection of SelectedRows, as this code which I ran selecting an empty row with index #4, confirms:

DataGridViewRow emptyrow = grid_lic.Rows[4];
if (grid_lic.SelectedRows.Contains(emptyrow))
MessageBox.Show("The row is empty!");

The Selected property of the CurrentRow is false:

if (grid_lic.Rows[4].Selected == false)
MessageBox.Show("False");
else
MessageBox.Show("True");

The problem was identified, I just don't know why it happens nor how to solve it. Any ideas?

Thank you.

Richard Deeming10-Dec-15 6:53

Richard Deeming

10-Dec-15 6:53

Try something like this:

var row = grid_lic.CurrentRow;
if (row == null || !row.Selected)
{
    if (grid_lic.SelectedRows.Count == 0)
    {
        MessageBox.Show("Select a row.");
        return;
    }
    
    row = grid_lic.SelectedRows[0];
}

if (string.IsNullOrEmpty(Convert.ToString(row.Cells[1].Value)) 
  || string.IsNullOrEmpty(Convert.ToString(row.Cells[2].Value)) 
  || string.IsNullOrEmpty(Convert.ToString(row.Cells[6].Value)))
{
    MessageBox.Show("Fill the empty cells");
    return;
}

using (OdbcConnection connection = CreateConnection())
using (OdbcCommand command = new OdbcCommand("insert into lojas (NIF, Loja, bloqueado, DataFim, lastupdate, Nome) values (?, ?, ?, ?, ?, ?)", connection))
{
    command.CommandType = CommandType.Text;
    command.Parameters.AddWithValue("@NIF", row.Cells[1].Value);
    command.Parameters.AddWithValue("@Loja", row.Cells[2].Value);
    command.Parameters.AddWithValue("@Bloqueado", checkBox_bloq.Checked);
    command.Parameters.AddWithValue("@DataFim", row.Cells[4].Value);
    command.Parameters.AddWithValue("@lastupdate", row.Cells[5].Value);
    command.Parameters.AddWithValue("@Nome", row.Cells[6].Value);
    
    connection.Open();
    command.ExecuteNonQuery();
}

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Member 1144944714-Dec-15 7:25

14-Dec-15 7:25

That code allows me to fill an empty row which is what I don't want, it just doesn't allow to add data when the row is not selected, even if the cells are filled.

Member 1144944714-Dec-15 8:08

14-Dec-15 8:08

I solved it this way:

if(!row.Selected)
 {
   if (grid_lic.SelectedRows.Count == 0)
     {
       MessageBox.Show("Select the row.");
       return;
      }

  row = grid_lic.SelectedRows[0];
  }

 int i = grid_lic.SelectedRows[0].Index;

  if (string.IsNullOrEmpty(Convert.ToString(grid_lic.Rows[i].Cells[1].Value)) || string.IsNullOrEmpty(Convert.ToString(grid_lic.CurrentRow.Cells[2].Value))
|| string.IsNullOrEmpty(Convert.ToString(grid_lic.CurrentRow.Cells[6].Value)))
 {
    MessageBox.Show("Preencha os campos vazios");
    return;
  }

using (OdbcConnection connection = CreateConnection())
{
    OdbcCommand Command = new OdbcCommand("insert into lojas (NIF, Loja, bloqueado, DataFim,       lastupdate, Nome) values (?, ?, ?, ?, ?, ?)", connection);
   Command.CommandType = CommandType.Text;
   Command.Parameters.AddWithValue("@NIF", grid_lic.CurrentRow.Cells[1].Value);
   Command.Parameters.AddWithValue("@Loja", grid_lic.CurrentRow.Cells[2].Value);
   Command.Parameters.AddWithValue("@Bloqueado", checkBox_bloq.Checked);
   Command.Parameters.AddWithValue("@DataFim", grid_lic.CurrentRow.Cells[4].Value);
   Command.Parameters.AddWithValue("@lastupdate", grid_lic.CurrentRow.Cells[5].Value);
   Command.Parameters.AddWithValue("@Nome", grid_lic.CurrentRow.Cells[6].Value);
             
   connection.Open();
   Command.ExecuteNonQuery();
}