Re: Print Queue implementation by linked list class - C# Discussion Boards

Re: Print Queue implementation by linked list class

14-Nov-15 5:12

are you trying to say Document will be like node class in link list.

Document class is a abstract class then how Document class can be a node?

the below code is ok ?

do i need to at all have variable data which return object or Subject property will do the job?

public abstract class Document
{
    public Document next;
    public Object data;

    public string Subject { get; set; }

    public abstract string type();
}

tbhattacharjee

OriginalGriff14-Nov-15 5:29

Re: Print Queue implementation by linked list class

14-Nov-15 5:29

An abstract class can have concrete properties, fields, and methods - it just can;t be instantiated. Which means that is you have this:

public abstract class Document
   {
   public Document Next = null;
   }
public class PdfDocument : Document
   {
   }
public class WordDocument : Document
   {
   }

The you can't do this:

Document d = new Document();

Because you can't create an instance of an abstract class.
But you can do this:

Document d = new PdfDocument();
d.Next = new WordDocument();

Because you can create instances of derived concrete classes, and assign them to variables which contain the abstract base class.

It's a bit like cars: Car is an abstract concept, while Ford Fiesta is a specific concrete type of Car, so you can buy one. If you try to go into a dealers and buy "A Car" without wanting any make or model you are going to get some very funny looks... Laugh | :laugh:

You probably don't want the Subject to be part of the abstract base class, unless all Document types will definitely have a Subject - and you certainly don't want the content to be party of the base class because you don't know what it is or what it needs to be stored in. (Any more than you'd put the rear passenger seats in the Car class, because that would cause problems with two seaters - which don't have any - and seven seaters - which might have two rows of rear passenger seats, or two "benches" as in an old Landrover.)

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Tridip Bhattacharjee14-Nov-15 5:22

Re: Print Queue implementation by linked list class

14-Nov-15 5:22

as you said i wrote the code. you said Start by creating your PrintQueue class - add a private Head variable which is a Document. Add a Next property to your Document class which is also a Document. This allows you to create the linked list.

so i wrote the code like

class PrintQueue
{
    private Document head;

    public void Push(Object data)
    {
        Document toAdd = new Document();
        toAdd.data = data;

        Document current = head;
        while (current.next != null)
        {
            current = current.next;
        }
        current.next = toAdd;
    }
}


public abstract class Document
{
    public Document next;
    public Object data;

    public string Subject { get; set; }

    public abstract string type();
}

public class WordDocument : Document
{
    public override string type()
    {
        return "docx";
    }
}

public class PdfDocument : Document
{
    public override string type()
    {
        return "pdf";
    }
}

this line

Document toAdd = new Document();

giving error because abstract class can not be instantiated.

i failed for this area design as you said For Pop, check if there are any items in the Head, and remove it to a temporary variable, setting the value of Head to the Next value of the Document you removed. Set the Next value of the temporary value to null, and return the temporary value.

just do not being able to write code for Pop function. please help me for pop.

looking for help to complete this code. thanks

tbhattacharjee

OriginalGriff14-Nov-15 5:35

Re: Print Queue implementation by linked list class

14-Nov-15 5:35

See the answer I wrote to your previous comment.

What part of Pop is difficult?

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Tridip Bhattacharjee14-Nov-15 8:27

Re: Print Queue implementation by linked list class

14-Nov-15 8:27

this is my full updated code but still the code is not completed and there is error.

see the code and also read my first post and guide me how to complete the program.

class PrintQueue
    {
        private Document head;

        private int size;
        public int Count
        {
            get
            {
                return size;
            }
        }

        public void Push(Object data)
        {
            Document toAdd = new Document();
            toAdd.data = data;

            Document current = head;
            while (current.Next != null)
            {
                current = current.Next;
            }
            current.Next = toAdd;
            size++;
        }

        public bool Pop()
        {
            Document tempNode = head;

            Document lastNode = null;
            int count = 0;

            if (size > 0)
            {
                while (tempNode != null)
                {
                    if (count == size - 1)
                    {
                        lastNode.Next = tempNode.Next;
                        return true;
                    }
                    count++;

                    lastNode = tempNode;
                    tempNode = tempNode.Next;
                }
            }
            return false;
        }
    }


    public abstract class Document
    {
        public Document Next;
        public Object data;

        public string Subject { get; set; }

        public abstract string type();
    }

    public class WordDocument : Document
    {
        public override string type()
        {
            return "docx";
        }
    }

    public class PdfDocument : Document
    {
        public override string type()
        {
            return "pdf";
        }
    }

for this line i will get error

Document toAdd = new Document();

but how could i use there worddoc or pdfdoc class because i do not know which one should use inside in PrintQueue class?

so tell me what is the work around and also see and tell me Pop() function is properly constructed or not ?

thanks

tbhattacharjee

Tridip Bhattacharjee14-Nov-15 18:33

Re: Print Queue implementation by linked list class

14-Nov-15 18:33

the 2 questions i was trying to solve as follows

Question 1 : Write a class named Document to represent a document node in a print queue. it should contain a method name that returns the subject of the document and an abstract method called type that returns the document type . from document class derive two concrete classes named word document and pdf document.

Question 2 : Another class named Print Queue that is implemented as a linked list of Document objects. Print Queue should have a method named Push for adding a document to the end of the list, a method named pop for removing the first document from the list , and a method named DisplayContents for listing all of the documents in the Print Queue, reporting both the Name and Type of each element Print Queue should not use any standard library classes it should be own implementation of linked list.

here i like to post whatever at last i achieved. so please see the code and question let me know is it correct as per the 2 question pasted here.

see the latest code

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace PrintQueueDemo
{
    class PrintQueue
    {
        Node head;
        Node tail;

        /// <summary>
        /// add a document to the print queue
        /// </summary>
        /// <param name="strType">document type</param>
        /// <param name="strName">docunent name</param>
        public void Push(string strType, string strName)
        {
            if (head == null)
            {
                head = new Node(strType, strName);
                tail = head;
            }
            else
            {
                Node node = new Node(strType, strName);
                tail.setNext(node);
                tail = node;
            }
        }

        /// <summary>
        /// pop a document from the queue
        /// </summary>
        /// <returns>null if printqueue is empty, else document</returns>
        public Node.Document Pop()
        {
            if (head == null)
                return null;

            Node.Document doc = new Node.Document(head.document.Type, head.document.Name);
            head = head.nextnode;
            if (head == null)
                tail = null;
            return doc;
        }

        /// <summary>
        /// get the current content of the queue
        /// </summary>
        /// <returns>string with current content (line per entry)</returns>
        public string DisplayContents()
        {
            string content = "";
            Node node = head;
            if (node == null)
                return "PrintQueue is empty";

            content = node.document.Name + ": " + node.document.Type;
            while (node.nextnode != null)
            {
                node = node.nextnode;
                content += "\r\n" + node.document.Name + ": " + node.document.Type;
            }
            return content;
        }

        public class Node
        {
            public Document document { get; private set; }
            public Node nextnode { get; private set; }

            public Node(string strType, string strName)
            {
                document = new Document(strType, strName);
            }

            public void setNext(Node node)
            {
                nextnode = node;
            }
            
            public class Document
            {
                public string Type { get; private set; }
                public string Name { get; private set; }

                public Document(string strType, string strName)
                {
                    Name = strName;
                    Type = strType;
                }
            }
        }
    }
}

PrintQueue pq = new PrintQueue();
pq.Push("cpp", "main.cpp");
pq.Push("c#", "main.cs");
pq.Push("c", "main.c");
pq.Push("h", "myinclude.h");

Console.WriteLine(pq.DisplayContents());
Console.WriteLine("===");

PrintQueue.Node.Document doc;
doc = pq.Pop();
Console.WriteLine("{0}: {1}", doc.Name, doc.Type);
doc = pq.Pop();
Console.WriteLine("{0}: {1}", doc.Name, doc.Type);
doc = pq.Pop();
Console.WriteLine("{0}: {1}", doc.Name, doc.Type);
doc = pq.Pop();
Console.WriteLine("{0}: {1}", doc.Name, doc.Type);
Console.WriteLine("===");

Console.WriteLine(pq.DisplayContents());
Console.WriteLine("===");

pq.Push("xls", "workbook.xls");
Console.WriteLine(pq.DisplayContents());

just tell me the above code will be accepted as per 2 question which i pasted at top. thanks

tbhattacharjee

OriginalGriff14-Nov-15 23:23

Re: Print Queue implementation by linked list class

14-Nov-15 23:23

No.
From a personal POV, I wouldn't use a tail unless I really had to - it complicates things, and it far to easy to mess it up. I'd traverse the list (or actually use a Queue rather than a linked list anyway).

But...
Why are you returning a new node on Pop? What's wrong with the actual node? Why waste time creating a new one, when it may not be the same as the original in all respects?

Why do you have a public nextnode property and a setNext method? Dump the method and make the setter public as well.

If you are going to use XML comments (and it's a good idea) use them consistently: i.e. every public object should have a "proper" comment.

What happened to the abstract Document class?

Why does your test code not check for nulls? There is no point in returning null for an error if you don't check for it anywhere!

Why do it like this:

content = node.document.Name + ": " + node.document.Type;
while (node.nextnode != null)
{
    node = node.nextnode;
    content += "\r\n" + node.document.Name + ": " + node.document.Type;
}

Try changing it round:

while (node.nextnode != null)
{
    content += node.document.Name + ": " + node.document.Type + "\r\n";
    node = node.nextnode;
}

Or better, use a string builder:

public string DisplayContents()
{
    StringBuilder content = new StringBuilder();
    Node node = head;
    while (node != null)
    {
        content.AppendFormat("{0} : {1}\n", node.document.Name, node.document.Type);
        node = node.nextnode;
    }
    return content.ToString();
}

And why is Document a part of Node? Is there a good reason? I can see why you might want them to be separate classes, but...
If Node inherited from Document that would make sense, or even if Document inherited from Node - but making it an encapsulated class feels very wrong, and complicates your code.

I'd probably make Node an abstract class, and inherit an abstract Document from that, then inherit the concrete PdfDocument and WordDocument you were using previously from there.

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

modified 15-Nov-15 7:57am.

Tridip Bhattacharjee15-Nov-15 21:14

Re: Print Queue implementation by linked list class

15-Nov-15 21:14

i have posted so many question for this issue with my though and code. i have one request can you please post the full right code as per your thought and thinking and it will long time for you because already i post the full code and you just need to arrange the same code as your thinking.

would you please help me posting code as per your thinking. thanks

tbhattacharjee

OriginalGriff15-Nov-15 21:25

15-Nov-15 21:25

No - this is your homework, and it may seem cruel to not do it for you, but...you need to understand this stuff because the next assignment will assume that you do and build upon it. And the best way to understand it is to do it, looking at anothers code doesn't tell you why it's like it is.

Plus, you do realize that your tutor knows this site exists and would mark your code knowing you copied it from me? That's not likely to give you a good mark! Laugh | :laugh:

So have a go. It's not complicated once you get your head round it, and you seem to be intelligent enough to do it easily - if you stop trying to take short cuts! Wink | ;)

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Parallel vs Threading

Ger Hayden14-Nov-15 0:22

14-Nov-15 0:22

I'm doing some automated testing where I read a datarow from a spreadsheet then pull in a set of steps from and apply the data to a web page.

There is no dependency between the data row, each using its own browser instance to simulate an individual user.

From the little I've learned there are performance differences between parallel and thread based executions.

At the moment I intend to go thread based - but may I have some feedback from community based in your experience.

Ger

Gerry Schmitz14-Nov-15 9:42

Gerry Schmitz

14-Nov-15 9:42

There is no easy answer.

Depending on the type processing required and the hardware resources available (i.e. CPU "cores"), parallelizing will perform better or it may not.

Building and tearing down tasks incurs overhead; overhead not incurred in "non-parallel" operations. If the load can be spread around, and all tasks can run independently then parallelizing can work for you; otherwise it may not. You need to benchmark your options and keep in mind your final configuration; don't optimize prematurely.

Ger Hayden14-Nov-15 11:27

14-Nov-15 11:27

112 pages take 50 mins to complete sequentially

Ger

Gerry Schmitz14-Nov-15 20:29

Gerry Schmitz

14-Nov-15 20:29

And?

I once got a payroll job that ran for 24 hours down to 20 minutes by presorting one of the input files.

No multitasking.

Ger Hayden15-Nov-15 9:50

15-Nov-15 9:50

And ... I expect some experimentation is in order.

I've never operated beyond a single thread in a commercial environment before - I've never had the need, just like your experience a decent sort or index has always been sufficient.

If it works well, it should give me a simulated multi user situation.

Each discrete task opens a web page, browses to a URL (served by localhost) fills two text boxes hits two radios, clicks a button then kills the page.

Ger

Gerry Schmitz15-Nov-15 10:22

Gerry Schmitz

15-Nov-15 10:22

I see; thank you.

The problem (IMO) you are faced with is that the response from each web page (i.e. site) can be different; based on the path to that site.

I would therefore say your app is "IO / Input bound".

In this case, parallel processing should help since other tasks can run while others wait for a web response (using asynchronous callbacks).

(Out of curiosity, I would put "stop watch" code around my internet accesses and time them for the various sites).

Ger Hayden18-Nov-15 3:24

Moving Data from one form to another

18-Nov-15 3:24

For the specific test threading reduced the elapsed time from 50 to 25 mins, and significantly improved CPU utilisation.

Ger

KakitaIppatsu13-Nov-15 14:45

KakitaIppatsu

13-Nov-15 14:45

I'm trying to take data collected on a form, and output it to another form, but I'm getting an "inaccessible due to its protection level" error.

So I have form A, that has a panel with some dynamically generated textboxes.
FormA -> panelA -> txtQtyA

In Form B, I want to access the data, and I'm trying to use:
txtQtyB.text = FromA.panelA.txtQtyA.Text, but I get the error for panelA.

I have tried changing the forms constructor to Public, just to see if it would "see" it with no luck.

Any assistance would be appreciated.

John Torjo13-Nov-15 14:51

John Torjo

13-Nov-15 14:51

You need to edit this: "FromA.panelA.txtQtyA" in the Visual Designer. It's got a property called "Modifiers" which is set to Private. You'll want to make that either Internal or Public - depending on your needs.

Best,
John

-- LogWizard Meet the Log Viewer that makes monitoring log files a joy!

KakitaIppatsu13-Nov-15 15:24

KakitaIppatsu

13-Nov-15 15:24

That removed the error, but introduced another.

I now get an error on the same line but is is under FormA.PanelA stating: An object reference is required for the non-static field, method or property.

txtQtyB.Text = FormA.panelA.txtQtyA.Text;

I'm not sure how I can change the accessor for a dynamically created control?

And just to add a little more. FormA creates and calls FormB.

John Torjo13-Nov-15 15:30

John Torjo

13-Nov-15 15:30

You need an instance of FormA, like:

var forma = new FormA();
txtQtyB.Text = forma.panelA.txtQtaA.Text;

Or, more likely:

var forma = new FormA();
txtQtyB.Text = forma.txtQtaA.Text;

-- LogWizard Meet the Log Viewer that makes monitoring log files a joy!

OriginalGriff13-Nov-15 21:43

13-Nov-15 21:43

Or even more likely, he needs the existing instance of the form that the user entered data into... Sigh | :sigh:

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

OriginalGriff13-Nov-15 21:35

13-Nov-15 21:35

No.
This is a bad idea - it ties the two design of the two forms together and means they can't be modified without considering the impact of changes on the outside world.
The default setting is private for a reason, and changing it to public is a hack!

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

BillWoodruff13-Nov-15 16:26

BillWoodruff

13-Nov-15 16:26

Changing the 'Ctor of a Form's access to 'Public is a mistake.

You need to set up a dynamic linkage between the run-time created TextBoxes in FormA and FormB. There are several ways you could do this, all relatively simple to implement. One example:

1. if FormB is a "Main Form" and creates the instance of FormA, you could have code in FormB create the TextBoxes at run-time and inject them into FormA: that way, FormB would have direct references to the TextBoxes.

To select from several other possible techniques, it would be helpful to know:

1. which is the "Main Form" here: A, B, or ? if A is not the Main Form where is the code that declares an instance of it and shows it ?

2. which is the Form in which the run-time TextBoxes in A are created: A ? or ?

3. do the number of TextBoxes created at run-time vary, or are they always the same number of TextBoxes ?

«I want to stay as close to the edge as I can without going over. Out on the edge you see all kinds of things you can't see from the center» Kurt Vonnegut.

OriginalGriff13-Nov-15 21:42