The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: hhg

Brisingr Aerowing10-Aug-15 14:16

Brisingr Aerowing

10-Aug-15 14:16

What do you get when you cross a joke with a rhetorical question?

The metaphorical solid rear-end expulsions have impacted the metaphorical motorized bladed rotating air movement mechanism.

Do questions with multiple question marks annoy you???

Re: hhg

Dharmesh .S. Patil12-Aug-15 1:46

Dharmesh .S. Patil

12-Aug-15 1:46

Re: hhg

Brisingr Aerowing12-Aug-15 1:48

Brisingr Aerowing

12-Aug-15 1:48

Re: hhg

jeron112-Aug-15 5:09

jeron1

12-Aug-15 5:09

"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle

I feel so dirty

PIEBALDconsult7-Aug-15 10:00

PIEBALDconsult

7-Aug-15 10:00

I just stuck this in a small data import utility that I don't particularly care about:

catch ( System.Data.DataException err )
{
  if ( !err.ToString().Contains ( "Cannot insert duplicate key" ) )
  {
    throw ;
  }
}

If they don't care enough to send me clean data, why should I spend a Friday afternoon writing good code?

modified 7-Aug-15 16:45pm.

Re: I feel so dirty

Mike (Prof. Chuck)8-Aug-15 1:11

Mike (Prof. Chuck)

8-Aug-15 1:11

that's the way to do it... why should always we developers have the pressure of being exact and clean Big Grin | :-D

would've done it too this way... if it was friday afternoon in the mid of summer Poke tongue | ;-P

Re: I feel so dirty

Marc Clifton8-Aug-15 1:29

Marc Clifton

8-Aug-15 1:29

PIEBALDconsult wrote:
err.ToString()

Whatever happened to err.Message ? Wink | ;)

Marc

Imperative to Functional Programming Succinctly

Contributors Wanted for Higher Order Programming Project!

Re: I feel so dirty

PIEBALDconsult8-Aug-15 6:07

PIEBALDconsult

8-Aug-15 6:07

Nah, I tried that first, but the text is in an InnerException.

I have code that spelunks the Exceptions looking for the actual Error code from SQL Server, but I didn't have it handy.

Re: I feel so dirty

Richard Deeming10-Aug-15 2:15

Richard Deeming

10-Aug-15 2:15

If it's in the innermost exception:

catch ( System.Data.DataException err )
{
    if ( !err.GetBaseException().Message.Contains ( "Cannot insert duplicate key" ) )
    {
        throw;
    }
}

Exception.GetBaseException Method | MSDN[^]

If it can be anywhere in the chain:

catch ( System.Data.DataException err )
{
    bool isDuplicateKey = false;
    Exception currentErr = err;
    
    while (currentErr != null && !isDuplicateKey)
    {
        isDuplicateKey = currentErr.Message.Contains ( "Cannot insert duplicate key" );
        currentErr = currentErr.InnerException;
    }
    
    if ( !isDuplicateKey )
    {
        throw;
    }
}

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: I feel so dirty

Eddy Vluggen10-Aug-15 2:41

Eddy Vluggen

10-Aug-15 2:41

Though I can see the improvement; wouldn't the weak spot here being the check for a localized message? IIRC, then different (localized) versions of .NET will give different results.

"Kan geen rij met dubbele sleutel invoegen in object 'dbo.aa673 met unieke index 'IX_673'."

Next you'll hear "It worked on Win7, and then I opened it on another machine and it crashed. We didn't change anything and it should still be working. Why does Windows do that?" Laugh | :laugh:

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Re: I feel so dirty

Richard Deeming10-Aug-15 2:46

Richard Deeming

10-Aug-15 2:46

Indeed. Checking the SQL error codes would be a more robust approach.

However, it sounds like this is a program that's only ever run on one computer, so it's unlikely to suddenly start throwing errors in Dutch. Smile | :)

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: I feel so dirty

Eddy Vluggen10-Aug-15 5:18

Eddy Vluggen

10-Aug-15 5:18

Richard Deeming wrote:
However, it sounds like this is a program that's only ever run on one computer

I wish I had gotten a penny everytime that assumption fell apart Smile | :)

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Re: I feel so dirty

PIEBALDconsult10-Aug-15 3:32

PIEBALDconsult

10-Aug-15 3:32

When I do it right, I walk the InnerExceptions to find the first System.Data.SqlClient.SqlException with one of the following error codes:

errorcodes = new System.Collections.Generic.Dictionary<int,PIEBALD.Data.ErrorCode>() ;

errorcodes [ 1205 ] = PIEBALD.Data.ErrorCode.Deadlock             ;
errorcodes [ 2601 ] = PIEBALD.Data.ErrorCode.Duplicate            ;
errorcodes [ 2627 ] = PIEBALD.Data.ErrorCode.Duplicate            ;
errorcodes [  547 ] = PIEBALD.Data.ErrorCode.ReferentialIntegrity ;
errorcodes [   -2 ] = PIEBALD.Data.ErrorCode.Timeout              ;

Then wrap it in a custom Exception:

public partial class DuplicateException : PIEBALD.Data.OperationFailedException ...

public partial class ReferentialIntegrityException : PIEBALD.Data.OperationFailedException ...

public partial class TimeoutException : PIEBALD.Data.OperationFailedException ...

Then my code can catch and act on specific error codes.

Re: I feel so dirty

Xmen Real 16-Dec-15 4:26

Xmen Real

16-Dec-15 4:26

What if locale is not english

TVMU^P[[IGIOQHG^JSHA#@RFJ\c^JPL>;"[,/|+&WLEZGc

AFXc!L<br /> %^]*IRXD#@GKCQ
R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_ADEPABIKRDFVS)EVLQK)JKQUFK[MUKs$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia>

-----------------------------------------------
128 bit encrypted signature, crack if you can

I blame San Andreas - it's his default...

Duncan Edwards Jones23-Jul-15 1:18

Duncan Edwards Jones

23-Jul-15 1:18

SQL

ALTER TABLE [tablename] ADD DEFAULT (NULL) FOR [fieldname]

Well yes - that should make a huge difference.... Confused | :confused:

Re: I blame San Andreas - it's his default...

ZurdoDev23-Jul-15 2:21

ZurdoDev

23-Jul-15 2:21

Duncan Edwards Jones wrote:
that should make a huge difference

You can never be too clear. $Shucks | :-\$

There are only 10 types of people in the world, those who understand binary and those who don't.

Re: I blame San Andreas - it's his default...

Eddy Vluggen23-Jul-15 2:34

Eddy Vluggen

23-Jul-15 2:34

Then why is there no comment explaining the default? Roll eyes | :rolleyes:

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Re: I blame San Andreas - it's his default...

ZurdoDev23-Jul-15 2:39

ZurdoDev

23-Jul-15 2:39

Eddy Vluggen wrote:
Then why is there no comment explaining the default?

Reminds me of some code I inherited.

DataManager dm = new DataManager();
// open the connection
dm.Open();

Ya, thanks for the helpful comment. Roll eyes | :rolleyes:

There are only 10 types of people in the world, those who understand binary and those who don't.

Re: I blame San Andreas - it's his default...

Eddy Vluggen23-Jul-15 2:43

Eddy Vluggen

23-Jul-15 2:43

That is rather helpful; it explains that the DataManager is merely a wrapper round a connection, and that it probably should be deleted from the project and simply replaced by an IDbConnection and a factory $Shucks | :-\$

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Smiles, headache sometimes

ravikhoda13-Jul-15 19:09

ravikhoda

13-Jul-15 19:09

Working on Google sign in API for one of my project which need to load one j query file called

https://apis.google.com/js/client:plusone.js

i copy this link send it to my co-worker by Skype, he copied and apply that code. Boom, g-sign in button do not click. the same code working fine on the test project that we have created but not on our main project.

Reason,
Skype see "client:plusone.js" and convert :P to Poke tongue | ;-P

and when same code goes to vs it leaves a blank space and copied like "client lusone.js". after spending some half an hour we finally got a working example of Google sign in.

Ravi Khoda

Re: Smiles, headache sometimes

Sanket Saxena13-Jul-15 21:04

Sanket Saxena

13-Jul-15 21:04

Thank God the code didn't use mooning Smile | :)

And you thought some of the CodeProject questions were bad...

Rob Grainger13-Jul-15 11:26

Rob Grainger

13-Jul-15 11:26