C / C++ / MFC

CPallini9-Oct-14 4:17

CPallini

9-Oct-14 4:17

What's wrong in including param.h in MyApiClass source file?

THESE PEOPLE REALLY BOTHER ME!! How can they know what you should do without knowing what you want done?!?!
-- C++ FQA Lite

piul9-Oct-14 5:01

piul

9-Oct-14 5:01

well... the application in which I use the lib won't compile, will it?? Or am I missing something?

Including param.h in libApi.cpp, when compiling the application

//MyApp.cpp
#include "libApi.h"
//library links with this
void main (void)
{
//...
}

I get an error saying "libApi.h: 'Param' undeclared identifier"

Orjan Westin9-Oct-14 5:06

Orjan Westin

9-Oct-14 5:06

You can use the pimpl idiom:

C++

//libApi.h

class MyApiClass{
  public:
  //some methods, the implementation of which is simply forwarding to MyApiClassImpl ...
  private:
  // forward declaration of implementation details
  class MyApiClassImpl;
  //
  std::auto_ptr<MyApiClassImpl> impl;
};

and

C++

// libApi.cpp
#include <map>
#include <string>
#include "Param.h"

// Declaration of implementation class
class MyApiClass::MyApiClassImpl
{
public:
  // Mirroring MyApiClass...
private:
  std::map<std::string, Param> vars;
};

// Implementation of API class
MyApiClass::MyApiClass()
: impl(new MyApiClassImpl())
{}

int MyApiClass::SomeFunction()
{
  return impl->SomeFunction();
}

// Implementation class
MyApiClass::MyApiClassImpl::MyApiClassImpl()
{}

int MyApiClass::MyApiClassImpl::SomeFunction()
{
  // Do the stuff...
}

(Edited to fix code written too fast...)

modified 9-Oct-14 11:12am.

Freak309-Oct-14 22:28

Freak30

9-Oct-14 22:28

Your Approach only works as long as you are never required to pass a Param object as paramter or return one. Of course you could work with forward declaration (if you only pass references/pointers), but I would suggest another solution.

Create a libapi.hpp and include the headers in the correct order (i.e. map, string, Param.h, libApi.h). Consumers of your API inlclude the hpp. In the libApi.cpp you include the Param.h before the libApi.h. Then it should work.

The good thing about pessimism is, that you are always either right or pleasently surprised.

C++ MFC Dialog Password encryption Vs2005 [moved]

Orjan Westin9-Oct-14 23:02

Orjan Westin

9-Oct-14 23:02

Ideally, you'd want minimal exposure, to ensure low coupling. The original post made a point of only showing Param in the private section, and said the user of the library should not be playing around with Param, so I assumed it was not a public type.

If the Param type was a public type used in the interface, the best solution would be to include Param.h in libApi.h instead of introducing a new file.

COM Component

john56329-Oct-14 1:45

john5632

9-Oct-14 1:45

I am placing COM component (WMP) on dialog. When I place it and run the application, dialog does not appear but when I delete it and run, dialog appears.

Please suggest what can be issue?

I debug the code and saw DoModal function.

It is executing the portion of DoModal as m_hWnd is comiing NULL.

<pre lang="c++">
// hide the window before enabling the parent, etc.
if (m_hWnd != NULL)
SetWindowPos(NULL, 0, 0, 0, 0, SWP_HIDEWINDOW|
SWP_NOSIZE|SWP_NOMOVE|SWP_NOACTIVATE|SWP_NOZORDER);

modified 9-Oct-14 7:54am.

Re: COM Component

«_Superman_»9-Oct-14 2:26

«_Superman_»

9-Oct-14 2:26

Add the function AfxEnableControlContainer() in the InitInstance method of you app class.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++) (October 2009 - September 2013)

Polymorphism in C

WinterC7-Oct-14 20:16

WinterC

7-Oct-14 20:16

i have done my insertion code for the registration form but now i have to do password encryption after register which i totally have no idea on how to do it in C++ MFC dialog application. please help me if u have any source files. just encrypt the password part.

UpdateData();

    MYSQL *ssock;
    ssock = (MYSQL *)malloc(sizeof(MYSQL));
    mysql_init(ssock);

    conn = mysql_init(NULL);

    if (conn == NULL) {
        printf("Error %u: %s\n", mysql_errno(conn), mysql_error(conn));
        exit(1);
    }

    if (mysql_real_connect(conn, "127.0.0.1", "root", "Root", "inomatic", 0, NULL, 0) == NULL)
    {
        printf("Error %u: %s\n", mysql_errno(conn), mysql_error(conn));
        exit(1);
    }

    int tmp = atoi((LPSTR)(LPCTSTR)m_Contact);

    if(m_Password != m_CfmPassword)
        {
        MessageBox("Both Password do not match! Please enter again.");
        m_EditPassword.SetFocus();
        }
    if(m_Username == "" || m_Password=="" || m_CfmPassword =="" || m_Email =="" || m_Contact =="" || m_Company == "")
        {
        MessageBox("Please fill in all the blanks.");
        }
    else if (m_Password == m_CfmPassword)
        {
                Insert(conn,(LPSTR)(LPCTSTR)m_Username,(LPSTR)(LPCTSTR)m_Password,(LPSTR)(LPCTSTR)m_Email,tmp,(LPSTR)(LPCTSTR)m_Company,"User");
                MessageBox("Thank You! You have successfully registed into People Counter Application.");
        }
    UpdateData(FALSE);
    mysql_close(conn);
    //Clear text after register ======================================================================================================================================
    m_EditUsername.SetSel(0,-1),m_EditPassword.SetSel(0,-1),m_EditCfmPassword.SetSel(0,-1),m_EditEmail.SetSel(0,-1),m_EditContact.SetSel(0,-1),m_EditCompany.SetSel(0,-1);
    m_EditUsername.Clear();
    m_EditPassword.Clear();
    m_EditCfmPassword.Clear();
    m_EditEmail.Clear();
    m_EditContact.Clear();
    m_EditCompany.Clear();

Winter

modified 8-Oct-14 9:09am.

Re: C++ MFC Dialog Password encryption Vs2005

Nelek8-Oct-14 0:08

Nelek

8-Oct-14 0:08

As you were said in the previous post, this is the wrong forum for such questions.

Please search the right forum and post it there. Here is to post about the internal things of the site

M.D.V.

If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.

Re: C++ MFC Dialog Password encryption Vs2005 [moved]

Richard MacCutchan8-Oct-14 4:16

Richard MacCutchan

8-Oct-14 4:16

Do not use encryption for passwords. You should add a salt value and use the two pieces of data to create a one-way hash which you store in your database. Remember, encrypted data can be decrypted, hashes cannot. There are many articles and samples explaining this in detail, including Secure Password Authentication Explained Simply[^].

Does this line of code bother anyone?

stgagnon7-Oct-14 11:29

7-Oct-14 11:29

A whipper-snapper (sort-of) on my team wrote this:

for (index = 0; index < num_systems && systems[index].type == SYSTEM_TYPE_XYZ && (systems[index].name, "XYZname"); ++index);

I don't care very much for excessive cleverness. I care for maintainability. And debug-ability. This does not meet that requirement for me.

Does anyone else feel this way? I am feeling old and curmudgeonly about this, however I want some honest opinions.

«_Superman_»7-Oct-14 15:53

«_Superman_»

7-Oct-14 15:53

Here's my take on this.
If you need a minute to think about what a code statement does, then it has to go.
Get rid of it.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++) (October 2009 - September 2013)

Polymorphism in C

stgagnon8-Oct-14 2:36

8-Oct-14 2:36

Thank you. My confidence is bolstered.

Richard MacCutchan7-Oct-14 22:40

Richard MacCutchan

7-Oct-14 22:40

No, and this is really not the place.

stgagnon8-Oct-14 2:38

8-Oct-14 2:38

Sorry I bothered you. Please educate me: Where would you have posed the question?

Richard MacCutchan8-Oct-14 2:48

Richard MacCutchan

8-Oct-14 2:48

The Lounge, or Weird & Wonderful. It's not a C/C++ question.

CPallini7-Oct-14 23:06

CPallini

7-Oct-14 23:06

Quote:
(systems[index].name, "XYZname")

?!?

THESE PEOPLE REALLY BOTHER ME!! How can they know what you should do without knowing what you want done?!?!
-- C++ FQA Lite

stgagnon8-Oct-14 2:41

8-Oct-14 2:41

I know!

The line does not even do what the coder intends it to do. Too bad the compiler did not complain.

That alone is reason enough to 86 it, of course.

This program is rife with this kind of stuff. Some of it may even work, but as Superman says, I should not have to spend more than a moment understand it..

Stefan_Lang13-Oct-14 3:00

Stefan_Lang

13-Oct-14 3:00

The result of that part of the condition would be the same as

C++

static_cast<bool>(system[index].name)

The string literal will be evaluated but the result of the comma operator is always the leftmost argument. (You probably know that, but I thought I should offer an explanation for less experienced readers)

My guess is this was supposed to be a string comparison. Not that it makes the condition look any better...

Oh, and btw., I know that '??!' is the trigraph for '|', but I'm not familiar with '?!?'. Typo? Poke tongue | ;-P