Re: Refactoring versus Performance - C# Discussion Boards

Agent__00714-Jul-14 19:42

14-Jul-14 19:42

I have been asked to refactor a couple of modules which are extremely critical with respect to the performance and are already taking a few seconds more than the desired time. So, they later will be worked on performance optimizations as well.

I have come across following block of code:

// some method declarations and statements here 

foreach // <-- iterating about 30 times
  // some loop declarations
  foreach // <-- iterating about 150 times
     // some loop declarations
     foreach // <-- iterating about 500 times
         // some loop declarations
         // some statements -> good candidates for 
         //             refactoring as method-calls within current DLL as well as external one   (##)
     end
   end
end         

// some method-statements here

I was thinking to refactor the statements ((##) above). But as per my knowledge, method calls do take finite amount of execution time for push/pop onto/from the stack. Considering these modules are really critical w.r.t. the performance (as in any other relevant scenario):

0. Should I really be considering function-call times while dealing with performance?
1. Should I really go ahead with refactoring the above statements (especially for those which involve significant number of push/pop operations)?
1.1. If yes, should I refactor those statements to methods only in current DLL or the external one is also feasible?

Any pointers will be appreciated. Thanks!

Whether I think I can, or think I can't, I am always bloody right!