C / C++ / MFC

doug2517-Jul-13 5:06

17-Jul-13 5:06

so wofstream can't be optimized? it all works well without optimization

Richard MacCutchan17-Jul-13 5:22

17-Jul-13 5:22

doug25 wrote:
so wofstream can't be optimized? it all works well without optimization

Sorry, I don't understand what you are saying here. As far as Irecall from all the tests I have run, you cannot write wide characters via a wstream. I would be interested to see the code you have that does work. In the meantime I will retry my own tests.

Use the best guess

doug2517-Jul-13 5:48

17-Jul-13 5:48

sorry, I've discovered what was happening, it isn't a problem with wstring optimazation. I was converting the file to another format the functions i'm using behave differently with optimization.

The problem is nothing to do with vectors or wstrings. it's a directx set of functions i'm using that fail when optimazation is turned on. It was difficult to determine tat this was where the program was failing.

modified 17-Jul-13 12:17pm.

Richard MacCutchan17-Jul-13 7:12

17-Jul-13 7:12

doug25 wrote:
the functions i'm using behave differently with optimization.

I find that very difficult to believe. Much more likely is that you have a bug somewhere that only shows when you have optimization turned on.

Use the best guess

doug2517-Jul-13 9:38

17-Jul-13 9:38

well, it could be a mistake I've made but I've managed to find exactly where the error occurs by using #pragma optimize("g", off)
and
#pragma optimize("g", on)

it's one function, I can't see any mistakes

C++

#pragma optimize("g", off)

void AddDataObject(ID3DXFileSaveObject* xFileSave, ID3DXFileData* child, ID3DXFileSaveData* xSaveData)
{
	// Add data for this child then each of it's children
	SIZE_T nChildren = 0;
	child->GetChildren(&nChildren);

	// add child
	GUID templateid, id;
	child->GetType(&templateid);
	child->GetId(&id);
	char name[MAX_PATH];
	
	SIZE_T sz;
	child->GetName(name, &sz);

	SIZE_T dataSize;
	void* data = NULL;

	child->Lock(&dataSize, (LPCVOID*)&data);
	
	if(xSaveData)
	{
		xSaveData->AddDataObject(templateid, name, (const GUID*)&id, dataSize, data, &xSaveData);
	}
	else
	{
		xFileSave->AddDataObject(templateid, name, (const GUID*)&id, dataSize, data, &xSaveData);
	}

	child->Unlock();

	// For each child of child, add child data
	// Add data for all sub children (recurse)
	for(int i=0; i<nChildren; i++)
	{
		ID3DXFileData* ch = NULL;
		if(SUCCEEDED(child->GetChild(i, &ch)))
		{
			// Add data for children of this child (ch)
			AddDataObject(xFileSave, ch, xSaveData);
		}
	}
}

#pragma optimize("g", on)

Richard MacCutchan17-Jul-13 20:57

17-Jul-13 20:57

What problem and where does it occur?

Use the best guess

doug2518-Jul-13 2:48

18-Jul-13 2:48

the problem is some strings are not loaded, or at least are not written to the new file. e.g. each line in the output file that should contain "Frame frame_name {" (works without opt.) reads "Frame {".

I will try freeing the memory of child data objects although I have assumed they get released when the top level data object get released and I will try what Jochan suggested.

There is very little documentation on how to use these functions.

I won't be able to reply for a while if I do fix the problem but cheers.

Richard MacCutchan18-Jul-13 2:56

18-Jul-13 2:56

doug25 wrote:
the problem is some strings are not loaded, or at least are not written to the new file. e.g. each line in the output file that should contain "Frame frame_name {" (works without opt.) reads "Frame {".

Now I'm totally lost; the code you posted does not seem to have anything at all to do with these comments. It may be better to close off this thread and start a new question when you are ready to proceed.

Use the best guess

doug2518-Jul-13 3:16

18-Jul-13 3:16

I haven't explained it very well. Basically, I've written a program that writes a .x file using wofstream. But the file doesn't look very pretty so I'm using the directx code I posted to convert it to a better format, so I can also save it as binary or compressed as well as structured text. Basically saves me having to rewrite the program.

I'll close the thread.

doug2518-Jul-13 3:31

18-Jul-13 3:31

how do I close a thread?

Richard MacCutchan18-Jul-13 3:50

18-Jul-13 3:50

You can just stop posting, or edit your original question and add "[closed]" or "[solved]" to the title, and a comment to the effect that you have closed it.

Use the best guess

Jochen Arndt17-Jul-13 21:08

Jochen Arndt

17-Jul-13 21:08

That is a recursive function. You may generate assembler output to see the differences between the optimized and unoptimized code.

You should also check for success on all functions that may fail. At least the AddDataObject() return values should be checked and returned upon errors to leave the recursion if something wrent wrong.

doug2518-Jul-13 2:55

Win32 ListView control doesn't display any icons

18-Jul-13 2:55

thanks, I'll try that

Jonathan Davies16-Jul-13 7:48

Re: Win32 ListView control doesn't display any icons

16-Jul-13 7:48

Using VS2008 Prof. on Windows8, a Win32 ListView control in Report mode doesn't display any icons at the start of each row. It shows data which I can sort, but no icons.

I'm assuming its some bit or attribute not set somewhere so have to show all the relevant code for someone to see what I'm missing. The list (header)setup code is here (followed by the row insertion code taken out of its loop and then my test code). All error handling removed. I've compared this to an ATL/WTL program that shows the icons and I can't see any difference.

The image list is initialised by the CDeviceImageList constructor which uses the below code to initialize the list:

C++

class CDeviceImageList
{
private:
	SP_CLASSIMAGELIST_DATA m_spImageData;		//!< Structure containing class image list information.
public:
	/**
		Builds an image-list that contains bitmaps for every installed device-class.
	*/
	CDeviceImageList()
	{
		RtlZeroMemory(&m_spImageData, sizeof(SP_CLASSIMAGELIST_DATA));
		m_spImageData.cbSize = sizeof(SP_CLASSIMAGELIST_DATA);
		BOOL b = SetupDiGetClassImageList(&m_spImageData);
		if(FALSE == b)
		{
			assert(!"Failed to aquire class image list");
		}
	}
         
	operator HIMAGELIST() const throw()
	{ 
		return m_spImageData.ImageList; 
	}

...

ListView setup before the data ...

C++

LVITEM lvItem;
SecureZeroMemory(&lvItem, sizeof(LVITEM));

LVCOLUMN lvCol;
SecureZeroMemory(&lvCol, sizeof(LVCOLUMN));

HWND hList=GetDlgItem(hwnd,IDC_LIST1);

lvCol.pszText=L"Port";                                  // First Header Text
lvCol.mask=LVCF_TEXT;                                   // .pszText is valid


lvCol.cx=60;                                            // width of coloumn 1
lvCol.mask   |= LVCF_WIDTH;                             // .cx (width) is valid


lvCol.iSubItem = 0;                                     // Col 0
lvCol.mask  |= LVCF_SUBITEM;                            // .iSubItem is valid

lvCol.fmt   = HDF_SORTUP;                               // Set an up arrow
lvCol.fmt     |= LVCFMT_LEFT;                           // and left-align the column.
lvCol.mask  |= LVCF_FMT;                                // .format is valid

int nCol = 0;
nCol = ListView_InsertColumn(hList, lvCol.iSubItem, &lvCol);



lvCol.iSubItem = 1;                                     // Col 1
lvCol.pszText=L"Device";                                // Col 1 title
lvCol.cx=220;                                           // Col 1 width
nCol = ListView_InsertColumn(hList, lvCol.iSubItem, &lvCol);


lvCol.iSubItem = 2;                                     // Col 2
lvCol.pszText=L"Manufacturer";                          // Col 2 title
lvCol.cx=100;                                            // width of coloumn
nCol = ListView_InsertColumn(hList, lvCol.iSubItem, &lvCol);



CDeviceImageList cImageList;
HIMAGELIST hImageList = cImageList;

HIMAGELIST hRet = ListView_SetImageList(hList,  hImageList, LVSIL_SMALL,);

ListView_SetExtendedListViewStyle(hList, LVS_EX_INFOTIP | LVS_SHOWSELALWAYS);

At this point I can get the image list back from the ListView
The relevant row insertion code, after which I can get the icons, is below but the ListView doesn't display them...

C++

LVITEM lvItem;
SecureZeroMemory(&lvItem, sizeof(LVITEM));
lvItem.mask=LVIF_TEXT;             // Text Style
lvItem.cchTextMax = 0;           // Max size of text

lvItem.iItem=n;                    // choose item  - n is loop counter here
lvItem.iSubItem=0;                 // Put in first coloumn
lvItem.pszText=m_pData[n]->szName;  // Text to display

lvItem.iImage = ImageIndex;
lvItem.mask |= LVIF_IMAGE;


lvItem.lParam=(LPARAM)m_pData[n];
lvItem.mask |= LVIF_PARAM;

// Get the list view handle
HWND hList=GetDlgItem(hwnd,IDC_LIST1);


int nItemIndex = ListView_InsertItem(hList, &lvItem); // Send info to the Listview

//Presuming don't need lParam set any more...
lvItem.lParam=0;
lvItem.mask &= ~LVIF_PARAM;

//Nor image
lvItem.iImage = 0;
lvItem.mask &= ~LVIF_IMAGE;

lvItem.iSubItem=1;
lvItem.pszText=(LPTSTR)(LPCTSTR)szData[n][1];
ListView_SetItem(hList, &lvItem); // Enter text to SubItems


lvItem.iSubItem=2;
lvItem.pszText=(LPTSTR)(LPCTSTR)szData[n][2];
ListView_SetItem(hList, &lvItem); // Enter text to SubItems

After each loop above I can use the following three lines to get the icons (and a few more to display them as proof). But the ListView still refuses to show them...

HWND hList=GetDlgItem(hwnd,IDC_LIST1);
HIMAGELIST hGotList = ListView_GetImageList(hList, LVSIL_SMALL);
HICON hIcon = ImageList_GetIcon(hGotList, ImageIndex, ILD_NORMAL);

modified 17-Jul-13 5:07am.

Randor 16-Jul-13 13:01

Randor

16-Jul-13 13:01

Hi,

How are you creating your image list? Are these 32 bit icons?

About Image Lists[^]

Best Wishes,
-David Delaune

Re: Win32 ListView control doesn't display any icons

Jonathan Davies16-Jul-13 23:49

Re: Win32 ListView control doesn't display any icons

16-Jul-13 23:49

David,
I've now added the code showing the creation of the image list to my question as you're not the only one to ask how it's created or initialized. Basically my CDeviceImageList constructor uses a call to SetupDiGetClassImageList[^].

At the end of my list setup and data initialization I can use the last three lines of code shown to basically: GetDialog, GetListView, and GetIcon followed by a call to

C++

SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)hIcon);

to display in the top-left corner of the dialog the very icon I expect to see in the ListView. which would seem to prove the ImageList in the ListView has the icons.

Are they 32 bit? Not to my knowledge.

I've read the stuff on ImageLists, ListViews etc. until I almost know it by heart.

Richard MacCutchan16-Jul-13 20:59

Re: Win32 ListView control doesn't display any icons

16-Jul-13 20:59

C++

CDeviceImageList cImageList;
HIMAGELIST hImageList = cImageList;

HIMAGELIST hRet = ListView_SetImageList(hList,  hImageList, LVSIL_SMALL,);

I note that you are using the CDeviceImageList class from this Article[^], in which case you should post your question in the forum at the end of the article to dicuss with the author. Although it looks to me that you have not initialised the object with any icons.

Use the best guess

Jonathan Davies16-Jul-13 23:24

Re: Win32 ListView control doesn't display any icons

16-Jul-13 23:24

Richard,
I've asked the Author of that CDeviceImageList class article you refer to (me) and he's sure the list is initialized - though he cold of course be wrong. I've now added the code from the constructor of this class to the question to show how its initialized.

Tp prove the ListView ImageList is initialized, After setting up the list I can use the three lines show at the end of my question, which are basically,

GetDialog, GetListView, GetIcon

, followed by

C++

SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)hIcon);

to display the exactly the icon I'm looking for in the top-left corner of the dialog box.

Which seems to prove the initialization.

Richard MacCutchan17-Jul-13 1:33

Re: Win32 ListView control doesn't display any icons

17-Jul-13 1:33

Then that suggests that you are not usiing the correct values when you add an item to the ListView. I would suggest you step through with your debugger to see which icon index is being used when you add an item to the control.

Use the best guess

Jonathan Davies17-Jul-13 2:27

Re: Win32 ListView control doesn't display any icons

17-Jul-13 2:27

Richard,
Stepped through it repeatedly, also side by side comparing it with working ATL/WTL example. I've just typed and run the below test at the end of the loop that fills rows with data where n is the loop variable. I get the LVITEM.iImage which is the index for the row, get a completely new ImageList from the ListView and get the icon from that ImageList successfully and can display it in the dialog top-left corner for any n.

C++

LVITEM lvItemP2;
SecureZeroMemory(&lvItemP2, sizeof(LVITEM));
lvItemP2.mask = LVIF_IMAGE;
lvItemP2.iItem = n;
BOOL bGotItem2 = ListView_GetItem(hList,  &lvItemP2);

HIMAGELIST hNewImageList =  ListView_GetImageList(hList, LVSIL_SMALL);
if(NULL == hNewImageList)
{
    DWORD dwErr = GetLastError();
    std::wstring szErr = CWin32ErrToWString()(dwErr);
    assert(!"Failed to get image list during test");
}

HICON hIconP2 = ImageList_GetIcon(hNewImageList, lvItemP2.iImage, ILD_NORMAL);
if(NULL == hIconP2)
{
    DWORD dwErr = GetLastError();
    std::wstring szErr = CWin32ErrToWString()(dwErr);
    assert(!"Failed to get icon from image list during test");
}
SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)hIconP2);

Richard MacCutchan17-Jul-13 4:49

Re: Win32 ListView control doesn't display any icons

17-Jul-13 4:49

All well and good, but it does not really address your problem, which is about setting the imagelist and image index correctly in your list view items.

Use the best guess

Jonathan Davies17-Jul-13 6:42

Re: Win32 ListView control doesn't display any icons

17-Jul-13 6:42

I'd say that getting the imagelist from the listview and getting the index into that list from each set of row data and using that index into the imagelist to come up with the expected icon shows I'm setting the imagelist and index correctly and the reason for non-display must be something else.

Stepping through each row item is set with image-index 0x1A, and this is also the value extracted from each row item after setting it.

The imagelist when obtained is of size 0x4A images as is the imagelist extracted from the listview later.

Richard MacCutchan17-Jul-13 7:33

Re: Win32 ListView control doesn't display any icons

17-Jul-13 7:33

You are quite right, I mis-read what was happening there. I am afraid I cannot think of anything else to suggest. I have been looking at my own sample ListView program and it works fine, although I do creae the imagelist myself.

Use the best guess

Jonathan Davies18-Jul-13 0:19