|
source.compiler wrote: well lemme explain whats my problem !
i thought writing codes is most simple part of developing ,but after some project which i did ,i found that need to change my coding style ! as you know for one porpuse is many way to achieve ! but i found always choose worst way !
There are a lot of ways to do something, and even we bicker about what is "best". And most of us here will have some "old code" somewhere from years ago that makes 'em go "wtf" today.
Always ask an explanation if there's an opportunity to do so.
source.compiler wrote: well is any book or reference to teach me how i choose best way? at least better way!
You might want to download FxCop; it checks your code using pre-set rules. Another sweet way of learning alternatives is to read existing code (I love meeting new brownfields!) and, again if possible, ask for explanation if something is interesting.
Get lots of practice. Start your own open-source project, so that you'll be forced to "maintain" your own code.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
so just exprience can show me better ways to writing codes?
|
|
|
|
|
Start thinking about how "programming" skills overlap with the non-programming things you do. Draw on your experience in the other areas of your life to help you improve. For example, work on your writing. Coding is composition and all the rules you learned about writing well apply to your programming: say what you mean; don't use a 10-cent word when a 5-cent word will do; don't mix metaphors (i.e., models); etc.
|
|
|
|
|
Yes.
The big advantage is that you'll learn the stuff you need right away, as opposed to learning a lot of abstract techniques that are unknown in a development-team where you might become part of.
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
If your in a team code reviews can help if all parties are willing to put the time and effort in.
|
|
|
|
|
Hey there! I'm trying to write into a command prompt window (Not the debugger) from my C# GUI with no luck (I've looked at lots of examples), and I'm not sure where I am going wrong. The command prompt window will open, it will accept text if i type it in from my keyboard, but it won't accept it from my application.
I've tried with both the windows command prompt, and the custom one we are trying to write into. Long story short I am trying to access an AtmelAVR programmer from command line to automatically program devices in our assembly process. I can automatically program by command line when I enter the text myself, I just can't get out GUI to do it... I've attached my code below:
EDIT: Working in VS2010 on Windows 7
Any help is greatly appreciated!
<pre lang="c#">
Process PrgCommandPrmpt = new Process();
PrgCommandPrmpt.StartInfo.UseShellExecute = false;
PrgCommandPrmpt.StartInfo.FileName = "C:/Program Files (x86)/Atmel/Atmel Studio 6.0/extensions/Application/StudioCommandPrompt.exe";
PrgCommandPrmpt.StartInfo.RedirectStandardInput = true;
PrgCommandPrmpt.StartInfo.RedirectStandardOutput = true;
PrgCommandPrmpt.StartInfo.RedirectStandardError = true;
PrgCommandPrmpt.StartInfo.CreateNoWindow = true;
PrgCommandPrmpt.EnableRaisingEvents = false;
PrgCommandPrmpt.Start();
PrgCommandPrmpt.StandardInput.AutoFlush = true;
StreamWriter inputWriter = PrgCommandPrmpt.StandardInput;
StreamReader outputReader = PrgCommandPrmpt.StandardOutput;
StreamReader errorReader = PrgCommandPrmpt.StandardError;
myDelay5s();
tboxVerbose.AppendText("Doing stuff now!");
string CommandText = "cd..";
inputWriter.WriteLine("WHY DONT YOU WORK");
PrgCommandPrmpt.StandardInput.Write(CommandText);
inputWriter.Close();
|
|
|
|
|
|
Thanks for the reply; I hadn't seen that particular example, but it is doing the same as all the rest.
myStreamWriter.WriteLine(inputText);
then
myStreamWriter.Close();
The "Console.Writeline" writes to the debugger console which also works for me...
I write to the non-debugger console here:
inputWriter.WriteLine("WHY DONT YOU WORK");
inputWriter.Close();
I'm at a loss as to why it won't just work, it seems to be doing the exact same thing as the 10 or examples I've looked at...
EDIT: Grammar
modified 14-Feb-13 10:05am.
|
|
|
|
|
I just tested that sample and it works fine. I would suggest you check some of the options you have selected to ensure none of them is conflicting with what you are trying to do. You could also take that working sample and modify it to use the command you wish to run and see what happens.
|
|
|
|
|
I'm not sure that we are trying the same thing here. I loaded that example into a new app, and it doesn't write to the console either. I also get an error on this line about a NullReferenceException, presumably as the buffer is empty?
inputText = Console.ReadLine();
if (inputText.Length > 0)
What "Settings" are you referring to when you said I should check the settings?
|
|
|
|
|
If I change the application to a console application I can now run it without it crashing, but it still doesn't hand data out to the programmers command prompt.
|
|
|
|
|
Well I'm not sure what you are doing wrong. I just copied the code from the link I gave you, then wrote another program that reads and writes to the standard input and output stream, and it all worked. Maybe the fault lies with the program that you are trying to execute; what exactly does it do?
|
|
|
|
|
The program we are trying to write into is just a CMDPrompt that has been written to access the programming functions of the AtmelAVR programmer through command line. The commands we need to send resemble the one below:
atprogram -t avrispmk2 -i isp -xr -d ATmega328 -v chiperase
I'd say that ya maybe its the program, but we can't write into the windows command prompt (cmd.exe) either... The only place we can write to is the console debugger prompt.
|
|
|
|
|
In that case your approach is wrong. You need to set all these options into the StartInfo properties, or add them to the Process.Start method call, as described in the sample code here[^].
|
|
|
|
|
Interesting, This sounds promising. I'll make some changes and get back to you. Thanks for all the help.
|
|
|
|
|
ok, This all seems to point to the StartInfo settings, which I believe are correct already:
Process Temp = System.Diagnostics.Process.Start("CMD.exe");
Temp.StartInfo.UseShellExecute = false;
Temp.StartInfo.RedirectStandardInput = true;
Temp.StartInfo.RedirectStandardOutput = true;
Temp.StartInfo.RedirectStandardError = true;
Temp.Start();
Temp.StandardInput.WriteLine("Test");
Temp.Close();
So unless I've missed something, I don't think this is where the issue is.
|
|
|
|
|
I just tried this again from a Windows forms application and it still works.
|
|
|
|
|
Even something as simple as this doesn't put out any text...
string CommandText = "cd.. \r";
System.Diagnostics.Process.Start("CMD.exe", CommandText);
|
|
|
|
|
Nor would it, that just runs an independent process, which changes directory and immediately terminates without producing any output.
I have to say you are maybe getting yourself tied in knots here, by repeatedly trying everything you can think of, without really looking at what you should be doing. Think about what program you are trying to run, how it must be started, what input data it may read and what output it may produce. That should then determine how you need to start it, whether you need to feed it any input (beyond its initial parameters) and whether you should expect to read from its output stream.
|
|
|
|
|
Yeah, We are using a command prompt, or command processor as someone just called it (I may be using the wrong name for it). Then all re need to do is to literally send in a line (string) with a carriage return, read the text that comes in, and repeat based off of the text that comes back.
When I started it seemed easy enough to do, but it now seems that its not easy to feed text into a cmd window.
|
|
|
|
|
adam.m.b.nelson wrote: but it now seems that its not easy to feed text into a cmd window.
Yes, it's perfectly easy, but you need to understand what is happening in that window, as I explained in an earlier post. I have not used the Process class before, but by following the rules, and understanding what goes on in the started application, I demonstrated that it works as documented.
|
|
|
|
|
Granted I am completely and utterly lost, but from the examples I have seen everything seems to be "right" but it still doesn't work.
Let's simplify this and say I simply want to write a line to the CMD window, from my GUI, and leave it sitting there staring at me. This program below should do that, NO?
private void btnKapow_Click(object sender, EventArgs e)
{
Process Temp = Process.Start("C:/Windows/System32/cmd.exe");
Temp.StartInfo.UseShellExecute = false;
Temp.StartInfo.RedirectStandardInput = true;
Temp.Start();
Temp.StandardInput.WriteLine("Test");
Temp.Close();
}
I'm completely out of my domain here, I'm an embedded programmer, and have built some GUI's in the past without an issue, but this single process is far more indepth than anything I have done before.
|
|
|
|
|
Not really. You start the command window, send it a (meaningless) word and then immediately close it. Maybe if you explain exactly what your program is supposed to do, I can offer some more suggestions. Explain:
- How is the program invoked manually from a command window.
- What, if any, further input commands do you need to type in to the program.
- What output is produced by the program on the command window, that you need to capture.
- What command, if any, is used to terminate the program.
The answer will not be forthcoming before tomorrow, but I'm sure it's possible to do it.
|
|
|
|
|
OK, I am starting to understand the issue. I had noticed it looked like there were two windows for an instant, but i attributed it to one of the Win7 window effects. So what is likely happening is there are actually two windows, and the one just opens and closes so fast that I can't see it?
To use the 'atprogram' the only route i can find into it is to use the StudioCommandPrompt located here "C:/Program Files (x86)/Atmel/Atmel Studio 6.0/extensions/Application/StudioCommandPrompt.exe". Once its open I need to run these commands:
atprogram -t avrispmk2 -i isp -xr -d ATmega328 -v chiperase
atprogram -t avrispmk2 -i isp -xr -d ATmega328 write -fs --values 7FD9FF
atprogram -t avrispmk2 -i isp -xr -d ATmega328 program -f Example.hex
After each step the window spits out some pass fail information.
There are alternative command line programming options, but that is the one I learned first.
This all makes a lot more sense now that I know the window is opening and closing very fast, it actually explains a lot. We're at the end of the day here, but first thing in the morning I'll try pumping in program commands like that and see if it works.
This whole time I saw an idle window sitting there, and assumed it meant the input hadn't been received.
Thanks for your help and patience, I will update tomorrow morning.
|
|
|
|
|
Slightly off topic, but given that you are (apparently) using Atmel Studio[^] to develop some embedded code application, what exactly is this C# program supposed to be for?
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
