Re: how to return value after user input - C / C++ / MFC Discussion Boards

Re: how to return value after user input

Member 21198442-Nov-12 8:51

Member 2119844

2-Nov-12 8:51

yes i have add InFlag = true; it is not working.

CString CMyTextBox::GetString()
{
// how to come here after press enter by user that is main thing
    if (InFlag == true)
        return RetVal;
    return "";
}

it is call form dialog class here is code.

void CRetValTestDlg::OnGetString()
{
    m_TxInput.InFlag = false;
    CString s = m_TxInput.GetString();
    m_TxOutput.SetWindowText (s);
}
void CRetValTestDlg::OnGetNumber()
{
    m_TxInput.InFlag = false;
    CString s;
    double d = m_TxInput.GetNumber();
    s.Format ("%d",d);
    m_TxOutput.SetWindowText (s);
}

i would like to upload project file for review. if possible.

Re: how to return value after user input

Santhosh G_2-Nov-12 16:32

Santhosh G_

2-Nov-12 16:32

Few comments.
1) First statement of CRetValTestDlg::OnGetString() set InFlag to false. Therefore m_TxInput.GetString() will return "".
Move InFlag = false to CRetValTestDlg::OnGetString(). Accessing a member variable outside of class is not a good.
2) First statement of CRetValTestDlg::OnGetNumber() set InFlag to false. Therefore m_TxInput.GetString() will return 0. Move InFlag = false to CRetValTestDlg::OnGetNumber().
3) modify CMyTextBox::OnKeyDown() like this

if (nFlags == 28) // Enter press
{
    InFlag = true;
    GetWindowText(RetVal);
}

4) Need to identify Enter KeyPress in your EditControl. 3) Normally an Edit control will not get Enter key press, On Enter keypress, focused button click action will be performed.
One option is to change the style of your Edit control to Multi-line. Change MultiLine to true, or enable ES_MULTILINE for the CMyTextBox window style.
Another option is to identify enter keypress from PreTranslateMessage(), if "VK_ENTER" key down is occurred from edit control set your InFlag to true.

Re: how to return value after user input

Member 21198442-Nov-12 18:19

Member 2119844

2-Nov-12 18:19

yes i did as you said.
the functions does not work. because functions does not wait for Enter.

The function call from outer class so that InFlag has to false until press enter but with out press enter function ends. the function is not giving chance to press Enter or type any text to Edit box.

Re: how to return value after user input

Santhosh G_2-Nov-12 18:26

Santhosh G_

2-Nov-12 18:26

Which function ?
On every key press, CMyTextBox::OnKeyDown() will call. But Enter will not called. Its reason is "Enter" keypress will consider as Action of currently focused button. please change the MultiLine property of EditBox and check whether enter is recieved in KEyDown

Re: how to return value after user input

Member 21198442-Nov-12 18:33

Member 2119844

2-Nov-12 18:33

keyDown received Enter. that is not a problem. but if you see my code you will find that function does not wait for enter. function are (double CMyTextBox::GetNumber() and CString CMyTextBox::GetString()) they have to wait until press enter. i think the problem is this.

here is link of project file.
https://skydrive.live.com/redir?resid=78B222720843DE16!116&authkey=!AAjKOKZHSd-q9lI

please kindly check test project.

Re: how to return value after user input

Santhosh G_2-Nov-12 19:01

Santhosh G_

2-Nov-12 19:01

Please move GetWindowText() to CMyTextBox::GetNumber() and CMyTextBox::GetString(). CMyTextBox::OnKeyDown() will not give text values.

CRetValTestDlg::OnGetString() still calls m_TxInput.InFlag = false; Please remove it.

Re: how to return value after user input

Member 21198442-Nov-12 19:34

Member 2119844

2-Nov-12 19:34

no no. this is not a way what i need. i need to get value after press Enter Key.

Re: how to return value after user input

Santhosh G_2-Nov-12 19:43

Santhosh G_

2-Nov-12 19:43

"After press Enter key" I can undestand that you need to get the String and Number values on pressing Enter key.is it right ?

Re: how to return value after user input

Member 21198442-Nov-12 21:02

Member 2119844

2-Nov-12 21:02

Yes. when it call function. like GetString();

Re: how to return value after user input

Santhosh G_2-Nov-12 21:27

Santhosh G_

2-Nov-12 21:27

If you can override PreTranslateMessage() in your Dialog class, you can track Enter press from PreTranslateMessage().

BOOL CRetValTestDlg::PreTranslateMessage(MSG* pMsg)
{
    if( pMsg->message == WM_KEYDOWN &&
        pMsg->wParam == VK_RETURN &&
        pMsg->hwnd == GetDlgItem( IDC_TX_INPUT )->m_hWnd)
    {
        // When pressing Enter key in IDC_TX_INPUT edit box, you will get control here.
        // Return FALSE ensures Dialog will not process this Enter KeyPress

        // return FALSE;
    }
    return CDialog::PreTranslateMessage(pMsg);
}

Re: how to return value after user input

Member 21198442-Nov-12 22:05

Member 2119844

2-Nov-12 22:05

yes this is the part which i did not understand. how it goes to GetString or GetNumber function. because PreTranslateMessage in Dlg class. and GetString and GetNumber function in other class. so how it will connect with each other. and how it trap event from one class to other class function. i would like to request for little more detail and step. how it work?
if that is just need to get number or string and put in variable it will be ok. but the value should return from function.

Re: how to return value after user input

Santhosh G_2-Nov-12 22:41

Santhosh G_

2-Nov-12 22:41

PreTranslateMessage in Dlg class. and GetString and GetNumber function in other class. so how it will connect with each other.
You can directly call m_TxInput.GetString() and m_TxInput.GetNumber() from PreTranslateMessage().

If you want to send a message to CMyTextBox class, you can call PostMessage() with a USER function to the edit control.

Re: how to return value after user input

Member 21198443-Nov-12 0:24

Member 2119844

3-Nov-12 0:24

Thanks. but i don't know about it. is it possible to give one working example. it will be great help for me. please consider i am learning.

Re: how to return value after user input

Richard MacCutchan3-Nov-12 2:56

Richard MacCutchan

3-Nov-12 2:56

I have been following this thread and I think you are painting yourself into a corner. You could make this so much easier for yourself by using the standard messages and notifications available to a dialog and its child controls.

One of these days I'm going to think of a really clever signature.

Re: how to return value after user input

Member 21198443-Nov-12 5:40

Member 2119844

3-Nov-12 5:40

well sir, i am just learning and doing work. i don't have much idea about it. so i request for help. i am trying this from all most a week. i google it and did not found simillar to what i am looking for. maybe because i don't have enough knowledge. so..
hoping to get help from some kind heart.

Re: how to return value after user input

Richard MacCutchan3-Nov-12 7:07

Richard MacCutchan

3-Nov-12 7:07

Member 2119844 wrote:
hoping to get help from some kind heart.

Which is what I offered to you yesterday. Use the features of the CDialog and its controls rather than struggling to try and interpret individual keystrokes that are already captured for you. Text boxes have events that you can capture as characters are entered into them, which allow you to check and/or modify their content. The CDialog class has a function that will capture or refresh all the data between the dialog and the associated class variables etc.

One of these days I'm going to think of a really clever signature.

Re: how to return value after user input

Member 21198443-Nov-12 8:12

Member 2119844

3-Nov-12 8:12

Dear sir, i really appreciate your and Santhosh suggestion. i do. but the thing is bit difference what i am looking for. maybe i am not able to describe very well, what i am looking for. sorry for that. because my English is not good enough. so please don't get me wrong. once again i am trying to explain what i need to do. and what i come up to.

i need to make function that return value after press Enter key. not directly and not in any other way. but from function when it call from outer class.

this is the event when user press button in dlg class.

C++

void CRetValTestDlg::OnGetString() 
{
	m_TxInput.InFlag = false;
	CString s = m_TxInput.GetString();
	m_TxOutput.SetWindowText (s);
}

and this is CMyTextBox calss member function which is call from dlg class on button press. which need to return value.

C++

CString CMyTextBox::GetString()
{
	if (InFlag == true)
		return RetVal;
	return "";
}

now i have come upto this

C++

CString CMyTextBox::GetString()
{
	while (InFalg != true) // this is infinite loop but
	{
		DoEvents(); // doEvents hole for it so it wait until it get event
		if (InFlag == true) // the InFlag = true when user press Enter;
		return RetVal; // and return value
	}
	return ""; // else return "";
}

this is work. but when i use While and DoEvents the processor took lot of work. it took all most 50% of CPU used. and which is really not good. i think. and some time it does not come out from that loop when user left so when the program close. it remain in task manager. and CUP running.

now What i am looking for is -> is there any other way to wait till event. maybe using CEvent or CallBack or threading or something else. without using lot of CPU used. because i don't know anything about them. i have never use.

C++

CString CMyTextBox::GetString()
{
//====================== Here i am looking for help =============================
// wait for event here or WaitTill (InFlag !=true); in this line i need help.
//==================================================================================
	if (InFlag == true)
		return RetVal;
	return "";
}

i hope this time i could able to tell what i need for. this is really important for me.
so Please Please Help.

Re: how to return value after user input

Richard MacCutchan3-Nov-12 9:03

Richard MacCutchan

3-Nov-12 9:03

All I can do is repeat what I said before. Use the events and notifications of the CDialog class. The default action when user presses the enter key is to call the OnOK() function. You add code to that method to capture the text using the UpdateData() function. Let the dialog do the work for you. Maybe you should spend some time reading the documentation about Dialog Boxes[^] in general, and the CDialog[^] class in particular. You may also find that the documentation is available in your own language.

One of these days I'm going to think of a really clever signature.

Re: how to return value after user input

Member 21198443-Nov-12 16:40

Member 2119844

3-Nov-12 16:40

ok i will try. but.
as you said. >> Use the events and notifications of the CDialog class.
Which Events and Notification?
i use this to block call OnOk() while press Enter Key.

C++

BOOL CRetValTestDlg::PreTranslateMessage( MSG* pMsg )
{
 if (pMsg->message == WM_KEYDOWN)
    {
        if ((pMsg->wParam == VK_RETURN) || (pMsg->wParam == VK_ESCAPE))
            pMsg->wParam = NULL;// VK_TAB;
    }

    return CDialog::PreTranslateMessage( pMsg );
}

how dialog do my work.
it would be great if i could get some sample code.
i have spend lot of time to read and search. i did not find or i did not understand. so i request for help. if i understand, i may not request for help.

Re: how to return value after user input

Richard MacCutchan3-Nov-12 22:23

Richard MacCutchan

3-Nov-12 22:23

I don't know what you are hoping to achieve with the code above, but it is not likely to help you. Please spend some time reading the two links I gave in my previous answer, so you understand how dialogs operate.

One of these days I'm going to think of a really clever signature.

Re: how to return value after user input

Member 21198443-Nov-12 23:59

Member 2119844

3-Nov-12 23:59

Thank you.

Re: how to return value after user input

David Crow4-Nov-12 17:28

David Crow

4-Nov-12 17:28

By default, a dialog's OnOK() handler will be called when you "press" the Enter key from within an edit control. If you would rather the edit control do something else, check out the ES_WANTRETURN style.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

problem with sprintf_s() on win 7

Member 93537761-Nov-12 22:57

Member 9353776

1-Nov-12 22:57

char buffer[50]
int offset =3;
char Buffer[250];

sprintf_s(&buffer[offset],offset,"%s",Buffer);

When we use the above funcation and application crashed with the folloing message

---------------------------
Microsoft Visual C++ Debug Library
---------------------------
Debug Assertion Failed!

Program: xyz.exe
File: f:\dd\vctools\crt_bld\self_x86\crt\src\vsprintf.c Line: 244 Expression: ("Buffer too small", 0)

For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts.

(Press Retry to debug the application)
---------------------------
Abort Retry Ignore
---------------------------

OS used : Windows 7 32bit OS
Microsoft Visual Studio 2008 (VC++)
Version 9.0.30729.1SP

Re: problem with sprintf_s() on win 7

Santhosh G_1-Nov-12 23:34

Santhosh G_

1-Nov-12 23:34

Second parameter of sprintf_s is the size of destination buffer.
If length of formatted string is greater than the size of source buffer, sprintf_s will create debug assertion.

If length of string in Buffer is less than 3, then it will not create an debug assertion.

Here you can change the second parameter of sprintf_s to 47,by considering offset in buffer.

Re: problem with sprintf_s() on win 7

Member 93537764-Nov-12 17:46

Member 9353776

4-Nov-12 17:46

char buffer[50]
int offset =3;
char Buffer[250];

OR

char buffer[50]
int offset =3;
char Buffer[50];

Is working fine with VS6.0, but when the same code is compiled with VS2008 I am still getting the same error as mentioned above.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.