Re: Internal connection fatal error!! why?!! - C# Discussion Boards

Internal connection fatal error!! why?!!

17-Sep-12 22:05

If this method is sealed to you, then you must pass in the fully qualified file name. The code I gave you will still do.

This is the problem with contract shops; they don't always give you good code. They'll give you exactly, and only, what you ask for.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

Re: C# access a file

PIEBALDconsult17-Sep-12 17:00

PIEBALDconsult

17-Sep-12 17:00

But even when it works the reference will immediately go out of scope.

Jassim Rahma17-Sep-12 5:12

17-Sep-12 5:12

Hi,

I am getting the above error on the last line:

MSSQLconnection.Close();

could you please help..

here is the code:

try
{
    MSSQLconnection = new SqlConnection(ConfigurationManager.ConnectionStrings["MSSQL"].ConnectionString);
    MSSQLconnection.Open();

    // where is_migrated = false;
    MSSQLcommand = new SqlCommand("select * from persons where is_migrated = 0 order by file_no", MSSQLconnection);
    MSSQLreader = MSSQLcommand.ExecuteReader();

    while (MSSQLreader.Read())
    {
        // display the file no;
        lblFileNo.Text = "File# " + MSSQLreader["file_no"].ToString();

        // update MySQL 
        MySQL_connection = new MySqlConnection(ConfigurationManager.ConnectionStrings["mySQL"].ConnectionString);
        MySQL_connection.Open();
        // MySQL_command = new MySqlCommand("insert into patients (current_file_no, id_type, id_number, date_of_birth, full_name, nationality, gender, old_file_no, marital_status, blood_group, patient_is_vip, is_outside_country, address_outside_address, address_country, address_flat, address_building, address_road, address_avenue, address_block, address_po_box, contact_mobile, contact_home_tel, personal_email, created_date) values (?current_file_no, ?id_type, ?id_number, ?date_of_birth, ?full_name, ?nationality, ?gender, ?old_file_no, ?marital_status, ?blood_group, ?patient_is_vip, ?is_outside_country, ?address_outside_address, ?address_country, ?address_flat, ?address_building, ?address_road, ?address_avenue, ?address_block, ?address_po_box, ?contact_mobile, ?contact_home_tel, ?personal_email, ?created_date)", MySQL_connection);
        MySQL_command = new MySqlCommand("insert into patients (current_file_no, id_type, id_number, date_of_birth, full_name, nationality, gender, old_file_no, marital_status, blood_group, patient_is_vip, is_outside_country, address_outside_address, address_country, address_flat, address_building, address_road, address_avenue, address_block, address_po_box, contact_mobile, contact_home_tel, personal_email, created_date) values (param_current_file_no, param_id_type, param_id_number, param_date_of_birth, param_full_name, param_nationality, param_gender, param_old_file_no, param_marital_status, param_blood_group, param_patient_is_vip, param_is_outside_country, param_address_outside_address, param_address_country, param_address_flat, param_address_building, param_address_road, param_address_avenue, param_address_block, param_address_po_box, param_contact_mobile, param_contact_home_tel, param_personal_email, param_created_date)", MySQL_connection);

        MySQL_command.Parameters.Add("param_current_file_no", MySqlDbType.Int32).Value = Convert.ToInt32(MSSQLreader["file_no"]);
        MySQL_command.Parameters.Add("param_id_type", MySqlDbType.VarChar, 255).Value = MSSQLreader["id_type"].ToString();
        MySQL_command.Parameters.Add("param_id_number", MySqlDbType.VarChar, 255).Value = MSSQLreader["id_number"].ToString();
        MySQL_command.Parameters.Add("param_date_of_birth", MySqlDbType.VarChar, 255).Value = MSSQLreader["date_of_birth"];
        MySQL_command.Parameters.Add("param_full_name", MySqlDbType.VarChar, 255).Value = MSSQLreader["person_name"].ToString();
        MySQL_command.Parameters.Add("param_nationality", MySqlDbType.VarChar, 255).Value = MSSQLreader["nationality"].ToString();
        MySQL_command.Parameters.Add("param_gender", MySqlDbType.VarChar, 255).Value = MSSQLreader["gender"].ToString();
        MySQL_command.Parameters.Add("param_old_file_no", MySqlDbType.VarChar, 255).Value = MSSQLreader["old_file_no"].ToString();
        MySQL_command.Parameters.Add("param_marital_status", MySqlDbType.VarChar, 255).Value = MSSQLreader["marital_status"].ToString();
        MySQL_command.Parameters.Add("param_blood_group", MySqlDbType.VarChar, 255).Value = MSSQLreader["blood_group"].ToString();
        MySQL_command.Parameters.Add("param_patient_is_vip", MySqlDbType.VarChar, 255).Value = MSSQLreader["person_is_vip"].ToString();
        MySQL_command.Parameters.Add("param_is_outside_country", MySqlDbType.VarChar, 255).Value = MSSQLreader["is_outside_country"].ToString();
        MySQL_command.Parameters.Add("param_address_outside_address", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_outside_address"];
        MySQL_command.Parameters.Add("param_address_country", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_country"].ToString();
        MySQL_command.Parameters.Add("param_address_flat", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_flat"];
        MySQL_command.Parameters.Add("param_address_building", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_building"];
        MySQL_command.Parameters.Add("param_address_road", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_road"];
        MySQL_command.Parameters.Add("param_address_avenue", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_avenue"];
        MySQL_command.Parameters.Add("param_address_block", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_block"];
        MySQL_command.Parameters.Add("param_address_po_box", MySqlDbType.VarChar, 255).Value = MSSQLreader["address_po_box"];
        MySQL_command.Parameters.Add("param_contact_mobile", MySqlDbType.VarChar, 255).Value = MSSQLreader["contact_moblle"];
        MySQL_command.Parameters.Add("param_contact_home_tel", MySqlDbType.VarChar, 255).Value = MSSQLreader["contact_home_tel"];
        MySQL_command.Parameters.Add("param_personal_email", MySqlDbType.VarChar, 255).Value = MSSQLreader["email_address"];
        MySQL_command.Parameters.Add("param_created_date", MySqlDbType.Timestamp).Value = Convert.ToDateTime(MSSQLreader["created_date"]);

        int MySQL_reader = MySQL_command.ExecuteNonQuery();

        MySQL_command.Dispose();
        MySQL_connection.Close();

        // Mark it Updated in MSSQL
        mark_migrated(Convert.ToInt32(MSSQLreader["file_no"]));
    }
}
catch (Exception exp)
{
    return;
}
finally
{
    MSSQLcommand.Dispose();
    MSSQLreader.Close();
    MSSQLconnection.Close();
}

Pete O'Hanlon17-Sep-12 6:09

17-Sep-12 6:09

You have closed your connection in the body of the try block, and then you attempt to close it again in the finally block. You only need to do this once - the simple fix is to remove the Dispose/Close pair from inside the try part.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

Andrei Straut17-Sep-12 6:14

17-Sep-12 6:14

The way I see it, he actually has 2 different connections in there OMG | :OMG:

an MS-SQL and a MySQL one, and in the try he closes the MySQL one, not the MS-SQL one. I had posted the same answer immediately after you, but deleted it. Then I took another look, and spotted it

EDIT: I did upvote your solution before that though, and I'll leave it as is

Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.

Emmanuel Medina17-Sep-12 7:43

Emmanuel Medina

17-Sep-12 7:43

What Andrei says is true, I had thought what Pete said (closing the connection twice) but then I saw they're different connections.

I think I've seen this problem when the command's connection is not closed right away after use; since you already have the data in the reader, maybe you could close the SQLConnection before the while loop and see if it helps?.

And just my point of view: the catch block should either give an informative message of the problem (or at least just log the message somewhere) or it should be done away with.

Jassim Rahma17-Sep-12 7:56

17-Sep-12 7:56

Hi guys,

no he's right Smile | :)

sorry..

i missed it..

the connection was already closed here:

mark_migrated(Convert.ToInt32(MSSQLreader["file_no"]));

this is the code which closes the connection:

private void mark_migrated(int file_no)
{
    MSSQLconnection_Migrated = new SqlConnection(ConfigurationManager.ConnectionStrings["MSSQL"].ConnectionString);
    MSSQLconnection_Migrated.Open();

    // where is_migrated = false;
    MSSQLcommand_Migrated = new SqlCommand("update persons set is_migrated = 1 where file_no = " + file_no, MSSQLconnection_Migrated);
    int MSSQLreader_Migrated = MSSQLcommand_Migrated.ExecuteNonQuery();

    MSSQLcommand_Migrated.Dispose();
    MSSQLconnection_Migrated.Close();
}

I will try checking connection state before closing and revert back if not zsolved.

thanks guys

Emmanuel Medina17-Sep-12 8:12

Emmanuel Medina

17-Sep-12 8:12

jrahma wrote:
MSSQLconnection_Migrated = new SqlConnection(ConfigurationManager.ConnectionStrings["MSSQL"].ConnectionString);

Isn't that a whole different connection though?

Jassim Rahma17-Sep-12 8:18

17-Sep-12 8:18

oh sorry!

you are right..

then where is the problem?!!

Andrei Straut17-Sep-12 8:25

17-Sep-12 8:25

Scoping issues. Try moving your MSSQL connection before the try - catch block. Also, I've only now noticed it. Just out of curiosity: does your code even compile?

Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.

PIEBALDconsult17-Sep-12 8:42

PIEBALDconsult

17-Sep-12 8:42

I don't think that's it either.

PIEBALDconsult17-Sep-12 8:39

PIEBALDconsult

17-Sep-12 8:39

I dunno.

Does your mark_migrated try to use the same Connection reference that the above code uses? Or does it replace it?

Unrelated to the error:

Please don't keep instantiating and disposing the Connection, Command, and Parameters within the while loop.

0) Instantiate the Connection
1) Instantiate the Command
2) Instantiate and Add the Parmeters
3) while (MSSQLreader.Read())
3.1) Assign the Parameter values
3.2) ExecuteNonQuery
4) Close and Dispose

jschell17-Sep-12 8:43

jschell

17-Sep-12 8:43

In general a bad idea all around.

If an exception occurs you do NOT know why it occurred.
It is possible that almost anything afer that point will cause another exception.

Thus your code should be structured like this.

try
{
  ...
  command.Dispose();
  connect.Close();
  // At this point ALL resources should be cleaned up for
  // a normal exit.
}
catch(Exception e)
{
   // Clean up resources for abnormal exit.

   // REPORT THE EXCEPTION!!!!!
   try
   {
     command.Dispose();
   }
   catch(Exception)
   {
     // Ignore it because we already have an exception
   }

   try
   {
     connection.Close();
   }
   catch(Exception)
   {
     // Ignore it because we already have an exception
   }

   // Repeat try/catch for all other resources.
 }  // End of first try

 // There is NO finally block.  All connection
 // resources were cleaned up by regular process flow or exception block.
 // finally could be used for resources that were NOT connection related.

Pete O'Hanlon17-Sep-12 9:33

17-Sep-12 9:33

Now that it's been pointed out that they are different connections (I completely missed that), I would refactor this. Rather than the pattern you are using here, I would look to use the using command. Also, if you pass in CommandBehavior.CloseConnection on your call to ExecuteDataReader, you will automatically close the ocnnection when you finish iterating over the data reader.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

Jassim Rahma17-Sep-12 9:59

17-Sep-12 9:59

but how can I use the CommandBehavior.CloseConnection with ExecuteNonQuery()?

Interprocess Communication from C# to HTML page

Emmanuel Medina17-Sep-12 10:13

Emmanuel Medina

17-Sep-12 10:13

Well, you are using ExecuteReader in your code, not ExecuteNonQuery. ExecuteReader can take CommandBehavior.CloseConnection as a parameter

vjpudelski17-Sep-12 4:53

vjpudelski

17-Sep-12 4:53

I have a standalone HTML page used for data entry by a third party application. The form is opened in an IE window directly from the directory that it is stored. What I need to do is send information from a C# Class Library that is being called by a different system and send the information to this html page. ideas?

basically I want to do something like have javascript poll a tcp port until I send something but not sure how that works.

Also considered writing a C# COM object and using the object tag to make that part of the page and do all communication through C# but not sure if this is the best route.

Re: Interprocess Communication from C# to HTML page

Eddy Vluggen17-Sep-12 7:16

Eddy Vluggen

17-Sep-12 7:16

How about ASP.NET? Seems to me it was created for this kind of stuff.

Bastard Programmer from Hell Suspicious | :suss:

if you can't read my code, try converting it here[^]

Re: Interprocess Communication from C# to HTML page

Abhinav S17-Sep-12 7:59

Abhinav S

17-Sep-12 7:59

A non C# solution - you might want to try and use Comet notifications[^].

WP7.5 Apps - XKCD | Calvin | SMBC | Sound Meter | Speed Dial

Open Source Alternatives to Word Library and Word Compnents

ASPnoob17-Sep-12 3:29

ASPnoob

17-Sep-12 3:29

Hi all, I am trying to create a method that allows users to convert a Word document to other kinds of files like PDFs, text files, etc., and that means using Word library and Word components. These need the Office Interop Word Assembly to work and I heard that hosting companies won't install it for you because of the licensing fee and they won't let you install it on their web server unless you sign up for a dedicated server. Are there open source alternatives out there that I can use? Thanks in advance.

modified 17-Sep-12 11:17am.

Re: Open Source Alternatives to Word Library and Word Compnents

Andrei Straut17-Sep-12 3:50

Re: Open Source Alternatives to Word Library and Word Compnents

17-Sep-12 3:50

Yes, you can use the OpenOffice API for .NET to manipulate Office docs programmatically. I've used it before, and it works.

However, if you do decide to use it, be warned: it's not easy, and it's very poorly documented, not to mention intuitive. But if you do get it working, it's a wonder.

Good luck!

Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.

Pete O'Hanlon17-Sep-12 3:55

Re: Open Source Alternatives to Word Library and Word Compnents

17-Sep-12 3:55

Sounds like something that would be well worth reading as an article.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

Andrei Straut17-Sep-12 4:08