The Weird and The Wonderful

Martin Thwaites wrote:

string keyToFind = "asdfgsd44rtgr";
 
Dictionary<string, object> dctTemp = GetDictionary();
 
object theObject = dctTemp.ToList().FirstOrDefault(x => x.key == keyToFind).Value;

object theObject = GetDictionary()[keytoFind];

using System.Collections.Generic;

namespace ConsoleApplication2
{
	class Program
	{
		static void Main(string[] args)
		{
			Class1.Sample();
		}
		static class Class1
		{
			private static Dictionary GetDictionary()
			{
				var retval = new Dictionary();
				retval.Add("asdfgsd44rtgr", "1");

				//Throws Error
				//System.ArgumentException was unhandled
				//Message=An item with the same key has already been added.
				//Source=mscorlib
				//StackTrace: {ommitted}
				retval.Add("asdfgsd44rtgr", "throws error");
				return retval;
			}
			public static void Sample()
			{
				string keyToFind = "asdfgsd44rtgr";

				Dictionary dctTemp = GetDictionary();

				//object theObject = dctTemp.ToList().FirstOrDefault(x => x.Key == keyToFind).Value;
				object theObject = GetDictionary()[keyToFind];
			}


		}

	}
}

Nathan D Cook wrote:

 
First, why check for null every time and a ToString().ToUpper() every
time? Why not just check it once and set a string that we can check?

Nathan D Cook wrote:

Third, in the VoidPayment function why are we doing yet another ToUpper when we
know we are passing in either a capitalized PAID or ADJUSTED string? VoidPayment
is only called from those two spots, and it's not really a function that should
be called elsewhere or added anywhere else later.

if (combo.SelectedItem.ToString() != null)
   {
   switch (combo.SelectedItem.ToString().ToUpper())
      {
      case "APPROVED":
         ...
         break;
      case "UNAPPROVED":
         ...
         break;
...

string selection = null;
if (combo.SelectedItem != null) selection = combo.SelectedItem.ToString().ToUpper();
switch (selection)
{
  case "APPROVED":
    //...
    break;
  case "UNAPPROVED":
    //...
    break;
  default:
    //...
    break;
}

_field = string.Copy(s.Field);

_field = s.Field