|
Hello,
I recently began working on a project in C# .Net, written in MS Visual Studio 2010, where many things are at least peculiar...
All files are in root directory, meaning there are no subdirs.
Files include several classes which, in best case, may belong to the same or a similar fact.
Even if there is only one Class in a .cs file, it doesn’t always have the same name, meanig for a Class Car the file may have a name Frm_View.cs, in other words completely irrelevant to the class name.
Hungarian notation is being used, like in the old MS times.
There is an enorm amount of internal, static and both internal static variables and functions.
There is no inheritance between classes.
There are no interfaces.
It seems to me that it is about an old C programm, which has been ported into C#, but only as far as syntax concerns.
What do you think?
|
|
|
|
|
Based on your comments, your program may follow only very few principles of OOPS (if at all).
So I guess you can say its does not follow many OOPS concepts.
But them, I guess its very difficult to write a 'perfect' OOP program in any case though.
|
|
|
|
|
If the application is a C# one, then it's Object Oriented - however, it sounds like it's only just OOP. Perhaps we should coin the term A Little Bit OOP (ALBOOP), as it seems to fit.
|
|
|
|
|
If there are objects (and all C# programs have them) then it is Object Oriented Programming.
nstk wrote: there are no subdirs.
That doesn't matter.
nstk wrote: Class Car the file may have a name Frm_View.cs
That doesn't matter.
nstk wrote: Hungarian notation is being used
That doesn't matter.
nstk wrote: There is an enorm amount of internal, static and both internal static variables
and functions.
That may be a code smell, but it doesn't mean it's not OOP.
nstk wrote: There is no inheritance between classes
That's not always required. Using inheritence simply to use inheritence is a code smell too.
nstk wrote: There are no interfaces.
That doesn't matter.
nstk wrote: It seems to me that it is about an old C programm,
Quite possibly. But you have to judge the existing program on its own merits (if any).
|
|
|
|
|
|
That exactly is my point.
|
|
|
|
|
Thanks for your replies. I am aware that C# an OOP language is. I am also aware that it is not obligatory to have inheritance or interfaces. But in this case everything is against an OOP design. And if every function in a programme can change every variable in it, then imho it has nothing to do with OOP, although in it's syntax there are always classes, since otherwise it wouldn't compile.
I wrote this message because I wanted to get a feedback from the forum, since I plan to write to my boss that this piece of code is worthless and should be rewritten with a new concept. As a matter of fact, we are being confronted with all these problems that are described in the software enginnering literature since years. We always deal with a lot of bugs and problems, no one is completely sure of what is happening, we have not a complete picture of the structure, we are steadily debugging step by step hoping to find out what changed that variable at the last moment(because any class can do that) and even the person who did program it and recently made some changes, had to search for some unexpected new errors that arose.
I think it's time to get rid of that piece of software for the simple reason that it is not as OOP designed. Any objections?
|
|
|
|
|
You can write object oriented code in C, and you can write mostly non-object oriented code in C#. But C is still not an object oriented language, and C# still is. So when you asked "is it OOP?" then what does that even mean?
And also, does it matter? So that program may or may not be "proper OOP design", but are you sure that's a problem? Would it help if it were?
OOP is not a silver bullet that magically solves all problems - indeed it often creates new ones.
If there is a problem with maintainability of the code, then there is a problem with the maintainability of the code. Whether it's object oriented or not doesn't necessarily imply there is a problem with the maintainability of the code, and if both are true at the same time anyway, that does not necessarily make the non-OOP-ness the cause of the problem.
TL;DR: if there is a problem with the code, fix it. If it's not OOP designed but there is no problem, why fix what isn't broken?
|
|
|
|
|
nstk wrote: I wrote this message because I wanted to get a feedback from the forum, since I
plan to write to my boss that this piece of code is worthless and should be
rewritten with a new concept.
Err..no.
You have some code that is unlikely to have an Object Oriented design.
That however doesn't make it "worthless".
If the code is being used in the business then it is far from "worthless".
If it isn't being used then it shouldn't be changed at all.
nstk wrote: We always deal with a lot of bugs and problems, no one is completely sure of
what is happening, we have not a complete picture of the structure, we are
steadily debugging step by step hoping to find out what changed that variable at
the last moment(because any class can do that) and even the person who did
program it and recently made some changes, had to search for some unexpected new
errors that arose.
Now those are problems. And those are problems that OOP will NOT fix.
However there are other practices that if put into place MIGHT fix those problems. Those practices can be applied to a OO and structured app. In certain cases it might be easier to apply them to OO code. But not necessarily.
It might the case that the code is badly implemented and thus it is more cost effective to rewrite it. However based on the problems listed above a rewrite MUST insure that the same problems are not allowed to exist with the rewritten code.
|
|
|
|
|
im developing a application ... that has some softwares which i have to install silentlt back side while installing the other on user selection... im developing using visual studio 2010 .. c# . please any one help
|
|
|
|
|
Why?
That sounds a lot like the kind of installation I really don't want to run...
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
|
|
|
|
|
Are you talking about prerequisites such as installing SQL Server Express?
|
|
|
|
|
Here[^] is the standard list of command line operations for an installer. Have a look at the /quiet command mode.
|
|
|
|
|
Here is my code:
//Line below shows an email msg obj with To segment being an array (could have null to x number of receipients/emails):
emailMessage.EmailParamHeaders.To
//Below is creation of mail message obj:
MailMessage m = new MailMessage();
//Line blow is adding each To email address to the "m" object
emailMessage.EmailParamHeaders.To.ToArray().ToList().ForEach(x => m.To.Add(x));
How can I only add the elements of the array "To" where value is not null?
Thank you in advance.
|
|
|
|
|
try this
emailMessage.EmailParamHeaders.To.ToArray().ToList().ForEach(x => {if(m != null) m.To.Add(x);});
|
|
|
|
|
Thank you so much for the answer, that worked with minor change:
emailMessage.EmailParamHeaders.To.ToArray().ToList().ForEach(x => { if (x != null) m.To.Add(x); });
|
|
|
|
|
Why are you converting to array, and then to a list? Also, if your email message supports AddRange, an alternative is to try the following?
var addresses = (from p in emailMessage.EmailParamHeaders.To
where p != null
select p).ToList();
if (addresses != null && addresses.Count>0)
m.To.AddRange(addresses);Depending what's going on inside the Add method, you can often find that an AddRange works more efficiently.
|
|
|
|
|
In a C#.net 2010 application, I would like a suggestion on how to complete the following task:
In a string field, I need to make certain the only values that are returned by a routine are:
1. alphabetic characters only,
2. The result must be in uppper case,
3. No other characters are allowed.
Can you tell me how to accomplish this task?
|
|
|
|
|
Check your results for validty before you return the value from the method??
You can look into using Code Contracts[^] to simplify this process a bit.
|
|
|
|
|
I'd go with a Regex:
string input = "1234asdfASDFG,../;[][";
string output = Regex.Replace(input, "[^A-Z]", "");
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
|
|
|
|
|
I want to place design surface on button control, which is located on design surface. Is there a way to place design surface inside other design surface?
I create new design control(design surface with button control as root component) in CreateInstance() of other design surface and have next exception:
The CurrentContext property of the LicenseManageris currently lockedand cannot be changed.
I think, during executing of CreateInstance()(of main design surface) current design host(of main design surface) is locked, therefore I can't create other design surface.
modified 12-Jun-12 3:54am.
|
|
|
|
|
Hi All,
I am writing an application and need to save some data with an incremental number.
My first thought was to use an integer that be could incremented and shoved out disk, now I am trying to do thing properly so I have come up with the following
String Path = Directory.GetCurrentDirectory();
string[] file_text = Directory.GetFiles(@Path, "*.txt");
string Name;
int FileTotal = 0;
for (int i = 0; i <= file_text.Length - 1; i++)
{
Name = file_text[i].Substring(Path.Length+1);
FileTotal++;
}
MessageBox.Show(FileTotal.ToString());
FileTotal++;
MessageBox.Show("Next File to Written is " + FileTotal.ToString());
It looks for the file (in the bit of example code .txt ...) adds one to the total for the next one. Is this the 'correct' way of doing things or am I creating a kludge that will come back and bite me later.
Glenn
|
|
|
|
|
What you are trying to do is unclear; please explain more clearly.
glennPattonWork wrote: Is this the 'correct' way of doing things or am I creating a kludge that will
come back and bite me later.
It might be OK, but I can't say for sure until I know what you are trying to accomplish.
Is there a database involved?
|
|
|
|
|
Hi,
Sorry about that I had not really had chance to proof read it when it got posted (mix of Web connection and finger trouble) What I am aiming to do is to create a load data files
such as Data001.msg, Data002.msg etc at the moment I have it updating a variable that goes to an ini file (I know, I am under orders to make an .ini, you bring up XML but no! separate story)I want the program to look at the location say there are six file with an .msg extension I would like the variable to be seven and create Data007.msg and on. I was trying to find a way to do this that wasn't too bad. Sorry, there is no database involved at this stage!
Glenn
|
|
|
|
|
glennPattonWork wrote: say there are six file ... I would like the variable to be seven
Well, then what about int FileTotal = file_text.Length ; ?
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
