Visual Basic

Re: VB 2010 code fails when copying root directory.

30-Jan-12 2:30

I have a VB application I wrote in 2002 with Visual Studio 2002 at that time. It copies files and directories with a variety of parameters. We use the utility to copy files from server to server or destktop to desktop via scheduled tasks, etc.

It is a framework 1.0 app and has worked for years. This past year it was evident it needs upgraded to VS 2010. Everything is working fine except in Windows 7 with parameters we've used for years with XP and on the servers, when we copy a root directory, for example, D:\, the copy program will try to copy the Recycle Bin and the System Volume Information and fail. In previous operating systems I'm guessing it didn't try to copy these items, but in Windows 7 for some reason it does.

We really don't want to copy these two items anyhow, so in the new VS VB 2010 code I wrote the following logic, but I've found that from one server it isn't working:

<br />
Dim source as string = "D:\"<br />
Dim currentDirectory As DirectoryInfo = New DirectoryInfo(source)<br />
Dim di As DirectoryInfo<br />
For Each di In currentDirectory.GetDirectories()<br />
  If blnIsRoot = True Then<br />
    If (di.Attributes = FileAttributes.Normal) Or _<br />
       (di.Attributes = FileAttributes.Directory) Or _<br />
       (di.Attributes = FileAttributes.SparseFile) Or _<br />
       (di.Attributes = FileAttributes.ReparsePoint) Or _<br />
       (di.Attributes = FileAttributes.NotContentIndexed) Or _<br />
       (di.Attributes = FileAttributes.System) Or _<br />
       (di.Attributes = FileAttributes.Offline) Or _<br />
       (di.Attributes = FileAttributes.Temporary) Or _<br />
       (di.Attributes = FileAttributes.Device) Or _<br />
       (di.Attributes = FileAttributes.Hidden) Or _<br />
       (di.Attributes = FileAttributes.Encrypted) Or _<br />
       (di.Attributes = FileAttributes.Compressed) Or _<br />
       (di.Attributes = FileAttributes.Archive) Or _<br />
       (di.Attributes = FileAttributes.ReadOnly) Then<br />
<br />
           .... logic to copy directory<br />
<br />
end if statments, next statements, etc...<br />

With this code, it will copy a root directory (d:\) and all sub directories and ignore the recycle bin and system volume information.

Code works 99% of the time, but with one server which houses our intranet, I'm copying from \\inttranetserver\wwwroot\dept\its\ to d:\test\ and it is not copying any directories at all, even though there are multiple under ..\its\

I run the code in debug, set breakpoints and skip the if statement (shown above) checking attributes and it works fine, but put that if statment back in it doesn't copy any of the directories.

I'd like to use better logic, for example something that checks for "if recycle bin or if system volume information" but I haven't found anything.

Any suggestions? Confused | :confused:

Thanks

Lost in the vast sea of .NET

Luc Pattyn30-Jan-12 2:45

Re: VB 2010 code fails when copying root directory.

30-Jan-12 2:45

Hi,

some facts:
1. file attributes are flags, several of them can be set at the same time, so your compare statements aren't going to cut it.
2. Windows, since Vista, is more protective about a number of files and folders, your old code is probably getting access violations.

what I do:
- copy everything you need in a big loop; inside the loop, have a try-catch, and log each individual failure.
- before copying, check for some special names and skip those.
- the exceptions will tell you which files you will have to skip, i.e. which checks to add to your code.
- and this will have to amended every time you move to the next Windows version...

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

KreativeKai30-Jan-12 3:09

Re: VB 2010 code fails when copying root directory.

30-Jan-12 3:09

On this fact:
"file attributes are flags, several of them can be set at the same time, so your compare statements aren't going to cut it."

I am seeing this when I follow via breakpoints, where it seems like several attributes are set. This makes sense to me.

Your suggestions:
- copy everything you need in a big loop; inside the loop, have a try-catch, and log each individual failure.
- before copying, check for some special names and skip those.

I like your suggestions, I just have a question. As far as tracking it to a log file, what attributes do you think I should catch that would be helpful to log? di.Attributes, di.fullname... anything else?

When you say special names, are you saying if I check fullname and the name of the recycle bin to a string I define "Recycle Bin ...". Is the name always consistent. We have several differnt servers 2000, 2003, 2008 and workstations are basically XP, Vista, and now 7. I assume the names might change between operating systems and the log will be helpful. I like this idea, but hoping you can clarify a little?

Thanks for your help!
Wink | ;)

Lost in the vast sea of .NET

Luc Pattyn30-Jan-12 3:21

Re: VB 2010 code fails when copying root directory.

30-Jan-12 3:21

KreativeKai wrote:
what attributes ...?

just the name, attributes aren't relevant, they can change, e.g. when a backup is made.

KreativeKai wrote:
special names...

check everything you ever encountered, do not change with the Windows version, just add to the skip list:

for (...) {
    ...
    if (shortName=="Recycle Bin") continue;
    if (shortName=="Trash Can") continue;
    ...
    try {
        ....
    } catch(...) {
        ....
    }
}

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

KreativeKai30-Jan-12 8:07

Re: VB 2010 code fails when copying root directory.

30-Jan-12 8:07

Thanks for all your help Luc! It is appreciated! Cool | :cool:

Below is the code I used in case anyone else can learn from it later when searching the message boards...

<br />
Dim di As DirectoryInfo<br />
For Each di In currentDirectory.GetDirectories()<br />
  Dim strDirectoryName As String = di.Name<br />
  Dim intFoundRB As Integer = strDirectoryName.IndexOf("$RECYCLE.BIN")<br />
  Dim intFoundSV As Integer = strDirectoryName.IndexOf("System Volume Information")<br />
  'Skip $Recycle.Bin or System Volume Information directories<br />
  If (intFoundRB = -1) And (intFoundSV = -1) Then<br />
     Try<br />
        ... Copy logic<br />
     Catch ex As Exception<br />
        ... logic writing to log file for future reference if needed...<br />
     End Try<br />
  End If<br />
Next

Lost in the vast sea of .NET

Dave Kreskowiak30-Jan-12 4:25

Dave Kreskowiak

30-Jan-12 4:25

On top of what Luc said, why are you even checking attributes?? Unless they determine eligibility of a file to be copied, you have no need to look at the file attributes. Your code snippet suggests that you're not using the attributes for anything at all, so I'd just remove the checks.

A guide to posting questions on CodeProject[^]

Dave Kreskowiak

Re: VB 2010 code fails when copying root directory.

KreativeKai30-Jan-12 8:00

Re: VB 2010 code fails when copying root directory.

30-Jan-12 8:00

Hi Dave,
I was checking attributes because originally I was hoping to exclude the Recycle Bin and System Volume Information by skipping a system attribute, but found through testing that if I did an "if statement" with all the attributes it worked. Didn't make sense, but worked... Unfortunately from our intranet server, the copy was skipping those folders, so the logic was no longer sound.

You would think Microsoft would have a way of catching the recycle bin in the logic by looking for an attribute of some kind related to system files/directories?

Oh well, the logic worked by catching the name of the directories and skipping them that way.

Thanks for the feedback! Always appreciated!

Lost in the vast sea of .NET

Dave Kreskowiak30-Jan-12 8:10

Dave Kreskowiak

30-Jan-12 8:10

For future reference, your code wasn't checking to see if any attributes were turned on. That IF statement you posted only returned True if one and only one attribute was turned on. Your check got lucky if it returned true.

You would normally check to see if a single bit flag is enabled like this:

If (di.Attributes And FileAttributes.System) = FileAttributes.System Then

A guide to posting questions on CodeProject[^]

Dave Kreskowiak

Re: VB 2010 code fails when copying root directory.

KreativeKai30-Jan-12 9:18

30-Jan-12 9:18

Thanks for the clarification! It is evident now that I was misunderstanding the File.Attributes logic. Smile | :)

Lost in the vast sea of .NET

visual basic6.0

mahesh kagitha28-Jan-12 18:41

mahesh kagitha

28-Jan-12 18:41

download the visual basic 6.0 softwear

Richard MacCutchan28-Jan-12 21:40

Richard MacCutchan

28-Jan-12 21:40

VB 6 is a dead system. If you are interested in developing using Visual Basic then get a copy of the express version[^].

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Gregory Gadow30-Jan-12 7:45

Gregory Gadow

30-Jan-12 7:45

Dead system? Feh. "It has worked for ten years, we don't need to upgrade! Now, I need this list of changes implemented by tomorrow...."

Eddy Vluggen30-Jan-12 7:47

Eddy Vluggen

30-Jan-12 7:47

"Good luck in finding 10 year old hardware with a 10 year old OS that still supports your platform. Better yet, try and get tech support from Microsoft, and don't forget to invite me when you try."

Either one moves on, or ones becomes obsoleted.

Bastard Programmer from Hell Suspicious | :suss:

Abhinav S28-Jan-12 22:03

Abhinav S

28-Jan-12 22:03

Visual Basic 6.0 was never free.
However, it would be prudent you look at working in .Net instead of VB6 now.

Luc Pattyn28-Jan-12 22:16

28-Jan-12 22:16

Thanks, I won't, I just don't think so.

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

Richard MacCutchan28-Jan-12 22:26

Richard MacCutchan

28-Jan-12 22:26

Go on, give it a try, you might like it. Wink | ;)

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Luc Pattyn28-Jan-12 22:44

28-Jan-12 22:44

Oh, but I have used it, in a previous century.
I did like it then, to some degree; I also am sure I won't like it today.

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

Bernhard Hiller29-Jan-12 20:51

Bernhard Hiller

29-Jan-12 20:51

Luc Pattyn wrote:
previous century

Previous millenium!

Visual Basic 6.0 Resource Center[^]
Upgrading Applications Created in Previous Versions of Visual Basic[^]

thatraja28-Jan-12 23:00

thatraja

28-Jan-12 23:00

Really you want to go with VB6?

Visual Basic 6.0

Christian Graus wrote:
VB6 is obsolete by a decade and was always horrible.

Christian Graus wrote:
Why is anyone still using VB6 in 2011 ? Self loathing ? A dinosaur who refused to move with the times ?

I suggest you to go with Visual Studio Express Editions[^]

thatraja

FREE Code Conversion VB6 ASP VB.NET C# ASP.NET C++ JAVA PHP DELPHI | Nobody remains a virgin, Life screws everyone Sigh | :sigh:

Framework .l.29-Jan-12 16:28

Framework .l.

29-Jan-12 16:28

it's useless heritage, the ugliest program i ever saw.. what a waste of time.. Dead | X|