Re: Question about Chart in C# - C# Discussion Boards

Re: C# UnauthorizedAccessException

29-Jan-12 3:53

No problem!
Google translate works wonders... Laugh | :laugh:

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

Abhinav S29-Jan-12 19:04

Abhinav S

29-Jan-12 19:04

Try and ask questions in English.
It will allow a larger user base to answer it.

As an example, I have no idea what this question is about.

Re: C# UnauthorizedAccessException

Bernhard Hiller29-Jan-12 20:44

Bernhard Hiller

29-Jan-12 20:44

A non-administrative user must not write into the ProgramFiles folder (translation hint: "must not" bedeutet "darf nicht").
Create an installation package - the "System" account used by the installer can write to that folder.
In case you want to write application data used by all users, the folder should go to CommonApplicationData, and data by a specific user to LocalApplicationData.

Question about Chart in C#

pongpanut28-Jan-12 20:31

28-Jan-12 20:31

i need to create chart with data from my database by select product from checkbox in listbox and between date from datetimepicker bet when click the button for generate graph value in graph show same data for every series i don't know how to fix this problem

this is my code

if (row.Cells[1].Value != null && (bool)row.Cells[1].FormattedValue)
                {                       
                        String idtoselect = row.Cells[0].Value.ToString();
                        String str1 = idtoselect.ToString();
                        
                        try
                        {
                            string sql2 = "select NAME_Product from Product where  Product.ID_Product = '"+str1+"' ";
                            SqlCommand testcommand2 = new SqlCommand(sql2, conn);
                            rdr = testcommand2.ExecuteReader();

                            while (rdr.Read())
                            {
                                test = rdr["NAME_Product"].ToString();

                            }
                            rdr.Close();

                            try
                            {
                                CultureInfo ci = new CultureInfo("th-TH");
                                string sql = "SELECT * FROM Order1 where ID_Product = '"+str1+"' AND DATE_Order BETWEEN '" + dateTimePicker1.Value.ToString("s") + "' AND '" + dateTimePicker2.Value.ToString("s") + "' ";
                                da = new SqlDataAdapter(sql, conn);
                                ds = new DataSet();
                                da.Fill(ds, "Order1");
                                chart1.DataSource = ds.Tables["Order1"];
                                chart1.ChartAreas["ChartArea1"].Area3DStyle.Enable3D = true;
                                
                                chart1.Series.Add(test);
                                chart1.Series[test].ChartArea = "ChartArea1";
                                chart1.Series[test].BorderWidth = 4;
                                chart1.Series[test].ChartType = System.Windows.Forms.DataVisualization.Charting.SeriesChartType.Line;                                
                                chart1.Series[test].YValueMembers += "QUANTITY_Order";
                                chart1.Series[test].XValueMember += "DATE_Order";

                                chart1.DataBind();
                                MessageBox.Show("test :" );
                            }
                            catch (Exception ex)
                            {
                                MessageBox.Show("test :" + ex);
                            }
       
                        }
                        catch
                        {
                            MessageBox.Show("exception");
                        }

and this my output

http://image.ohozaa.com/view/80v2q]

i'm so sorry if i type a wrong word because my english is not good

Thank you for answer

OriginalGriff28-Jan-12 21:06

28-Jan-12 21:06

There are a number of "silly" things going on there which it would be worth fixing before you start looking at the meat of your problem:

String idtoselect = row.Cells[0].Value.ToString();
String str1 = idtoselect.ToString();

Why?
idtoselect is already a string, so why convert it to a string in order to load it into another string? In fact you never reference idtoselect agains, so why not just use that throughout, where the name is a bit more meaningfull than str1?

string sql2 = "select NAME_Product from Product where  Product.ID_Product = '"+str1+"' ";

Is a bad idea - do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

while (rdr.Read())
{
    test = rdr["NAME_Product"].ToString();
}

test is a string - it can only hold a single value, so why use a loop? Use

if (rdr.Read())

instead.

CultureInfo ci = new CultureInfo("th-TH");

Does nothing at all unless you actually use it in a conversion.

string sql = "SELECT * FROM Order1 where ID_Product = '"+str1+"' AND DATE_Order BETWEEN '" + dateTimePicker1.Value.ToString("s") + "' AND '" + dateTimePicker2.Value.ToString("s") + "' ";

Seriously, don't concatenate strings. You have the DateTime values as DateTime. SQL understands DateTime, and does not need it to be in any particular format. Unlike strings, where it does (SQL needs ISO format yyyy-MM-dd), and you aren't providing that, you are providing the short date form of your current culture.

string sql = "SELECT * FROM Order1 where ID_Product = @ID AND DATE_Order BETWEEN @D1 AND @D2";
da = new SqlDataAdapter(sql, conn);
da.SelectCommand.Parameters.AddWithValue("@ID", idtoselect);
da.SelectCommand.Parameters.AddWithValue("@D1", dateTimePicker1.Value);
da.SelectCommand.Parameters.AddWithValue("@D2", dateTimePicker2.Value);

And you may find that if you do all that, your problem may magically disappear! I suspect it might...

BTW: Stop using the Visual Studio default names for things. dateTimePicker1, dateTimePicker2 don't mean a whole lot - try reading the above with them called startDate and endDate instead - see how much easier it is to read?

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

pongpanut28-Jan-12 21:47

28-Jan-12 21:47

Thank you for your answer Smile | :)

i have fix my code but my problem still show i don't know what what happen Frown | :(

OriginalGriff28-Jan-12 21:49

28-Jan-12 21:49

So what does your code look like now?
What values are you giving it?
What values are in your DB?

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

pongpanut28-Jan-12 22:20

28-Jan-12 22:20

my code is

string test = "";

            foreach (DataGridViewRow row in dataGridView1.Rows)
            {
                if (row.Cells[1].Value != null && (bool)row.Cells[1].FormattedValue)
                {                       
                        String idtoselect = row.Cells[0].Value.ToString();
                        
                        try
                        {
                            string sql2 = "select NAME_Product from Product where  Product.ID_Product = '"+idtoselect+"' ";
                            SqlCommand testcommand2 = new SqlCommand(sql2, conn);
                            rdr = testcommand2.ExecuteReader();

                            if (rdr.Read())
                            {
                                test = rdr["NAME_Product"].ToString();
                            }
                            rdr.Close();

                            try
                            {
                                CultureInfo ci = new CultureInfo("th-TH");
                                string sql = "SELECT * FROM Order1 where ID_Product = @ID AND DATE_Order BETWEEN @D1 AND @D2";
                                da = new SqlDataAdapter(sql, conn);
                                da.SelectCommand.Parameters.AddWithValue("@ID", idtoselect);
                                da.SelectCommand.Parameters.AddWithValue("@D1", dateTimePicker1.Value);
                                da.SelectCommand.Parameters.AddWithValue("@D2", dateTimePicker2.Value);
                                
                                ds = new DataSet();
                                da.Fill(ds, "Order1");
                                chart1.DataSource = ds.Tables["Order1"];
                                chart1.ChartAreas["ChartArea1"].Area3DStyle.Enable3D = true;
                                
                                chart1.Series.Add(test);
                                chart1.Series[test].ChartArea = "ChartArea1";
                                chart1.Series[test].BorderWidth = 4;
                                chart1.Series[test].ChartType = System.Windows.Forms.DataVisualization.Charting.SeriesChartType.Line;                                
                                chart1.Series[test].YValueMembers += "QUANTITY_Order";
                                chart1.Series[test].XValueMember += "DATE_Order";

                                chart1.DataBind();
                                MessageBox.Show("test :" );
                            }
                            catch (Exception ex)
                            {
                                MessageBox.Show("test :" + ex);
                            }
       
                        }
                        catch
                        {
                            MessageBox.Show("Exception");
                        }
                

                }

i want to select quantity(QUANTITY_Order) that have been sold to show on my chart

if i select only one product chart will be show with correct value but if i choose two product in my list box for compare with two product value of first product will be wrong and it copy value of second product

this's my demo interface
http://image.ohozaa.com/view/8146d

it will show all product in database to list box and datetimepicker1 for select start date to find quantity in database and datetimepicker2 for select finish date

then when i select two data in listbox and i use MessageBox.Show("test :" ); for break to show my chart

this picture will show value of first product
http://image.ohozaa.com/view/8146t

then when i click on messagebox will show second product

http://image.ohozaa.com/view/81473

then you can see the value of first product in blue line will change value like second product Frown | :(

this is my database on mysqlserver 2005

http://image.ohozaa.com/view/8147g

thank you for your answer to much Smile | :)

Luc Pattyn28-Jan-12 22:38

Luc Pattyn

28-Jan-12 22:38

I don't know what kind of charting component you are using nor how it works, however
chart1.DataSource = ds.Tables["Order1"];
looks very suspicious to me: the last row selected will set the final value of DataSource, so I am not surprised all series shown refer to it.

The chart probably needs a single table that holds all the data, so each series can point to one column of that one table.

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

pongpanut29-Jan-12 0:10

29-Jan-12 0:10

thank you for all reply

now i'm try to use datatable but it have same problem

this is my code

datatb = new DataTable();
da.Fill(datatb);
chart1.DataSource = datatb;

i don't know why it's wrong

i really need your help Frown | :(

i'm so new in c#

please Frown | :(

OriginalGriff28-Jan-12 23:08

28-Jan-12 23:08

I would agree with Luc that a DataTable would be more use than a DataSet - if you only use one table, then there is no point in allowing for others.

But looking at your images, it looks right.

You have a limited range of dates, all of which fall within your start and end dates, and the graph looks right - assuming that you are only using an ID_product of 18 - your SELECT query will only return 3 rows (since I suspect the BETWEEN ignores the entry on the 29th because it is after the start of the day.

What did you expect it to look like?

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

pongpanut29-Jan-12 1:58

29-Jan-12 1:58

i try to use data table but it show same problem i don,t know what's wrong Sigh | :sigh:

OriginalGriff29-Jan-12 2:06

29-Jan-12 2:06

As I said - from the data you showed, it looked right - what are you expecting to see?

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

pongpanut29-Jan-12 2:16

29-Jan-12 2:16

data in chart not like in my database

ID_Product = 14 have quantity 19 at(26/1/2555) ,1 at(28/1/2555) ,8 at(29/1/2555)

and

ID_Product = 18 have quantity 1 at(25/1/2555) ,1 at(27/1/2555) ,5 at(28/1/2555) and 3 at(29/1/2555)

but in chart why shown same value

please help me i'm stuck this problem for 2 day if i fix this ploblem it's will help for my project to much Sigh | :sigh:

OriginalGriff29-Jan-12 2:58

29-Jan-12 2:58

Ah. Ok. that makes some sense.

You are using the same data values for each series: I'm not sure exactly what you need to do to fix that (I don't use the Microsoft Chart control) but it looks like a Chart control always takes it's data from a single table. This is taken and adapted from their example:

// Create an empty table.
DataTable table = new System.Data.DataTable("Table1");

// Add three columns to the table.
table.Columns.Add("Category", typeof(String));
table.Columns.Add("Value", typeof(Double));
table.Columns.Add("SecondValue", typeof(Double));

// Add data rows to the table.
table.Rows.Add(new object[] { "Lost", 0, 17 });
table.Rows.Add(new object[] { "Very Good", 1, 5 });
table.Rows.Add(new object[] { "Good", 2, 0 });
table.Rows.Add(new object[] { "Unlikely", 3, 9 });
table.Rows.Add(new object[] { "Firm Order", 4, 1 });
DataSet set = new DataSet();

set.Tables.Add(table);
chart1.DataSource = set.Tables[0].DefaultView;
//chart1.DataSource = dv3;

chart1.Series["Series1"].XValueMember = "Category";
chart1.Series["Series1"].YValueMembers = "Value";
chart1.Series.Add("Series2");
chart1.Series["Series2"].XValueMember = "Category";
chart1.Series["Series2"].YValueMembers = "SecondValue";
chart1.DataBind();

This does show two independent data plots, but from the same table. If it is the case that it always works from the same table, then you will have to either change your SELECT statement to return multiple columns (a PITA when you are dealing with user-selectable columns) or manually create a table, create the columns you need and add the data points to the appropriate columns. Not difficult, but fiddly and a bit messy. There may be an easier way, but I don't know what it is.

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

Luc Pattyn29-Jan-12 8:35

Luc Pattyn

29-Jan-12 8:35

I would go for a single SQL statement that fills a single table with all required information, it would look somewhat like this:

select NAME_Product from Product where  Product.ID_Product IN ( '"+str1+"' ",  '"+str2+"' ",  '"+str3+"' )

and you may want to append GROUP BY Product.ID_Product

So you would need:
- a loop to build the one SQL statement
- the execution of that SQL stm resulting in one DataTable
- a loop to tell your chart where to find all the data series

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

Luc Pattyn28-Jan-12 22:12

Luc Pattyn

28-Jan-12 22:12

Luc Pattyn [My Articles] Nil Volentibus Arduum

Fed up by FireFox memory leaks I switched to Opera and now CP doesn't perform its paste magic, so links will not be offered. Sorry.

pongpanut28-Jan-12 22:23

Writing source code in seperate files

28-Jan-12 22:23

http://image.ohozaa.com/view/81473[^]

this is my new link Smile | :)

output

Fred 3427-Jan-12 22:27

Fred 34

27-Jan-12 22:27

How can we write the long source of a program in
2 or 3 files and relate them together at build time.

Richard MacCutchan27-Jan-12 22:37

Richard MacCutchan

27-Jan-12 22:37

Use Partial Classes[^].

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Eddy Vluggen27-Jan-12 23:44

Eddy Vluggen

27-Jan-12 23:44

I rather think he has five source-files (.cs) that should be linked to a single executable. The IDE does that for us Smile | :)

Bastard Programmer from Hell Suspicious | :suss:

Richard MacCutchan28-Jan-12 0:19

Richard MacCutchan

28-Jan-12 0:19

The question (as with so many) is somewhat open to interpretation. Frown | :(

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Eddy Vluggen28-Jan-12 5:19

Eddy Vluggen

28-Jan-12 5:19

Yes, but the wording "two or three files" are a give-away.

..with everybody recommending on how to distribute classes over multiple files Big Grin | :-D

Bastard Programmer from Hell Suspicious | :suss:

Richard MacCutchan28-Jan-12 5:26

Richard MacCutchan

28-Jan-12 5:26

Which is why I made the suggestion that I did.

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman