The Weird and The Wonderful

Jeroen De Dauw5-Aug-11 13:20

Jeroen De Dauw

5-Aug-11 13:20

Why is he copying the code?! He could just call the function this stuff is in again, and have it be properly recursive as a bonus.

Jeroen De Dauw (blog | Twitter | Identi.ca)

BillW336-Aug-11 1:07

BillW33

6-Aug-11 1:07

That is a really brilliant bit of code. Roll eyes | :rolleyes:

Just because the code works, it doesn't mean that it is good code.

Richard X Menezes8-Aug-11 5:08

Richard X Menezes

8-Aug-11 5:08

Completely agree to you. And am the one responsible for their deliverables, as I am their lead. Frown | :(

Richard Menezes

Hopeless cases [modified]

Tom Chantler9-Aug-11 2:46

Tom Chantler

9-Aug-11 2:46

Don't mention that there's an error, just show him the code and ask him why he shouldn't be fired for being a total moron! If he is actually any good, he'll laugh about it and say, "Oh yeah, you're right, maybe you'll have to let me go!"

Infinite Loop

Colin Mullikin5-Aug-11 5:12

Colin Mullikin

5-Aug-11 5:12

While trying to find a possible infinite loop, I added the second line below:

Delphi

while true do begin
  Reset(CurrFile);
  ReadLn(CurrFile,Pierce);

The break statement to exit the while loop depends on making it to a specific line in the file. Since I already read some lines before this, I thought just in case the line I was waiting for was above them, I would reset the file. After debugging this a few times, I realized that I was an idiot, and I moved the reset to just before the while... Sigh | :sigh:

The United States invariably does the right thing, after having exhausted every other alternative. -Winston Churchill

America is the only country that went from barbarism to decadence without civilization in between. -Oscar Wilde

Wow, even the French showed a little more spine than that before they got their sh*t pushed in.[^] -Colin Mullikin

Re: Infinite Loop

Gary R. Wheeler7-Aug-11 0:55

Gary R. Wheeler

7-Aug-11 0:55

I'm sure I've done that one. More than once.

Hangs head in shame...

Software Zen: delete this;

Lutosław4-Aug-11 22:44

Lutosław

4-Aug-11 22:44

Java

// ...
switch(getRodzajSprawy()){
case Biletowa:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(true);
	
	
	// Druki ścisłej rejestracji / Wezwanie do zapłaty		
	if(initData){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		prepareTrainCombo(true);
		trainCombo.setSelection(new StructuredSelection(Common.nullLongComboModel));
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dwaDniTemu);
		editTrescReklamacjiText.setInput("zwrot za bilet");
	}
	if(isEdit && previousComplaintType != null){
		//someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		if(!previousComplaintType.equals(ComplaintTypeEnum.Biletowa) && !register3911ChangeToTheSame)
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		prepareTrainCombo(true);
		trainCombo.setSelection(new StructuredSelection(Common.nullLongComboModel));
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dwaDniTemu);
		//editTrescReklamacjiText.setInput("zwrot za bilet");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case BiletowaMiedzynarodowa:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(true);
	
	prepareTrainCombo(true);
	// Druki ścisłej rejestracji / Wezwanie do zapłaty
	if(initData){
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		if(!previousComplaintType.equals(ComplaintTypeEnum.BiletowaMiedzynarodowa) && !register3911ChangeToTheSame)
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case Bezbiletowa:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(true);
	
	
	// Druki ścisłej rejestracji / Wezwanie do zapłaty
	if(initData){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		prepareTrainCombo(true);
		trainCombo.setSelection(new StructuredSelection(Common.nullLongComboModel));
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dwaDniTemu);
		editTrescReklamacjiText.setInput("anulowanie wezwania");
	}
	if(isEdit && previousComplaintType != null){
		//someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		if(!previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		prepareTrainCombo(true);
		trainCombo.setSelection(new StructuredSelection(Common.nullLongComboModel));
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dwaDniTemu);
		if(!previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
	}
	someControl.setText(textForCallsToPay);
	someControl.setDrukiScRejSection(textForCallsToPay);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case RoszczeniaKomMiedzynarodowa:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(true);
	
	
	// Druki ścisłej rejestracji / Wezwanie do zapłaty			
	if(initData){
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		prepareTrainCombo(false);
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		if(!previousComplaintType.equals(ComplaintTypeEnum.RoszczeniaKomMiedzynarodowa))
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		prepareTrainCombo(false);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case RoszczeniaKomKrajowa:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(true);
	
	
	// Druki ścisłej rejestracji / Wezwanie do zapłaty			
	if(initData){
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		prepareTrainCombo(false);
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		if(!previousComplaintType.equals(ComplaintTypeEnum.RoszczeniaKomKrajowa))
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		prepareTrainCombo(false);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case Odstapienie:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(true);
	
	prepareTrainCombo(true);
	// Druki ścisłej rejestracji / Wezwanie do zapłaty			
	if(initData){
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		//prepareTrainCombo(true);
		prepareDokUlgCombo(true);
		prepareOryginalBiletuCombo(true);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		if(!previousComplaintType.equals(ComplaintTypeEnum.Odstapienie))
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		//prepareTrainCombo(true);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(true);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(true);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case Skargi:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(false);
	
	prepareTrainCombo(true);
	// Druki ścisłej rejestracji / Wezwanie do zapłaty			
	if(initData){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		//prepareTrainCombo(true);
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		if(!previousComplaintType.equals(ComplaintTypeEnum.Skargi) && !register51ChangeToTheSame)
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		//prepareTrainCombo(true);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
		receiversTableTemp.removeAll();
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case Wnioski:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(false);
	
	prepareTrainCombo(true);
	// Druki ścisłej rejestracji / Wezwanie do zapłaty			
	if(initData){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		//prepareTrainCombo(true);
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		if(!previousComplaintType.equals(ComplaintTypeEnum.Wnioski) && !register51ChangeToTheSame)
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		//prepareTrainCombo(true);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
		receiversTableTemp.removeAll();
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
case PytaniaInf:
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	editIncomeDate.getDateValidatableViewer().getTrigerButton().setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(true);
	someControl.setRequired(true);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(false);
	someControl.setRequired(false);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	someControl.setExpanded(false);
	someControl.setEnabled(false);
	
	prepareTrainCombo(true);
	// Druki ścisłej rejestracji / Wezwanie do zapłaty			
	if(initData){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		//prepareTrainCombo(true);
		prepareDokUlgCombo(false);
		prepareOryginalBiletuCombo(false);
		someControl.setInput(dzis);
		editTrescReklamacjiText.setInput("");
	}
	if(isEdit && previousComplaintType != null){
		someControl.setInput(null);
		someControl.setInput(null);
		someControl.setInput(null);
		if(!previousComplaintType.equals(ComplaintTypeEnum.PytaniaInf) && !register51ChangeToTheSame)
			editNumerReklamacjiText.setInput(createComplaintNumber(rodzSpr));
		else
			someControl.setInput(prevComplaintNumber);
		//prepareTrainCombo(true);
		tmpSel = editDokUlgCombo.getSelection();
		prepareDokUlgCombo(false);
		someControl.setSelection(tmpSel);
		tmpSel = editOryginalBiletuCombo.getSelection();
		prepareOryginalBiletuCombo(false);
		someControl.setSelection(tmpSel);
		//someControl.setInput(dzis);
		//editTrescReklamacjiText.setInput("");
		if(previousComplaintType.equals(ComplaintTypeEnum.Bezbiletowa))
			editDrukScRejList.setItems(new ArrayList(0));
		receiversTableTemp.removeAll();
	}
	someControl.setText(textForTickets);
	drukiScRejSection.layout();
	someControl.setDrukiScRejSection(textForTickets);
	someControl.setEnabled(true);
	someControl.setEnabled(true);
	someControl.setEnabled(false);
	someControl.setEnabled(false);
	break;
default:
	
// ...

note: I have replaced names of controls and removed commentaries, to protect property.

Greetings - Jacek

modified on Friday, August 5, 2011 4:59 AM

V.4-Aug-11 23:47

4-Aug-11 23:47

Yup, you can send it to The daily WTF[^]

Freak305-Aug-11 2:43

Freak30

5-Aug-11 2:43

editTravelDate.getDateValidatableViewer().getTrigerButton().setEnabled(false);

What's a triger button? Is it somewhat related to a tiger button? Striped one maybe? Big Grin | :-D

Ian Shlasko5-Aug-11 3:24

Ian Shlasko

5-Aug-11 3:24

There's a three-part solution to this little problem...

0) Find the person who wrote that code
1) Erase every line of code they've ever written, and reformat every disk it's ever touched, just to be safe
2) Introduce them to the exciting new opportunities in the food services industry

Proud to have finally moved to the A-Ark. Which one are you in?
Author of the Guardians Saga (Sci-Fi/Fantasy novels)

fjdiewornncalwe5-Aug-11 3:33

fjdiewornncalwe

5-Aug-11 3:33

It would have taken them a long time to get that code out...
If they translate that behavior into serving me my fries, they'll never get to me warm, never mind hot.

I wasn't, now I am, then I won't be anymore.

Ian Shlasko5-Aug-11 4:07

Ian Shlasko

5-Aug-11 4:07

Hmm... Maybe that's how the person ended up in software development...

"You can't cook fries, you can't flip burgers, and you can't operate a cash register... You're just not cut out for fast food... Have you ever considered learning Java?"

Proud to have finally moved to the A-Ark. Which one are you in?
Author of the Guardians Saga (Sci-Fi/Fantasy novels)

Lutosław5-Aug-11 3:50

Lutosław

5-Aug-11 3:50

It has been written using an append and don't touch anything else or everything blows method. It is a three-year history code, with no unit tests, so...

Greetings - Jacek

Re: Hopeless cases [modified]

Ian Shlasko5-Aug-11 4:08

Ian Shlasko

5-Aug-11 4:08

Hmm... Good point.

Format twice, just to be sure.

Proud to have finally moved to the A-Ark. Which one are you in?
Author of the Guardians Saga (Sci-Fi/Fantasy novels)

John Y.17-Nov-11 7:06

John Y.

17-Nov-11 7:06

My mouth is just wide open... speechless

________
John Y.
Developer

SQL between

wizardzz28-Jul-11 11:42

wizardzz

28-Jul-11 11:42

Ugh, I just hate the bad usage of BETWEEN in SQL in some legacy SP's at my work.

Horrible to use for finding values between a date range, when the date range can be 1 day, ugh!

"I have a theory that the truth is never told during the nine-to-five hours. "
— Hunter S. Thompson

GuyThiebaut30-Jul-11 11:47

GuyThiebaut

30-Jul-11 11:47

I'm not keen on the between keyword either - I always have to test if between means exclude or include the bounds.
I much prefer >= and <=.

Continuous effort - not strength or intelligence - is the key to unlocking our potential.(Winston Churchill)

OriginalGriff30-Jul-11 22:49

OriginalGriff

30-Jul-11 22:49

I dunno - I do remember that between is inclusive, so I tend to see it as more readable, generally.
However, most of the time I do use explicit tests instead, because I don't want to include the upper or lower bound. Ho Hum.

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

Manfred R. Bihy: "Looks as if OP is learning resistant."

GuyThiebaut30-Jul-11 23:32

GuyThiebaut

30-Jul-11 23:32

I was thinking about why I find something like the word "between" so confusing.

I think the reason follows on from the VB versus C# discussion[^] that was going on in the lounge.

To explain this it goes something like this for me: if someone told me to kick a ball "between" the goal posts this would mean to me to hit anywhere "inbetween" the goal posts and not hit the goal posts themselves.

So for me there is a certain ambiguity in the meaning of "between".
Whereas >= and <= holds no ambiguity for me and this is partly why I like C# over VB - the lack of verbosity seems to make it easier for me to understand...

Maybe I am just too curmudgeonly...

Continuous effort - not strength or intelligence - is the key to unlocking our potential.(Winston Churchill)

OriginalGriff30-Jul-11 23:41

OriginalGriff

30-Jul-11 23:41

Yes, there is a difference between words in English and word in coding languages, generally in terms of precision.

The main reasons I prefer C# to VB is that is is more precise: in VB DataRows(17) could be an array element or a function call, in C# the difference is clear. Plus I hate the general use of var, automatic (and normally wrong) casting and don't get me started with On Error Resume Next Laugh | :laugh:

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

Manfred R. Bihy: "Looks as if OP is learning resistant."

Robert Rohde31-Jul-11 18:07

Robert Rohde

31-Jul-11 18:07

OriginalGriff wrote:
in VB DataRows(17) could be an array element or a function call,
in C# the difference is clear

As much as I prefer C# over VB.NET this is not true.
DataRows[17] could either be an array access or a call to an indexer which is nothing else than a method call.

Robert

Lutosław1-Aug-11 23:22

Lutosław

1-Aug-11 23:22

Robert Rohde wrote:
DataRows[17] could either be an array access or a call to an indexer which is nothing else than a method call.

An indexer is an operator which is supposed to simulate accessing array's elements by sth like index, so the meaning is clear. A problem appears whe a coder implements an indexer which, for example, serializes an object to a file. However, if a coder knew about a "hidden feature" like indexers the he probably wouldn't be so unwise. In VB, if you see DataRows(17) and know that DataRows is a collection, then you think "well probably it is an indexer".

Greetings - Jacek

Firo Atrum Ventus1-Aug-11 23:33

Firo Atrum Ventus

1-Aug-11 23:33

Jacek Gajek wrote:
if a coder knew about a "hidden feature" like indexers then he probably wouldn't be so unwise

Nicely said Thumbs Up | :thumbsup:

Excuse me for my improper grammar and typos.
It's because English is my primary language, not my first language.

My first languages are C# and Java.
VB, ASP, JS, PHP and SQL are my second language.
Indonesian came as my third language.
My fourth language? I'm still creating it, I'll let you know when it's done! Big Grin | :-D