Click here to Skip to main content
15,897,291 members
Home / Discussions / C#
   

C#

 
AnswerRe: Do Lambda expressions smell? Pin
PIEBALDconsult30-Jul-11 6:24
mvePIEBALDconsult30-Jul-11 6:24 
GeneralRe: Do Lambda expressions smell? Pin
jschell30-Jul-11 7:45
jschell30-Jul-11 7:45 
AnswerRe: Do Lambda expressions smell? Pin
jschell30-Jul-11 7:46
jschell30-Jul-11 7:46 
AnswerRe: Do Lambda expressions smell? Pin
BobJanova31-Jul-11 22:45
BobJanova31-Jul-11 22:45 
QuestionCreate array in class. Pin
Herboren29-Jul-11 9:49
Herboren29-Jul-11 9:49 
AnswerRe: Create array in class. Pin
Member 448708329-Jul-11 10:06
Member 448708329-Jul-11 10:06 
GeneralRe: Create array in class. [modified] Pin
Herboren29-Jul-11 10:35
Herboren29-Jul-11 10:35 
GeneralRe: Create array in class. Pin
Keith Barrow30-Jul-11 0:28
professionalKeith Barrow30-Jul-11 0:28 
Your class looks pretty good, here are some suggestions to tighten it up:

string[] _clArray;


Don't have members with typenames, this should be _cl (or _cla if the a means something other than array). For one thing it is redundant, secondly it is against naming conventions, thirdly names should be meaningful (using array might make sense in an type classing a solar panel array for example). The Microsoft guidance is not to prefix fields (with "_" for example), but I (and most of the people I know do this, as it is internal other devs won't see it (unless reading your code directly).

You should consider:

public string[] Cla
{
    get { return this._clArray; }
    private set { this._clArray = value; }
}


private prevents the array instance being changed from outide the class. It does lead to problems filling the array, you can do this with the class's constructor or with a specific array-setting method. Personally I'd go for the generic List<string> mentioned earlier by membernnnnnnn. With this you just create the instance inside the object and then can call the it's add method from the get accesssor. Under various circumstances you might want to make the list totally immutable from outside the class, to do this you should get rid of the public accessor you have and look at collection as readonly[^], you can then add Add and Remove methods etc that perform some validation for example.

Note also Cla your class breaks the normal .net naming conventions, you should try to keep to these: the Microsoft classes are written this way and you will confuse other devs using your code by not doing this.

GeneralRe: Create array in class. Pin
BobJanova31-Jul-11 22:49
BobJanova31-Jul-11 22:49 
GeneralRe: Create array in class. Pin
Keith Barrow1-Aug-11 2:16
professionalKeith Barrow1-Aug-11 2:16 
QuestionSOAP versioning limits - loading legacy assembly Pin
lukeer29-Jul-11 3:04
lukeer29-Jul-11 3:04 
AnswerRe: SOAP versioning limits - loading legacy assembly Pin
jschell29-Jul-11 8:27
jschell29-Jul-11 8:27 
GeneralRe: SOAP versioning limits - loading legacy assembly Pin
lukeer31-Jul-11 22:54
lukeer31-Jul-11 22:54 
GeneralRe: SOAP versioning limits - loading legacy assembly Pin
jschell1-Aug-11 7:44
jschell1-Aug-11 7:44 
QuestionKnowing and tracing application memory consumtion and leaks? Pin
Chesnokov Yuriy28-Jul-11 21:24
professionalChesnokov Yuriy28-Jul-11 21:24 
AnswerRe: Knowing and tracing application memory consumtion and leaks? Pin
Dave Kreskowiak29-Jul-11 3:31
mveDave Kreskowiak29-Jul-11 3:31 
GeneralRe: Knowing and tracing application memory consumtion and leaks? Pin
Chesnokov Yuriy29-Jul-11 10:01
professionalChesnokov Yuriy29-Jul-11 10:01 
GeneralRe: Knowing and tracing application memory consumtion and leaks? Pin
Dave Kreskowiak29-Jul-11 11:01
mveDave Kreskowiak29-Jul-11 11:01 
QuestionASF Stream VU Meter Pin
jjdacl28-Jul-11 16:30
jjdacl28-Jul-11 16:30 
AnswerRe: ASF Stream VU Meter PinPopular
Keith Barrow28-Jul-11 23:26
professionalKeith Barrow28-Jul-11 23:26 
GeneralRe: ASF Stream VU Meter Pin
BillWoodruff30-Jul-11 2:28
professionalBillWoodruff30-Jul-11 2:28 
AnswerRe: ASF Stream VU Meter Pin
GuyThiebaut29-Jul-11 2:55
professionalGuyThiebaut29-Jul-11 2:55 
QuestionWhat is best way to declare constants set? Pin
JP_Rocks27-Jul-11 19:26
JP_Rocks27-Jul-11 19:26 
AnswerRe: What is best way to declare constants set? Pin
lukeer27-Jul-11 21:13
lukeer27-Jul-11 21:13 
AnswerRe: What is best way to declare constants set? Pin
Rob Philpott27-Jul-11 23:22
Rob Philpott27-Jul-11 23:22 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.