C / C++ / MFC

if (button1 == NULL)
{
	button1 = ::CreateWindowEx(WS_EX_LEFT,L"button",L"Button1", WS_CHILD ,50,50,50,50,parent,NULL,::GetModuleHandle(NULL),NULL);
	SendMessage(button1, WM_SETFONT, (WPARAM)defFont, MAKELPARAM(TRUE, 0));
	::ShowWindow(button1,SW_SHOW);
}
if (button2 == NULL)
{
	button2 = ::CreateWindowEx(WS_EX_LEFT,L"button",L"Button2", WS_CHILD ,125,50,50,50,parent,NULL,::GetModuleHandle(NULL),NULL);
	SendMessage(button2, WM_SETFONT, (WPARAM)defFont, MAKELPARAM(TRUE, 0));
	::ShowWindow(button2,SW_SHOW);

}

LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch(msg)
	{
		case SW_SHOW:
			break;
		case WM_COMMAND:
			if (wParam == BN_CLICKED)
			{
				Triggered(L"1"); //Shows a messagebox.
			}
			break;
		case WM_SHOWWINDOW:
			Init(hwnd); //Builds the buttons here.
			break;
		case WM_CLOSE:
			DestroyWindow(hwnd);
			break;
		case WM_DESTROY:
			PostQuitMessage(0);
			break;
		default:
			return DefWindowProc(hwnd, msg, wParam, lParam);
	}
	return 0;

}

// The code compiles but it has some problems and
// inefficiencies.  Describe what its trying to do, then
// comment on the bugs and how to fix them.  Also please give suggestions on
// how to improve the method. Name relevant softwareprinciples



bool Item::SetInt( INT_STAT key, int val, UpdateType update )
{

  m_Something->SetInt( key, val );

  int i;
  bool retval;

  byte* buffer = new byte[ 256 ];

  if ( update & No_UpdateType == No_UpdateType )
  {
    return false;
  }


  if ( update & Private_UpdateType == Private_UpdateType )
  {

    for ( i = 0; i < m_numEvents; ++i )
      {
        if ( m_eventFilter[i] == key )
		{
          retval = true;
        } 
		else 
		{
          retval = false;
        }
      }

    if ( retval ) {
      SendPrivateEvent( buffer, key, val );
    }
  }


  if ( update & Public_UpdateType == Public_UpdateType ) 
  {
  
    for ( i = 0; i < m_numEvents; ++i )
      {
         if ( m_eventFilter[i] == key ) 
		 {
           retval = true;
         }
		 else 
		 {
           retval = false;
         }
      }

    if ( retval ) 
	{
      SendPublicEvent( buffer, key, val );
    }
  }


  delete buffer;

  return retval;
}

My Answers:
//This function returns a boolean (true or false);
// if No_UpdateType, this function quits and exits with a return value of false
// if Private_UpdateType || public_UpdateType, we will check to see if the key
//passed in exists in the m_eventFilter Array, if it does, we will "sendPublicNetworkEvent" 
//or "sendPrivateNetworkEvent" respectively

//////////////////////////////////
//Inefficiencies and Suggestions:
//////////////////////////////////
//buffer was never initialized
//buffer in this example is passed as an argumeatnt, but was never implemented (no data assigned to it)
//If the buffer meant to be used as an output, it should have been passed as a refernce (&buffer)

//In the if conditional statements, update is being used as a boolean, to evaluate a boolean expresion with
//a mask - not good practise.

//if m_eventFilter is a larger array, it makes the search for the key expensive,
//it would be more efficient to use a Map for look up
//worst case scenario, if array had to be used, I would break out of the loop once key is found.

//redundant repetitive code

//This switch logic is popular in C++ design patterns, in designs where code reacts to the change of 
//object state, State Design Patterns as well as Observer patterns are ideal.
//So, when updateObjectType changes, the appropriate handler can be called at runtime.