The Weird and The Wonderful

AspDotNetDev wrote:

I wasn't sure if I should put this in "Clever Code" or "Hall of Shame".

Return String.Format("{0} {1} {2}", firstName, middleName, lastName).Replace("  ", " ").Trim()

0. What if, for whatever reason, a user has two consecutive spaces in their first name? Given the variety of cultures, I wouldn't discount this.
1. This version creates several extra and unnecessary strings.
2. Unnecessary CPU time spent scanning the name parts (first/middle/last) for space to replace.

VUnreal wrote:

You can try it at home

static int listSize = 10000000;
static int tests = 10;
static List<int> list = new List<int>();

static void LoopClassic()
{
    DateTime start= DateTime.Now;
    int f;
    for(int i= 0; i< tests; i++)
    {
        for(int j = 0; j < list.Count; j++)
            f = list[j];
    }
    TimeSpan  elapsed = DateTime.Now.Subtract(start);
    Console.WriteLine("Classic: {0}", elapsed.TotalMilliseconds );
}


static void LoopCrufty()
{
    DateTime start = DateTime.Now;
    int f;

    for (int i = 0; i < tests; i++)
    {
        for(int j=0;true;j++)
            try
            {
                f = list[j];
            }
            catch
            {
                break;
            }
    }
    TimeSpan elapsed = DateTime.Now.Subtract(start);
    Console.WriteLine("Crufty: {0}", elapsed.TotalMilliseconds);
}

static void Main(string[] args)
{
    for (int i = 0; i < listSize; i++)
        list.Add(i);
    LoopClassic();
    LoopCrufty();
    Console.ReadKey();
}

static void LoopClassic2()
{
    DateTime start = DateTime.Now;
    int f;
    for (int i = 0; i < tests; i++)
    {
        int count = list.Count;
        for (int j = 0; j < count; j++)
            f = list[j];
    }
    TimeSpan elapsed = DateTime.Now.Subtract(start);
    Console.WriteLine("Classic2: {0}", elapsed.TotalMilliseconds);
}

VUnreal wrote:

You made me laugh.

' This sub gets info from the database.
Public Sub GetInfoFromDataBase(connString As String)
'blah blah blah...

' Open the connection.
conn.Open

' Check if the value is not DBNull or Nothing.
If dataRow("someColumn").Value IsNot DBNull.Value AndAlso dataRow("someColumn").Value IsNot Nothing Then
' Do stuff...
End If

'etc.
End Sub

/// <summary>
///  Method Name
/// </summary>
public void MethodName()
{
//uncommented code here...
}