C / C++ / MFC

goldenrose9 wrote:

as it is not initialized using new/malloc, so i cannot use delete[]/free.

Yusuf wrote:

delete reader

delete reader

delete []reader

delete [] reader;

std::vector<char> read_from_file( std::size_t bytes_to_read )
{
    std::vector<char> bytes_read( bytes_to_read );
    std::size_t number_bytes_read = 0;
    ReadFile( handle_of_file, &bytes_read[ 0 ], &number_of_bytes_read, 0 );
    return bytes_read;
}

std::vector<char>& read_from_file( std::size_t bytes_to_read, std::vector<char> &bytes_read )
{
    bytes_read.reserve( bytes_to_read );
    std::size_t number_bytes_read = 0;
    ReadFile( handle_of_file, &bytes_read[ 0 ], &number_of_bytes_read, 0 );
    bytes_read.resize(number_of_bytes_read);
    return bytes_read;
}

Niklas Lindquist wrote:

bytes_read.reserve( bytes_to_read );

goldenrose9 wrote:

3rd parameter is missing in the ReadFile()

goldenrose9 wrote:

Can i use BYTE instead of char to read the file

std::vector<BYTE> bytes_read;

std::vector<std::string> bytes_read;

A some_function()
{
    A a;

    /* Other stuff */

    return a;
}

void some_function( memory_block_the_size_of_a &a )
{
    new( &a ) A;

    /* Other stuff */
}

A a = some_function();

memory_block_the_size_of_a block;
A &a( *reinterpret_cast<A *>( block ) );
some_function( &block );

/* Other stuff */

a->~A();

A a = some_function( b );

const size_t wanted_chunk_size = 512;
std::vector<char> buffer;
do
{
    read_from_file(wanted_chunk_size, buffer);
    write_to_somewhere(buffer);
}
while (buffer.size() == wanted_chunk_size);

Aescleal wrote:

you can actually end up with slower code if someone writes (naively):

A a = some_function( b );

as you still end up triggering the copy constructor.

Aescleal wrote:

- It's assignment not copy construction (so A a = some_function() can invoke NRVO while a = some_function() won't).