C / C++ / MFC

Re: Hello i hooked readprocessmemory and have some problems logging its lpBuffer

1-Jan-11 21:40

nah1337 wrote:

char* mybytes = (char*)lpBuffer;

Change it to :

unsigned char* mybytes = (unsigned char*)lpBuffer;

Just say 'NO' to evaluated arguments for diadic functions! Ash

nah13371-Jan-11 21:46

nah1337

1-Jan-11 21:46

Hi, it did not make any difference the log is still same:

Here is the output

lpBuffer: 4d

lpBuffer: 5a

lpBuffer: 90

lpBuffer: 0

lpBuffer: 3

lpBuffer: 0

lpBuffer: 0

lpBuffer: 0

lpBuffer: 4

lpBuffer: 0

lpBuffer: 0

lpBuffer: 0

Re: Hello i hooked readprocessmemory and have some problems logging its lpBuffer

Richard MacCutchan1-Jan-11 22:05

Re: Hello i hooked readprocessmemory and have some problems logging its lpBuffer

1-Jan-11 22:05

I'm sorry but I don't see what is wrong with this ouptut; it is the same sequence of bytes shown in your orignal message as received in your memory buffer.

Just say 'NO' to evaluated arguments for diadic functions! Ash

nah13371-Jan-11 22:16

nah1337

1-Jan-11 22:16

I wanted to log them straight out i mean like in row not as separated like my log functions does it, but if that is impossible then its ok for me.

Re: Hello i hooked readprocessmemory and have some problems logging its lpBuffer

Richard MacCutchan2-Jan-11 1:10

2-Jan-11 1:10

nah1337 wrote:
wanted to log them straight out i mean like in row

Well, it's just a matter of correcting your code so that you do not log each item on a separate line.

Just say 'NO' to evaluated arguments for diadic functions! Ash

LPCWSTR Problem.?

goldenrose91-Jan-11 19:24

goldenrose9

1-Jan-11 19:24

Hi to everybody,
I am creating a native win32 dll with the following function.

LPCWSTR __stdcall DisplayInfo()
{
        wchar_t* hello =_T("Yahoooooooooo!");
	return (LPWSTR)hello;
}

Program compiles successfully. But when i use it in my visual basic application, the entire IDE crashes.

Private Declare Function DisplayInfo Lib "dllexample1" () As String


Private Sub Command1_Click()
   MsgBox DisplayInfo
End Sub

Help?????

:: Roses ::

Richard MacCutchan2-Jan-11 1:14

2-Jan-11 1:14

I'm no expert, but I do not think you can call a C++ function directly like this, and expect a String to be returned. I would suggest posting your question in the Visual Basic forum, as someone there will probably know the answer.

Just say 'NO' to evaluated arguments for diadic functions! Ash

User 74293382-Jan-11 3:47

User 7429338

2-Jan-11 3:47

The hello string is a local variable within the DisplayInfo() function; so when you return, the memory is freed. You return a pointer to the string, but the string's memory got overwritten.

To fix this this particular problem, you could make hello a static variable; this will keep its address valid after returning.

Another, more generally usable way would be to pass a string variable to DisplayInfo() and copy hello's content to it inside the function.

modified 13-Sep-18 21:01pm.

CPallini2-Jan-11 5:03

2-Jan-11 5:03

Actually, in this particular case, the local variable points to a string literal that is, of course, not freed.
Smile | :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Stefan_Lang9-Jan-11 23:54

Stefan_Lang

9-Jan-11 23:54

I wouldn't be too sure about that. The variable hello is not declared const, so it would be valid to modify the content of this string later in the code like this:

hello[3]=0;

This means the compiler does have to create a local string variable on the stack, inside this function. And this particular string variable will indeed be destroyed upon return.

You might argue that there is no such modification, but since the function itself passes a (non-const) pointer to this string, the caller might modify the contents instead! Also, later calls to that function need to initialize hello with the original string, not an address to a presumed literal which in the meantime might have been changed to god knows what. So what you'll want to pass is a copy of the literal being used for intialization, not the address of the literal itself!

CPallini10-Jan-11 0:21

10-Jan-11 0:21

Stefan63 wrote:
This means the compiler does have to create a local string variable on the stack, inside this function. And this particular string variable will indeed be destroyed upon return.

You are wrong, at least on Microsoft compiler, these strings have static storage duration, see http://msdn.microsoft.com/en-us/library/0h227906.aspx[^].
Smile | :)

Stefan_Lang10-Jan-11 0:45

Stefan_Lang

10-Jan-11 0:45

Duh

Microsoft wrote:
Microsoft Specific

You win

P.S.:
if a DLL uses a static variable, and gets called just once, will the variable be released after the last (and only) call, or at the end of the lifetime of the application that calls it?

I'm pretty sure about a C++ app calling a C++ DLL; but not so much about another language app that might use other DLL bindings...

CPallini10-Jan-11 0:58

Re: LPCWSTR Problem.? [modified]

10-Jan-11 0:58

Actually it looks a more general fact, see, for instance http://stackoverflow.com/questions/267114/scope-of-string-literals[^] (look at reported sentences of the C++ standard).

Static variables are, ehm, static, in other words, must be there...
Smile | :)

Stefan_Lang10-Jan-11 2:44

Stefan_Lang

10-Jan-11 2:44

Thanks for the link. My problem with the original question was that I didn't notice the 'C' part of the return type, assuming it was LPWSTR, like the cast on the return statement. Also the variable hello is not a const string pointer. At the very least the local variable used to temporarily store a pointer to the literal is a non-const pointer however, and thus should be usable for modifying the string it points to!

I've tested it in Visual Studio though, and it appears that even a non-const string pointer initialized to point to a string literal may not be used to change that literal: code that tries to do this does compile without warnings, but when run causes a run-time exception. For all I know this behaviour is Microsoft Specific.

Consider this example

char* DisplayInfo()
{
   char* hello = "hello!";
   return hello;
}

int _tmain(int argc, _TCHAR* argv[])
{
   char* h = DisplayInfo();
   if (strlen(h)>0)
       h[0] = 0;
	return 0;
}

When you call DisplayInfo, normally all you should care about is the function prototype, which states it returns a pointer to characters. By testing the string length you assert that the pointer is non-zero and points to an array of characters of non-zero length. it should be totally legitimate to alter individual characters within that array, as the return type was non-const.

But it turns out doing so might result in a run-time error, depending on how DisplayInfo is being implemented, and based on how string literals are being treated, even when dealing with non-const string types!

The link you provided mentions const string types only, and thus doesn't apply here - this is indeed compiler-specific, and might indeed just be Microsoft Specific.

Regarding my PS question: I was just being overly cautious. A dynamic library will only be loaded once it's used, not neccessarily upon starting the application that uses it. So the static variables will not exist from the start. I wondered whether for similar reasons the DLLs might be discarded once they are no longer needed. But of course, that is absurd, as the application wouldn't know in advance when a DLL is being called for the last time... Blush | :O

P.S. (another one):
I just noticed that the last section of the quote from the standard states

The C++ Standard wrote:
The effect of attempting to modify a string literal is undefined.

This implies you do in fact have a non-const string pointer. Before it says

The C++ Standard wrote:
An ordinary string literal has type "array of n const char"

(or const wchar_t).

How can you modify const char? I am confused now Confused | :confused:

modified on Monday, January 10, 2011 8:52 AM

Re: LPCWSTR Problem.? [updated]

CPallini2-Jan-11 5:12

2-Jan-11 5:12

It looks like VB6, isn't it?
As far as I know the Visual Basic Runtime takes for granted that DLLs' functions use ANSI strings and takes care about the conversions, hence you have to use char* instead of wchar_t* inside your DisplayInfo function.

BTW have a look, for instance, at the following tutorial http://www.programmers-corner.com/tutorial/4[^].

[update]
Please note you mustn't return the string that way, you should instead modify the passed buffer, see this MSDN article[^].
[/update]

Smile | :)

modified on Sunday, January 2, 2011 12:33 PM

Sauro Viti2-Jan-11 5:39

Sauro Viti

2-Jan-11 5:39

As far as I know, the VB6 strings are unicode and their VC correspondant is the BSTR type...

CPallini2-Jan-11 5:59