C#

Object name: ProgressForm'.
   at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
   at ProgressForm.SetProgressDescription(String description)
   at Mycomponent.UpdateProgressDialogDescription(String description)
   at Mycomponent.Initialize(Int32 hashCode, Int32 numSeries, Int32[] nInstances)
   at 
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.runTryCode(Object userData)
   at System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()</ExceptionString></Exception></TraceRecord>
An unhandled exception of type 'System.ObjectDisposedException' occurred in System.Windows.Forms.dll
<pre>


Cheers,
Keith

at ProgressForm.SetProgressDescription(String description)

if (this.InvokeRequired)
{
   ProgressValueDelegate pvd = new ProgressValueDelegate(SetProgressValue);
   this.Invoke(pvd, new object[] { value });
   return;
}
else
{
   m_progressBar.Value = value;
}

ISyncronizeInvoke sync = (ISyncronizeInvoke)this;
if (sync != null)
{
    if(sync.InvokeRequired)
    {
        ProgressValueDelegate pvd = new ProgressValueDelegate(SetProgressValue);
        object[] args = { value };
        sync.Invoke(pvd, args);
        return;
    }
    else
    {
        m_progressBar.Value = value;
    }
}

private volatile bool formClosed = false;

private void Form1_FormClosing(object sender, FormClosingEventArgs e)
{
    formClosed = true;
}

delegate void ProgressValueDelegate(int value); 
public void SetProgressValue(int value)
{
    if (this.InvokeRequired)
    {
       ProgressValueDelegate pvd = new ProgressValueDelegate(SetProgressValue);                
       this.Invoke(pvd, new object[] { value });
    }
    else
    {
       if( formClosed == false )
       {
           m_progressBar.Value = value;
       }
    }
}

HuntrCkr wrote:

you can also move the if

public void SetProgressValue(int value)
{
    if( formClosed == true )
    {
        return;
    }

    if (this.InvokeRequired)
    {
       ProgressValueDelegate pvd = new ProgressValueDelegate(SetProgressValue);                
       this.Invoke(pvd, new object[] { value });
    }
    else
    {
        m_progressBar.Value = value;
    }
}

Luc Pattyn wrote:

My mistake. You're right about the test, if it sits on the top of the method, it gets executed twice so it can't go wrong. However executing it twice all the time may be a high price to pay for potentially saving one thread switch when the form closes.

Luc Pattyn wrote:

I do not really agree on the BeginInvoke issue.

public void SetProgressValue(int value)
{
    MethodInvoker method = delegate
    {
        if (!formClosed)
        {
            m_progressBar.Value = value;
        }
    };
 
    if (InvokeRequired)
        BeginInvoke(method);
    else
        method.Invoke();
}