Re: string copy problem in structure variable - C / C++ / MFC Discussion Boards

Re: Font of command buttons on property pages

prasad_som6-May-07 20:59

6-May-07 20:59

There are standard ids for cancel , help,ok button(IDCANCEL,IDHELP,IDOK).
About other buttons, you may need to take help of spy utility to find their ids.

Prasad
MS MVP - VC++

how to wisely use memory to store data

cy163@hotmail.com5-May-07 1:18

cy163@hotmail.com

5-May-07 1:18

I created a struct
[code]
struct S{

char Name[20];
int score;

}
[/code]
to store personal info of a lot of people. I need to store the data into hard disk file for later use. i use CFile.write(....) for this purpose.

My problem is that some memory space is wasted due to the design of the struct, since it is often that one' name is much less than 20 characters. In the above design, whenever a new structure is created by 'new', 24 bytes memory space is used.

I also designed another structure to solve this problem,

<br />
sturct S{<br />
string Name;<br />
int score;<br />
}<br />
<br />

However, this design had problem with the write() function of CFile. I found that actually nothing had written into the 'Name' item of a structure when I tried to read out the data from the file, but it is normal for the 'score' item of the same structure.

Anyone please tell how to solve this problem.

Thanks.

Re: how to wisely use memory to store data

Hans Dietrich5-May-07 2:14

Hans Dietrich

5-May-07 2:14

You talk about memory space and then you talk about writing data to disk. Are you concerned with in-memory space, or the space used on the disk?

In memory, you could change the struct to contain a pointer to the char string, which you could allocate with new. The pointer would cost 4 bytes, plus the length of the char string. Not that much savings, unless you're dealing with huge populations, and then I think you have quite a different problem.

On the disk, you could do several things. 1) compress the records; 2) write the records as char strings - "NAME,100" - terminated with the usual line endings. Simple, but it eliminates the unused bytes, and unless you're dealing with huge populations, saving a million bytes on the disk seems like a waste of effort.

Best wishes,
Hans

Re: how to wisely use memory to store data

Mark Salsbery5-May-07 6:48

Mark Salsbery

5-May-07 6:48

To add to Hans Dietrich's reply...

Serialization works good for this IMO.

You could make the class(struct) serializable -

// Note:  Simple example - missing overrun checking, error handling, etc.
 
struct S{
   char Name[20];
   int score;
 
   void Serialize(CFile &file);
   void Unserialize(CFile &file);
}
 
void S::Serialize(CFile &file)
{
   WORD wStrLen = (WORD)strlen(Name);
   file.Write(&wStrLen, sizeof(WORD));
   if (wStrLen > 0)
      file.Write(Name, wStrLen);
   file.Write(&score, sizeof(int));
}
 
void S::Unserialize(CFile &file)
{
   WORD wStrLen;
   file.Read(&wStrLen, sizeof(WORD));
   if (wStrLen > 0)
      file.Read(Name, wStrLen);
   Name[wStrLen] = '\0';
   file.Read(&score, sizeof(int));
}

To write an S object to a file, call Serialize().
To read an S object from a file, call Unserialize().

Also, since you're using MFC, MFC's built-in CObject serialization is available.

Mark

"Posting a VB.NET question in the C++ forum will end in tears." Chris Maunder

string copy problem in structure variable

amitmistry_petlad 5-May-07 0:21

amitmistry_petlad

5-May-07 0:21

Hi!
Need help to copy string in the structure variable .

following is my structure,

struct argument_list
{
WCHAR *pszInFile;
WCHAR *pszOutFil;

Confused | :confused:

what should i have used here string or char *? Confused | :confused:

char* Host; // Initially I had used string but strcpy function does not support to copy the string

char* UserID;
char* InitPackageRequest;
char* ScriptFile;

};

I have made this structure for the thread. to pass the parameter.

for that i have used the following.

struct argument_list *l;
l=(argument_list *)malloc(sizeof(argument_list));

<br />
                        <code>is lstrcpy require here?

l->pszInFile=bufferwithpath;

l->pszOutFil=w_Output;
l->_ProtectSet=_ProtectSet;
l->hList=hList;
//l->Host(HOST);

l->Host=NULL;
strcpy(l->Host,HOST); //got error here

l->hwndEncrypt=hwndEncrypt;
l->hWndinoutfiledir=hWndinoutfiledir;
l->hwndParent=hDlg;
l->InitPackageRequest=NULL;
strcpy(l->InitPackageRequest,sINIT_PACKAGE_RESPONSE.c_str());
l->Port=PORT;
l->ScriptFile=NULL;
strcpy(l->ScriptFile,COMMUNICATOR_SCRIPT_FILE_PATH);

l->UserID=NULL;
strcpy(l->UserID,UserID.c_str());

"Success lies not in the result , But in the efforts !!!!!"
Amit Mistry - petlad -Gujarat-India

Re: string copy problem in structure variable

Hans Dietrich5-May-07 0:49

Hans Dietrich

5-May-07 0:49

amitmistry_petlad wrote:
strcpy(l->Host,HOST); //got error here

You got an error because there is no memory associated with the 'Host' member - it's just a pointer. You must either: 1) allocate memory before the strcpy - for example, l->Host = malloc(...); OR you can change the struct to a specific size for the 'Host' member - for example, char Host[100].

You seem to be confused about the difference between a char* pointer (char *s), and an array of char's (s[100]). You can use either one in the strcpy() function, but if you want to use a pointer, be sure you know where the memory has been allocated.

Re: string copy problem in structure variable

amitmistry_petlad 5-May-07 1:01

amitmistry_petlad

5-May-07 1:01

Thank you very much
sir ! Smile | :)

"Success lies not in the result , But in the efforts !!!!!"
Amit Mistry - petlad -Gujarat-India

Re: string copy problem in structure variable

amistry_petlad12-Apr-10 12:49

amistry_petlad

12-Apr-10 12:49

amit here

How To change degault font of ToolTip control?

Atul234-May-07 23:38

Atul23

4-May-07 23:38

Hi All
I am doing one application in VC++,MFC in which i have to use ToolTip control with font other that default font of system.So if any body have some hint about this query then plz forward me.

Thanks

aaamm

error problem

anu jaggi4-May-07 23:02

anu jaggi

4-May-07 23:02

hello
i'm using HRESULT GetFileDuration(Qword* duration) in win32 to get duration.
For this function i have to add "wmsdk.h and wmsdkidl.h" header files
When i add these files by giving appropriate path i'm facing errors

syntax error : identifier '__RPC__in' c:\wmsdk\wmfsdk11\include\structuredquery.h
syntax error : identifier '__RPC__out' c:\wmsdk\wmfsdk11\include\structuredquery.h ........

there are around 45 such errors

help me to solve this problem
thanks!!

Re: error problem

amitmistry_petlad 4-May-07 23:58

amitmistry_petlad

4-May-07 23:58

Please use the window media format sdk 9.5. in place of 11.

"Success lies not in the result , But in the efforts !!!!!"
Amit Mistry - petlad -Gujarat-India

Create Registry Entry in Vista ...

Manjunath S4-May-07 22:33

Manjunath S

4-May-07 22:33

Hi all,
My Application uses RegCreateKeyEx to create a registry.This appilcation has to work in both windows XP and Vista. In windows XP it create registry successfully ,But in Vista it fails to create registry ...

How do i Solve it ....

Manjunath S
GESL
Bangalore

Re: Create Registry Entry in Vista ...

prasad_som4-May-07 22:50

prasad_som

4-May-07 22:50

Manjunath S wrote:
But in Vista it fails to create registry ...

Vista has lots of restrictions, dealing with registry. You may like to read UAC for that. Search for UAC on MSDN.

Prasad
MS MVP - VC++

Re: Create Registry Entry in Vista ...

Manjunath S4-May-07 22:56

Manjunath S

4-May-07 22:56

Thanks for your reply

Any sample code available to just create a registry in windows Vista ...

Manjunath S
GESL
Bangalore

Re: Create Registry Entry in Vista ...

Sameer_Thakur4-May-07 23:03

Sameer_Thakur

4-May-07 23:03

I faced the same problem with my application.

I used a manifest.xml in my application as a resource and it solved the problem.
Here are the contents of that manifest.xml file.

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity
version="1.0.0.0"
processorArchitecture="X86"
name="CompanyName.ProductName.YourApp"
type="win32"
/>

<description>Your application description here.</description>
<dependency>
<dependentAssembly>
<assemblyIdentity
type="win32"
name="Microsoft.Windows.Common-Controls"
version="6.0.0.0"
processorArchitecture="X86"
publicKeyToken="6595b64144ccf1df"
language="*"
/>
</dependentAssembly>
</dependency>

<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
<security>
<requestedPrivileges>
<requestedExecutionLevel
level="highestAvailable"
uiAccess="false"/>
</requestedPrivileges>
</security>
</trustInfo>

</assembly>

Call InitCommonControls() in the InitInstance() of ur application
BOOL CURApp::InitInstance()
{
InitCommonControls();
--------------------------
----------------------
}

U can follow these steps to include manifest.xml in ur project.
Once writing manifest.xml is completed, you will want to add the manifest.xml file to your project in the resource editor. In Visual Studio 6, hit Ctrl+R to add a new resource, select all files and double click manifest.xml to add the file. When you see the custom resource dialog, enter the number "24" as the resource type and hit OK. Once imported, right click on the resource to open the properties window and change the ID to the number "1".

Sameer Thakur

Re: Create Registry Entry in Vista ...

Manjunath S4-May-07 23:21

Manjunath S

4-May-07 23:21

Thanks Sammer for ur valuable reply...

Iam using Visual studio installer to install an application.In the installer i have a custom action DLL.In this DLL before installing the application i have to check the registry whetheir any entry with name same as my application name is present,if present take the path entered there, if not create a registry entry named with my applciation name....

Any tips to do above in vista ....

Manjunath S
GESL
Bangalore

Re: Create Registry Entry in Vista ...

Sameer_Thakur4-May-07 23:33

Sameer_Thakur

4-May-07 23:33

Logically.....

You can add that xml file as a resource in a DLL that u are using as a custom action DLL.(No need to call InitCommonControls() in that case.)

By doing that ur DLL will get elevated privileges to read/write registry entries on Vista.

Sameer Thakur

Re: Create Registry Entry in Vista ...

Manjunath S4-May-07 23:45

Manjunath S

4-May-07 23:45

Hi sameer
Can u tell me what actually done in this XMl...
How it helps to edit registry
And how Custom Dll Handles it...

Manjunath S
GESL
Bangalore

Re: Create Registry Entry in Vista ...

Sameer_Thakur5-May-07 0:00

Sameer_Thakur

5-May-07 0:00

In Vista there is a concept of User Account Control (UAC) by which it prevents any major changes in registry (though you are logged in as an Admin).
To enable registry changes, we need to provide higher privileges to the application.

To do this there is a tag in manifest.xml …

<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
<security>
<requestedPrivileges>
<requestedExecutionLevel
level="highestAvailable"
uiAccess="false"/>
</requestedPrivileges>
</security>
</trustInfo>

Here we are granting the “highestAvailable” privilege to the application/DLL which ultimately grants the permission to ur application/DLL to access (Read/Write) registry.

Sameer Thakur

Re: Create Registry Entry in Vista ...

Manjunath S5-May-07 0:14

Manjunath S

5-May-07 0:14

Thanks sameer
I will try this and udapte ...

Manjunath S
GESL
Bangalore

Re: Create Registry Entry in Vista ...

Michael Dunn5-May-07 7:06

Michael Dunn

5-May-07 7:06

What happens on Vista? Post your code.

--Mike--
Visual C++ MVP Cool | :cool:

LINKS~! Ericahist | PimpFish | CP SearchBar v3.0 | C++ Forum FAQ

Dunder-Mifflin, this is Pam.

Re: Create Registry Entry in Vista ...

Manjunath S6-May-07 20:05

Manjunath S

6-May-07 20:05

Hi guys,
I tried with embedding the manifest.xml in my Dll as posted in the previous reply to write registry entry in windows vista. But this fails to create any effect (my Dll could not create the registry entry)

Manjunath S
GESL
Bangalore

Re: Create Registry Entry in Vista ...

Michael Dunn6-May-07 20:14

Michael Dunn

6-May-07 20:14

The XML that specifies what execution level you want only makes sense for EXEs, not DLLs, since the execution level applies to a process as a whole.

--Mike--
Visual C++ MVP Cool | :cool:

LINKS~! Ericahist | PimpFish | CP SearchBar v3.0 | C++ Forum FAQ

Dunder-Mifflin, this is Pam.

Re: Create Registry Entry in Vista ...

Manjunath S6-May-07 20:44

Manjunath S

6-May-07 20:44