C / C++ / MFC

error C2109: subscript requires array or pointer type
error C2143: syntax error : missing ';' before ')'

for(i=0;i    f=1,c=0;

#include "stdafx.h"
#include<stdlib.h>
#include<stdio.h>
#include<conio.h>
#include<string.h>


int _tmain(int argc, _TCHAR* argv[])
{
	 char *s,*a;
    int i,l,f,c,x;
    printf("Enter a string : ");
    scanf("%s",s);
    l=strlen(s);
    s[l]=0;
    a=(char*)malloc(l);
    for(i=0;i<l;i++);
    f=1,c=0;
    while(f)


        {
        x=l-1;
        a[x]=c++;
        for(i=0;i<l && c-1<l;i++)
        printf("%c",s[a[x]]);
        if(i>=l) 
        printf("\n");
        while(a[x]>=l)


            {
            a[x]=c=0;
            if(x<0){f=0;break;}
            a[x]++;
        }
    }

    printf("Completed");

	return 0;
}

Run-Time Check Failure #3 - The variable 's' is being used without being initialized.

scanf("%s",s);

scanf("%s",&s);

Unhandled exception at 0x1026f8bc (msvcr90d.dll) in TestingProject.exe: 0xC0000005: Access violation reading location 0xcc006975.

char *s = new char;

Failure is Success If we learn from it!!

char *s;
int i,l,*a,f,c,x;
printf("Enter a string : ");
scanf("%s",s);

for(i=0;i
 f=1,c=0;
 while(f)

2 bugs found.
> recompile ...
65534 bugs found.

int fac(int n)
{
  if (n == 0) return 1;
  else return n*fac(n - 1);    	    
}

void permute(char *string, int n, int rank)
{
  vector<char> vec;
  for (int ctr = 0; ctr < n; ctr++) vec.push_back(string[ctr]);

  for (int ctr = n; ctr >= 1; ctr--)
    {
      int quotient = rank/fac(ctr-1);
      char c = vec[quotient];
      vec.erase(vec.begin()+quotient);
      *string++ = c;
      rank%=fac(ctr-1);    	 
    }    		  
}

void showpermutes(char *string)
{
  char temp[20];  	
  int n = strlen(string);    	
  // if the string is too big, we can't continue
  if (n > 19) return;
  int nfac = fac(n);
  for (int ctr = 0; ctr < nfac; ctr++)
    {	         
      strcpy(temp, string);    	     
      permute(temp, n, ctr);    	     
      cout << temp << endl;
    }     		       
}

int _tmain(int argc, _TCHAR* argv[])
{
	showpermutes("AB");
	system("PAUSE");
	getche();
	return 0;
}