Re: Getting values to Add up from a datagrid text box [modified] - C# Discussion Boards

I agree with you, but would add one other thing: using the built in serializer makes it difficult to change the structure in later versions and still read older data files correctly. You can find that the time saved in the beginning is multiplied several times when changes occur. For that reason I prefer to serialize it all myself right from the start!

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

Good point Thumbs Up | :thumbsup:

Thanks for the very helpful reply!
It confirms that I'm not crazy--maybe--and it gets me past that wall.

Tom

I uploaded a project that contains only the bug and nothing else.
It is here: http://www.megaupload.com/?d=I935FBST

There is the MDI container, a splitter and a treeview. I created 2 Childforms for the MDI container.
Here's the problem:
When I try to labeledit/beginedit a node in the treeview while Child Form 1 is not on top, it will basically simulate a canceledit after I type the first character. So if I wanted to edit the node's text to say, "David", all I will get from it is a "D" and it will stop the editing right there.

I tested it more and found this to be a messy solution:

private void treeView1_BeforeLabelEdit(object sender, NodeLabelEditEventArgs e)
{
if (this.HasChildren == true)
{
this.MdiChildren[0].BringToFront();
}

}

Is there a proper solution to this problem that doesn't force MdiChildren[0] to come to the front whenever any node's label is being edited?

Thank you,
Crazy

Ok my problem is I am using a data grid to collect a spacing from the user.
I am trying to get these values to add to each other.
I can get the first item to be placed in my program at 120", then then next item to be placed at 240".
So the second item will add to the first item.

My problem is anything after the first two items just keeps adding to the first instead of the over all total.
This is what I am looking for:
The Datagrid values are user input for example:
Row 1 120
Row 2 120
Row 3 120
(the rows will keep adding as long as the user has more to put in them.)

The first row of the datagrid defines an item at the 120" location.

Next I want to add the first row to the second row of the datagrid so the item will be at 240" location. ( It works up to here)

Next I want the value of row (1 and row 2) + the third row of the datagrid so the item will be at the 360" location.

I essentially want the value of the last row to add to the total of all of the previous rows.

Hope this all makes sense.
Thanks

for (int i = 0; i < d_Endpost.Rows.Count -1 ; i++)
{
///Sets Endpost Spacing


DataGridViewRow EndPostSpacing = d_Endpost.Rows[i];
Double xVal = 0;

foreach(DataGridViewRow row in d_Endpost.Rows)
{
string PostSpacing = EndPostSpacing.Cells["EPSpacing"].Value.ToString();
double PostSpacingTotal = I2M(double.Parse(PostSpacing.ToString()));
Double temp = PostSpacingTotal;
if (i == 0)
{
xVal = temp;
}
else
{
xVal = temp += PostSpacingTotal;
}

}
}

Try:

xVal += temp += PostSpacingTotal;

But I think you need to look at a few things here:
1) xVal will go out of scope when the for loop ends - throwing away your data.
2) You aren't using the DataGridVeiwRow at all - why foreach over them?
3) Rather than converting a cell value to a string, then to a double, then I2M (whatever that does) why not use the Cell.Value directly? Or at least use TryParse so that a data error will not cause an exception?

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

Message Removed

Hi! Sorry for the delay in responding, I had to collect my wife for work, feed her lunch, that kind of thing...

You aren't far off what you want to do, you have just got bogged down in "that works so I'll keep it" syndrome! We all do that, so don't feel bad!

I have modified your code a fair amount, and will explain why as we go through:

Double xVal = 0;

foreach (DataGridViewRow row in d_Endpost.Rows)
    {
    double postSpacing = 0.0;
    double postSpacingMetric = 0.0;
    string userEntry = (string)row.Cells["EPSpacing"].Value;
    if (!string.IsNullOrEmpty(userEntry))
        {
        if (Double.TryParse(userEntry, out postSpacing))
            {
            postSpacingMetric = Imperial2Metric(postSpacing);
            }
        else
            {
            MessageBox.Show("Invalid entry (" + userEntry + ") please enter the post spacing in inches and try again");
            return;
            }
        xVal += postSpacingMetric;
        Console.WriteLine(xVal);
        }
    }

Firstly, I have removed the outer loop - as you have realised, you only need the one and in this case the foreach makes it all a bit more readable. Generally, try to avoid for loops when you can use foreach and don't need to know how many elements you are dealing with.
Next, I specifically get the element value into a string - you don't need to do this, but it both makes it more obvious and ties the error message to it better later. Because we know that a DataGridViewRow.Value property will (in this case) always be a string, we can cast it, with no need for a conversion.
Then, check it isn't empty! If it is, and we don't check, then we will get a null reference exception.
Ok so far, try and parse it. TryParse works like Parse, but instead of throwing an exception if the user types in his name instead of the distance, it returns will a true or false to say the conversion worked. If it fails, tell the user what he did wrong!
It is always worth checking user input - if you don't then a simple mistake can cause your program to fail. Check it, and handle it nicely!
Include the current metric value in the running total.
Display the total so far with Console.WriteLine - this is where you would do whatever you need to with the values as they are being generated.
Why do I not check the first one to start the running total? Why bother? Because I initialise the running total to 0 when I declare it, the first element output will be the first value the user enters. If I don't need to create a special case, I won't bother!

Try running this through the debugger - it is well worth getting used to it, you are going to spend a lot of time looking at your code through debug screens!

Hope that all makes sense!

[edit] included the word "don't" in the phrase "so don't feel bad" - Oops![/edit]

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

I think that all makes sense. I was wondering how to do a check if the user used a value or not.
It kinda works now.
If I say put 3 spaces at 120", it now puts all of the items at 360". Instead of 1 at 120" 1 at 240" and 1 at 360".

I greatly appreciate your help!

Post teh code you are using - I'd guess it's a typo, or you are using the values after the loop - when they are allready added together...

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

After looking at it again I was ending my foreach statement to early.

I don't know why I didn't put the rest of the code in there.
Now it works great! I thank you for all of your help..

You are welcome!

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

Message Removed

OK, rules for good code:
1) Don't use "#region" to break up your code, use it to group together similar items - consturctors, event handlers, public methods, private methods, and so on. If you want to show where you are handling comething, then extract it into a method, and give the method a sensible name "SingleC" and "DoubleC" for example. You can then comment these using "///" and intellisense will pick up and help you out. It makes the flow of control easier to spot. VS can extract code as a method, just highlight it and right click - "Refactor", "Extract Method"
2) Use indenting properly! VS indents things really nicely, and make it so much more obvious what it going on - I had to faff around a bit to get it like this (since I don't have and dont want) your class definitions but then VS indented everything really nicely.
3) Be consistant in indenting: one space, two space, back a bit - it really doesn't help you see what is going on. VS has loads of options for this: Indent braces to match content, number of character to indent, newlines, opening brace on same line, etc. Find a style you like, and stick with it. I prefer braces on new lines, indent three characters, indent braces to match content - but that is me, and there are enough arguments about that allready!
4) Don't use comments to explain what the code does - explain why the code is doing it. "This Sets If its a Single CEE or Double CEE" followed by a test saying "if (DBLCee == "False")" is useless - why is it important to know if it is single or double cee? I have no idea, and the comment does not help me at all. (P.S. I don't actually need to know, but someone who works on your code might).

double xVal = 0;

foreach (DataGridViewRow row in d_Endpost.Rows)
    {
    double postSpacing = 0.0;

    double postSpacingMetric = 0.0;
    string userEntry = (string)row.Cells["EPSpacing"].Value;
    if (!string.IsNullOrEmpty(userEntry))
        {
        if (Double.TryParse(userEntry, out postSpacing))
            {
            postSpacingMetric = I2M(postSpacing);
            }
        else
            {
            MessageBox.Show("Invalid entry (" + userEntry + ") please enter the post spacing in inches and try again");
            return;
            }
        xVal += postSpacingMetric;
        Console.WriteLine(xVal);
        }
    string PostType = row.Cells["EndPostType"].FormattedValue.ToString();
    string DBLCee = row.Cells["DBLCee"].FormattedValue.ToString();
    // This Sets If its a Single CEE or Double CEE
    // (Replace this comment with what a Single Cee and Double Cee are, and
    // why they are different.)
    if (DBLCee == "False")
        {
        SingleCee(Distance2Points, xVal, PostType);
        }
    else
        {
        DoubleCee(Distance2Points, xVal, PostType);
        }
    }

From this you can see a couple of things straight away:
1) All your processing code is outside the check to see if there is any data to process!
2) You have lest the Console.WriteLine in, when it serves no purpose now.

And the mthods became:

private void DoubleCee(double Distance2Points, double xVal, string PostType)
    {
    if (xVal < Distance2Points / 2)
        {
        ///This Figures the columns at the Left side of the Ridge
        ///This is the Left of the Double CEE
        Beam EndPost = new Beam();
        EndPost.StartPoint = new T3D.Point(xVal, 0, 0);
        EndPost.EndPoint = new T3D.Point(xVal, 0, (EaveHt - (PurlinSlope + I2M(1.5))) + (xVal * Math.Tan(AngleRadians)));
        EndPost.Material.MaterialString = "55";
        EndPost.Name = "Endpost";
        EndPost.Profile.ProfileString = PostType.ToString();
        EndPost.Position.Depth = Position.DepthEnum.BEHIND;
        EndPost.Position.Plane = Position.PlaneEnum.LEFT;
        EndPost.Position.Rotation = Position.RotationEnum.FRONT;
        EndPost.Class = "3";
        EndPost.Insert();
        ///This Figures the columns at the Left side of the Ridge
        ///This is the Right of the Double Cee
        Beam EndPostR = new Beam();
        EndPostR.StartPoint = new T3D.Point(xVal, 0, (EaveHt - (PurlinSlope + I2M(1.5))) + (xVal * Math.Tan(AngleRadians)));
        EndPostR.EndPoint = new T3D.Point(xVal, 0, 0);
        EndPostR.Material.MaterialString = "55";
        EndPostR.Name = "Endpost";
        EndPostR.Profile.ProfileString = PostType.ToString();
        EndPostR.Position.Depth = Position.DepthEnum.FRONT;
        EndPostR.Position.Plane = Position.PlaneEnum.LEFT;
        EndPostR.Position.Rotation = Position.RotationEnum.FRONT;
        EndPostR.Class = "3";
        EndPostR.Insert();
        }
    else
        {
        //This Figures the columns at the Right side of the Ridge
        ///This is the Left of the Double Cee
        Beam EndPost = new Beam();
        EndPost.StartPoint = new T3D.Point(xVal, 0, 0);
        EndPost.EndPoint = new T3D.Point(xVal, 0, (EaveHt - (PurlinSlope + I2M(1.5))) + ((Distance2Points - xVal) * Math.Tan(AngleRadians)));
        EndPost.Material.MaterialString = "55";
        EndPost.Name = "Endpost";
        EndPost.Profile.ProfileString = PostType.ToString();
        EndPost.Position.Depth = Position.DepthEnum.BEHIND;
        EndPost.Position.Plane = Position.PlaneEnum.LEFT;
        EndPost.Position.Rotation = Position.RotationEnum.BACK;
        EndPost.Class = "3";
        EndPost.Insert();
        ///This Figures the columns at the Right side of the Ridge
        ///This is the Right of the Double Cee
        Beam EndPostR = new Beam();
        EndPostR.StartPoint = new T3D.Point(xVal, 0, (EaveHt - (PurlinSlope + I2M(1.5))) + ((Distance2Points - xVal) * Math.Tan(AngleRadians)));
        EndPostR.EndPoint = new T3D.Point(xVal, 0, 0);
        EndPostR.Material.MaterialString = "55";
        EndPostR.Name = "EndPostR";
        EndPostR.Profile.ProfileString = PostType.ToString();
        EndPostR.Position.Depth = Position.DepthEnum.FRONT;
        EndPostR.Position.Plane = Position.PlaneEnum.LEFT;
        EndPostR.Position.Rotation = Position.RotationEnum.BACK;
        EndPostR.Class = "3";
        EndPostR.Insert();
        }
    }

private void SingleCee(double Distance2Points, double xVal, string PostType)
    {
    if (xVal < Distance2Points / 2)
        {
        ///This Figures the columns at the Left side of the Ridge
        Beam EndPost = new Beam();
        EndPost.StartPoint = new T3D.Point(xVal, 0, 0);
        EndPost.EndPoint = new T3D.Point(xVal, 0, (EaveHt - (PurlinSlope + I2M(1.5))) + (xVal * Math.Tan(AngleRadians)));
        EndPost.Material.MaterialString = "55";
        EndPost.Name = "Endpost";

        EndPost.Profile.ProfileString = PostType.ToString();
        EndPost.Position.Depth = Position.DepthEnum.MIDDLE;
        EndPost.Position.Plane = Position.PlaneEnum.LEFT;
        EndPost.Position.Rotation = Position.RotationEnum.FRONT;
        EndPost.Class = "3";
        EndPost.Insert();
        }
    else
        {
        ///This Figures the columns at the Right side of the Ridge
        Beam EndPost = new Beam();
        EndPost.StartPoint = new T3D.Point(xVal, 0, 0);

        EndPost.EndPoint = new T3D.Point(xVal, 0, (EaveHt - (PurlinSlope + I2M(1.5))) + ((Distance2Points - xVal) * Math.Tan(AngleRadians)));
        EndPost.Material.MaterialString = "55";
        EndPost.Name = "Endpost";
        EndPost.Profile.ProfileString = PostType.ToString();
        EndPost.Position.Depth = Position.DepthEnum.BEHIND;
        EndPost.Position.Plane = Position.PlaneEnum.LEFT;
        EndPost.Position.Rotation = Position.RotationEnum.BACK;
        EndPost.Class = "3";
        EndPost.Insert();
        }
    }

(I will leave it to you to comment them since I don't know that much about roofing houses!)

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

Message Removed

miggs70 wrote:
I wasn't aware that I could separate things out with privates

They are called methods: private is a keyword that can go before the return type to tell the compiler that it should not be visible outside the class.

If you are trying to learn C# by looking at samples, you will take forever, and will have to work very hard. You will find it easier if you try a more structured method, such as a book. Have a look here: C# Yellow Book[^] it is the book they give first year students at Hull University and it's both not a bad start and free.
Do you have a copy of Visual Studio yet? If not, then Microsoft will give you a copy of the Express edition (which handles most things, and is well up to learning the language). See Here[^] for a copy. Warning - it's quite big!
And of course - CodeProject is more than willing to help!

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

can any 1 send me the link that finds overlapping area of n rectangles

How can i change resource file that i use it in my project at runtime !
or
How to change Resource file Dynamically ?!

See the MSDN[^] pages on resource files.

Hint: try researching with Google/MSDN/CodeProject articles first.

MVP 2010 - are they mad?

how to have :

System.ComponentModel.ComponentResourceManager res = new ComponentResourceManager(typeof("<code>C:\Resource.resx</code>"));

I don't think you can get what you have coded above; see here[^] for details.

MVP 2010 - are they mad?

I am developing an application in c# , but the default window style on vista does not fit my requirement in term of look .
I want to have the application style like the default style in MFC application .

I am really concerned about the menustrip which I would like to be like the one in VLC player or any default MCF application

please How can I do it in c#. look around but nothing about it .

Application.EnableVisualStyle(); does not work

Is it ok in .Net 3.5 to change a property within a foreach loop? Does it still run the risk of producing unpredictable results? Also, will the potential results be noticeable or might it cause some type of slow, inconspicuous but nonetheless catastrophic error.

For example:

foreach(Employee janitor in EmployeesWithPayIncrease)
{
janitor.Salary += 5000;
}

Thanks for any help or information you can provide.

It is fine to change a property; the only thing you can't do is change the loop variable or the list itself.
So

foreach(Employee janitor in EmployeesWithPayIncrease)
   {
   janitor.Salary += 5000;
   }

is fine, but

foreach(Employee janitor in EmployeesWithPayIncrease)
   {
   janitor = new Employee();
   }

or

foreach(Employee janitor in EmployeesWithPayIncrease)
   {
   EmployeesWithPayIncrease.Remove(janitor);
   }

are not, as it would mean it would compromise the enumeration.

If Barbie is so popular, why do you have to buy her friends?

Eagles may soar, but weasels don't get sucked into jet engines.

If at first you don't succeed, destroy all evidence that you tried.

I can think of ways to make the first piece of code fail as well Smile | :)