C#

John Simmons / outlaw programmer wrote:

and it's absolutely tits

Pete O'Hanlon wrote:

We use it to hive off our Tcp processing, and it just works

private void PacketReceivedCallback(IAsyncResult result)
{
    IOClient client = (IOClient)result.AsyncState;

    int bytesRead = client.Socket.EndReceive(result);

    if (bytesRead != 0)
    {
        lock (clientLock)
        {
            StringBuilder sb = new StringBuilder();

            if (client.IncompleatePacket.Length > 0)
            {
                sb = client.IncompleatePacket;
            }

            foreach (byte CurrentByte in client.ReadBuffer)
            {
                if (CurrentByte == EmptyByte)
                {
                    continue;
                }

                if (CurrentByte == PacketTerminator)
                {
                    PacketReceived(client, sb.ToString());
                    bytesReceived += sb.ToString().Length;

                    BroadcastPacket(sb.ToString(), client);

                    sb = new StringBuilder();
                    client.IncompleatePacket = new StringBuilder();
                }

                if (CurrentByte != EmptyByte && CurrentByte != PacketTerminator)
                {
                    sb.Append((char)CurrentByte);
                }
            }

            if (sb.Length > 0)
            {
                client.IncompleatePacket.Append(sb.ToString());
            }
        }
        client.Socket.BeginReceive(client.ReadBuffer, 0, client.ReadBuffer.Length, SocketFlags.None, 
                                   new AsyncCallback(PacketReceivedCallback), client);
    }
    else
    {
        CloseConnection(client);
    }
}

Luc Pattyn wrote:

2.
Your code is silently converting incoming bytes into chars into strings. That may be fine, however in general TCP/IP transports binary data. It is up to the application layers to decide what that data represents. You probably are aware of all this, but I wanted to say it explicitly just in case.

Harvey Saayman wrote:

I'll shove the entire piece of data into a collection of some type

My girlfriend says in the background:

Oh my gosh you guys should learn when to switch off

b0 = (byte)length;
b1 = (byte)(length >> 8);
b2 = (byte)(length >> 16);
b3 = (byte)(length >> 24);