C / C++ / MFC

Problem with Win32 Threads

23-Nov-09 5:16

mmmm... I would say is basically the same :S

kikoso23-Nov-09 2:13

23-Nov-09 2:13

Hello all,

I´m trying to multithread an application by using CreateThread function. So far I´ve done the following:

//Here I initialize the Thread
LPDWORD iID;
HANDLE hThread; // array of thread handles
hThread = CreateThread (
            0, // Security attributes
            0, // Stack size
            (LPTHREAD_START_ROUTINE)OpenCVWin32::Form1::Threadi,
            NULL,
            CREATE_SUSPENDED,
            iID);
}

//Called function
static DWORD WINAPI Threadi()
{
	System::Windows::Forms::MessageBox::Show("Hi there!");
	return 0;
}

When I launch the application, the thread is not created, as I cannot go inside the Threadi function. I´m right now using VC++ 2008. Does anyone has a suggestion on why this could be happening?

Thanks

HimanshuJoshi23-Nov-09 2:22

HimanshuJoshi

23-Nov-09 2:22

kikoso wrote:
CREATE_SUSPENDED,

This is the problem. If you use this attribute then the thread is created in suspended state. More Info Here[^]

If you want the thread to start as soon as you launch the application, don't create a thread in suspended state. If you want to create in suspended state, then you can use ResumeThread() function.

kikoso23-Nov-09 2:38

23-Nov-09 2:38

Thank you HimanshuJoshi. I was reading in zig-zag the doc, so I didn´t realize about it.

I still have some problems. After changing it, I have a problem accessing the memory. This is the error I got (after using 0 instead of CREATE_SUSPENDED,:

<br />
Unhandled exception at 0x003628c2 in OpenCV Win32.exe: 0xC0000005: Access violation reading at position 0x0000000c.<br />

I´ve been thinking about sending the 3 parameter as
(LPTHREAD_START_ROUTINE)&OpenCVWin32::Form1::Threadi,

But I got a different error:

error C3374: Address of "OpenCVWin32:: Form1:: Threadi" can only be adopted if a delegate instance is created.

I will appreciate any suggestions. Thank you Smile | :)

Member 392263923-Nov-09 2:27

Member 3922639

23-Nov-09 2:27

LPTHREAD_START_ROUTINE is defined as:

typedef DWORD (WINAPI *PTHREAD_START_ROUTINE)(
LPVOID lpThreadParameter
);
typedef PTHREAD_START_ROUTINE LPTHREAD_START_ROUTINE;

so, your thread function is to be:

static DWORD WINAPI Threadi(LPVOID lpThreadParameter)
{
System::Windows::Forms::MessageBox::Show("Hi there!");
return 0;
}

kikoso23-Nov-09 2:32

23-Nov-09 2:32

Hello!

Thank you! I didn´t though that passing the parameters will be compulsory. But nevermind, I put it on my code.

Rajesh R Subramanian23-Nov-09 2:50

Rajesh R Subramanian

23-Nov-09 2:50

If you're using MFC, you *must* use AfxBeginThread to begin a worker thread. If you are using Win32, you should be using _beginthreadex to create a thread.

CreateThread is an API and that will even create a thread if you're linking to the single threaded version of the CRT (which will inevitably lead to disaster).

If you're writing managed code, take a look at Thread.Start method in the documentation. Basically, I want to emphasise that there's no sane reason or excuse to use CreateThread from your code. There are safer and sane alternatives.

“Follow your bliss.” – Joseph Campbell

kikoso23-Nov-09 5:15

Subscript requires array or pointer type

23-Nov-09 5:15

Hello,

I finally found the problem. The code for the Thread Function was inside the ref class, so that made it managed code. I finally put outside it, and now is working fine Smile | :)

Thank you.

deadlyabbas23-Nov-09 0:47

deadlyabbas

23-Nov-09 0:47

I was having this initially
double* m_Value [4];
I want to redefine it differently.So what I did is

typedef vector <double> DOUBLE_VECTOR;
DOUBLE_VECTOR DoubleVec;
vector <double_vector> m_Value;

Above I did in .h file

Now I initialize it in constructor I mean .cpp file

DoubleVec.resize (10,0.0);
m_SplitArrPtr.resize (5,DoubleVec);

Till here I thing I have done fine.

Issue:
Now there is a function whose defination is somewhat like this

static void Func (double& ObjData,void* DataPtr);

In above function I have to fill the ObjData by DataPtr OK

So I did this

void ClassName::Func (double& ObjData,void* DataPtr)
{

int RowIndex = 0; // row index
int ColIndex = 0; // column index

//copy data to existing structure
for (RowIndex;
RowIndex < 5;
RowIndex++)
{
for(ColIndex;
ColIndex < 10;
ColIndex++)
{
ObjData [RowIndex][ColIndex] = DataPtr->m_Value [RowIndex][ColIndex];
} //for ColIndex
} // for RowIndex

}
But I am facing an error

"error C2109: subscript requires array or pointer type"

So please help me out that how I will be able to fill the ObjData.

Re: Subscript requires array or pointer type

Cedric Moonen23-Nov-09 1:03

Re: Subscript requires array or pointer type

23-Nov-09 1:03

Please, read the posting guidelines and format your code properly, it is almost unreadable.

deadlyabbas wrote:
static void Func (double& ObjData,void* DataPtr);

deadlyabbas wrote:
ObjData [RowIndex][ColIndex] = DataPtr->m_Value [RowIndex][ColIndex];

ObjData is a double, not an array so you can't use it like an array. DataPtr is a pointer to void, so if you want to access its content, you first have to cast it to something appropriate. Why are you using a pointer to void here ?

Cédric Moonen
Software developer

Charting control [v2.0]
OpenGL game tutorial in C++

T210223-Nov-09 1:29

T2102

23-Nov-09 1:29

ObjData is a double &. To use two subscripts (ObjData[RowIndex][ColIndex]). You have to have a two dimensional array such as double **ObjData.

How can i register a service using Visual Studio Setup .???

jain_MS22-Nov-09 23:53

jain_MS

22-Nov-09 23:53

Hi ,
I just wanted to know, how can I register a service using Visual studio setup project. I can create a Setup Project successfully, it installs all the program, but I need a hint on how to run register my exe as one of the services
And of course how can I unRegister the Service when
uninstalling the application.

Your help much appreciated.

Regds
Jain

Linking problem

KASR122-Nov-09 23:50

22-Nov-09 23:50

i have added a method in a header file as follows

void TestMethod()
{
..........
}

Now this header file is included in many places of same project.
The following error link error occurs.

Test.obj : error LNK2005: "void __cdecl TestMethod(void)" (?TestMethod@@YAXXZ) already defined in Test2.obj

How to rectify this error?

Cedric Moonen22-Nov-09 23:56

22-Nov-09 23:56

Why do you put the definition of your function in a header file ? Usually it is much better practice to move it to a cpp file.

Anyway, what you can do to remove your problem is make use of include guards. Surround your code in the file with this (replace MYFILE by something unique, typically the file name):

#ifndef MYFILE
#define MYFILE

.... // The rest of the header comes here

#endif

You can also put #pragma once at the top of your file. Google for "include guards" for more information.

Cédric Moonen
Software developer

Charting control [v2.0]
OpenGL game tutorial in C++

KASR122-Nov-09 23:59

22-Nov-09 23:59

i tried with
#pragma once

its not working.

Cedric Moonen23-Nov-09 0:10

23-Nov-09 0:10

~~Where did you put it ? And what do you mean with "its not working" ?~~

Anyway, as already suggested (by someone else also), putting the implementation of your function in a header file is very bad practice.

EDIT: it won't work anyway because if your file is include from two completely different cpp files, then you will end up with a duplicate function at compile time. So, move your implementation in a separate cpp file instead.

Cédric Moonen
Software developer

Charting control [v2.0]
OpenGL game tutorial in C++

KASR123-Nov-09 0:13

23-Nov-09 0:13

Yes i know that. To solve some issues they added function definition in header file.
I have added #pragma at the beginning of header file. Still same error(already defined).

KASR123-Nov-09 0:35

23-Nov-09 0:35

Please see 'Stuart Dootson' reply.

Richard MacCutchan23-Nov-09 0:02

Richard MacCutchan

23-Nov-09 0:02

Don't put implementation code in header files. Place this function in one .cpp file only.

KASR123-Nov-09 0:10

23-Nov-09 0:10

For some issues we have included one function definition in header file.
That we cannot change.

However

#pragma once

should slove the problem. But it doesnt why?

Cedric Moonen23-Nov-09 0:14

23-Nov-09 0:14

KASR1 wrote:
For some issues we have included one function definition in header file.
That we cannot change.

Why ? And why not trying to fix the original issue ?

Cédric Moonen
Software developer

Charting control [v2.0]
OpenGL game tutorial in C++

KASR123-Nov-09 0:19

23-Nov-09 0:19

Actually this project is a static library. When linking with some exe/dll we are getting CTime link error. So we have defined a function with CTime and including that header in the exe/dll.

Richard MacCutchan23-Nov-09 0:22

Richard MacCutchan

23-Nov-09 0:22

You do not seem to understand the difference between declaration and implementation. Your header file should contain only the declaration e.g.

void TestMethod();

The implementation code should go in a single source file (Test.cpp) as follows:

void TestMethod()
{
    // body of the TestMethod function
}

Try reviewing the relevant sections in your C/C++ guides for further explanations.