The Weird and The Wonderful

29-Apr-09 1:40

This is the base code vs generates to check for special keys, on a Smart Device project:

private void Form1_KeyDown(object sender, KeyEventArgs e)
{
    if ((e.KeyCode == System.Windows.Forms.Keys.Up))
    {
        // Subir oscilador
        // Subir
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Down))
    {
        // Bajar oscilador
        // Bajar
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Left))
    {
        // Izquierda
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Right))
    {
        // Derecha
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Enter))
    {
        // Entrar
    }

}

A Pocket PC is full of power, so let's check for every possible key.

Tony Pottier29-Apr-09 5:03

Tony Pottier

29-Apr-09 5:03

I don't see any horror here. What do you want to do if you need to check for those keys?

Stephen Hewitt29-Apr-09 5:12

Stephen Hewitt

29-Apr-09 5:12

If the first if is true, for example, why bother testing all the others which follow? It's dopey code.

Steve

Tony Pottier29-Apr-09 5:36

Tony Pottier

29-Apr-09 5:36

some else if would be much better indeed, and the switch/case would be even more appropriate for this stuff, but still it doesn't real shock me.

Vasudevan Deepak Kumar7-May-09 21:26

Vasudevan Deepak Kumar

7-May-09 21:26

That many bunch of ifs could have been elegantly presented with a decent switch block.

Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips

The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep!

adgonz29-Apr-09 5:18

29-Apr-09 5:18

It's not a big horror, its just funny to see it on Visual Studio. The correct implementation would be:

private void Form1_KeyDown(object sender, KeyEventArgs e)
{
    switch(e.KeyCode)
    {
        case System.Windows.Forms.Keys.Up:
            // Subir oscilador
            // Subir
            break;

        case System.Windows.Forms.Keys.Down:
            // Bajar oscilador
            // Bajar
            break;

        case System.Windows.Forms.Keys.Left:
            // Izquierda
            break;

        case System.Windows.Forms.Keys.Right:
            // Derecha
            break;

        case System.Windows.Forms.Keys.Enter:
            // Entrar
            break;

     }

}

KarstenK4-May-09 23:14

KarstenK

4-May-09 23:14

it is a horror that this visible code is so poor. Mad | :mad:

What about the non-visible code. Shame on Microsoft!!! Dead | X|

Press F1 for help or google it.
Greetings from Germany

VentsyV6-May-09 6:30

VentsyV

6-May-09 6:30

Invisible code ?!?? Where ??

KarstenK6-May-09 20:23

KarstenK

6-May-09 20:23

I mean the code we cant look at, like the soruce code of windwos or Office. $Shucks | :-\$

Press F1 for help or google it.
Greetings from Germany

Vasudevan Deepak Kumar7-May-09 21:27

Vasudevan Deepak Kumar

7-May-09 21:27

KarstenK wrote:
we cant look at, like the soruce code of windwos or Office

But we can feel it and enjoy it with timely patches and service packs.

Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips

The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep!

KarstenK7-May-09 21:59

KarstenK

7-May-09 21:59

Now I am feeling the difference between Version "6.0" and "6.1 RC" of a wellknown Microsoft product. I feel that they really work hard and encouraged. Blush | :O

Press F1 for help or google it.
Greetings from Germany

sucram18-May-09 0:02

sucram

18-May-09 0:02

Maybe he doesn't understand the Spanish. Laugh | :laugh:

Vita est usquequaque virtus victus ut plenus. Ego non sum semper iustus tamen Ego sum nunquam nefas!

0x3c029-Apr-09 10:51

0x3c0

29-Apr-09 10:51

Ah, but this way there's a nice little hack brewing. Modify the parameters in some ASM code mid-execution, and you can invoke multiple segments of code. That way, there's two operating modes built in - cracker and normal user. Crackers can have super-special zero-bug privileges, while normal users can get walloped with the bug-hammer
Of course, a nice little service running in the background on the target machines can do this automatically. Maybe a clause can be put in which stops modifying the code if certain packets are received. Grumpy, abusive user gets bugs, rich user with lots of contacts gets fewer

PIEBALDconsult30-Apr-09 14:18

PIEBALDconsult

30-Apr-09 14:18

You would delete the auto-generated code anyway wouldn't you?

Actually isn't there a file (or files) that contain such things and you can change them there?

adgonz4-May-09 4:45

4-May-09 4:45

PIEBALDconsult wrote:
You would delete the auto-generated code anyway wouldn't you?

Actually isn't there a file (or files) that contain such things and you can change them there?

Of course, I can change the code, the same way you would change the code on all the horrors published here. Isn't this forum to publish horrors you find over there?

I think this is a reply horror. Laugh | :laugh:

Megidolaon3-May-09 21:21

Megidolaon

3-May-09 21:21

This might not be a horror at all.
Maybe it's intended this way (I don't know as I never used a Pocket PC).
If the user presses multiple directions, several ifs are true and the code for each of them should be executed.

Otherwise diagonal directions would be impossible because it would accept only a single directional key at once.

adgonz3-May-09 21:33

3-May-09 21:33

Megidolaon wrote:
If the user presses multiple directions

Then multiple events are fired.

Megidolaon4-May-09 20:28

Megidolaon

4-May-09 20:28

...yes, thatwould be true

Paulo Zemek6-May-09 3:37

Paulo Zemek

6-May-09 3:37

Even if multiple keys where able to be captured at the same time, using many == will not be a solution.
After all, if the keys where combined using the | operator, as happens with flags, the right way to check the values will be using: if ((parameter & condition) == condition) or if ((parameter & condition) != 0)

But that's not the case with keys. So, this is an ugly code (but not an horror in my opinion).

A VS induced horror by me, kinda

Vasudevan Deepak Kumar7-May-09 21:29

Vasudevan Deepak Kumar

7-May-09 21:29

adgonz wrote:
multiple events are fired.

The application goes haywire and user runs amuck helter-skelter.

Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips

The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep!

Megidolaon27-Apr-09 22:28

Megidolaon

27-Apr-09 22:28

I think my VS is broken or something.
I get an error for not writing a return after a catch block.
The method in question:

private bool ReadIni()
{
   try
   {
   [do stuff]

      if ([error string != "" || string array with file content == null])
      {
        [return false; among other things]
      }
     else
     {
        [return true; among other things]
     }
   }
   catch (Exception ex)
   {
      [display error message]
   }
   return false //WTF?
}

Thomas Weller27-Apr-09 22:53

Thomas Weller

27-Apr-09 22:53

This is not an error at all...

If an exception would occur in the if-condition, the resulting control flow would be without any return statement. So the compiler error is nothing but correct. No broken VS, just malformed code...

Regards
Thomas

www.thomas-weller.de

Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.

killabyte28-Apr-09 2:13

killabyte

28-Apr-09 2:13

Why wouldnt you return something from the function declared

private bool ReadIni();

Jeroen De Dauw28-Apr-09 5:54

Jeroen De Dauw

28-Apr-09 5:54

My guess is that you then can do something like:

if (ReadIni()) 
{
// do something with the data
}
else
{
// show error
}

GSoC 2009 student for SMW!
---
My little forums: http://code.bn2vs.com
---
70 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65!