The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

One of my own :)

_Maxxx_12-May-09 20:21

_Maxxx_

12-May-09 20:21

#if (LIBRARYFLAG)
    using Product.Client;
#else
    using Product.Server;
#endif
using Product.Server;

To explain - we have the same services defined in Client and Server - this is using WCF. For development we set off LibraryFlag so use the services directly - without using WCF (it is faster and makes debugging easier)

Of course, if you create a new service, then dont create the client service, and set LIBRARYFLAG, resharper pops up a "Press alt-enter to add the 'using'" message.

I musta pressed it - so now it adds the using for the Server version.

Ohh it took me a while to spot what was happening!

___________________________________________
.\\axxx
(That's an 'M')

Re: One of my own :)

Lutosław12-May-09 21:39

Lutosław

12-May-09 21:39

There are more #if #endif-related ReSharper bugs. Here is one of them which I spotted some time ago:
I you'd enable generating XML documentation in your project settings, you will get warnings in every place where you didn't make documentation. So far so good. However, once upon a time I wanted to have a different description for debugging and realase builds.

#if DEBUG
		/// &lt;summary&gt;
		/// Useless and unreliable sh*t, do not use this.
		/// &lt;/summary&gt;
#else
		/// &lt;summary&gt;
		/// This is a very subtle class which performs many difficult and expensive algorithms.
		/// &lt;/summary&gt;
#endif
public class Damage : Occurance

C# compiler wasn't complaing, but ReSharper wanted me to add another summary.

Greetings - Jacek Gajek

High end SQL

Bernard Laplace12-May-09 5:15

Bernard Laplace

12-May-09 5:15

Found in a stored procedure...

Declare @IsClosed bit

SET @IsClosed = (SELECT ISNULL(Closed,0)
FROM TimeRegHeader
WHERE TSID = @TSID)

If @IsClosed Is Null
BEGIN
Select 0
END
else
BEGIN
Select @IsClosed
END

Re: High end SQL

_Damian S_12-May-09 19:36

_Damian S_

12-May-09 19:36

Well, you really have to be sure about these things!! Roll eyes | :rolleyes:

Knowledge is knowing that the tomato is a fruit. Wisdom is not putting it in fruit salad!!

Booger Mobile - Camp Quality esCarpade 2010

Re: High end SQL

Nagy Vilmos13-May-09 3:15

Nagy Vilmos

13-May-09 3:15

Arnaud Lhopiteau wrote:
ISNULL(Closed,0)

belts...

Arnaud Lhopiteau wrote:
If @IsClosed Is Null

and braces.

What more do you want?

Panic, Chaos, Destruction.
My work here is done.

[Message Deleted]

StarBP6-May-09 15:49

StarBP

6-May-09 15:49

[Message Deleted]

Re: Needless Polygon Rendering

Tristan Rhodes6-May-09 23:03

Tristan Rhodes

6-May-09 23:03

Hardly a Coding Horror. An inefficient process to be sure, but not a horror.

* Sensible Function names
* Sensible Method Sizes
* Sensible Variable Declarations
* Clear Intent

-------------------------------

Carrier Bags - 21st Century Tumbleweed.

Which language is this Urgent help required

Sanjaykalsi5-May-09 22:53

Sanjaykalsi

5-May-09 22:53

' MAIN()
'
' Entry point. No more PPd. & Add. (^800 = 5)
'
'^:MAIN
MAIN:
'^PR^! Retract form in printer.
PRINT CMD("PR");
'^PL66^! Set line count to 66 for this form.
PRINT CMD("PL66");
'^PN^! Normal print mode on.
PRINT CMD("PN")
'^:GET.TERMS
GET.TERMS:
'^?"BOL ENTER TERMS (1 - 4): 1. PREPAID 2. COLLECT 3. 3RD PARTY 4. COD"1"1""%d"800
'A%=VAL(INPUTBOX$("BOL ENTER TERMS (1 - 4): 1. PREPAID 2. COLLECT 3. 3RD PARTY 4.COD",1,"1"))
A%=3
'^OC(^800 < 1)(^GT GET.TERMS)
'^OC(^800 > 4)(^GT GET.TERMS)
IF (A%<1) OR (A%>4) THEN GOTO GET.TERMS
'^H
'
' Goto line 2
'^G2
PRINT CMD("G4");
'
' DATE, ORIGIN, DESTINATION
'
PRINT CMD("C50");CMD("D");STRING$(4," "); K$ ; STRING$(6," "); STRJUST$(FLD(14,0),3,"L"," ")
'GOTO ENDING
'
' Skip a line
'
PRINT
'PRINT
'
' Shippers acct Number
PRINT STRING$(20," "); L$
'
'
PRINT
PRINT
'
PRINT STRING$(2," "); CMD("YL");CMD("7");CMD("YB")
PRINT STRING$(2," "); CMD("YL");CMD("8");CMD("YB")
PRINT STRING$(2," "); CMD("YL");CMD("9");CMD("YB"); STRING$(32," "); CMD("PB"); "HAWB#: ";STRJUST$(FLD(10,0),18, "L", " ");CMD("Pb")
PRINT STRING$(2," "); " "
'
PRINT STRING$(2," "); " ";STRING$(20," "); M$
PRINT STRING$(2," ");STRIP$(FLD(40,0),"C", " ")
'
'
'Skip 4 lines
'
PRINT
PRINT
PRINT
PRINT
'
PRINT STRING$(2," ");CMD("YL");STRIP$(CMD("2"),"C"," ");CMD("YB")
PRINT STRING$(2," ");CMD("YL");STRIP$(CMD("3"),"C"," ");CMD("YB")
PRINT STRING$(2," ");CMD("YL");STRIP$(CMD("4"),"C"," ");CMD("YB")
PRINT STRING$(2," ");CMD("YL");STRIP$(CMD("14"),"C"," ");CMD("YB")
'PRINT STRING$(2," ");CMD("YL");STRIP$(CMD("5"),"C"," ");", ";STRIP$(CMD("6"),"C"," ");" ";STRIP$(CMD("7"),"C"," ");CMD("YB")
PRINT STRING$(2," ");CMD("YL");STRIP$(CMD("5"),"C"," ");CMD("YB")
'PRINT
PRINT STRING$(2," ");CMD("YL");STRJUST$(FLD(10,2),18,"L"," ");CMD("YB"); STRING$(2," "); STRIP$(FLD(8,2),"C"," ")
'PRINT STRING$(2," ");
' PO (13chars) / BOL #
PRINT STRING$(2," ");STRJUST$(FLD(40,0),20,"L"," "); STRING$(1," "); STRJUST$(FLD(9,0), 16, "L"," ");
'PRINT STRING$(2," ");STRJUST$(FLD(9,0),13,"L"," "); STRING$(1," "); STRJUST$(FLD(2,0), 16, "L"," ")
'

Re: Which language is this Urgent help required

OriginalGriff5-May-09 23:05

OriginalGriff

5-May-09 23:05

Have you posted this in every forum?

No trees were harmed in the sending of this message; however, a significant number of electrons were slightly inconvenienced.

This message is made of fully recyclable Zeros and Ones

Re: Which language is this Urgent help required

Dino Mulahusic5-May-09 23:16

Dino Mulahusic

5-May-09 23:16

English

Let there arise out of you a band of people inviting to all that is good, enjoining what is right, and forbidding what is wrong: They are the ones to attain felicity.

Āli-'Imrān (The Family of Imran), 104.

Re: Which language is this Urgent help required

KarstenK6-May-09 3:45

KarstenK

6-May-09 3:45

looks like a basic dialect from out of the legendary Bill Gates times. Confused | :confused:

Press F1 for help or google it.
Greetings from Germany

Message Removed

6-May-09 8:21

MadProgrammer76

6-May-09 8:21

Message Removed

Re: Which language is this Urgent help required

KarstenK6-May-09 20:21

KarstenK

6-May-09 20:21

So he found the right forum. Blush | :O

To be honest: tons of old code are running: in banks Cry | :((

, factories, (nuclear) plants or goverments agencies. They have often a problems finding the code and a maintainer, like COBOL.

Press F1 for help or google it.
Greetings from Germany

Visual Studio autogenerated code

adgonz29-Apr-09 1:40

adgonz

29-Apr-09 1:40

This is the base code vs generates to check for special keys, on a Smart Device project:

private void Form1_KeyDown(object sender, KeyEventArgs e)
{
    if ((e.KeyCode == System.Windows.Forms.Keys.Up))
    {
        // Subir oscilador
        // Subir
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Down))
    {
        // Bajar oscilador
        // Bajar
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Left))
    {
        // Izquierda
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Right))
    {
        // Derecha
    }
    if ((e.KeyCode == System.Windows.Forms.Keys.Enter))
    {
        // Entrar
    }

}

A Pocket PC is full of power, so let's check for every possible key.

Re: Visual Studio autogenerated code

Tony Pottier29-Apr-09 5:03

Tony Pottier

29-Apr-09 5:03

I don't see any horror here. What do you want to do if you need to check for those keys?

Re: Visual Studio autogenerated code

Stephen Hewitt29-Apr-09 5:12

Stephen Hewitt

29-Apr-09 5:12

If the first if is true, for example, why bother testing all the others which follow? It's dopey code.

Steve

Re: Visual Studio autogenerated code

Tony Pottier29-Apr-09 5:36

Tony Pottier

29-Apr-09 5:36

some else if would be much better indeed, and the switch/case would be even more appropriate for this stuff, but still it doesn't real shock me.

Re: Visual Studio autogenerated code

Vasudevan Deepak Kumar7-May-09 21:26

Vasudevan Deepak Kumar

7-May-09 21:26

That many bunch of ifs could have been elegantly presented with a decent switch block.

Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips

The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep!

Re: Visual Studio autogenerated code

adgonz29-Apr-09 5:18

adgonz

29-Apr-09 5:18

It's not a big horror, its just funny to see it on Visual Studio. The correct implementation would be:

private void Form1_KeyDown(object sender, KeyEventArgs e)
{
    switch(e.KeyCode)
    {
        case System.Windows.Forms.Keys.Up:
            // Subir oscilador
            // Subir
            break;

        case System.Windows.Forms.Keys.Down:
            // Bajar oscilador
            // Bajar
            break;

        case System.Windows.Forms.Keys.Left:
            // Izquierda
            break;

        case System.Windows.Forms.Keys.Right:
            // Derecha
            break;

        case System.Windows.Forms.Keys.Enter:
            // Entrar
            break;

     }

}

Re: Visual Studio autogenerated code

KarstenK4-May-09 23:14

KarstenK

4-May-09 23:14

it is a horror that this visible code is so poor. Mad | :mad:

What about the non-visible code. Shame on Microsoft!!! Dead | X|

Press F1 for help or google it.
Greetings from Germany

Re: Visual Studio autogenerated code

VentsyV6-May-09 6:30

VentsyV

6-May-09 6:30

Invisible code ?!?? Where ??

Re: Visual Studio autogenerated code

KarstenK6-May-09 20:23

KarstenK

6-May-09 20:23

I mean the code we cant look at, like the soruce code of windwos or Office. $Shucks | :-\$

Press F1 for help or google it.
Greetings from Germany

Re: Visual Studio autogenerated code

Vasudevan Deepak Kumar7-May-09 21:27

Vasudevan Deepak Kumar

7-May-09 21:27

KarstenK wrote:
we cant look at, like the soruce code of windwos or Office

But we can feel it and enjoy it with timely patches and service packs.

Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips

The woods are lovely, dark and deep,
But I have promises to keep,
And miles to go before I sleep,
And miles to go before I sleep!

Re: Visual Studio autogenerated code

KarstenK7-May-09 21:59

KarstenK

7-May-09 21:59

Now I am feeling the difference between Version "6.0" and "6.1 RC" of a wellknown Microsoft product. I feel that they really work hard and encouraged. Blush | :O

Press F1 for help or google it.
Greetings from Germany

Re: Visual Studio autogenerated code

sucram18-May-09 0:02

sucram

18-May-09 0:02

Maybe he doesn't understand the Spanish. Laugh | :laugh:

Vita est usquequaque virtus victus ut plenus. Ego non sum semper iustus tamen Ego sum nunquam nefas!

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.