|
Wouldn't float.IsNaN(x) be a more readable way to achieve that?
|
|
|
|
|
Only decimal numbers have NaN as static class member (at least ni C#), natural numbers like int or short don't have it.
Though if something is NaN, you would get an error the moment it's assigned to a natural number variable.
|
|
|
|
|
That is a good test for a custom "!=" operator 
Greetings from Germany
|
|
|
|
|
If action is volatile, it would be possible for the second test to succeed even if the first fails. Indeed, if it's a memory-mapped mapped register, such behavior might even be expected.
|
|
|
|
|
That's true.
But in that case it has to be made explicit in the code, either by using comments or a critical section or whatever may be appropriate.
Otherwise it would indeed be a very severe coding horror (since it could cause an error that would be very hard to find...) .
www.thomas-weller.de
Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.
|
|
|
|
|
Reminds me of that little DOS / Win console classic to wait for a keystroke:
if (!getch()) getch();
yes, this is the right way to do it
|
|
|
|
|
There should be more code like your example. I'm all for double checking things instead of just single checking. 
Chris Meech
I am Canadian. [heard in a local bar]
In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
|
|
|
|
|
I agree. In this day and age you can never be sure of anything...
DoesJessicaAlbaLoveMe uncertain = new DoesJessicaAlbaLoveMe();
string yahhhoooooo = "";
if (DoesJessicaAlbaLoveMe != null && DoesJessicaAlbaLoveMe!= null)
{
yahhhoooooo = uncertain.ToString().ToString().ToString();
}
else
{
yahoo = "She's just teasin :P";
}
A dogged, arrogant belief in self and the childlike idealism that comes with not knowing my limits. This is my greatest blessing, my priceless attribute.
|
|
|
|
|
TommyTomToms wrote: DoesJessicaAlbaLoveMe != null && DoesJessicaAlbaLoveMe!= null
It is quite dangerous: if uncertain is volatile, it may change in the meantime. Indeed, if it's not on paper, such behavior might even be expected.
Greetings - Gajatko
Portable.NET is part of DotGNU, a project to build a complete Free Software replacement for .NET - a system that truly belongs to the developers.
|
|
|
|
|
Not totally sure about that without checking, but:
Isn't an if statement atomic, at least such a simple one? I.E.: Is uncertain allowed to change at all between the two boolean checks, may it be volatile or not?
www.thomas-weller.de
Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.
|
|
|
|
|
uncertain = uncertian I'm affraid that Jessica could change a volatile value of the uncertian even during the '=' symbol.
Greetings - Gajatko
Portable.NET is part of DotGNU, a project to build a complete Free Software replacement for .NET - a system that truly belongs to the developers.
|
|
|
|
|
So there's absolutely nothing you can do -
this code IS dangerous and stays dangerous  .
-- Or is it Jessica who is dangerous... 
www.thomas-weller.de
Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.
|
|
|
|
|
If "foo" is volatile, the statement "if (foo == foo) bar();" must read the value of foo exactly twice and compare the two values read. If "foo" happens to be an address in normal RAM, the two reads would be most likely read the same data unless an interrupt or task switch happened to occur between them (not terribly likely). Not everything in a processor-based system is RAM, however. When a typical flash memory chip is performing a write cycle, consecutive read operations are guaranteed to return different data. If the generated code for the above 'if' statement didn't read 'foo' twice, the 'if' test would succeed even while the flash was still being written.
|
|
|
|
|
Thanks for that - wasn't totally sure about it from the top of my head...
www.thomas-weller.de
Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.
|
|
|
|
|
hey, if would b gr8 if u could explain wat u mean by variable being volatile
Ravie Busie
Coding is my birth-right and bugs are part of feature my code has!
|
|
|
|
|
hey, if would b gr8 if u could explain wat u mean by variable being volatile
This is not a place for programming questions, but in this context, a 'volatile' variable is one that is marked with the 'volatile' keyword. If a variable is declared volatile, expressions involving that variable may not be optimized. If 'foo' were not volatile, the code (assume foo, bar1, bar2, and bar3 are of type int):
foo = bar1;
bar2 = foo*25;
bar3 = foo*25;
foo = 8;
could be safely replaced with:
bar3 = bar2 = bar1 * 25;
foo = 8;
and indeed some compilers would make such a replacement. If 'foo' were volatile, however, all four of the original statements would have to be performed as-is, in sequence.
|
|
|
|
|
No, an if statement is not guaranteed to be atomic as it can be decomposed into multiple binary instructions, and a task switch can occur between any of those instructions unless the compiler designates the entire sequence as a critical section.
|
|
|
|
|
Some code I encountered yesterday included:
if (string.IsNullOrEmpty(client) || string.IsNullOrEmpty(client))
I think it's just a typo.
|
|
|
|
|
ClementsDan wrote: I think it's just a typo.
In my case the code should be:
if (action == InvalidContentActions.Remove || action == InvalidContentActions.CommentOut)
Greetings - Gajatko
Portable.NET is part of DotGNU, a project to build a complete Free Software replacement for .NET - a system that truly belongs to the developers.
|
|
|
|
|
I hope you have a 22 inch above screen.
bool UpdateImageFileWithGPSPosition(LPCTSTR lpszPictureFilePath, char* lat_lon)
{
LPCTSTR lpszModPictureFilePath = lpszPictureFilePath;
IImagingFactory* pImgFactory = NULL;
IImage* pImage = NULL;
bool fIsClsFounded = false;
GUID guidImageEncoderCls;
HRESULT hr = S_OK;
hr = CoCreateInstance(CLSID_ImagingFactory, NULL, CLSCTX_INPROC_SERVER, IID_IImagingFactory, (void **)&pImgFactory);
if (SUCCEEDED(hr))
{
IStream* pFileStream = CreateStreamByFileName(lpszPictureFilePath);
IImageDecoder* pImageDecoder = 0;
hr = pImgFactory->CreateImageDecoder(pFileStream, DecoderInitFlagNone, &pImageDecoder);
if (SUCCEEDED(hr))
{
ImageInfo imageInfo;
hr = pImageDecoder->GetImageInfo(&imageInfo);
if (SUCCEEDED(hr))
{
UINT nEncodersCount = 0;
ImageCodecInfo* pEncoders = NULL;
hr = pImgFactory->GetInstalledEncoders(&nEncodersCount, &pEncoders);
if (SUCCEEDED(hr))
{
for (UINT i = 0; i < nEncodersCount; i++)
{
if (pEncoders[i].FormatID == imageInfo.RawDataFormat)
{
guidImageEncoderCls = pEncoders[i].Clsid;
fIsClsFounded = true;
break;
}
}
}
if (fIsClsFounded)
{
PropertyItem pi;
{
pi.id = PropertyTagSoftwareUsed;
pi.type = PropertyTagTypeASCII;
pi.length = sizeof(char) * 30;
pi.value = lat_lon;
hr = pImageDecoder->SetPropertyItem(pi);
if (SUCCEEDED(hr))
{
IImageEncoder* pImageEncoder = NULL;
hr = pImgFactory->CreateImageEncoderToFile(
&guidImageEncoderCls,
lpszModPictureFilePath,
&pImageEncoder);
if (SUCCEEDED(hr))
{
IImageSink* pImageSink = NULL;
hr = pImageEncoder->GetEncodeSink(&pImageSink);
if (SUCCEEDED(hr))
{
UINT uiPropertiesCount = 0;
hr = pImageDecoder->GetPropertyCount(&uiPropertiesCount);
if (SUCCEEDED(hr))
{
UINT totalBufferSize = 0;
UINT numProperties = 0;
hr = pImageDecoder->GetPropertySize(&totalBufferSize, &numProperties);
if (SUCCEEDED(hr))
{
PropertyItem* pis = (PropertyItem*)malloc(totalBufferSize);
hr = pImageDecoder->GetAllPropertyItems(
totalBufferSize,
numProperties,
pis);
if (SUCCEEDED(hr))
{
hr = pImageSink->PushPropertyItems(
numProperties,
totalBufferSize,
pis);
if (SUCCEEDED(hr))
{
hr = pImageDecoder->BeginDecode(pImageSink, NULL);
if (SUCCEEDED(hr))
{
while (true)
{
hr = pImageDecoder->Decode();
if (SUCCEEDED(hr))
{
pImageDecoder->EndDecode(hr);
break;
}
else if (FAILED(hr))
{
pImageDecoder->EndDecode(hr);
break;
}
else if (hr == E_PENDING)
{
continue;
}
}
}
}
free(pis);
}
}
}
pImageSink->Release();
}
pImageEncoder->TerminateEncoder();
pImageEncoder->Release();
}
}
}
}
pImageDecoder->Release();
}
}
Stream_release(pFileStream);
pImgFactory->Release();
}
return SUCCEEDED(hr);
}
- Currahee! We stand alone together.
|
|
|
|
|
wasn't he aware of
return false
statement? Might wanna to stick with "single entry-single exit" type of function coding..... 
|
|
|
|
|
"return false" alone might not help, a CComPtr (was that the name? never did mfc..) would also be useful 
|
|
|
|
|
I commented just by seeing return type of the function. Did't dare to look into 16 layers at all... 
As per prototype
bool UpdateImageFileWithGPSPosition(LPCTSTR lpszPictureFilePath, char* lat_lon)
my comment meant the function would return false in case of failure (rather increasing the layers). 
|
|
|
|
|
Easier to do specific cases surely?
------------------------------------
"The greatest tragedy in mankind's entire history may be the hijacking of morality by religion"
Arthur C Clarke
|
|
|
|
|
Let me guess - there's a coding rule to use only one return statement per method?
Regards,
mav
--
Black holes are the places where God divided by 0...
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
![Rose | [Rose]](https://www.codeproject.com/script/Forums/Images/rose.gif)
