Click here to Skip to main content
15,567,221 members
Home / Discussions / C#
   

C#

 
GeneralRe: ActiveX and c# Pin
ORi x18-Sep-02 4:29
ORi x18-Sep-02 4:29 
GeneralRe: ActiveX and c# Pin
Stephane Rodriguez.18-Sep-02 5:03
Stephane Rodriguez.18-Sep-02 5:03 
GeneralBeep Pin
Mazdak18-Sep-02 1:02
Mazdak18-Sep-02 1:02 
GeneralRe: Beep Pin
Stephane Rodriguez.18-Sep-02 2:46
Stephane Rodriguez.18-Sep-02 2:46 
QuestionStatic Analysis tools? Pin
Martin D18-Sep-02 0:51
Martin D18-Sep-02 0:51 
AnswerRe: Static Analysis tools? Pin
Stephane Rodriguez.18-Sep-02 2:25
Stephane Rodriguez.18-Sep-02 2:25 
GeneralRe: Static Analysis tools? Pin
leppie18-Sep-02 5:15
leppie18-Sep-02 5:15 
GeneralRe: Static Analysis tools? Pin
leppie18-Sep-02 7:24
leppie18-Sep-02 7:24 
OK, so I got a @#$#load of errors again, though most of these "errors" are totally biased design "rules" (really only considerations).

EG all priority 1:

MemberNameKeywordCollision:
The member name 'Stop' conflicts in whole or part with reserved keyword 'Stop'. //yeah right, maybe with your code, but not with mine Laugh | :laugh:

EventHandlerNamesEndInEventHandler:
Rename 'BASSProgessHandler' to end in 'EventHandler'. //why make the name even longer, it wont effect the code.

EventFirstParameterIsNamedSender:
Change the first parameter of 'Progress' to an object type named 'sender'. // hell, i cast enough, why do i need to cast even more?

MemberOnlyShortAcronymsAreAllCaps:
Correct capitalization of member name 'get_ChannelEAXMix'. // again, who cares? EAX looks better to me than Eax (that looks more like some assembler function, maybe FXCop will complain about it too Laugh | :laugh:

ExceptionsRequireMultipleConstructors:
Add a constructor with a string parameter to custom exception 'BASSException'. Add a constructor with a string parameter and exception parameter to custom exception 'BASSException'. Add a protected constructor with a SerializationInfo object parameter and a StreamingContext object parameter to custom exception 'BASSException'. // again why? if you dont need it, why clutter your code with useless code?

TypeNameKeywordCollision:
The type name 'Error' conflicts in whole or part with reserved keyword 'Error'. // reserved????

MemberNamesDontUseUnderscores:
Remove the underscore from 'BASS_OK'. //if its not OK, why even make it legal to use?

ParameterNamesUseCamelCasing:
Instead of parameter name 'Length', use 'length'. // i cant help it if i hit my caps lock by mistake.

TypesDontExposePublicInstanceFields:
Make 'fWetDryMix' private or protected and provide a public property to access it. // Properties dont allways work when u need to "chain" a few, also the extra processing (repeated get/sets) makes it inefficient.

NamespaceNamesUsePascalCasing:
Instead of namespace 'nBASS', use 'NBASS'. //no, nBASS looks way cooler Smile | :)

and now for the 2 (yes only 2) usefull ones (priority 1):

AssembliesShouldBeStrongNamed:
Sign 'nBASS' with a strong name key. // not neccesary, but recommended.

MethodShouldKeepAliveIntPtrIfFinalized:
Add a GC.KeepAlive(this) to the method 'Void Stop()'. //i have no idea what they mean...does look like it could break my code though.

Any comments welcome Wink | ;)
GeneralRe: Static Analysis tools? Pin
Stephane Rodriguez.18-Sep-02 7:47
Stephane Rodriguez.18-Sep-02 7:47 
GeneralRe: Static Analysis tools? Pin
leppie18-Sep-02 7:54
leppie18-Sep-02 7:54 
GeneralRe: Static Analysis tools? Pin
Martin D19-Sep-02 0:13
Martin D19-Sep-02 0:13 
GeneralRe: Static Analysis tools? Pin
leppie19-Sep-02 0:42
leppie19-Sep-02 0:42 
GeneralRe: Static Analysis tools? Pin
James T. Johnson19-Sep-02 1:18
James T. Johnson19-Sep-02 1:18 
GeneralRe: Static Analysis tools? Pin
leppie19-Sep-02 1:27
leppie19-Sep-02 1:27 
GeneralRe: Static Analysis tools? Pin
James T. Johnson19-Sep-02 1:42
James T. Johnson19-Sep-02 1:42 
GeneralRe: Static Analysis tools? Pin
James T. Johnson19-Sep-02 5:17
James T. Johnson19-Sep-02 5:17 
GeneralRe: Static Analysis tools? Pin
leppie19-Sep-02 6:24
leppie19-Sep-02 6:24 
GeneralRe: Static Analysis tools? Pin
James T. Johnson19-Sep-02 0:53
James T. Johnson19-Sep-02 0:53 
GeneralRe: Static Analysis tools? Pin
leppie19-Sep-02 1:17
leppie19-Sep-02 1:17 
GeneralRe: Static Analysis tools? Pin
James T. Johnson19-Sep-02 1:38
James T. Johnson19-Sep-02 1:38 
GeneralRe: Static Analysis tools? Pin
leppie19-Sep-02 2:09
leppie19-Sep-02 2:09 
GeneralPopup menu Pin
Mazdak17-Sep-02 22:17
Mazdak17-Sep-02 22:17 
GeneralRe: Popup menu Pin
Stephane Rodriguez.17-Sep-02 22:45
Stephane Rodriguez.17-Sep-02 22:45 
GeneralRe: Popup menu Pin
Mazdak17-Sep-02 22:51
Mazdak17-Sep-02 22:51 
QuestionAuto-updater? Pin
floydboy5817-Sep-02 19:27
floydboy5817-Sep-02 19:27 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.