C / C++ / MFC

declared as
std::vector<POSITION> m_selection;

in member function:
if (m_selection.size() > 0){
		m_selection.clear(); // previously used to crash here.       
}                       // then I put this if
	

    .........
,.............
        .......
	POSITION pos = m_selStart.getItem();
	while(pos != NULL && pos != m_selEnd.getItem())
	{
		m_selection.push_back(pos); // CRASH HERE
		pos = getMan()->getNext(pos);
	}

	ASSERT(pos);
	m_selection.push_back(m_selEnd.getItem());

Iain Clarke wrote:

It's not FATAL - but the two mindsets of the framework designers are quite different.

// abstract iteration position
struct __POSITION {};
typedef __POSITION* POSITION;

ThisIsMeRon wrote:

Desktop.exe!_invalid_parameter_noinfo() Line 125 + 0xc bytes C++

#include <stdexcept>
#include <iostream>

int main(int, char**)
{
   try
   {
      throw std::runtime_error("Test");
   }
   catch(std::exception& e)
   {
      std::cerr << "Caught exception - " << e.what() << std::endl;
   };
}

class MyErrorClass
{

char *reason;
int *i;

public:
   
   MyErrorClass(char *r)
   {
      i = new int[6];
      cout<<"Constructor"<<endl;
         reason = r;
      cout<<reason<<endl;
      
   }
   
   char* giveReason()
   {
      return reason;
   }
   ~MyErrorClass()
   {
      cout<<"destructor"<<endl;
      delete[] i;
   }
   
};
void main()
{
   
   try
   {
      throw MyErrorClass("error");
   }
   catch (MyErrorClass* e)
   {
      cout<<"Exception caught --- "<<e->giveReason()<<endl;
   }
}

catch (MyErrorClass &e)

class MyErrorClass
{

char *reason;
int *i;

public:
   
   MyErrorClass(char *r)
   {
      i = new int[6];
      cout<<"Constructor"<<endl;
         reason = r;
      cout<<reason<<endl;
      
   }
   
   char* giveReason()
   {
      return reason;
   }
   ~MyErrorClass()
   {
      cout<<"destructor"<<endl;
      delete[] i;
   }
   
};
void main()
{
   
   try
   {
      throw MyErrorClass("error");
   }
   catch (MyErrorClass& e)
   {
      cout<<"Exception caught --- "<<e.giveReason()<<endl;
   }
}

Jijo raj wrote:

Well, the reason for crash is due to the fact that MyErrorClass::i is being de-allocated twice, since the copy constructor is not written for deep copy

Jijo raj wrote:

I'm using Visual Studio 6.0. Which one you're using?

Stuart Dootson wrote:

Even so, I'd still recommend throwing objects, not pointers - the real solution is for the OP to write a better exception class, I think.

Stuart Dootson wrote:

2003, 2005 and 2008 - certainly not VC6!!! The reason I don't use VC6 is because it is so primitive in terms of C++ language support.

Jijo raj wrote:

still my favorite due to the excellent fast IDE

Jijo raj wrote:

Well, i'm waiting for VC10 which is supposed to be the new 6.

#include <stdexcept>
#include <iostream>

int main(int, char**)
{
   try
   {
      throw std::runtime_error("Test");
   }
   catch(std::exception& e)
   {
      std::cerr << "Caught exception - " << e.what() << std::endl;
   };
}