|
David Hovey wrote: I tried running the Fill command of the new DataAdapter and reference the old DataSet but this does not work when rows are being modified
Are you getting an exception? If so, please include info about the exception.
David Hovey wrote: I have tried various methods such as BeginEdit of the row and AcceptChanges, but perhaps I am not using them correctly
It would be a whole lot easier if you could post the code part that's not working, including the refill portion.
|
|
|
|
|
Thanks again.
Private m_dsData As DataSet
Public Sub LoadData()
'MsgBox("Legacy function LoadData() called.")
Dim dbDataAdapter As OleDbDataAdapter
dbDataAdapter = New OleDbDataAdapter()
Try
m_dsData = Nothing
m_dsData = New DataSet
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Congregations", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Congregations")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM HomeTalks", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "HomeTalks")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM CongregationSpeakers", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "CongregationSpeakers")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM CongregationSpeakerOutlines", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "CongregationSpeakerOutlines")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Outlines", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Outlines")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM OutlineCategories", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "OutlineCategories")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Readers", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Readers")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Chairmen", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Chairmen")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Hospitality", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Hospitality")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM AwayTalks", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "AwayTalks")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Notes", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Notes")
dbDataAdapter.SelectCommand = New OleDbCommand("SELECT * FROM Conductors", m_dbConnection)
dbDataAdapter.Fill(m_dsData, "Conductors")
dbDataAdapter.Dispose()
Catch ex1 As Data.DataException
MsgBox("A data exception occured while loading data." & vbCr & "Description: " & ex1.Message, MsgBoxStyle.Exclamation)
m_dbConnection.Close()
m_dbConnection.Dispose()
DbDataAdapter.Dispose()
Catch ex2 As System.Exception
MsgBox("A system exception occured while loading data." & vbCr & "Description: " & ex2.Message, MsgBoxStyle.Exclamation)
m_dbConnection.Close()
m_dbConnection.Dispose()
DbDataAdapter.Dispose()
End Try
End Sub
Public Function EditCongregation(ByVal rCongo As Congregation) As Notification
Dim da As OleDbDataAdapter ', daSpeakers As OleDbDataAdapter
Dim dt As New DataTable
Dim dr As DataRow
Dim commandBuilder As Data.OleDb.OleDbCommandBuilder
Dim drCongos() As DataRow
'Dim dtSpeakers As New DataTable
drCongos = m_dsData.Tables("Congregations").Select("CongregationName = '" & rCongo.Name & "'")
If UBound(drCongos) > -1 Then
If UBound(drCongos) > 0 Then
Return Notification.SevereError
End If
If Not drCongos(0).Item("ID") = rCongo.RecordID Then
Return Notification.CongregationAlreadyExist
End If
End If
'da = New OleDbDataAdapter("SELECT ID, CongregationName, KingdomHallAddress, Coordinator, CoordinatorHome, " & _
' "CoordinatorMobile, CoordinatorEmail, MeetingDay, MeetingTime, KingdomHallPhone FROM Congregations " & _
' "WHERE ID = " & rCongo.RecordID, m_dbConnection)
da = New OleDbDataAdapter("SELECT ID, CongregationName, KingdomHallAddress, Coordinator, CoordinatorHome, " & _
"CoordinatorMobile, CoordinatorEmail, MeetingDay, MeetingTime, KingdomHallPhone FROM Congregations", m_dbConnection)
da.Fill(dt)
'da = New OleDbDataAdapter("SELECT ID, CongregationName, KingdomHallAddress, Coordinator, CoordinatorHome, " & _
' "CoordinatorMobile, CoordinatorEmail, MeetingDay, MeetingTime, KingdomHallPhone " & _
' "FROM Congregations", m_dbConnection)
'da.Fill(dt)
commandBuilder = New OleDbCommandBuilder(da)
drCongos = dt.Select("ID = " & rCongo.RecordID)
'daCongo = New OleDbDataAdapter("SELECT CongregationName, Speaker, Coordinator, SpeakerHome, " & _
' "SpeakerMobile, SpeakerEmail, MeetingDay, MeetingTime, KingdomHallPhone FROM CongregationSpeakers " & _
' "WHERE CongregationName = '" & strName & "'", m_dbConnection)
If UBound(drCongos) = -1 Then
EditCongregation = Notification.CongregationNotFound
ElseIf UBound(drCongos) > 0 Then
EditCongregation = Notification.SevereError
Else
dr = drCongos(0)
dr.Item("CongregationName") = rCongo.Name
dr.Item("Coordinator") = rCongo.Coordinator
dr.Item("CoordinatorEmail") = rCongo.CoordinatorEmail
dr.Item("CoordinatorHome") = rCongo.CoordinatorHome
dr.Item("CoordinatorMobile") = rCongo.CoordinatorMobile
dr.Item("KingdomHallAddress") = rCongo.KingdomHallAddress
dr.Item("KingdomHallPhone") = rCongo.KingdomHallPhone
dr.Item("MeetingDay") = rCongo.MeetingDay
dr.Item("MeetingTime") = rCongo.MeetingTime
da.Update(dt)
m_dsData.Tables.Remove("Congregations")
da.Fill(m_dsData, "Congregations")
EditCongregation = Notification.Successful
End If
End Function
|
|
|
|
|
David Hovey wrote: da.Fill(m_dsData, "Congregations")
I take it, that's the point where you expect the datatable (Congregations) to refresh. Are you getting an exception or what are the symptoms?
|
|
|
|
|
Sorry forgot to clarify...
No exception occurs. It is very odd. I feel like I'm doing something wrong that is dumb and simple.
No exception occurs and after running the Fill method, I've tested the table to see if a value is updated and it is...But then. After routine is finished the value is back to previous.
Do I need to set a property for run a method on the table or dataset to allow the rows to update?
The way I can fix it is by delete the table altogether and then using the Fill method. That obviously works.
But in other circumstances the new table may not contain that columns that existed before.
|
|
|
|
|
Okay, some guesses:
Have you noticed this on documentation:
When using subsequent Fill calls to refresh the contents of the DataSet, two conditions must be met:
1. The SQL statement should match the one initially used to populate the DataSet.
2. The Key column information must be present. If primary key information is present, any duplicate rows are reconciled and only appear once in the DataTable that corresponds to the DataSet. Primary key information may be set either through FillSchema, by specifying the PrimaryKey property of the DataTable, or by setting the MissingSchemaAction property to AddWithKey.
Also I'm not sure what's the status of each row after refresh so after refilling the dataset you could have a look with the debugger and if the states are modified, accept changes after fill (on the whole dataset). Somehow the behaviour sounds like the changes might have been rejected somewhere in the other parts of the code.
|
|
|
|
|
Thanks for your help Mika.
You were right all along. There were a couple things I was doing wrong during my debugging to figure this out. But in the end Number 2 of your last post was the problem.
I didn't think the PrimaryKey was the problem because when I open the database in Access 2007 (using 2007 version database) it shows my column ID as the primary key. This is the column that Access automatically created when I first created the tables.
Shouldn't the OleDbDataAdapter read this information about the primary key??
Thanks again!
|
|
|
|
|
David Hovey wrote: Thanks for your help
No problem.
David Hovey wrote: Shouldn't the OleDbDataAdapter read this information about the primary key
When using just Fill-method it won't read anything else than basic properties (column names, data types for columns etc). If you want to have a data table which corresponds to the schema in Access, I think when creating the table for the first time, you should do something like this (before the first fill):
da.FillSchema(m_dsData, SchemaType.Mapped);
|
|
|
|
|
Hello Friends,
I wrote a query for a purpose like this;I have a field by name "CustomerName".I want it to be split as FirstName and LastName as shown below:
CustomerName FirstName LastName
Jack Daniels Jack Daniels
Jack,Daniels Jack Daniels
My query looks like this;
select substring(customername,1,CHARINDEX(',', customername) -1) as [firstname ],
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername)) AS [LastName]
from TableName
My Problem is i have two conditions the splitter could be "," or "" in the customername field
I need to integrate this conditions to my query either using "case" or "iif".
ie if the charindex is " " do this and if the charindex is ", " do this
I am not sure how i can do this.Any help is welcome
|
|
|
|
|
Use CASE[^] and test if CHARINDEX for comma or space is greater than 0 and based on that use SUBSTRING to split the string. Something like:
... CASE
WHEN CHARINDEX(',', customername) > 0 THEN SUBSTRING(customername,1, CHARINDEX(',', customername) -1)
ELSE SUBSTRING(customername,1,CHARINDEX(' ', customername) -1)
END AS FirstName ....
|
|
|
|
|
Hi Mika,
I modified my query like this;It still is not working 
select customername,
case when CHARINDEX(',', customername)>0 then
substring(customername,1,CHARINDEX(',', customername) -1) as [firstname ],
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername)) AS [LastName]
else
substring(customername,1,CHARINDEX(',', customername) -1) as [firstname ],
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername)) AS [LastName]
from TableName
|
|
|
|
|
Trustapple wrote: It still is not working
Getting and error message?
I think it should be more like (may contain several typos):
select customername,
case
when CHARINDEX(',', customername)>0 then
substring(customername,1,CHARINDEX(',', customername) -1)
else
substring(customername,1,CHARINDEX(' ', customername) -1)
end as [firstname ],
case
when CHARINDEX(',', customername)>0 then
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername))
else
SUBSTRING(customername, CHARINDEX(' ', customername) + 1, LEN(customername))
end AS [LastName]
from TableName
|
|
|
|
|
Hey Mika,
Thanks for you trying to help.My server i unavailable now.I will be able to access it only after 5hours.As soon as i try thi s query i will post a reply and let you know.
Many Thanks for your help....
Merry Christmas
|
|
|
|
|
|
Hey Mika,
Thanks again to you and Ben....It worked.I made slight modification in the query though...a very slight one.
The credit goes to you guys ....
Please see the working query and let me know if any tweaking is necessary...becuase i will be cghnaging this select to update query for around 9million records.....
select customername,
-- get the last name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(',', customername) - 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, CHARINDEX(' ', customername) + 1, LEN(customername) - CHARINDEX(' ', customername) + 1) -- space is delimiter
else
'' -- neither comma nor space found
end as [lastname],
-- get the first name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername) - CHARINDEX(',', customername) + 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(' ', customername) - 1) -- space is delimiter
else
'' -- neither comma nor space found
end AS [firstname]
from TableName
|
|
|
|
|
Hey Mika,
The time now is 7:59 AM for you,i beleive....Happy sleeping .
Thanks again to you and Ben....It worked.I made slight modification in the query though...a very slight one.
The credit goes to you guys ....
Please see the working query and let me know if any tweaking is necessary...becuase i will be cghnaging this select to update query for around 9million records.....
select customername,
-- get the last name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(',', customername) - 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, CHARINDEX(' ', customername) + 1, LEN(customername) - CHARINDEX(' ', customername) + 1) -- space is delimiter
else
'' -- neither comma nor space found
end as [lastname],
-- get the first name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername) - CHARINDEX(',', customername) + 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(' ', customername) - 1) -- space is delimiter
else
'' -- neither comma nor space found
end AS [firstname]
from TableName
|
|
|
|
|
I think it should be:
select customername,
-- get the last name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(',', customername) - 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(' ', customername) - 1) -- space is delimiter
else
'' -- neither comma nor space found
end as [lastname],
-- get the first name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername) - CHARINDEX(',', customername) + 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, CHARINDEX(' ', customername) + 1, LEN(customername) - CHARINDEX(' ', customername) + 1) -- space is delimiter
else
'' -- neither comma nor space found
end AS [firstname]
from TableName
Keep It Simple Stupid! (KISS)
|
|
|
|
|
Yeah, you're rught. I misplaced the commas. Corrected now.
Ben Fair wrote: SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername) - CHARINDEX(',', customername) + 1) -- comma is delimiter
Although it's 'cleaner' to use the rest of the length as a parameter, it's not necessary. Basically if you want the rest of the string you can pass any value as long as it's at least the rest of the length.
|
|
|
|
|
Oh, I wasn't aware of that; I'll have to remember that! Thanks!
Keep It Simple Stupid! (KISS)
|
|
|
|
|
Hey ,
Thanks a lot to you and Mika it worked.
You guys have been wonderful.
Hey i ran into another problem....
I might need to integrate one more condition;ie along with our query i want it to also do this that is if the customername is Mika (ie the name is only one word and it doesnot contain any ',' or ' ')Then it should update to FirstName.....Am pasting the working query below can any of you integrate this to my query.....
Name FirstName LastName
Mika Mika
Ben Ben
QUERY:update TableName
set lastname=
-- get the last name
case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(',', customername) - 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, CHARINDEX(' ', customername) + 1, LEN(customername) - CHARINDEX(' ', customername) + 1) -- space is delimiter
else
'' -- neither comma nor space found
end,
-- get the first name
firstname = case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername) - CHARINDEX(',', customername) + 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(' ', customername) - 1) -- space is delimiter
else
'' -- neither comma nor space found
end
modified on Thursday, December 11, 2008 2:23 AM
|
|
|
|
|
Trustapple wrote: Thanks
You're welcome.
Trustapple wrote: along with our query i want it to also do this that is if the customername is Mika (ie the name is only one word and it doesnot contain any ',' or ' ')Then it should update to FirstName.....
Do you mean something like this:
update TableName
set lastname
= case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(',', customername) - 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, CHARINDEX(' ', customername) + 1, LEN(customername) - CHARINDEX(' ', customername) + 1) -- space is delimiter
else
TableName.LastName --<code> no delimitter so don't change lastname in the table</code>
end,
firstname
= case
when CHARINDEX(',', customername) > 0 then
SUBSTRING(customername, CHARINDEX(',', customername) + 1, LEN(customername) - CHARINDEX(',', customername) + 1) -- comma is delimiter
when CHARINDEX(' ', customername) > 0 then
SUBSTRING(customername, 1, CHARINDEX(' ', customername) - 1) -- space is delimiter
else
customername -- <code>no delimiter so use the full data to firstname</code>
end ...
|
|
|
|
|
Hey Mika,
I got it working.Thanks for your help......again .
Lots of Bestwishes,
Jiju
|
|
|
|
|
Trustapple wrote: Thanks for your help
You're welcome.
|
|
|
|
|
Hallo,
I am working in an company which is using extensivly right outer joins. I argue that outer joins are bad for performance, and we have a lot of performance problems. We are using db2 from IBM.
To show you an example (a query which returns page size error in system temporary tablespace)
But nobody seems to care. My colleges add more and more right outer joins to querries.
Here is the example:
Please give me some feetback if this is an ordinary query (my colleges say a database must be able to handle this) or if I am right. I think this query is overkill.
SELECT RentObj.Classific1 AS Classific1, RentObj.Classific2 AS Classific2, RentObj.Classific3 AS Classific3, RentObj.Classific4 AS Classific4, RentObj.Classific5 AS Classific5, RentObj.Classific6 AS Classific6, RentObj.Classific7 AS Classific7, RentObj.Classific8 AS Classific8, RentObj.Classific9 AS Classific9, RentObj.Classific10 AS Classific10, RentObj.RentObjId AS RentObjId, Car.RegistrationNumber AS RegistrationNumber, RentObj.Number AS Number, Classification_1.Code AS CCode_1, Classification_2.Code AS CCode_2, Classification_3.Code AS CCode_3, Classification_4.Code AS CCode_4, Classification_5.Code AS CCode_5, Classification_6.Code AS CCode_6, Classification_7.Code AS CCode_7, Classification_8.Code AS CCode_8, Classification_9.Code AS CCode_9, Classification_10.Code AS CCode_10, Car.RentObjId AS Car_RentObjId, Car.FirstLicense AS FirstLicense, Car.ChassisNo AS ChassisNo, Car.CarDocumentNo AS CarDocumentNo, Car.CarKeyNo AS CarKeyNo, Car.CubicCapacity AS CubicCapacity, Car.Kilowatt AS Kilowatt, Car.PayLoad AS PayLoad, Car.RadioCode AS RadioCode, Car.MayorRevison AS MayorRevison, Car.TankContent AS TankContent, Car.Consumption AS Consumption, Car.Kilometer AS Kilometer, Car.UnitNumber AS UnitNumber, Car.KilometerMax AS KilometerMax, Car.KMHigCos AS KMHigCos, Car.KMCI AS KMCI, Car.FuelType AS FuelType, Car.PS AS PS, Car.BrakeSpecInvest AS BrakeSpecInvest, Car.Totalweight AS Totalweight, Car.Unloadedweight AS Unloadedweight, Car.MatchRegNumber AS MatchRegNumber, Car.ConsumptionCityIn AS ConsumptionCityIn, Car.ConsumptionCityOut AS ConsumptionCityOut, Car.CO2Emission AS CO2Emission, RentObj.CompanyId AS CompanyId, RentObj.RentObjTypeId AS RentObjTypeId, RentObj.LicenceeId AS LicenceeId, RentObj.ObjEvent AS ObjEvent, RentObj.StationCIId AS StationCIId, RentObj.ObjPositionCIId AS ObjPositionCIId, RentObj.CostCarrierId AS CostCarrierId, RentObj.CheckInStatPlanId AS CheckInStatPlanId, RentObj.CheckInDatePlan AS CheckInDatePlan, RentObj.State AS State, RentObj.Notice AS Notice, RentObj.SumActCostYear AS SumActCostYear, RentObj.SumEstCostYear AS SumEstCostYear, RentObj.SumActCostMonth AS SumActCostMonth, RentObj.SumActCostDay AS SumActCostDay, RentObj.SumActCostHour AS SumActCostHour, RentObj.SumEstCostsMonth AS SumEstCostsMonth, RentObj.SumActCostWeek AS SumActCostWeek, RentObj.SumEstCostWeek AS SumEstCostWeek, RentObj.CostActDay AS CostActDay, RentObj.CostEstDay AS CostEstDay, RentObj.OperatingLife AS OperatingLife, RentObj.Startavailability AS Startavailability, RentObj.ClassificDescr AS ClassificDescr, RentObj.DateEstSale AS DateEstSale, RentObj.DateActSale AS DateActSale, RentObj.SalesType AS SalesType, RentObj.WebVisible AS WebVisible, RentObj.LedgerId AS LedgerId, RentObj.LedgerAsset AS LedgerAsset, RentObj.TaxId AS TaxId, RentObj.isAlienRentObj AS isAlienRentObj, RentObj.CountService AS CountService, RentObj.CreateDataSrc AS CreateDataSrc, RentObj.RentContractNote AS RentContractNote, RentObj.LedgerProcCode AS LedgerProcCode, RentObj.MinDriverLicence AS MinDriverLicence, RentObj.MinDriverAge AS MinDriverAge, RentObj.PriceSellWWW AS PriceSellWWW, RentObj.ListPriceNet AS ListPriceNet, RentObj.ListPriceGross AS ListPriceGross, RentObj.ListPriceType AS ListPriceType, RentObj.PurchasePrice AS PurchasePrice, RentObj.ResidalPrice AS ResidalPrice, RentObj.PurchaseDiscount AS PurchaseDiscount, RentObj.AmortizationType AS AmortizationType, RentObj.AmortizationRecord AS AmortizationRecord, RentObj.BankPercent AS BankPercent, RentObj.LastBankAmount AS LastBankAmount, RentObj.AmortizationAct AS AmortizationAct, RentObj.CustKeyBuyer AS CustKeyBuyer, RentObj.LeasingStart AS LeasingStart, RentObj.LeasingEnd AS LeasingEnd, RentObj.CustKeyLeaser AS CustKeyLeaser, RentObj.LeasingDuration AS LeasingDuration, RentObj.RentDurationType AS RentDurationType, RentObj.CustKeySup AS CustKeySup, RentObj.LeasBackBuy AS LeasBackBuy, RentObj.LeasBackBuyDate AS LeasBackBuyDate, RentObj.LeasRate AS LeasRate, RentObj.SupOrderNo AS SupOrderNo, RentObj.UsageState AS UsageState, RentObj.DamageCount AS DamageCount, RentObj.DamageCosts AS DamageCosts, RentObj.TransferCosts AS TransferCosts, RentObj.CountWKZPrint AS CountWKZPrint, RentObj.WKZType AS WKZType, RentObj.WKZDemarc AS WKZDemarc, RentObj.WKZBase AS WKZBase, RentObj.WKZAmount AS WKZAmount, RentObj.WKZDueDate AS WKZDueDate, RentObj.WKZDuration AS WKZDuration, RentObj.WKZPersonAccNo AS WKZPersonAccNo, RentObj.WKZPercent AS WKZPercent, RentObj.WKZTaxId AS WKZTaxId, RentObj.ActivOrgaKey AS ActivOrgaKey, RentObj.RentContractId AS RentContractId, RentObj.RentObjTransactId AS RentObjTransactId, RentObj.WWWSellDescr AS WWWSellDescr, RentObj.PurchasePrCalcPer AS PurchasePrCalcPer, RentObj.PurchasePrCalcMonth AS PurchasePrCalcMonth, RentObj.PurchasePrCalcBase AS PurchasePrCalcBase, RentObj.CalcCode1 AS CalcCode1, RentObj.CalcCode2 AS CalcCode2, RentObj.CalcCode3 AS CalcCode3, RentObj.CalcCode4 AS CalcCode4, RentObj.CalcCode5 AS CalcCode5, RentObj.CalcCode6 AS CalcCode6, RentObj.CalcCode7 AS CalcCode7, RentObj.CalcCode8 AS CalcCode8, RentObj.CalcCode9 AS CalcCode9, RentObj.CalcCode10 AS CalcCode10, RentObj.Classific11 AS Classific11, RentObj.Classific12 AS Classific12, RentObj.Classific13 AS Classific13, RentObj.Classific14 AS Classific14, RentObj.Classific15 AS Classific15, RentObj.ClassificDescr2 AS ClassificDescr2, RentObj.ClassificDescr3 AS ClassificDescr3, RentObj.ClassificDescr4 AS ClassificDescr4, RentObj.ClassificDescr5 AS ClassificDescr5, RentObj.ContentRentObjId AS ContentRentObjId, RentObj.PropertyVariId AS PropertyVariId, RentObj.LedgerIdDeprec AS LedgerIdDeprec, RentObj.LedgerIdAsset AS LedgerIdAsset, RentObj.SupBillNo AS SupBillNo, RentObj.BillingDate AS BillingDate, RentObj.InsurClassific1 AS InsurClassific1, RentObj.InsurClassific2 AS InsurClassific2, RentObj.LeasContractNo AS LeasContractNo, RentObj.CheckOutDate AS CheckOutDate, RentObj.CheckInDate AS CheckInDate, RentObj.CheckOutStationId AS CheckOutStationId, RentObj.Lic_ShortDescr AS Lic_ShortDescr, RentObj.CustKeyPES AS CustKeyPES, RentObj.PESNotice AS PESNotice, RentObj.PESAmountDisc AS PESAmountDisc, RentObj.PESAmountNet AS PESAmountNet, RentObj.hasSellBill AS hasSellBill, RentObj.TaxPerc AS TaxPerc, RentObj.PurchaseDicountAmount AS PurchaseDicountAmount, RentObj.AmountSellPlan AS AmountSellPlan, RentObj.AmountSellNet AS AmountSellNet, RentObj.SellDiscPerc AS SellDiscPerc, RentObj.AmountSellDisc AS AmountSellDisc, RentObj.SellTaxId AS SellTaxId, RentObj.SellTaxPerc AS SellTaxPerc, RentObj.AmountSellGross AS AmountSellGross, RentObj.PurchaseTaxAmount AS PurchaseTaxAmount, RentObj.AmountSellTax AS AmountSellTax, RentObj.AgentIdBuyer AS AgentIdBuyer, RentObjType.RentObjTypeNo AS RentObjTypeNo, CostCarrier.Descr1 AS CostCarrier_Descr1, CostCarrier.CostCarrierNo AS CostCarrierNo, CostCarrier.CostCarrierNoC AS CostCarrierNoC, Ledger.LedgerNo AS LedgerNo, Ledger.Descr1 AS Ledger_Descr1, Ledger.TaxPercentage AS TaxPercentage, Ledger.LedgerNoC AS LedgerNoC, RentObj.StateShortDescr AS StateShortDescr, RentObj.AssetNo AS AssetNo, BusinessArea.ShortDescr AS BusinessAreaShortDescr, RentObj.BusinessAreaId AS BusinessAreaId, BusinessAreaAsset.ShortDescr AS BussAreaAssetShortDescr, RentObj.BussAreaAssetId AS BussAreaAssetId, RentObj.ExtCode1 AS ExtCode1, RentObj.ExtCode2 AS ExtCode2, RentObj.ExtCode3 AS ExtCode3, RentObj.ExtCode4 AS ExtCode4, RentObj.ExtCode5 AS ExtCode5, RentObj.ClassificDamageImageId AS ClassificDamageImageId, RentObj.NextAppointmentDate AS NextAppointmentDate, RentObj.NextAppointmentKM AS NextAppointmentKM, RentObj.NextAppointmentDateType AS NextAppointmentDateType, RentObj.NextAppointmentKMType AS NextAppointmentKMType, RentObj.hasBuyBill AS hasBuyBill, RentObj.DoAutoCalculateCosts AS DoAutoCalculateCosts, RentObj.WKZNo AS WKZNo, RentObj.WKZBonusNo AS WKZBonusNo, RentObj.PlanStartAvailability AS PlanStartAvailability, Classification11.Code AS CCode_11, Classification12.Code AS CCode_12, RentObj.PESAmountOpen AS PESAmountOpen, RentObj.PESAmountBooked AS PESAmountBooked, RentObj.LastAccrualDate AS LastAccrualDate, RentObj.ClassificDescr6 AS ClassificDescr6, Classification_1.ShortDescr AS ShortDescr_CL1, Classification_2.ShortDescr AS ShortDescr_CL2, Classification_3.ShortDescr AS ShortDescr_CL3, Classification_4.ShortDescr AS ShortDescr_CL4, Classification_5.ShortDescr AS ShortDescr_CL5, Classification_6.ShortDescr AS ShortDescr_CL6, Classification_7.ShortDescr AS ShortDescr_CL7, Classification_8.ShortDescr AS ShortDescr_CL8, Classification_9.ShortDescr AS ShortDescr_CL9, Classification_10.ShortDescr AS ShortDescr_CL10, Classification11.ShortDescr AS ShortDescr_CL11, Classification12.ShortDescr AS ShortDescr_CL12, RentObj.cid_modda AS cid_modda, RentObj.CountABDataInt1 AS CountABDataInt1, RentObj.CountABDataInt2 AS CountABDataInt2, RentObj.CountABDataInt3 AS CountABDataInt3, 'EMA' AS EMA, RentObj.SellPlanDampingPr AS SellPlanDampingPr, RentObj.OwnRentObj AS OwnRentObj, Classification_1.ClassificationId AS ClassificationId1, Classification_10.ClassificationId AS ClassificationId10, Classification_2.ClassificationId AS ClassificationId2, Classification_3.ClassificationId AS ClassificationId3, Classification_4.ClassificationId AS ClassificationId4, Classification_5.ClassificationId AS ClassificationId5, Classification_6.ClassificationId AS ClassificationId6, Classification_7.ClassificationId AS ClassificationId7, Classification_8.ClassificationId AS ClassificationId8, Classification_9.ClassificationId AS ClassificationId9, Classification11.ClassificationId AS ClassificationId11, Classification12.ClassificationId AS ClassificationId12 FROM CRM.Car Car, CRM.Classification Classification12 RIGHT OUTER JOIN CRM.Classification Classification11 RIGHT OUTER JOIN CRM.BusinessArea BusinessAreaAsset RIGHT OUTER JOIN CRM.BusinessArea BusinessArea RIGHT OUTER JOIN CRM.Ledger Ledger RIGHT OUTER JOIN CRM.CostCarrier CostCarrier RIGHT OUTER JOIN CRM.RentObjType RentObjType RIGHT OUTER JOIN CRM.Classification Classification_2 RIGHT OUTER JOIN CRM.Classification Classification_3 RIGHT OUTER JOIN CRM.Classification Classification_4 RIGHT OUTER JOIN CRM.Classification Classification_5 RIGHT OUTER JOIN CRM.Classification Classification_6 RIGHT OUTER JOIN CRM.Classification Classification_7 RIGHT OUTER JOIN CRM.Classification Classification_8 RIGHT OUTER JOIN CRM.Classification Classification_9 RIGHT OUTER JOIN CRM.Classification Classification_10 RIGHT OUTER JOIN CRM.Classification Classification_1 RIGHT OUTER JOIN CRM.RentObj RentObj ON Classification_1.ClassificationId = RentObj.Classific1 ON Classification_10.ClassificationId = RentObj.Classific10 ON Classification_9.ClassificationId = RentObj.Classific9 ON Classification_8.ClassificationId = RentObj.Classific8 ON Classification_7.ClassificationId = RentObj.Classific7 ON Classification_6.ClassificationId = RentObj.Classific6 ON Classification_5.ClassificationId = RentObj.Classific5 ON Classification_4.ClassificationId = RentObj.Classific4 ON Classification_3.ClassificationId = RentObj.Classific3 ON Classification_2.ClassificationId = RentObj.Classific2 ON RentObjType.RentObjTypeId = RentObj.RentObjTypeId ON CostCarrier.CostCarrierId = RentObj.CostCarrierId ON Ledger.LedgerId = RentObj.LedgerId ON BusinessArea.BusinessAreaId = RentObj.BusinessAreaId ON BusinessAreaAsset.BusinessAreaId = RentObj.BussAreaAssetId ON Classification11.ClassificationId = RentObj.Classific11 ON Classification12.ClassificationId = RentObj.Classific12 WHERE Car.RentObjId = RentObj.RentObjId AND (((RentObj.ObjEvent = '20')) AND ((RentObj.State = '02')) AND RentObj.isAlienRentObj = 0) AND (RentObj.CompanyId = 10) ORDER BY 14 ASC
|
|
|
|
|
Joining 18 tables does not seem like a good idea. You need a data warehouse with denormalized design.
Maybe the Right outer join is a business requirement. But we should not assume that the database will just handle this!! Here comes our responsibility as developers, designers and DBAs to optimize the structure to satisfy business needs.
|
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
