C / C++ / MFC

11-Jul-08 4:59

I tested your code as follows:

struct CStockEntry
{
	int entry;
	CStockEntry(int i = 0)  {entry = i;}
};

class DeptStock
{
public:
	CArray<CStockEntry, CStockEntry> stockArr;   

	void SetCStockEntryArr(CArray<CStockEntry, CStockEntry>& arr) 
	{   
		for (int i=0; i <= arr.GetUpperBound(); i++) 
		{   
			CStockEntry se = arr.GetAt(i);   
			this->stockArr.Add(se);   
		}   

		CString s1 = _T("Size of copied Array & Org:");   
		s1.Format(_T("%s %d %d"), s1, stockArr.GetSize(), arr.GetSize());  // This shows same number of arr & stockArr GetSize 
		AfxMessageBox(s1);   

		s1.Empty();   
		return;   
	}   

	CArray<CStockEntry, CStockEntry>& GetStockEntryArr() 
	{   
		CString s1 = _T("Size of Returning Array:");   
		s1.Format(_T("%s %d"), s1, stockArr.GetSize());  // This shows 0 as GetSize 
		AfxMessageBox(s1);   

		s1.Empty();   

		return this->stockArr;   
	}   
};

...

	CArray<CStockEntry, CStockEntry> stockArr;
	stockArr.Add(CStockEntry(0));
	stockArr.Add(CStockEntry(1));
	stockArr.Add(CStockEntry(2));
	stockArr.Add(CStockEntry(3));
	stockArr.Add(CStockEntry(4));
	DeptStock test;
	test.SetCStockEntryArr(stockArr);
	CArray<CStockEntry, CStockEntry> &stockArrRef = test.GetStockEntryArr();

It works fine.

What aren't you showing?

FWIW, calling Empty() on those local CStrings is unnecessary.

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Re: CArray problem

Trupti Mehta12-Jul-08 0:57

Trupti Mehta

12-Jul-08 0:57

Hi Mark,

If I add objects in array like you are adding, then my code is working perfect. But I am working different way. In my GUI, I add objects in the array in my GUI CPage4 (m_page4 member var), then on Ok button I create DeptStock deptStock object & SetCStockEntryArr(m_page4.GetStockEntries()).
TILL this things are fine.
Then I pass deptStock to a file to store the object details in file.
g_dbOperations.Write_StockTextFile(deptStock);

// WRITE Departments MAP TO FILE
void DbOperations::Write_StockTextFile(DeptStock deptStock) {
	
        .........  
	CString toWrite;
	int index = -1;

	OperatorDetails od = deptStock.GetOperator();
	DeptDetails dd = deptStock.GetDept();
	CArray<cstockentry,>& stockArr = deptStock.GetStockEntryArr();  // This returns 0 sizxe array
//	stockArr = deptStock.GetStockEntryArr();

/*	CStockEntry cse1(2.2f, 5, 10.2f);
	CStockEntry cse2(5.0f, 3, 15.0f);
	stockArr.Add(cse1);
	stockArr.Add(cse2);
*/	
	CString str(_T("Stock Size:"));
	str.Format(_T("%s %d \n %s %d"), str, stockArr.GetSize(), _T("Dept Stock Arr "), deptStock.GetStockEntryArr().GetSize());   
	AfxMessageBox(str);   // Both DISPLAYS 0

This is how the flow is. If I remove the above comments of adding objects od CStockEntry to stockArr, it gives proper results. But I have already added the array elements & not able to retrive.

I have given a better & clear picture of the flow of my program & error point. Hope you can help me out to track the problem.

Thanks

Terry

Re: CArray problem

Mark Salsbery12-Jul-08 7:47

How can I display a cursor for the text?

12-Jul-08 7:47

Trupti Mehta wrote:
If I add objects in array like you are adding, then my code is working perfect.

That should help you track it down. If your array is empty, debug the code
that's supposed to populate it...why are no items added?

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

danginkgo11-Jul-08 3:35

danginkgo

11-Jul-08 3:35

I am displaying some text in a window.
I want to have a text cursor when I click the mouse left button.
How can I do this?

danginkgo

Re: How can I display a cursor for the text?

led mike11-Jul-08 5:22

led mike

11-Jul-08 5:22

danginkgo wrote:
I am displaying some text in a window.
I want to have a text cursor when I click the mouse left button.
How can I do this?

Well it's called a Caret, but if you are trying to create your own text editing window you have a lot of work to do.

SetCaretPos[^]

led mike

Regarding Application.ScreenUpdating() - Draw Graph in Excel

vimaltiwari11-Jul-08 3:35

vimaltiwari

11-Jul-08 3:35

Hi,
i want to draw the graph in excel by parsing file,
so when i have parsed the data, in that period i want to hide the construction of the graph between the parsing process completion,In Excel we can write this script to hide the Macro:
Application.ScreenUpdating = false or true,

and between this processing period we can show message in status bar by using this
Application.StatusBar = "Now processing File "
Application.StatusBar = false;

i want to do this in the C++, Is that any method available in that which can corelate the same functionality as like as excel scripting..

Thanks in advance,

Regards,
Vimal

Re: Regarding Application.ScreenUpdating() - Draw Graph in Excel

led mike11-Jul-08 5:25

led mike

11-Jul-08 5:25

The Office products expose COM interfaces. For Excel it's called the Excel Object Model. Each Version it changes to some degree so you should use the correct version. Here is a link to one

http://msdn.microsoft.com/en-us/library/aa141044(office.10).aspx[^]

led mike

EnterCriticalSection() problem on Vista

SRKSHOME11-Jul-08 3:31

11-Jul-08 3:31

Hi,
I have thread running. It will EnterCriticalSection at some poit. This works perfectly alright on Windows XP or lower versions of OS. But it is not working on Vista. Sometime it works but sometimes it doesn't. It always stuck at EnterCriticalSection(). It is not able to get the ownership. I have written code like:

pReadList->Request(); //This function calls EnterCriticalSection(. But it will always stuck on Vista.

if( some condition )
{
//some action
}
pReadList->Release() //This function calls LeaveCriticalSection() API.

Please help.
Thanks

Mark Salsbery11-Jul-08 5:27

11-Jul-08 5:27

SRKSHOME wrote:
This works perfectly alright

Extremely unlikely. "Appears to work perfectly" is probably more accurate.

You don't show any relevant code, so it's tough to offer any kind of help.

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SRKSHOME14-Jul-08 4:58

14-Jul-08 4:58

Here is sample code. Please help

void DSReadableConnectionThread::RemoveConnection( const DSReadableConnection &connection )
{
pReadList->Request(); /*Request()calls ::EnterCriticalSection().This works in windows xp and below versions of OS. But it is not working on Vista. It contineously wait at EnterCriticalSection().
pNewConnectionList>Request();*/

if( !pReadList->Remove(connection) )
{
pNewConnectionList->Remove( connection );
}
// If no connections to process then put ThreadMain() to sleep

if( pReadList->isEmpty()&& pNewConnectionList->isEmpty() )
{
ready.ClearSignal();
}
pNewConnectionList->Release();
pReadList->Release();
}

Mark Salsbery14-Jul-08 5:43

14-Jul-08 5:43

The only way this can happen is if another thread is already "in" the
critical section. But that wouldn't work on any OS.

If you can put together a project that builds and fails that will run on
my machine, I can take a look. Otherwise it's really hard to debug from here Smile | :)

There's still no relevant code I've seen. Is the critical section initialized properly
before any thread tries to enter it?

Are you positive it's deadlocking at the EnterCriticalSection?

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SRKSHOME14-Jul-08 19:09

14-Jul-08 19:09

I checked it again. Initialization of critical section is properly done.
Here is actual code goes..

inline void Request() const
{
EnterCriticalSection( &_section ); //Here actually it stuck on Vista.
::InterlockedIncrement(&m_nLockCount);
}

If some other thread is using this crititcal section,it shouldn't have worked on any other os also.But it is working perfectly except on Vista.
Is there any change on Vista architecture in threading and synchronization. Something is mentioned in this link: http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=510229&SiteID=1
Do you have any idea on this?

Mark Salsbery15-Jul-08 5:36

15-Jul-08 5:36

The only difference in Vista is the threading is more efficient.
The changes can expose problems in improperly written threading code
(not as many problems as multi-core machines expose Smile | :)

).

You've got some kind of deadlock. Maybe put TRACE statements before
and after EVERY enter/leave of the critical section and see if you can find
it. I don't know what else to say except you need to debug it.

Why the InterlockedIncrement() call? What is the critical section protecting?

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SRKSHOME17-Jul-08 3:12

17-Jul-08 3:12

Hi...
I have checked it again. I don’t think there is any deadlock present. There is no resource as such on which more than 1 threads are waiting.

LockCount - RecursionCount = Number of waiting threads

In my case, Number of waiting threads = 0.

But I found one more interesting thing on vista. WaitForSingleObject() is used here. When I called this function with TIMEOUT=INFINITE. It is not coming out of loop at all. It will be looping there. On Vista WaitForSingleObject() returns 258(I guess it is=WAIT_TIMEOUT). But on XP and lower versions of OS this function returns 0(I guess it is=WAIT_OBJECT_0) and come out of the of the loop.Please see the below code.

bool DSEventSemaphore::WaitForSignal( DWORD TimeOut ) //TimeOut=INFINITE

{
if( State == SemInvalid )
{
return false;
}
DWORD retval;

#ifndef DSTRACEABLE_SIGNAL_STACK /*I haven't defined it. So it wiil not execute.*/
retval = WaitForSingleObject( event, TimeOut );

#else //It will come here
do
{ retval = WaitForSingleObject( event, (TimeOut< DSSLEEP_PERIOD ? TimeOut : DSSLEEP_PERIOD) ); //DSSLEEP_PERIOD=500
if( retval == WAIT_TIMEOUT )
{
if( TimeOut < DSSLEEP_PERIOD )
{
TimeOut = 0;
}
else
if( TimeOut != INFINITE )
{
TimeOut -= DSSLEEP_PERIOD;
}
}
else
{
TimeOut = 0;
}

} while( TimeOut );

#endif

switch (retval)
{
case WAIT_OBJECT_0:
State = SemOK;
return true;

case WAIT_TIMEOUT:
State = SemTimeOut;
Error = GetLastError();
return false;

case WAIT_FAILED:
default:
Error = GetLastError();
State = SemSystemError;
return false;
}
}

Could you please help me.

Mark Salsbery17-Jul-08 5:37

17-Jul-08 5:37

Forget about the difference between XP and Vista. It's not relevant
at all. The same threading rules apply as always. Vista can be much
more efficient at exposing faulty threading code. If it works on one
OS and not on another, then it DOESN'T WORK. I've found bugs YEARS
after I wrote the code that suddenly fail on a new OS. Also moving
from single core to multi-core machines can expose threading bugs.

Back to your code...

If WaitForSingleObject(INFINITE) is blocking forever, then the handle
is never getting signaled. It's that simple.

What code is responsible for signaling the event?

(FWIW, "event" is a keyword in C++ - you may not want to use that as a variable name Smile | :)

)

Mark

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

SRKSHOME12-Aug-08 1:05

12-Aug-08 1:05

Hi mark,
Finaly I am able resolve the issue.This issue is a classical example of starvation. The critical section is held by thread and is being released and requested again immediately in a tight while loop. This never allows other threads to acquire the critical section. But it is working on xp OS. This was leading to starvation on vista for the thread/threads waiting on that critical section. I have used the SwitchToThread() API call( sleep() also serve the purpose).But I found SwitchToThread() is better option. Looks like threading model on Vista is more efficient.

thanks for your help.

Joe Woodbury11-Jul-08 10:26

Joe Woodbury

11-Jul-08 10:26

It's "stuck" because that critical section is being used by another thread!

One possibility is that an exception is being thrown over the release.

Anyone who thinks he has a better idea of what's good for people than people do is a swine.
- P.J. O'Rourke

SRKSHOME11-Jul-08 23:35

11-Jul-08 23:35

Is there anyway to know which thread is using critical section?