Re: std::string to char* - C / C++ / MFC Discussion Boards

Re: std::string to char*

Stephen Hewitt1-Jul-08 14:34

Stephen Hewitt

1-Jul-08 14:34

That's assuming you cast away the consts so it even compiles.

Steve

Re: std::string to char*

CPallini1-Jul-08 21:26

CPallini

1-Jul-08 21:26

Good point indeed.
Smile | :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Re: std::string to char*

Stephen Hewitt1-Jul-08 14:33

Stephen Hewitt

1-Jul-08 14:33

toxcct wrote:
const char* exeroot = path.c_str();
strcat(exeroot, "/");
strcat(exeroot, "CharacterAnimation.exe");

Bad advice. The buffer returned from c_str is const and thus can't be modified. And it's wrong to cast away the const as it's const for a reason: the buffer used by a std::string need not be contiguous memory. If this is the case calling c_str makes a temporary buffer and copies the non-contiguous memory blocks into one contiguous memory block for you. It is not required to copy the blocks back. Also your code is in serious danger of causing a buffer overrun (if you made it compile by casting away the const): how do you know how big the buffer is?

Anyway the correct way is simpler, safe, works, is portable and requires no casts:

std::string path = dtCore::GetDeltaRootPath();
path += "/CharacterAnimation.exe";
system(path.c_str());

Steve

Re: std::string to char*

killabyte1-Jul-08 2:20

killabyte

1-Jul-08 2:20

You are sending strcat() the wrong param type i think.

std::string path = dtCore::GetDeltaRootPath();
const char* exeroot = path.c_str();
char* StrToCat = path.c_str();

strcat(StrToCat,"/");
strcat(StrToCat,","CharacterAnimation.exe");

etc..

Re: std::string to char*

CPallini1-Jul-08 2:29

CPallini

1-Jul-08 2:29

Buffer overrun along the horizon.
Smile | :)

Re: std::string to char*

killabyte1-Jul-08 2:34

killabyte

1-Jul-08 2:34

absolutely, but i only meant to identify the problem a lil more clearly Frown | :(

Re: std::string to char*

Stephen Hewitt1-Jul-08 14:42

Stephen Hewitt

1-Jul-08 14:42

This is seriously wrong. See http://www.codeproject.com/script/Forums/View.aspx?fid=1647&msg=2620460[^] for details.

Steve

Re: std::string to char*

CPallini1-Jul-08 2:24

CPallini

1-Jul-08 2:24

T.RATHA KRISHNAN wrote:
I followed the same method. But the following code:

Nope. You got it wrongly.

T.RATHA KRISHNAN wrote:
std::string path = dtCore::GetDeltaRootPath();
const char* exeroot = path.c_str();
strcat(path,"/");
strcat(path,"CharacterAnimation.exe");
result = system(path);
return true;

change to

std::string path = dtCore::GetDeltaRootPath();
path +="/";
path +="CharacterAnimation.exe";
result = system(path.c_str());
return true;

Re: std::string to char*

T.RATHA KRISHNAN1-Jul-08 2:39

T.RATHA KRISHNAN

1-Jul-08 2:39

Thanks a lot. I resolved the errors. But now my problem is: the variable path contains "Program Files". Compiler takes only Program leaving the space and after that. So the console displays an error: "C:\Program" is not recognized as an internal or external command,operable program or batch file. What to do?

Re: std::string to char*

toxcct1-Jul-08 2:46

toxcct

1-Jul-08 2:46

F*CK, you don't listen to me.

if you were using ShellExecute, that wouldn't have happened.
use quotes ( " " ) around your string (within the string I mean), or use ShellExecute

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: std::string to char*

T.RATHA KRISHNAN1-Jul-08 2:54

T.RATHA KRISHNAN

1-Jul-08 2:54

I don't understand this:(with in the string). My string definition is:

path += "/";
  path += "CharacterAnimation.exe";
  result = system(path.c_str());

Where should I put double quotes?

Re: std::string to char*

toxcct1-Jul-08 2:58

toxcct

1-Jul-08 2:58

god, do you understand this : use ShellExecute ?????
::ShellExecuteA(NULL, "open", path.c_str(), NULL, NULL, SW_NORMAL);

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: std::string to char*

SandipG 1-Jul-08 3:11

SandipG

1-Jul-08 3:11

Regards,
Sandip.

Re: std::string to char*

T.RATHA KRISHNAN1-Jul-08 3:20

T.RATHA KRISHNAN

1-Jul-08 3:20

Thanks. It's working now.

Re: std::string to char*

toxcct1-Jul-08 3:22

toxcct

1-Jul-08 3:22

T.RATHA KRISHNAN wrote:
Thanks. It's working now

at last... glad to hear that

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: std::string to char*

Mark Salsbery1-Jul-08 7:29

Mark Salsbery

1-Jul-08 7:29

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

Re: std::string to char*

SandipG 1-Jul-08 3:08

SandipG

1-Jul-08 3:08

You dont like ShellExecute(), do you??

within string means something like this

path += "\""; in the beginning and end also.

BTW if you have followed toxcct and used ShellExecute() there would not have be so much waste of your time.

Regards,
Sandip.

Re: std::string to char*

SandipG 1-Jul-08 2:56

SandipG

1-Jul-08 2:56

Relax dude Cool | :cool:

don't get so much angry Smile | :)

Regards,
Sandip.

Re: std::string to char* [modified]

CPallini1-Jul-08 3:00

CPallini

1-Jul-08 3:00

Whenever you have a path containing spaces, you need to (double)quote the it, i.e.

path = "\"" + path + "\"";
system( path.c_str());

modified on Tuesday, July 1, 2008 9:06 AM

Re: std::string to char*

toxcct1-Jul-08 3:14

toxcct

1-Jul-08 3:14

system() is deprecated.

moreover, i think we really should avoid to mention it anymore with this *ù"'# Wink | ;)

ShellExecute() for ever ! lol

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: std::string to char*

CPallini1-Jul-08 3:18

CPallini

1-Jul-08 3:18

toxcct wrote:
system() is deprecated.

And portable.
Smile | :)

BTW strcat without enough storage is more than deprecate Poke tongue | ;-P

(just kidding)

Re: std::string to char*

toxcct1-Jul-08 3:21

toxcct

1-Jul-08 3:21

absolutely, but that guy is coding like a pig... Suspicious | :suss:

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: std::string to char*

CPallini1-Jul-08 3:28

CPallini

1-Jul-08 3:28

Well, we, as teachers, are commited to do the miracle and transform him into a top-skilled-developer (brass band needed here).
Big Grin | :-D

Re: std::string to char*

led mike1-Jul-08 4:25

led mike

1-Jul-08 4:25

CPallini wrote:
Well, we, as teachers

Maybe CP should be renamed to TeachYourselfCPlusPlusIn21Posts.com[^]

led mike

Re: std::string to char*

CPallini1-Jul-08 8:18

CPallini

1-Jul-08 8:18

21 posts? Soooooooooo ambitious!
Big Grin | :-D

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.