C / C++ / MFC

// x.h
class X
{
private:
  class XImpl;
  XImpl* pimpl_;
public:
  bool Foo(long);
protected:
  int Bar(short);
};
// ximpl.h
class X::XImpl
{
public:
  bool Function();
  // ...
};
// x.cpp
bool X::Foo(long v)
{
  return pimpl_->Function();
}
// ximpl.cpp
bool X::XImpl::Function()
{
  // ...
  return true;
}

// x.h
class X2  // New generation.
{
private:
  class XImpl;
  XImpl* pimpl_;
public:
  bool Foo(long); // Leave this as the only public interface.
};
// ximpl.h
class X2::XImpl
{
public:
  bool Function();
protected:
  int Bar(short); // Move all the implementations of X into here, so no backpointer is needed.
};

X2 obj;
if(obj.Foo() /* invoke the opaque Function() */ ) {
 // ...
}

class Y : public X2
{
public:
  bool Test() {
    // Oops!! 
    // No access to Bar().
    // No access to Pimpl.
    return false;
  }
  // ...
};

George_George wrote:

why do you want to call Bar and Pimpl in method Test of class Y? If we put something (like Bar) in Pimpl part, it means it is not visible. So, I think it does not make senses to access Bar if it is in Pimpl part. Any comments?

class CTestDlg : public CDialog  // class Y : public X
{
protected:
  virtual BOOL OnInitDialog(void);
  // ...
};
BOOL CTestDlg::OnInitDialog()
{
  // ...
  CMenu* pMenu = GetSystemMenu(FALSE); // This is something like invoking X::Bar().
  // ...
}

George_George wrote:

I think you can still access Foo in class Y, right?

George_George wrote:

Do you mean the pattern of MFC dialog is good or not?

George_George wrote:

Does it relates to my original question?

In the ANSI version of this function, the name is limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, call the Unicode version of the function and prepend "\\?\" to the path. For more information, see Naming a File[^].

--Mike--
Visual C++ MVP
LINKS~! CP SearchBar v3.0 | C++ Forum FAQ

I work for Keyser Söze

Rajkumar R wrote:

Its seems you know the answer when posted the question (only 4 min difference)

Usef Marzbani wrote:

I'm sorry to post this question twice! But I realy need it...

DavidCrow wrote:

But you already got it.