|
...do it all in Page_Load!
My company recently purchased a smaller company and our development department took over developing their web applications. My first task was to put a new user control on a few pages in one of the apps. While working on the first page I noticed something a bit odd...
(Sorry for the VB. In my defense, I didn't write the app.)
Private Sub Page_Load(blah, blah) Handles Page.OnLoad
' create some objects, initialize some variables
If Page.IsPostBack
' validate the user input
ValidateInput()
' save the user input to the database
SaveInput()
End If
End Sub
Farther down in the code I find this...
Private Sub Submit_Click(obj, args) Handles btnSubmit.OnClick
' direct the user to the new page
Response.Redirect(page.aspx)
End Sub
Smile and the world smiles with you. Laugh and the world thinks your insane.
|
|
|
|
|
I feel your pain there. I'm working on a website right now, and the framework we are using to build it - all its samples, all the pages that are there to build upon - not a single event handler. All postbacks and redirects. Sometimes it makes me want to puke 
|
|
|
|
|
 And this guy still lives?!!!!
"Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning." - Rick Cook
"There is no wealth like knowledge, no poverty like ignorance." Ali ibn Abi Talib
|
|
|
|
|
disable reader(1)
return
gosub printMainMenu
' disable reader(1)
return
I found this little pretty in a basic program im writing. the indentation indicates my genius.
|
|
|
|
|
bigbrownbeaver wrote: the indentation indicates my genius
The lack thereof indicates otherwise.
|
|
|
|
|
Apparently it was stripped out when I posted it. Double wammy
|
|
|
|
|
tip 1!
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips:
- use PRE tags to preserve formatting when showing multi-line code snippets
- before you ask a question here, search CodeProject, then Google
|
|
|
|
|
This one showed up in a code review. 'Nuff said.
string EntityID = new System.Text.StringBuilder("").ToString();
Cheers!
Humble Programmer
,,,^..^,,,
|
|
|
|
|
That is the better substitute for string.Empty 
I am fighting against the Universe...
Reference-Rick Cook
|
|
|
|
|
Hey - you told that intern to use StringBuilder, because it is presumed to be faster.
Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words
|
|
|
|
|
C# is a mighty tool 
Greetings from Germany
|
|
|
|
|
would of been funnier like this
string EntityID += new System.Text.StringBuilder("").ToString();
|
|
|
|
|
Humble Programmer wrote: string EntityID = new System.Text.StringBuilder("").ToString();
string EntityID = new System.Text.StringBuilder("").ToString()<blink>.Replace("", "");</blink>
This should make it faster;P
Smile: A curve that can set a lot of things straight!
(\ /)
(O.o)
(><)
|
|
|
|
|
DEATH TO THE BLINK TAG!!!!!
--
If you view money as inherently evil, I view it as my duty to assist in making you more virtuous.
|
|
|
|
|
string EntityID = new System.Text.StringBuilder("").ToString().Replace("", "").Trim();
Just to remove any errant spaces ...
|
|
|
|
|
Good morning
Smile: A curve that can set a lot of things straight!
(\ /)
(O.o)
(><)
|
|
|
|
|
Ok, I come across stuff like this daily...but this one was the most recent
CREATE PROC foo<br />
<br />
BEGIN TRANSACTION<br />
<br />
SELECT @id = id FROM ...<br />
<br />
IF @id IS NOT NULL<br />
BEGIN<br />
...do some stuff, there is NO ROLLBACK in here or error checking...<br />
COMMIT<br />
END<br />
else<br />
ROLLBACK
It's just so...useless. We only ever rollback if we didn't do anything?
|
|
|
|
|
That makes the ROLLBACK extremely fast.
Chris Meech
I am Canadian. [heard in a local bar]
Stercorum pro cerebro habes. [Cicero]
|
|
|
|
|
Chris Meech wrote: That makes the ROLLBACK extremely fast.
Smile: A curve that can set a lot of things straight!
(\ /)
(O.o)
(><)
|
|
|
|
|
GibbleCH wrote: It's just so...useless. We only ever rollback if we didn't do anything?
Defensive coding at its finest.
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
GibbleCH wrote: It's just so...useless. We only ever rollback if we didn't do anything?
Well, maybe you didn't see a "set XACT_ABORT on" statement buried in the code? If that is set, then rollback is automatic whenever an error occurs.
|
|
|
|
|
Then get rid of the existing ROLLBACK.
|
|
|
|
|
This has a real drawback: you wont see that the code is poor. 
Greetings from Germany
|
|
|
|
|
Last Friday, I had to visit the bank to open a Term Deposit account. Just about a month back, I had requested the bank to update my communication preferences to the updated and corrected address. They confirmed but again ATM records showed the old address. They wanted one more application form towards that updation.
And for Term Deposit, again they retrieved and showed my old record. I just got irrititated and asked them about their 'sick' database system that really sucks or whether it was the nonchalant attitude of the hostile staff, they actually wanted to investigate into the issue.
The banking application seemed to have gleaming coding horrors.
1) There are two identifiers for a customer in thier system. Account Number and a CustomerID. For every relationship (Savings Account, Current Account, Term Deposit) that a customer opens, it actually copies and stores the data separately. Now, the teller has to update everything individually.
2) Give account number, it fetches from one table. Give CustomerID and the address is fetched from different table.
And given the number of customers in the bank, it means so much of data storage wasted besides the performance penalty on the system.
The software companies that take up banking projects which are interested in taking a fatty cheque home from the bank just raises the eyebrow whether they are really committed in giving a quality product? 
|
|
|
|
|
My Wife opened an online bussiness account with a local bank. They insisted that someone come out and train her how to use it.
The reason for this was not a training issue, rather the trainer had to change all the security settings on IE to get it to work (cache https pages, etc). I wouldnt have minded if they had:
a) Told us what they were going to do
b) Didnt pretend they hadnt done it until i said i knew they changed something and would go to the press.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
![Badger | [badger,badger,badger,badger...]](https://www.codeproject.com/script/Forums/Images/badger.gif)
