Re: Multiple CDC::SelectObject() - C / C++ / MFC Discussion Boards

PatrykDabrowski20-Mar-07 2:39

20-Mar-07 2:39

Yes, I delete some_bitmapX objects (when exiting the app as they are 'global').

What I care about is:
1) Performance
2) Avoid memory/resource leaks.

Is CDC::CreateCompatibleDC()/DeleteDC() slower comparing to CDC::SaveDC()/RestoreDC()??

Thanks for help.

Re: Multiple CDC::SelectObject()

CPallini20-Mar-07 2:45

CPallini

20-Mar-07 2:45

Please revise the order of your list
Smile | :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

Re: Multiple CDC::SelectObject()

toxcct20-Mar-07 3:14

toxcct

20-Mar-07 3:14

CPallini wrote:
Please revise the order of your list

so true !

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: Multiple CDC::SelectObject()

PatrykDabrowski20-Mar-07 3:19

PatrykDabrowski

20-Mar-07 3:19

I should put 1) && 2)...in fact as long as I dont have leaks, I care more about performance Smile | :)

So the order is fine Smile | :)

Re: Multiple CDC::SelectObject()

toxcct20-Mar-07 3:25

toxcct

20-Mar-07 3:25

PatrykDabrowski wrote:
I care more about performance So the order is fine

so, you prefer allocating some memory, even if you "can't" delete it, until it doesn't affect your performances ?

dude, you're not alone running on the system ! what if everybody was coding like this - letting memory leaks voluntarily - because it "doesn't affect the perfrmances of the application" ?? WTF | :WTF:

you should always care about leaks first (of course, thinking of not coding too dirtily, of course) and optimize only then, if necessary...

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: Multiple CDC::SelectObject()

PatrykDabrowski20-Mar-07 3:47

PatrykDabrowski

20-Mar-07 3:47

I have written "as long as I dont have leaks, I care more about performance Smile | :)

";)...so my priority is to avoid memory leaks and then I optimize my code.

I assume that both solutions don't cause leaks so I would like to choose faster one. (I mean CDC::CreateCompatibleDC()/DeleteDC against CDC::SaveCD()/RestoreDC() )

Re: Multiple CDC::SelectObject()

toxcct20-Mar-07 3:51

toxcct

20-Mar-07 3:51

PatrykDabrowski wrote:
I have written "as long as I dont have leaks, I care more about performance ";)...so my priority is to avoid memory leaks and then I optimize my code.

ok for me then Cool | :cool:

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: Multiple CDC::SelectObject()

Parthi_Appu20-Mar-07 2:49

Parthi_Appu

20-Mar-07 2:49

PatrykDabrowski wrote:
I delete some_bitmapX objects (when exiting the app as they are 'global').

If you are creating those object once and deleting at the end, then no problem.

PatrykDabrowski wrote:
CreateCompatibleDC()/DeleteDC() slower comparing to CDC::SaveDC()/RestoreDC()??

These two set of APIs are different from each other.
That is, after creating a compatible DC, you have select the needed objects into the DC. At last the original object belong to the DC have to be selected (the object returned, at the first select object, note this appicable for that specific type of object).
DelectDC will delete the DC that you created.

But the SaveDC and RestoreDC is for making the DC to its original state, you need not worry about reselecting the original objects. see below;

CDC dc; dc.CreateCompatibleDC(..);
dc.SaveDC();
dc.SelectObject(bitmap1); /* do something */
dc.SelectObject(bitmap2); /* do something */
dc.RestoreDC( -1 );
dc.DeleteDC();

By doing so, you need not have to maintain the old objects returned.

Do your Duty and Don't expect the Result

Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 1:06

Programm3r

20-Mar-07 1:06

I'm receiving the following error, and I have no idea why, even my try and catch blocks doesn't work.

Microsoft Visual C++ Runtime Library

Runtime Error!
Program:..<dir>\executableName.exe

This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.

Confused | :confused:

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

toxcct20-Mar-07 1:13

toxcct

20-Mar-07 1:13

Programm3r wrote:
Please contact the application's support team for more information

so what ! haven't you ??? Roll eyes | :rolleyes:

BTW, what a perfect situation for using a breakpoint, isn't it ?! Poke tongue | ;-P

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 1:30

Programm3r

20-Mar-07 1:30

toxcct wrote:
so what ! haven't you ???

I wrote the application. You tell me who I must call ??

toxcct wrote:
BTW, what a perfect situation for using a breakpoint, isn't it ?!

I know where it happens, but a breakpoint doesn't tell me what the problem was after the specific funtion call. After the error occured, does it?

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

toxcct20-Mar-07 1:39

toxcct

20-Mar-07 1:39

Programm3r wrote:
I wrote the application. You tell me who I must call ??

i was kidding you with the message Windows returned

Programm3r wrote:
I know where it happens, but a breakpoint doesn't tell me what the problem was after the specific funtion call. After the error occured, does it?

putting a breakpoint won't tell you what's the problem, but it will put you highly on the way.
do you know using the watch window ? you can inspect the content of your variables at a time, watching if the are correctly set... THIS can help you guessing what's wrong.

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 1:44

Programm3r

20-Mar-07 1:44

toxcct wrote:
i was kidding you with the message Windows returned

Sorry my bad ... Smile | :)

toxcct wrote:
do you know using the watch window ?

Yes. I'll try it.
Thank you very much toxcct.

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

prasad_som20-Mar-07 1:22

prasad_som

20-Mar-07 1:22

What call stack says to you ?

Prasad
Notifier using ATL | Operator new[],delete[][^]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 1:35

Programm3r

20-Mar-07 1:35

prasad_som wrote:
What call stack says to you ?

Just before the error:

> Win32ClibRFC.exe!CClibRFC32::rfcCall(char * szUname=0x00417960, char * szTag=0x00417968, char * lpFromDate=0x0041796c, char * lpToDate=0x0041797c, char * szDesc=0x0041798c) Line 262 C++
Win32ClibRFC.exe!wmain(int argc=1, wchar_t * * argv=0x009c5870) Line 281 C++
Win32ClibRFC.exe!__tmainCRTStartup() Line 583 + 0x19 bytes C
Win32ClibRFC.exe!wmainCRTStartup() Line 403 C

But afterwards ... nothing

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

prasad_som20-Mar-07 1:46

prasad_som

20-Mar-07 1:46

Programm3r wrote:
Win32ClibRFC.exe!CClibRFC32::rfcCall(char * szUname=0x00417960, char * szTag=0x00417968, char *

Is there such function in your app ? Try putting break point there.

Prasad
Notifier using ATL | Operator new[],delete[][^]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 1:57

Programm3r

20-Mar-07 1:57

prasad_som wrote:
Is there such function in your app ? Try putting break point there.

Yes,

int CClibRFC32::rfcCall(char* szUname, char* szTag, char* lpFromDate, char* lpToDate, char* szDesc)

But inside that function the error occurs at this point:

RFC_HANDLE handle;
RFC_FUNCTIONNAME functionname;
RFC_PARAMETER exporting[MAX_PARA];
RFC_PARAMETER importing[MAX_PARA];
RFC_TABLE tables[MAX_PARA];
rfc_char_t * exception_ptr;
RFC_PARAMETER changing[MAX_PARA];

rc = RfcCallReceiveEx(handle, functionname, exporting, importing, changing, tables, &exception_ptr); 
//At this function call

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

prasad_som20-Mar-07 2:12

prasad_som

20-Mar-07 2:12

Programm3r wrote:
rfc_char_t * exception_ptr;RFC_PARAMETER changing[MAX_PARA];rc = RfcCallReceiveEx(handle, functionname, exporting, importing, changing, tables, &exception_ptr);

Does RfcCallReceiveEx expects uninitialized RFC_HANDLE handle value, which is case here. Same is case with RFC_FUNCTIONNAME parameter.

Prasad
Notifier using ATL | Operator new[],delete[][^]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 2:24

Programm3r

20-Mar-07 2:24

prasad_som wrote:
Does RfcCallReceiveEx expects uninitialized RFC_HANDLE handle value, which is case here. Same is case with RFC_FUNCTIONNAME parameter.

Not quite, take the following into account (I know I didn't mention it before)

sprintfU (connect_param, cU("DEST=%s CLIENT=%s USER=%s PASSWD=%s LANG=%s"), dest, client, user, pass, lang);
// Connect to SAP - get handle
handle = RfcOpenEx(connect_param, &error_info);
// Set RFC Function Name
strncpyU (functionname, "RFC_FUNCTION_NAME", sizeofU (RFC_FUNCTIONNAME) - 1);

And even if that was the case, I have never before had a compiler error like that, where I didn't initilized my variables.

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

prasad_som20-Mar-07 2:27

prasad_som

20-Mar-07 2:27

Oh !
And what about last paramter of RfcCallReceiveEx, is it expected to pass initialized pointer ? Or RfcCallReceiveEx does that ?
Who is owner of RfcCallReceiveEx ? Can you debug it ?

Prasad
Notifier using ATL | Operator new[],delete[][^]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 2:42

Programm3r

20-Mar-07 2:42

prasad_som wrote:
And what about last paramter of RfcCallReceiveEx, is it expected to pass initialized pointer ?

No it is not expected to pass an initialized pointer:&exception_ptr

prasad_som wrote:
Who is owner of RfcCallReceiveEx ? Can you debug it ?

A library called librfc32 developed by I have no idea. Can I debug it? No I can not. But I have used it previously without any problem, surely I'm doing something stupid. Smile | :)

Thank you very much for your patients prasad_som.
Regards,

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

prasad_som20-Mar-07 2:49

prasad_som

20-Mar-07 2:49

Programm3r wrote:
surely I'm doing something stupid.

Only thing you can do wrong here is about parameters, as function is owned by some library. Check any information available about this function, and you are passing parameters are in correct manner.

Prasad
Notifier using ATL | Operator new[],delete[][^]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 2:59

Programm3r

20-Mar-07 2:59

Thank you very much for the help prasad_som,

Atleast I'm getting somewhere, the error has shifted to:
Unhandled exception at 0x77c42a16 in Win32ClibRFC.exe: 0xC0000005: Access violation reading location 0xcccccccc.

Stack
>msvcr80d.dll!_chvalidator_l(localeinfo_struct * plocinfo=0x0012de50, int c=1236604, int mask=4630471) Line 71 + 0x25 bytes C++

Compiler opens isctype.c file at the following location:

_LocaleUpdate _loc_update(plocinfo);

_ASSERTE((unsigned)(c + 1) <= 256);
if (c >= -1 && c <= 255)
{
    return (_loc_update.GetLocaleT()->locinfo->pctype[c] & mask);
}
else
{
    return (_loc_update.GetLocaleT()->locinfo->pctype[-1] & mask);
}

So as you can see, I'm coming somewhere .... Smile | :)

Baby steps Jig | [Dance]

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Re: Microsoft Visual C++ Runtime Library Error

toxcct20-Mar-07 3:08

toxcct

20-Mar-07 3:08

Programm3r wrote:
Compiler opens isctype.c file at the following location

this cannot be the source of the problem.
only your code is wrongly propagating dummy values. go through the call stack, from where the debugger stopped, and go up the stack until you reach a piece of code of your own... (and here, use the watch window Wink | ;)

)

[VisualCalc][Binary Guide][CommDialogs] | [Forums Guidelines]

Re: Microsoft Visual C++ Runtime Library Error

Programm3r20-Mar-07 3:18

Programm3r

20-Mar-07 3:18

toxcct wrote:
this cannot be the source of the problem

I know and yes you are right.
I'm still working on the problem.
Thanx again toxcct

The only programmers that are better than C programmers are those who code in 1's and 0's..... Smile | :)

Programm3r
Bronze

My Blog: ^_^

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.