Re: generic inherited class - C# Discussion Boards

6-Sep-06 9:33

How can I cast an inherithed generic class?

class c1{}
class c2 : c1{}
interface I1<t>{ void meth(T t);}

class g1<t> : I1<t> where T : c1{}
class g2<t> : g1<t> where T : c2{}

static main(....)
{
I1<c1> oI1 = null;
g2<c2> og2 = new g2<c2>();
oI1 = (I1<c1>) og2;
********************* I get this error :
Unable to cast object of type 'g2`1[c2]' to type 'I1`1[c1]'.
*********************

Why? If c2 is inherited from c1 and g2 is inherited from g1 and I1, this should not work?

Thanks

Nader Elshehabi6-Sep-06 10:17

6-Sep-06 10:17

Hello

Well, your code compiled well with me after some modifications. Here it is:

class c1{}
class c2 : c1{}
interface I1{ }

class g1<t> : I1 where t: c1{}
class g2<t> : g1<c1> where t: c2{}

I1 oI1 = null;
g2<c2> og2 = new g2<c2>();

public void MyMethod()
{
oI1 = (I1)og2;
}

You must have made another mistake somewhere!!

Regards

daveroberge6-Sep-06 10:46

6-Sep-06 10:46

Thanks for your quick answer.

You're right, I made a mistake. I didn't write enough detail and it was confusing. I'm sorry.

Here's all my example :

class c1{}
class c2 : c1{}
interface I1<t> {void Add(t a);}
class g1<t> : I1<t> where t : c1{
public virtual void Add(t a){...}}
class g2<t> : g1<c1> where t : c2 { }

I1<c1> oI1 = null;
g2<c2> og2 = new g2<c2>();
oI1 = (I1<c1>)og2;

*******At this point, everything is good****
However if I do : og2.Add(...) my parameter can be type c1!!! And I don't want because in my g2 class, the object used must be of type c1.
If a change this line
class g2<t> : g1<c1> where t : c2 { }' for
class g2<t> : g1<c2> where t : c2 { }', everyghing is good at the compile and I have to pass a class c2 in the Add method. A class c1 is not allowed and that's good. Unfortunately, casting doesn't work.

Thanks again

Nader Elshehabi6-Sep-06 11:30

6-Sep-06 11:30

Hello

daveroberge wrote:
it was confusing

Was??! H$#l I'm lost in all those Gs an Cs?!! WTF | :WTF:

Anyway, we will work this out bit by bit.

daveroberge wrote:
if I do : og2.Add(...) my parameter can be type c1!!! And I don't want

C2 is inherited from C1!! So C1 could fit in the place of C2 sometimes.

Now I don't get three things:
1- You want to cast what to what?
2- Where is the call that makes the error?
3- One time you say your parameter can be C1 then you say C1 is not allowed. I'm totally lost!!

Please repost your code with the error -don't modify your cast-, and comment on the line with the error. The most important thing is to check the "Ignore HTML tags..." below the post editting textbox so that the generic code tags would appear in your code.

PS. If I didn't reply for a while that means I fell asleep:->. Then I'll first thing in the morning!! It's 12:26AM here in Cairo and I should have been in bed about an hour ago!! Sleepy | :zzz:

Regards

daveroberge6-Sep-06 14:04

6-Sep-06 14:04

Hope your night was good Big Grin | :-D

this is a better code :

interface I1<t> { void Add(t a); }

class c1{
public string sVal = "test";}

class c2 : c1{
public string sVal2 = "test2";}

class g1<t> : I1<t> where t : c1{
public virtual void Add(t a){a.sVal = "svalmodified";}}

class g2<t> : g1<c2> where t : c2 {
public override void Add(c2 a){
a.sVal2 = "testmodified2";
base.Add(a);}}

private I1<c1> GetG1(){
g1<c1> oG1 = new g1<c1>();
oG1.Add(new c1());
return oG1;}

private I1<c1> GetG2(){
g2<c2> oG2 = new g2<c2>();
oG2.Add(new c2());
return (I1<c1>)oG2;} ********* see below the error ********

private void TestMethod(){
I1<c1> oTest1 = GetG1();
I1<c1> oTest2 = GetG2();}

****** error ******
Unable to cast object of type 'WindowsApplication2.g2`1[WindowsApplication2.c2]' to type 'WindowsApplication2.I1`1[WindowsApplication2.c1]'

I hope it's less confusing... Wink | ;)

Nader Elshehabi7-Sep-06 1:59

7-Sep-06 1:59

Hello

Gotcha!! Now your problem is clear. Here it is: -Watch carefully for generic types-

1- First you declare an object of type I1<c1> you name it oTest2
2- Then you call GetG2()
3- In the method you declare another object of type g2<c2> with the name oG2
Are following me??

Now the problem is that the definition of class g2 is that you inherit it from class g1<c2> -notice the c2 here!!-. So in the base class g1 which has the interface I1 the generic type is c2!! So by default the generic type of I1 -which is the interface of g1 and has the same generic type- is c2, not c1!! That's why when you try to return oG2 and cast it to interface I1<c1> it doesn't work!! It implements interface I1<c2> not I1<c1>. I hope now you see your problem now.

Suggested solutions -among many other solutions of course-.
1- Return type I1<c2> instead
private I1<c2> GetG2()
{
g2<c2> oG2 = new g2<c2>();
oG2.Add(new c2());
return (I1<c2>)oG2;
}

I1<c2> oTest2 = GetG2();
This will preserve your inheritance structure.

OR
Change your inheritance to implement I1<c1> interface in G2

class g2<t> : g1<c2>, I1<c1> where t : c2
{
public override void Add(c2 a)
{
a.sVal2 = "testmodified2";
base.Add(a);
}

public void Add(c1 a)
{
//Do something
}
}

I hope this helps!!

Regards

daveroberge7-Sep-06 3:07

7-Sep-06 3:07

Yes it helps me a lot for my understanding.

I thought that because c2 is inherited from c1, I1<c2> and I1<c1> was the same thing. So I1<c1> is the base of I1<c2> and in this case, it could be possible to cast from a I1<c2> to I1<c1>.

The problem with your solution #1 is that I can't put both return value from GetG1() & GetG2() in the same objet or an array of the same type (Ex: I1<c1>[]). The solution #2 is better but you're gonna be able to add an object of type c1.

Is there a pattern to do what I want? I mean, you have a factory accepting a base class X and you want to inherite a new factory but in this one, you only want to accept an inherited class from X.

Thanks for your help!!!

Nader Elshehabi7-Sep-06 9:04

7-Sep-06 9:04

Hello

You didn't specify, you want to return what type in the GetG2() method??

daveroberge wrote:
Only want to accept an inherited class from X.

If X is c1 then you want to return c2, right? G1 is the factory of c1, so G2 is the factory of C2, so, where is the problem? You could implement an I1< c2 > in G2 class!

Regards

daveroberge7-Sep-06 10:53

7-Sep-06 10:53

No I can't because both returned object from G1 and G2 will be put in the same object but at different time. Here's some changes in my code.

****old*****
private void TestMethod(){
I1<c1> oTest1 = GetG1();
I1<c1> oTest2 = GetG2();}

****new****
private I1<c1> TestMethod(int iVal){
if(iVal == 1 ) return GetG1();
else return GetG2();}

private void CallMethod() {
I1<c1> oValue = TestMethod(1);
oValue = TestMethod(2); } ****** Error while casting in GetG2()***

Thanks again for your help
D.

Nader Elshehabi7-Sep-06 11:26

7-Sep-06 11:26

Hello

Alright I got another way. Thank God for explicit casts..

Try adding this to your g2<t> class:

public static explicit operator g1<c1>(g2<t>
{
g1<c1> Toreturn = new g1<c1>();
//conversion here
return Toreturn;
}

now in GetG2() method return (g1<c1>)oG2;

I hope it works this time.

Regards

daveroberge7-Sep-06 14:31

7-Sep-06 14:31

Yeah I also tried that and that's my better option now but there's a hic... the returned object will not be the same after casting. All c2 objects will be the same but not the container g1. In my example, this case is not important I agree but it could be in another case. Anyway, it's still the better way... Smile | :)

but I'm still confusing with the fact that there's an automatic override made on methods but the casting is not clearly working.... Confused | :confused:

Thanks a lot

Ed.Poore6-Sep-06 12:01

Ed.Poore

6-Sep-06 12:01

First of all (I don't know if this is because you stipped out the <> tags), your interface I1 does not expose a generic type, it should be declared as

interface I1<T>
{
	void meth(T t);
}

Unless of course I1 is declared inside another generic class which exposes the generic type T, but from your code this is not the case.

The same applies for the declarations of g1 and g2, you need to include the <T> after the name (unless it's part of a parent class). Then everything should work. Although in your lines of code which create the generics you will need to specify which type to implement: e.g.

I1 ol1 = null;
g2 = og2 = new g2<int>();
ol1 = (I1) og2;

So in summary your code should probably look along the lines of

class c1
{
}
class c2 : c1
{
}

interface I1<T>
{
    void meth(T t);
    {
    }
}

class g1<T> : I1 where T : c1
{
}
class g2<T> : g1 where T : c2
{
}

static void Main(...)
{
    I1<object> oI1 = null;
    g2 og2 = new g2<object>();
    oI1 = (I1)og2;
}

Of couse this would be much nicer if the variables and types were named more appropriately.

As of how to accomplish this I have no idea, have you tried Google?
Faiing that try Badger | [badger,badger,badger,badger...]

daveroberge6-Sep-06 14:09

6-Sep-06 14:09

I'm sorry, I didn't check the box <Ignore HTML tags....> so all my <> tags were removed. I also tried on Google many times with different parameters but I have not found anything about that.... Frown | :(

Thanks

Ed.Poore6-Sep-06 18:38

Ed.Poore

6-Sep-06 18:38

Can you post the correct source code which is not working properly then?

As of how to accomplish this I have no idea, have you tried Google?
Faiing that try Badger | [badger,badger,badger,badger...]

daveroberge7-Sep-06 2:54

Placing description into a class/method???

7-Sep-06 2:54

Yes, my code is in a previous post...
thanks

Goalie356-Sep-06 8:55

Goalie35

6-Sep-06 8:55

How does microsoft insert descriptions of their classes?
I mean, if you type "System" and then a period, you're presented with a list of classes, methods, & namespaces to choose from.

Many of these items contain descriptions. For example if you type "System", and then scroll down to "WeakReference", it displays "References a weak reference, which represents an object...."

How can I insert these types of descriptions into my own custom classes and methods?

thanks.

-Goalie35

Nader Elshehabi6-Sep-06 9:13

6-Sep-06 9:13

Hello

Just type "///" in the line before the method or property name and the snippet wizard will make a lock like this:

/// <summary>
/// Write a description here
/// </summary>
/// <param name="ParamA"></param> Write a description here
/// <param name="ParamB"></param> Write a description here
public void MyMethod(int ParamA, int ParamB)
{

}

Now when you use this method in your project, or when you link to the project from another project in the solution, you will see the description.

To make this happen when you compile the code as a dll - exe don't need description, do they?- you must make an xml documentation file. To do that:
Your Projects property => Build => Check "XML doxumentation" in the lower part of the screen.

Regards Rose | [Rose]

Goalie356-Sep-06 9:31

Goalie35

6-Sep-06 9:31

That did it!

Thanks Rose.

-Goalie35

Nader Elshehabi6-Sep-06 9:46

6-Sep-06 9:46

Hello

Goalie35 wrote:
Thanks Rose.

My name isn't Rose Laugh | :laugh:

. It's the rose gif in my signature. It didn't appear because I removed html tags from my post.. My name is Nader Elshehabi.

Anyway, you are welcome. Smile | :)

Regards

Not Active6-Sep-06 9:56

Not Active

6-Sep-06 9:56

So, a rose by any other name is Nader Elshehabi Laugh | :laugh:

only two letters away from being an asset

Nader Elshehabi6-Sep-06 10:36