|
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose.
what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
|
|
|
|
|
|
Southmountain wrote: I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose.
throw new NotImplementedException();
Yup, that definitely requires comprehensive testing and validation! 
|
|
|
|
|
abort();
an old favorite. works as advertised. no obvious flaws. 
To err is human. Fortune favors the monsters.
|
|
|
|
|
works
"A little time, a little trouble, your better day"
Badfinger
|
|
|
|
|
Southmountain wrote: I reviewed only one line of code for one business rule.
Delete this part. It completely invalidates your second sentence. If you worked for me, and I read this line in a code review, you'd be looking for work. A one line change usually has many unintended consequences, and a proper review requires a much more extensive analysis. No code change, nor any hardware change, lives in a vacuum; there are always other effects, and they can be very subtle. If you're willing to accept this review as your best work, stick with the second sentence, and be prepared to defend it.
Will Rogers never met me.
|
|
|
|
|
|
"Approved after review and testing".
|
|
|
|
|
I have no idea what system or process you use for your code reviews, but I don't write comments for approvals.
I will do 10-20 code reviews per week, sometimes more, sometimes less.
We use Azure DevOps Services | Microsoft Azure[^] and I usually only make comments if there are issues, but when I approve I just click the Approve button and that is it, no comments necessary.
|
|
|
|
|
my approval is written in an email to reply to developer's request. this email will be saved and embed into BRD document.
diligent hands rule....
|
|
|
|
|
your code review system uses email as its method of communication?
I don't want to know the answer. 
|
|
|
|
|
If there are no comments for the review, we just approve the PR.
CI/CD = Continuous Impediment/Continuous Despair
|
|
|
|
|
A coworker always uses "Works as coded".
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.
|
|
|
|
|
And the best part is, he is ALWAYS right - even if there are unintended consequences.
Brent
|
|
|
|
|
I will use similar words to this statement
diligent hands rule....
|
|
|
|
|
"No concerns".
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
|
|
|
|
|
this may not be regarded as an approval 
diligent hands rule....
|
|
|
|
|
Wordle 537 3/6
⬛⬛⬛⬛🟨
🟨🟨🟨🟩⬛
🟩🟩🟩🟩🟩
|
|
|
|
|
Wordle 537 4/6
⬜⬜🟨🟩⬜
⬜🟨⬜🟩⬜
🟩🟩⬜🟩🟩
🟩🟩🟩🟩🟩
|
|
|
|
|
Wordle 537 4/6
⬜⬜⬜⬜🟨
⬜🟨⬜🟨🟨
🟨🟨🟨🟩🟩
🟩🟩🟩🟩🟩
|
|
|
|
|
Wordle 537 4/6
⬜🟨⬜⬜🟨
⬜⬜🟨🟩🟩
🟨🟨🟨🟩🟩
🟩🟩🟩🟩🟩
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Wordle 537 5/6*
⬜🟨🟨⬜⬜
🟨⬜⬜🟨⬜
🟨🟨⬜⬜⬜
🟨🟨⬜🟩🟩
🟩🟩🟩🟩🟩
Happiness will never come to those who fail to appreciate what they already have. -Anon
|
|
|
|
|
Wordle 537 6/6
⬜⬜🟨⬜🟨
⬜🟨⬜🟩⬜
⬜⬜⬜⬜⬜
🟨⬜🟨🟨⬜
🟩🟩⬜🟩🟩
🟩🟩🟩🟩🟩
|
|
|
|
|
⬜🟨⬜🟨🟨
🟨🟩🟨⬜⬜
⬜🟩⬜🟩🟩
⬜🟩⬜🟩🟩
🟩🟩⬜🟩🟩
🟩🟩🟩🟩🟩
Life should not be a journey to the grave with the intention of arriving safely in a pretty and well-preserved body, but rather to skid in broadside in a cloud of smoke, thoroughly used up, totally worn out, and loudly proclaiming “Wow! What a Ride!" - Hunter S Thompson - RIP
|
|
|
|
|
Wordle 537 5/6*
⬜⬜🟨⬜⬜
⬜🟨⬜🟨🟨
🟨⬜⬜🟩🟩
🟨🟨🟨🟩🟩
🟩🟩🟩🟩🟩
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
![Rose | [Rose]](https://codeproject.freetls.fastly.net/script/Forums/Images/rose.gif)